)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"77acf0952f3ac6ad570bdeb03b21679a40d198d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Giampaolo Lauria \u003clauria@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-03-12 16:17:10 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix exception message in Newtworks API extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Raise exception indicating VLAN is disabled when"},{"line_number":10,"context_line":"trying to associate a network w/ a tenant in cases where"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAN3%2F%2Fx1Q%3D","line":7,"updated":"2013-03-12 20:26:19.000000000","message":"\"Networks\" misspelled.","commit_id":"761bc51889458d567c372d7046fbae5c57c840c2"}],"nova/api/openstack/compute/contrib/os_networks.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"77acf0952f3ac6ad570bdeb03b21679a40d198d3","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        authorize(context)"},{"line_number":133,"context_line":"        if CONF.network_manager !\u003d \"nova.network.manager.VlanManager\":"},{"line_number":134,"context_line":"            raise exc.HTTPUnprocessableEntity("},{"line_number":135,"context_line":"                            explanation\u003d(_(\"VLAN support must be enabled\")))"},{"line_number":136,"context_line":"        if not body:"},{"line_number":137,"context_line":"            raise exc.HTTPUnprocessableEntity()"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2Fx1E%3D","line":135,"updated":"2013-03-12 20:26:19.000000000","message":"I don\u0027t think the API should be inspecting the config like this. If someone implemented their own manager inherited from VlanManager, then this would unnecessarily fail. The parent networkmanager class should define an implementation and raise NotImplementedError if it\u0027s not implemented. That exception can be caught here and turned into whatever you want.","commit_id":"761bc51889458d567c372d7046fbae5c57c840c2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9cc6f4f95ff9ab618d7cf08848221320f08cfdbc","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                context, project_id, network_id)"},{"line_number":142,"context_line":"        except NotImplementedError:"},{"line_number":143,"context_line":"            msg \u003d (_(\"VLAN support must be enabled\"))"},{"line_number":144,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":145,"context_line":"        except Exception as ex:"},{"line_number":146,"context_line":"            msg \u003d (_(\"Cannot associate network %(network)s\""},{"line_number":147,"context_line":"                     \" with project %(project)s: %(message)s\") %"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2FumQ%3D","line":144,"updated":"2013-03-14 19:39:08.000000000","message":"Looks like there is a webob.exc.HTTPNotImplemented exception which is probably better to raise here. Definitely looks much better than before :)","commit_id":"7ec0b3fcfcdb27b1a5bd9afa535d15218858392a"}],"nova/tests/api/openstack/compute/contrib/test_networks.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9cc6f4f95ff9ab618d7cf08848221320f08cfdbc","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    def add_network_to_project(self, context,"},{"line_number":129,"context_line":"                               project_id, network_uuid\u003dNone):"},{"line_number":130,"context_line":"        if (VLAN_IS_DISABLED):"},{"line_number":131,"context_line":"            raise NotImplementedError()"},{"line_number":132,"context_line":"        if network_uuid:"},{"line_number":133,"context_line":"            for network in self.networks:"},{"line_number":134,"context_line":"                if network.get(\u0027project_id\u0027, None) is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2FumM%3D","line":131,"updated":"2013-03-14 19:39:08.000000000","message":"I think this should be an attribute of the FakeNetworkAPI, not a global. Yes it might be some more plumbing in the test, but...","commit_id":"7ec0b3fcfcdb27b1a5bd9afa535d15218858392a"}]}