)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"75ce8d5dd2295d1866d55c95de25bec889010ea1","unresolved":false,"context_lines":[{"line_number":749,"context_line":"            self._check_instance_exists(context, instance)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"            try:"},{"line_number":752,"context_line":"                self._start_building(context, instance)"},{"line_number":753,"context_line":"            except exception.InstanceNotFound:"},{"line_number":754,"context_line":"                LOG.info(_(\"Instance disappeared before we could start it\"),"},{"line_number":755,"context_line":"                         instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FxoU%3D","line":752,"updated":"2013-03-12 21:57:14.000000000","message":"Dan, should the notify for \"create.start\" be moved up as well?","commit_id":"4814280ce0af71ad38155d07eefea7c762935fa7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8868e449ba58f40dc47923a685d12032a2ab32eb","unresolved":false,"context_lines":[{"line_number":749,"context_line":"            self._check_instance_exists(context, instance)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"            try:"},{"line_number":752,"context_line":"                self._start_building(context, instance)"},{"line_number":753,"context_line":"            except exception.InstanceNotFound:"},{"line_number":754,"context_line":"                LOG.info(_(\"Instance disappeared before we could start it\"),"},{"line_number":755,"context_line":"                         instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FxeU%3D","line":752,"in_reply_to":"AAAAN3%2F%2FxhE%3D","updated":"2013-03-12 23:34:54.000000000","message":"Ah, I see your concern now. However, this is all called from within wrap_instance_fault() which will reset task_state and vm_state on all errors (other than InstanceNotFound, which is the point of this patch). I think we should be fine as a result.","commit_id":"4814280ce0af71ad38155d07eefea7c762935fa7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ae865289ba3bc58efc936ed531774491287d3df1","unresolved":false,"context_lines":[{"line_number":749,"context_line":"            self._check_instance_exists(context, instance)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"            try:"},{"line_number":752,"context_line":"                self._start_building(context, instance)"},{"line_number":753,"context_line":"            except exception.InstanceNotFound:"},{"line_number":754,"context_line":"                LOG.info(_(\"Instance disappeared before we could start it\"),"},{"line_number":755,"context_line":"                         instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2Fxmc%3D","line":752,"in_reply_to":"AAAAN3%2F%2Fxm0%3D","updated":"2013-03-12 22:18:19.000000000","message":"Yeah, but it was still after check_image_size(), so I\u0027m not sure that we need to change that ordering for any reason. The _check_image_size() call can bail on error as well, so running that before we fire the create.start notification seems like a good idea, no? What am I missing?","commit_id":"4814280ce0af71ad38155d07eefea7c762935fa7"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"5f7b3400ccb95a249dbec8ec71dcec4ea0d98b40","unresolved":false,"context_lines":[{"line_number":749,"context_line":"            self._check_instance_exists(context, instance)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"            try:"},{"line_number":752,"context_line":"                self._start_building(context, instance)"},{"line_number":753,"context_line":"            except exception.InstanceNotFound:"},{"line_number":754,"context_line":"                LOG.info(_(\"Instance disappeared before we could start it\"),"},{"line_number":755,"context_line":"                         instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FxhE%3D","line":752,"in_reply_to":"AAAAN3%2F%2Fxmc%3D","updated":"2013-03-12 23:16:35.000000000","message":"Dan, earlier the notification (create.start) and database update (vm_states.BUILDING) was happening together. Now there are additional things that can happen between the two.\n\n-- dims","commit_id":"4814280ce0af71ad38155d07eefea7c762935fa7"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"64d75f4dd3c8dbb6f05e27de9e2e7b6d08e38f47","unresolved":false,"context_lines":[{"line_number":749,"context_line":"            self._check_instance_exists(context, instance)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"            try:"},{"line_number":752,"context_line":"                self._start_building(context, instance)"},{"line_number":753,"context_line":"            except exception.InstanceNotFound:"},{"line_number":754,"context_line":"                LOG.info(_(\"Instance disappeared before we could start it\"),"},{"line_number":755,"context_line":"                         instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2Fxm0%3D","line":752,"in_reply_to":"AAAAN3%2F%2FxnI%3D","updated":"2013-03-12 22:12:32.000000000","message":"Sorry should have been clearer, should we move the _notify_about_instance_usage call to just before the call for _check_image_size? since earlier _notify_about_instance_usage was just after _start_building. Yes, we should not be notifying if start building fails of course.","commit_id":"4814280ce0af71ad38155d07eefea7c762935fa7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b648f6354a4c21c1b4adcc8238b04884e20685c8","unresolved":false,"context_lines":[{"line_number":749,"context_line":"            self._check_instance_exists(context, instance)"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"            try:"},{"line_number":752,"context_line":"                self._start_building(context, instance)"},{"line_number":753,"context_line":"            except exception.InstanceNotFound:"},{"line_number":754,"context_line":"                LOG.info(_(\"Instance disappeared before we could start it\"),"},{"line_number":755,"context_line":"                         instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FxnI%3D","line":752,"in_reply_to":"AAAAN3%2F%2FxoU%3D","updated":"2013-03-12 22:08:27.000000000","message":"Hmm, why? I think this ought to be the first thing we do, and bail immediately. No point in firing the notification if we\u0027re just going to bail.","commit_id":"4814280ce0af71ad38155d07eefea7c762935fa7"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"cd9888be11fec1de5b74a639f531485ba0d5f56d","unresolved":false,"context_lines":[{"line_number":751,"context_line":"            try:"},{"line_number":752,"context_line":"                self._start_building(context, instance)"},{"line_number":753,"context_line":"            except exception.InstanceNotFound:"},{"line_number":754,"context_line":"                LOG.info(_(\"Instance disappeared before we could start it\"),"},{"line_number":755,"context_line":"                         instance\u003dinstance)"},{"line_number":756,"context_line":"                # Quickly bail out of here"},{"line_number":757,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2Fxnc%3D","line":754,"updated":"2013-03-12 22:01:48.000000000","message":"Is info the right level for this?  It\u0027s moving from a very loud warning to something that\u0027s easily missed.  I think warning might be appropriate.","commit_id":"4814280ce0af71ad38155d07eefea7c762935fa7"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"a622da789441b72f4d34ed99ac0692a92930d914","unresolved":false,"context_lines":[{"line_number":751,"context_line":"            try:"},{"line_number":752,"context_line":"                self._start_building(context, instance)"},{"line_number":753,"context_line":"            except exception.InstanceNotFound:"},{"line_number":754,"context_line":"                LOG.info(_(\"Instance disappeared before we could start it\"),"},{"line_number":755,"context_line":"                         instance\u003dinstance)"},{"line_number":756,"context_line":"                # Quickly bail out of here"},{"line_number":757,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FwOo%3D","line":754,"updated":"2013-03-13 19:04:40.000000000","message":"how about \u0027\"Instance was deleted \"... instead of disappeared?","commit_id":"4814280ce0af71ad38155d07eefea7c762935fa7"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"6f57bf66a0d63bc0435e41984eadc5e935b164f1","unresolved":false,"context_lines":[{"line_number":751,"context_line":"            try:"},{"line_number":752,"context_line":"                self._start_building(context, instance)"},{"line_number":753,"context_line":"            except exception.InstanceNotFound:"},{"line_number":754,"context_line":"                LOG.info(_(\"Instance disappeared before we could start it\"),"},{"line_number":755,"context_line":"                         instance\u003dinstance)"},{"line_number":756,"context_line":"                # Quickly bail out of here"},{"line_number":757,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FxkY%3D","line":754,"in_reply_to":"AAAAN3%2F%2FxnE%3D","updated":"2013-03-12 22:35:05.000000000","message":"Fair enough.  I don\u0027t feel strongly enough that it should be different, especially if it\u0027s already been discussed.","commit_id":"4814280ce0af71ad38155d07eefea7c762935fa7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b648f6354a4c21c1b4adcc8238b04884e20685c8","unresolved":false,"context_lines":[{"line_number":751,"context_line":"            try:"},{"line_number":752,"context_line":"                self._start_building(context, instance)"},{"line_number":753,"context_line":"            except exception.InstanceNotFound:"},{"line_number":754,"context_line":"                LOG.info(_(\"Instance disappeared before we could start it\"),"},{"line_number":755,"context_line":"                         instance\u003dinstance)"},{"line_number":756,"context_line":"                # Quickly bail out of here"},{"line_number":757,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FxnE%3D","line":754,"in_reply_to":"AAAAN3%2F%2Fxnc%3D","updated":"2013-03-12 22:08:27.000000000","message":"The consensus seemed to be that this is almost completely uneventful, so I felt that info was reasonable. The concern was that this is almost definitely a user-caused event (fast create followed by delete), so logging a trace or warning in the logs is too loud. Obviously, it\u0027s up for discussion :)","commit_id":"4814280ce0af71ad38155d07eefea7c762935fa7"}]}