)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"71f081afa2445da21e872c0596afddec4e0ed778","unresolved":false,"context_lines":[{"line_number":2719,"context_line":"            except (exception.InstanceNotFound,"},{"line_number":2720,"context_line":"                    exception.UnexpectedDeletingTaskStateError):"},{"line_number":2721,"context_line":"                LOG.debug(\u0027Instance was deleted while rebuilding\u0027,"},{"line_number":2722,"context_line":"                          instance\u003dinstance)"},{"line_number":2723,"context_line":"            except Exception as e:"},{"line_number":2724,"context_line":"                _fail_migration(migration)"},{"line_number":2725,"context_line":"                self._notify_about_instance_usage(context, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_32d756ef","line":2722,"updated":"2016-01-15 21:11:43.000000000","message":"I think we want to have the other cleanup steps in this block too:\n\n _fail_migration(migration)\n self._notify_about_instance_usage(context, instance,\n         \u0027rebuild.error\u0027, fault\u003de)\n\nto set the migration state properly (if there is a migration object) and notify that the rebuild failed.","commit_id":"12f728d8663e9fc993b773ac53418693e2130624"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"1df93214958b99a18591006a5ef0dca94d29823e","unresolved":false,"context_lines":[{"line_number":2719,"context_line":"            except (exception.InstanceNotFound,"},{"line_number":2720,"context_line":"                    exception.UnexpectedDeletingTaskStateError):"},{"line_number":2721,"context_line":"                LOG.debug(\u0027Instance was deleted while rebuilding\u0027,"},{"line_number":2722,"context_line":"                          instance\u003dinstance)"},{"line_number":2723,"context_line":"            except Exception as e:"},{"line_number":2724,"context_line":"                _fail_migration(migration)"},{"line_number":2725,"context_line":"                self._notify_about_instance_usage(context, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_ec71cda9","line":2722,"in_reply_to":"da6ed579_32d756ef","updated":"2016-01-16 13:32:25.000000000","message":"Done","commit_id":"12f728d8663e9fc993b773ac53418693e2130624"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"994bb97af1175e981ac381cd6ff1750d9979b5e6","unresolved":false,"context_lines":[{"line_number":2777,"context_line":"                    exception.UnexpectedDeletingTaskStateError) as e:"},{"line_number":2778,"context_line":"                LOG.debug(\u0027Instance was deleted while rebuilding\u0027,"},{"line_number":2779,"context_line":"                          instance\u003dinstance)"},{"line_number":2780,"context_line":"                self._set_migration_status(migration, \u0027failed\u0027)"},{"line_number":2781,"context_line":"                self._notify_about_instance_usage(context, instance,"},{"line_number":2782,"context_line":"                        \u0027rebuild.error\u0027, fault\u003de)"},{"line_number":2783,"context_line":"            except Exception as e:"},{"line_number":2784,"context_line":"                self._set_migration_status(migration, \u0027failed\u0027)"},{"line_number":2785,"context_line":"                self._notify_about_instance_usage(context, instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_0a2660ce","line":2782,"range":{"start_line":2780,"start_character":16,"end_line":2782,"end_character":49},"updated":"2016-02-03 23:52:20.000000000","message":"I noticed other handlings of InstanceNotFound (\"instance disappeared\") in compute manager don\u0027t do anything extra, but I was thinking if some migration object was created or a notification was emitted saying rebuild started, it\u0027s best to close the loop on those if the instance disappears","commit_id":"9ae822d412885c33a6d2a801be40c5787e64306d"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"71f081afa2445da21e872c0596afddec4e0ed778","unresolved":false,"context_lines":[{"line_number":2652,"context_line":"        # Test that we do not raise on delete"},{"line_number":2653,"context_line":"        instance \u003d objects.Instance(uuid\u003d\u0027fake-uuid\u0027)"},{"line_number":2654,"context_line":"        ex \u003d exception.UnexpectedDeletingTaskStateError("},{"line_number":2655,"context_line":"            instance_uuid\u003dinstance.uuid, expected\u003d\u0027expected\u0027, actual\u003d\u0027actual\u0027)"},{"line_number":2656,"context_line":"        with test.nested("},{"line_number":2657,"context_line":"            mock.patch.object(self.compute, \u0027_get_compute_info\u0027),"},{"line_number":2658,"context_line":"            mock.patch.object(self.compute, \u0027_do_rebuild_instance_with_claim\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_5d945b43","line":2655,"updated":"2016-01-15 21:11:43.000000000","message":"I think we should test with raising InstanceNotFound too since that\u0027s not supposed to raise either with this patch","commit_id":"12f728d8663e9fc993b773ac53418693e2130624"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"1df93214958b99a18591006a5ef0dca94d29823e","unresolved":false,"context_lines":[{"line_number":2652,"context_line":"        # Test that we do not raise on delete"},{"line_number":2653,"context_line":"        instance \u003d objects.Instance(uuid\u003d\u0027fake-uuid\u0027)"},{"line_number":2654,"context_line":"        ex \u003d exception.UnexpectedDeletingTaskStateError("},{"line_number":2655,"context_line":"            instance_uuid\u003dinstance.uuid, expected\u003d\u0027expected\u0027, actual\u003d\u0027actual\u0027)"},{"line_number":2656,"context_line":"        with test.nested("},{"line_number":2657,"context_line":"            mock.patch.object(self.compute, \u0027_get_compute_info\u0027),"},{"line_number":2658,"context_line":"            mock.patch.object(self.compute, \u0027_do_rebuild_instance_with_claim\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_8c67f1e9","line":2655,"in_reply_to":"da6ed579_5d945b43","updated":"2016-01-16 13:32:25.000000000","message":"Done","commit_id":"12f728d8663e9fc993b773ac53418693e2130624"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"994bb97af1175e981ac381cd6ff1750d9979b5e6","unresolved":false,"context_lines":[{"line_number":2674,"context_line":"            self.compute.rebuild_instance(self.context, instance, None, None,"},{"line_number":2675,"context_line":"                                          None, None, None, None, None)"},{"line_number":2676,"context_line":"            mock_set.assert_called_once_with(None, \u0027failed\u0027)"},{"line_number":2677,"context_line":"            mock_notify.assert_called_once_with(mock.ANY, instance,"},{"line_number":2678,"context_line":"                                                \u0027rebuild.error\u0027, fault\u003dex)"},{"line_number":2679,"context_line":""},{"line_number":2680,"context_line":"    def test_rebuild_deleting(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_7449ff8a","line":2677,"range":{"start_line":2677,"start_character":48,"end_line":2677,"end_character":56},"updated":"2016-02-03 23:52:20.000000000","message":"FYI this could be checked by mock patching RequestContext.elevated","commit_id":"9ae822d412885c33a6d2a801be40c5787e64306d"}]}