)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d08fbce97aa635e6da2daf852d238f64ed66e6d1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"lead to can\u0027t pass check in [1], it doesn\u0027t test properly."},{"line_number":13,"context_line":"This commit fixes the issue."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1]https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/os_tenant_networks.py#L74"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I19a57db073359a9e58a16cd0de39d39aa95d2aa5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a5de9d1_9a1f3d5b","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":119},"updated":"2016-01-27 10:45:10.000000000","message":"This URL should use a commit hash instead of \u0027master\u0027 to prevent things going out of date.","commit_id":"86a807a1a09d457e21409478d493ae18de691f71"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"211304de9bfe583116552367868bb6cf5410bb47","unresolved":false,"context_lines":[{"line_number":12,"context_line":"lead to can\u0027t pass check in [1], it doesn\u0027t test properly."},{"line_number":13,"context_line":"This commit fixes the issue."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1]https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/os_tenant_networks.py#L74"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I19a57db073359a9e58a16cd0de39d39aa95d2aa5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a5de9d1_b587aad6","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":119},"in_reply_to":"7a5de9d1_9a1f3d5b","updated":"2016-01-27 11:15:34.000000000","message":"will update in next patchset","commit_id":"86a807a1a09d457e21409478d493ae18de691f71"}],"nova/tests/unit/api/openstack/compute/test_tenant_networks.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d12868039647533548328a71ebd7d01a27c779cd","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def fake_network_api_get_all(context):"},{"line_number":59,"context_line":"    if (context.project_id \u003d\u003d DEFAULT_TENANT_ID):"},{"line_number":60,"context_line":"        return DEFAULT_NETWORK"},{"line_number":61,"context_line":"    else:"},{"line_number":62,"context_line":"        return NETWORKS"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_bf56f559","line":60,"updated":"2015-11-11 17:05:15.000000000","message":"This change looks unrelated. Why are you no longer using \u0027NETWORKS_WITH_DEFAULT_NET\u0027?","commit_id":"7ef3ed9d8c7daaead8af2ef6f1f7ba2c91559536"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"328f670ca1a4b24371ce4b8fd3718529e9bf523a","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def fake_network_api_get_all(context):"},{"line_number":59,"context_line":"    if (context.project_id \u003d\u003d DEFAULT_TENANT_ID):"},{"line_number":60,"context_line":"        return DEFAULT_NETWORK"},{"line_number":61,"context_line":"    else:"},{"line_number":62,"context_line":"        return NETWORKS"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_512a47dc","line":60,"in_reply_to":"da85f559_bf56f559","updated":"2015-11-12 02:49:40.000000000","message":"This is key change for this commit\n\nwe call  nova.network.api.API.get_all  twice to get network with default network.  see   https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/os_tenant_networks.py#L92\nand  https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/os_tenant_networks.py#L85\n\n\nThe wrong usage before is that returning  network with default network  in one call , due to it never passes the check  https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/os_tenant_networks.py#L74,  that\u0027s wrong.","commit_id":"7ef3ed9d8c7daaead8af2ef6f1f7ba2c91559536"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"26b92d60e74ccc680d8ab2c9991f2ff58061fbc5","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        get_mock.assert_called_once_with(ctxt, 1)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @mock.patch(\u0027nova.network.api.API.get_all\u0027)"},{"line_number":162,"context_line":"    def _test_network_index(self, get_all_mock, default_net\u003d\u0027True\u0027):"},{"line_number":163,"context_line":"        CONF.set_override(\"use_neutron_default_nets\", default_net)"},{"line_number":164,"context_line":"        get_all_mock.side_effect \u003d fake_network_api_get_all"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_59cd772f","line":162,"updated":"2015-11-29 09:16:07.000000000","message":"why are you changing this form a boolean to a string?\nthis is not related to the configuration variable but to a local parameter","commit_id":"3b24a4a8f331e2e528e1eef11b50f03616e055df"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"138f8f26174266112a185a46ac89d6515883b95f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        get_mock.assert_called_once_with(ctxt, 1)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @mock.patch(\u0027nova.network.api.API.get_all\u0027)"},{"line_number":162,"context_line":"    def _test_network_index(self, get_all_mock, default_net\u003d\u0027True\u0027):"},{"line_number":163,"context_line":"        CONF.set_override(\"use_neutron_default_nets\", default_net)"},{"line_number":164,"context_line":"        get_all_mock.side_effect \u003d fake_network_api_get_all"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_07b54a7c","line":162,"in_reply_to":"9a8ffd7b_59cd772f","updated":"2015-12-10 06:39:41.000000000","message":"see my following commit in  https://review.openstack.org/#/c/242416/. \nconfig option use_neutron_default_nets is StrOpt, so we need pass parameter default_net with string \u0027True\u0027.","commit_id":"3b24a4a8f331e2e528e1eef11b50f03616e055df"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"6e3053f9f18001101cb43d7376147eda67eed795","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @mock.patch(\u0027nova.network.api.API.get_all\u0027)"},{"line_number":160,"context_line":"    def _test_network_index(self, get_all_mock, default_net\u003dTrue):"},{"line_number":161,"context_line":"        CONF.set_override(\"use_neutron_default_nets\", default_net)"},{"line_number":162,"context_line":"        get_all_mock.side_effect \u003d fake_network_api_get_all"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        expected \u003d NETWORKS"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_ba14e09f","side":"PARENT","line":161,"range":{"start_line":161,"start_character":27,"end_line":161,"end_character":51},"updated":"2016-01-29 21:26:35.000000000","message":"we can\u0027t change this from string to bool? \nnot sure why use string to represent a boot value..","commit_id":"a37590c21bca175f642792b6707d2eb4e6349e51"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"f9366d5028cf108706a62bc4353d6056c5a2cf44","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @mock.patch(\u0027nova.network.api.API.get_all\u0027)"},{"line_number":160,"context_line":"    def _test_network_index(self, get_all_mock, default_net\u003dTrue):"},{"line_number":161,"context_line":"        CONF.set_override(\"use_neutron_default_nets\", default_net)"},{"line_number":162,"context_line":"        get_all_mock.side_effect \u003d fake_network_api_get_all"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        expected \u003d NETWORKS"}],"source_content_type":"text/x-python","patch_set":11,"id":"3afc51ec_db2508c3","side":"PARENT","line":161,"range":{"start_line":161,"start_character":27,"end_line":161,"end_character":51},"in_reply_to":"7a5de9d1_ba14e09f","updated":"2016-03-12 08:36:23.000000000","message":"will change it to boolean type.","commit_id":"a37590c21bca175f642792b6707d2eb4e6349e51"}]}