)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"514b08238afbf77a1f2d0e921aa44fa81459a5ea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Repair and rename test_is_volume_backed_instance_no_bdms()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The function did not assert the result of is_volume_backed_instance(), which"},{"line_number":10,"context_line":"is fixed here.  The function uses a mockup of get_by_instance_uuid() that"},{"line_number":11,"context_line":"returns an empty block device map, instead of calling"},{"line_number":12,"context_line":"block_device_make_list() with an explicit empty bdm as in another test case."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_5a12f263","line":9,"updated":"2015-11-09 15:39:23.000000000","message":"Don\u0027t know if a bot will pick this up, but this should be limited to 70 chars.","commit_id":"d8396823007ca8764d8617565b9cc3db17e753b4"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"514b08238afbf77a1f2d0e921aa44fa81459a5ea","unresolved":false,"context_lines":[{"line_number":8981,"context_line":"        self.assertTrue("},{"line_number":8982,"context_line":"            self.compute_api.is_volume_backed_instance(ctxt, instance, bdms))"},{"line_number":8983,"context_line":""},{"line_number":8984,"context_line":"    def test_is_volume_backed_instance_mocked_empty_bdm(self):"},{"line_number":8985,"context_line":"        ctxt \u003d self.context"},{"line_number":8986,"context_line":"        instance \u003d self._create_fake_instance_obj()"},{"line_number":8987,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_ba175ea2","line":8984,"updated":"2015-11-09 15:39:23.000000000","message":"Sorry, Sven, I\u0027m going to bikeshed this :)\n\nIt doesn\u0027t look right to have \u0027mocked\u0027 in there. It\u0027s also a bit confusing as it\u0027s using mox. I thought the original name was ok, tbh.\n\nWhile you\u0027re touching this, though, you might consider replacing mox with mock? Not a requirement, but nice to have.","commit_id":"d8396823007ca8764d8617565b9cc3db17e753b4"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"e8aabd24cc09ccdc99778149f028c489622a7bb5","unresolved":false,"context_lines":[{"line_number":8981,"context_line":"        self.assertTrue("},{"line_number":8982,"context_line":"            self.compute_api.is_volume_backed_instance(ctxt, instance, bdms))"},{"line_number":8983,"context_line":""},{"line_number":8984,"context_line":"    def test_is_volume_backed_instance_mocked_empty_bdm(self):"},{"line_number":8985,"context_line":"        ctxt \u003d self.context"},{"line_number":8986,"context_line":"        instance \u003d self._create_fake_instance_obj()"},{"line_number":8987,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_51838b04","line":8984,"in_reply_to":"da85f559_ba175ea2","updated":"2015-11-10 11:36:07.000000000","message":"I think the name before is confusing because in the tests above there are two other cases with \"no bdms\", so it\u0027s not really clear what\u0027s the difference to this one here.","commit_id":"d8396823007ca8764d8617565b9cc3db17e753b4"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"514b08238afbf77a1f2d0e921aa44fa81459a5ea","unresolved":false,"context_lines":[{"line_number":8992,"context_line":"                            block_device_obj.block_device_make_list(ctxt, []))"},{"line_number":8993,"context_line":"        self.mox.ReplayAll()"},{"line_number":8994,"context_line":""},{"line_number":8995,"context_line":"        self.assertFalse("},{"line_number":8996,"context_line":"            self.compute_api.is_volume_backed_instance(ctxt, instance, None))"},{"line_number":8997,"context_line":""},{"line_number":8998,"context_line":"    def test_reservation_id_one_instance(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_3a24ce0b","line":8995,"updated":"2015-11-09 15:39:23.000000000","message":"Nice catch.","commit_id":"d8396823007ca8764d8617565b9cc3db17e753b4"}]}