)]}'
{"nova/virt/libvirt/volume.py":[{"author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"change_message_id":"826ffe5104da97dff890536de416de6566e96b49","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        sup.disconnect_volume(connection_info, mount_device)"},{"line_number":173,"context_line":"        iscsi_properties \u003d connection_info[\u0027data\u0027]"},{"line_number":174,"context_line":"        self._iscsiadm_update(iscsi_properties, \"node.startup\", \"manual\")"},{"line_number":175,"context_line":"        self._run_iscsiadm(iscsi_properties, (\"--logout\",),"},{"line_number":176,"context_line":"                           check_exit_code\u003d[0, 255])"},{"line_number":177,"context_line":"        self._run_iscsiadm(iscsi_properties, (\u0027--op\u0027, \u0027delete\u0027),"},{"line_number":178,"context_line":"                           check_exit_code\u003d[0, 255])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAC3%2F%2F8Jo%3D","line":175,"updated":"2011-12-17 01:15:21.000000000","message":"should _run_iscsiadm support the second arg as a string instead of a list?  this seems like it could be a common mistake","commit_id":"a135c8ecd16bb6a97743e4be1b060daff874879e"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"3251f7aece4c0b9c7f0d9c6533a55f65a53b7329","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        sup.disconnect_volume(connection_info, mount_device)"},{"line_number":173,"context_line":"        iscsi_properties \u003d connection_info[\u0027data\u0027]"},{"line_number":174,"context_line":"        self._iscsiadm_update(iscsi_properties, \"node.startup\", \"manual\")"},{"line_number":175,"context_line":"        self._run_iscsiadm(iscsi_properties, (\"--logout\",),"},{"line_number":176,"context_line":"                           check_exit_code\u003d[0, 255])"},{"line_number":177,"context_line":"        self._run_iscsiadm(iscsi_properties, (\u0027--op\u0027, \u0027delete\u0027),"},{"line_number":178,"context_line":"                           check_exit_code\u003d[0, 255])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAC3%2F%2F7sY%3D","line":175,"in_reply_to":"AAAAC3%2F%2F8Jo%3D","updated":"2011-12-20 17:59:18.000000000","message":"Seems like writing the list literal as [\u0027--logout\u0027] is enough as the magic comma is not required.  utils.execute wants a list anyway","commit_id":"a135c8ecd16bb6a97743e4be1b060daff874879e"}]}