)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ec4a2be4f3d62d66fbacf757254b4e07f5f1f5ad","unresolved":false,"context_lines":[{"line_number":4385,"context_line":"def provider_fw_rule_destroy(context, rule_id):"},{"line_number":4386,"context_line":"    context.session.query(models.ProviderFirewallRule).\\"},{"line_number":4387,"context_line":"        filter_by(id\u003drule_id).\\"},{"line_number":4388,"context_line":"        soft_delete()"},{"line_number":4389,"context_line":""},{"line_number":4390,"context_line":""},{"line_number":4391,"context_line":"###################"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_570100ae","line":4388,"updated":"2015-11-11 13:02:04.000000000","message":"is there a reason this isn\u0027t just a model_query like the above calls? I feel like if this is going to be different for a reason, we should explain it in comments.","commit_id":"1c8a9baf1d13c310b4dd1e5f0dd327d55997a973"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"35b34ab4c0cae59abe202c396d55c16e869d7c17","unresolved":false,"context_lines":[{"line_number":4385,"context_line":"def provider_fw_rule_destroy(context, rule_id):"},{"line_number":4386,"context_line":"    context.session.query(models.ProviderFirewallRule).\\"},{"line_number":4387,"context_line":"        filter_by(id\u003drule_id).\\"},{"line_number":4388,"context_line":"        soft_delete()"},{"line_number":4389,"context_line":""},{"line_number":4390,"context_line":""},{"line_number":4391,"context_line":"###################"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_ab1ac46c","line":4388,"in_reply_to":"3a7e1126_5a9edbb9","updated":"2016-02-03 16:25:19.000000000","message":"The reasoning for why this is session.query vs model_query is a separate issue from what this patch is addressing.  I would love to see a comment as well, but I don\u0027t expect to see it in this patch.","commit_id":"1c8a9baf1d13c310b4dd1e5f0dd327d55997a973"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"45516b1a47eb6ec36593c52d54378fe5391ccb24","unresolved":false,"context_lines":[{"line_number":4385,"context_line":"def provider_fw_rule_destroy(context, rule_id):"},{"line_number":4386,"context_line":"    context.session.query(models.ProviderFirewallRule).\\"},{"line_number":4387,"context_line":"        filter_by(id\u003drule_id).\\"},{"line_number":4388,"context_line":"        soft_delete()"},{"line_number":4389,"context_line":""},{"line_number":4390,"context_line":""},{"line_number":4391,"context_line":"###################"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_57b8d210","line":4388,"in_reply_to":"da85f559_570100ae","updated":"2015-11-12 15:51:18.000000000","message":"We don\u0027t refactor the code, just make switch to the new way. Do you think it is important to change this?","commit_id":"1c8a9baf1d13c310b4dd1e5f0dd327d55997a973"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"ca168b2661b8ccb1597e3616084dc12dbcb9ac59","unresolved":false,"context_lines":[{"line_number":4385,"context_line":"def provider_fw_rule_destroy(context, rule_id):"},{"line_number":4386,"context_line":"    context.session.query(models.ProviderFirewallRule).\\"},{"line_number":4387,"context_line":"        filter_by(id\u003drule_id).\\"},{"line_number":4388,"context_line":"        soft_delete()"},{"line_number":4389,"context_line":""},{"line_number":4390,"context_line":""},{"line_number":4391,"context_line":"###################"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_5a9edbb9","line":4388,"in_reply_to":"da85f559_57b8d210","updated":"2015-12-21 15:36:17.000000000","message":"In my opinion it is ok","commit_id":"1c8a9baf1d13c310b4dd1e5f0dd327d55997a973"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"45516b1a47eb6ec36593c52d54378fe5391ccb24","unresolved":false,"context_lines":[{"line_number":4563,"context_line":"@main_context_manager.writer"},{"line_number":4564,"context_line":"def console_delete(context, console_id):"},{"line_number":4565,"context_line":"    # NOTE(mdragon): consoles are meant to be transient."},{"line_number":4566,"context_line":"    context.session.query(models.Console).\\"},{"line_number":4567,"context_line":"        filter_by(id\u003dconsole_id).\\"},{"line_number":4568,"context_line":"        delete()"},{"line_number":4569,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_b756decb","line":4566,"updated":"2015-11-12 15:51:18.000000000","message":"the same here","commit_id":"1c8a9baf1d13c310b4dd1e5f0dd327d55997a973"}]}