)]}'
{"nova/api/openstack/compute/evacuate.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5249a14e22455aee33e576a822dc7f4af4c8b557","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _get_on_shared_storage(self, req, evacuate_body):"},{"line_number":46,"context_line":"        if (req.api_version_request \u003c"},{"line_number":47,"context_line":"                api_version_request.APIVersionRequest(\"2.13\")):"},{"line_number":48,"context_line":"            return strutils.bool_from_string(evacuate_body[\"onSharedStorage\"])"},{"line_number":49,"context_line":"        else:"},{"line_number":50,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_498e40d1","line":47,"updated":"2015-11-11 14:26:20.000000000","message":"We needn\u0027t check the version again, we can just write like\n\nif evacuate_body.get(\u0027onSharedStorage\u0027, None):\n\n   ....","commit_id":"5581ce501163685f20fb31c0f9d0ef5d018dba0b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"07bb5854ae905d401ecb15d3629352fb6adf618f","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _get_on_shared_storage(self, req, evacuate_body):"},{"line_number":46,"context_line":"        if (req.api_version_request \u003c"},{"line_number":47,"context_line":"                api_version_request.APIVersionRequest(\"2.13\")):"},{"line_number":48,"context_line":"            return strutils.bool_from_string(evacuate_body[\"onSharedStorage\"])"},{"line_number":49,"context_line":"        else:"},{"line_number":50,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_e9eca2bc","line":47,"in_reply_to":"da85f559_498e40d1","updated":"2015-11-12 10:40:47.000000000","message":"This function is called for v2.13, v2.1 and v2.1-compatibility mode as well. In v2.1 this is cool as the schema enforces that onSharedStorage is present. I might be wrong here but as far as I know in case of v2.1-compatibility we are turning of schema validation. Therefore in that case your code would accept that onSharedStorage is missing from the body which is a change in the v2.0 semantic we don\u0027t want to do.","commit_id":"5581ce501163685f20fb31c0f9d0ef5d018dba0b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5249a14e22455aee33e576a822dc7f4af4c8b557","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                CONF.enable_instance_password):"},{"line_number":127,"context_line":"            return {\u0027adminPass\u0027: password}"},{"line_number":128,"context_line":"        else:"},{"line_number":129,"context_line":"            return {}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"class Evacuate(extensions.V21APIExtensionBase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_5c7e001a","line":129,"updated":"2015-11-11 14:26:20.000000000","message":"If there isn\u0027t anything returned for 2.13, we needn\u0027t return \u0027{}\u0027, just return None.","commit_id":"5581ce501163685f20fb31c0f9d0ef5d018dba0b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"07bb5854ae905d401ecb15d3629352fb6adf618f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                CONF.enable_instance_password):"},{"line_number":127,"context_line":"            return {\u0027adminPass\u0027: password}"},{"line_number":128,"context_line":"        else:"},{"line_number":129,"context_line":"            return {}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"class Evacuate(extensions.V21APIExtensionBase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_e999027a","line":129,"in_reply_to":"da85f559_5c7e001a","updated":"2015-11-12 10:40:47.000000000","message":"Done","commit_id":"5581ce501163685f20fb31c0f9d0ef5d018dba0b"}],"nova/api/openstack/compute/schemas/evacuate.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5249a14e22455aee33e576a822dc7f4af4c8b557","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"evacuate_v213 \u003d copy.deepcopy(evacuate)"},{"line_number":39,"context_line":"del evacuate_v213[\u0027properties\u0027][\u0027evacuate\u0027][\u0027properties\u0027][\u0027onSharedStorage\u0027]"},{"line_number":40,"context_line":"evacuate_v213[\u0027properties\u0027][\u0027evacuate\u0027][\u0027required\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_bc228ca1","line":40,"updated":"2015-11-11 14:26:20.000000000","message":"we can just removed this \u0027required\u0027","commit_id":"5581ce501163685f20fb31c0f9d0ef5d018dba0b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"07bb5854ae905d401ecb15d3629352fb6adf618f","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"evacuate_v213 \u003d copy.deepcopy(evacuate)"},{"line_number":39,"context_line":"del evacuate_v213[\u0027properties\u0027][\u0027evacuate\u0027][\u0027properties\u0027][\u0027onSharedStorage\u0027]"},{"line_number":40,"context_line":"evacuate_v213[\u0027properties\u0027][\u0027evacuate\u0027][\u0027required\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_c9c75e62","line":40,"in_reply_to":"da85f559_bc228ca1","updated":"2015-11-12 10:40:47.000000000","message":"Done","commit_id":"5581ce501163685f20fb31c0f9d0ef5d018dba0b"}],"nova/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"----"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  Remove ``onSharedStorage`` from the body of the"},{"line_number":138,"context_line":"  ``/v2.1/{tenant_id}/servers/{server_id}/action`` request if the action is"},{"line_number":139,"context_line":"  ``evacuate``. Nova will automatically detect if the instance is on shared"},{"line_number":140,"context_line":"  storage. Also adminPass is removed from the response body."}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a740942_5862673f","line":138,"updated":"2015-12-14 10:59:02.000000000","message":"maybe we can just say, remove onSharedStorage parameter from server\u0027s evacuate action. As we just working on the remove \u0027project_id\u0027 from the url. If mention the url, we need change it in the later.","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":135,"context_line":"----"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  Remove ``onSharedStorage`` from the body of the"},{"line_number":138,"context_line":"  ``/v2.1/{tenant_id}/servers/{server_id}/action`` request if the action is"},{"line_number":139,"context_line":"  ``evacuate``. Nova will automatically detect if the instance is on shared"},{"line_number":140,"context_line":"  storage. Also adminPass is removed from the response body."}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a740942_0e4252ae","line":138,"in_reply_to":"7a740942_5862673f","updated":"2015-12-14 12:57:35.000000000","message":"Done","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  Remove ``onSharedStorage`` from the body of the"},{"line_number":138,"context_line":"  ``/v2.1/{tenant_id}/servers/{server_id}/action`` request if the action is"},{"line_number":139,"context_line":"  ``evacuate``. Nova will automatically detect if the instance is on shared"},{"line_number":140,"context_line":"  storage. Also adminPass is removed from the response body."}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a740942_f83c7330","line":140,"updated":"2015-12-14 10:59:02.000000000","message":"It\u0027s better to add a little bit say, user can get password from \u0027/v2.1/{tenant_id}/servers/{server_id}/os-server-password\u0027","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  Remove ``onSharedStorage`` from the body of the"},{"line_number":138,"context_line":"  ``/v2.1/{tenant_id}/servers/{server_id}/action`` request if the action is"},{"line_number":139,"context_line":"  ``evacuate``. Nova will automatically detect if the instance is on shared"},{"line_number":140,"context_line":"  storage. Also adminPass is removed from the response body."}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a740942_4efcda71","line":140,"in_reply_to":"7a740942_f83c7330","updated":"2015-12-14 12:57:35.000000000","message":"If we remove tenant_id from the above line then I guess we shall not add it here so I tried to add this in a way that does not contain the tenant_id part","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"}],"nova/tests/functional/api_sample_tests/test_evacuate.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            self._verify_response(server_resp, subs, response,"},{"line_number":76,"context_line":"                                  expected_resp_code)"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            # Note(gibi):no server_resp means we expect empty body as"},{"line_number":79,"context_line":"            # a response"},{"line_number":80,"context_line":"            self.assertEqual(expected_resp_code, response.status_code)"},{"line_number":81,"context_line":"            self.assertEqual(\u0027\u0027, response.content)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_33f45cef","line":78,"updated":"2015-12-14 10:59:02.000000000","message":"In normally, we write note like this \"# NOTE(gibi): no server_resp means.....\"  We should write \u0027NOTE\u0027 and there is space between \":\" and \"no server_resp...\"","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            self._verify_response(server_resp, subs, response,"},{"line_number":76,"context_line":"                                  expected_resp_code)"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            # Note(gibi):no server_resp means we expect empty body as"},{"line_number":79,"context_line":"            # a response"},{"line_number":80,"context_line":"            self.assertEqual(expected_resp_code, response.status_code)"},{"line_number":81,"context_line":"            self.assertEqual(\u0027\u0027, response.content)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_2e52ae67","line":78,"in_reply_to":"7a740942_33f45cef","updated":"2015-12-14 12:57:35.000000000","message":"Done","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class EvacuateJsonTestV213(EvacuateJsonTest):"},{"line_number":118,"context_line":"    request_api_version \u003d \u00272.13\u0027"},{"line_number":119,"context_line":"    scenarios \u003d [(\u0027v2_13\u0027, {})]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @mock.patch(\u0027nova.conductor.manager.ComputeTaskManager.rebuild_instance\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_33a69c0f","line":118,"updated":"2015-12-14 10:59:02.000000000","message":"And this patch just merged https://review.openstack.org/#/c/256625/\n\nyou need use \u0027microversion\u0027 instead of \u0027request_api_version\u0027","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class EvacuateJsonTestV213(EvacuateJsonTest):"},{"line_number":118,"context_line":"    request_api_version \u003d \u00272.13\u0027"},{"line_number":119,"context_line":"    scenarios \u003d [(\u0027v2_13\u0027, {})]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @mock.patch(\u0027nova.conductor.manager.ComputeTaskManager.rebuild_instance\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_8197f3ea","line":118,"in_reply_to":"7a740942_33a69c0f","updated":"2015-12-14 12:57:35.000000000","message":"Done","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class EvacuateJsonTestV213(EvacuateJsonTest):"},{"line_number":118,"context_line":"    request_api_version \u003d \u00272.13\u0027"},{"line_number":119,"context_line":"    scenarios \u003d [(\u0027v2_13\u0027, {})]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @mock.patch(\u0027nova.conductor.manager.ComputeTaskManager.rebuild_instance\u0027)"},{"line_number":122,"context_line":"    def test_server_evacuate(self, rebuild_mock):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_d33cf8c9","line":119,"updated":"2015-12-14 10:59:02.000000000","message":"Current some patches are going to clean up sample tests. There should write like line 114 at https://review.openstack.org/#/c/256625/2/nova/tests/functional/api_sample_tests/test_services.py","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class EvacuateJsonTestV213(EvacuateJsonTest):"},{"line_number":118,"context_line":"    request_api_version \u003d \u00272.13\u0027"},{"line_number":119,"context_line":"    scenarios \u003d [(\u0027v2_13\u0027, {})]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @mock.patch(\u0027nova.conductor.manager.ComputeTaskManager.rebuild_instance\u0027)"},{"line_number":122,"context_line":"    def test_server_evacuate(self, rebuild_mock):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_01b30399","line":119,"in_reply_to":"7a740942_d33cf8c9","updated":"2015-12-14 12:57:35.000000000","message":"Done","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def test_server_evacuate(self, rebuild_mock):"},{"line_number":123,"context_line":"        # Note (wingwj): The host can\u0027t be the same one"},{"line_number":124,"context_line":"        req_subs \u003d {"},{"line_number":125,"context_line":"            \u0027host\u0027: \u0027testHost\u0027,"},{"line_number":126,"context_line":"            \"adminPass\": \"MySecretPass\","},{"line_number":127,"context_line":"        }"},{"line_number":128,"context_line":"        self._test_evacuate(req_subs, \u0027server-evacuate-req\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_5397a8eb","line":125,"updated":"2015-12-14 10:59:02.000000000","message":"Why in sample doc/api_samples/os-evacuate/v2.13/server-evacuate-req.json, the host is a uuid?","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def test_server_evacuate(self, rebuild_mock):"},{"line_number":123,"context_line":"        # Note (wingwj): The host can\u0027t be the same one"},{"line_number":124,"context_line":"        req_subs \u003d {"},{"line_number":125,"context_line":"            \u0027host\u0027: \u0027testHost\u0027,"},{"line_number":126,"context_line":"            \"adminPass\": \"MySecretPass\","},{"line_number":127,"context_line":"        }"},{"line_number":128,"context_line":"        self._test_evacuate(req_subs, \u0027server-evacuate-req\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_c4b74938","line":125,"in_reply_to":"7a740942_5397a8eb","updated":"2015-12-14 12:57:35.000000000","message":"Fixed the sample","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"}],"nova/tests/unit/api/openstack/compute/test_evacuate.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        self.assertIsNone(res)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @unittest.skip(\u0027Password is not returned from micro version 2.13 \u0027)"},{"line_number":339,"context_line":"    def test_evacuate_disable_password_return(self):"},{"line_number":340,"context_line":"        pass"},{"line_number":341,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_53dfa80c","line":338,"updated":"2015-12-14 10:59:02.000000000","message":"nit, s/micro version/Microversions/","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        self.assertIsNone(res)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @unittest.skip(\u0027Password is not returned from micro version 2.13 \u0027)"},{"line_number":339,"context_line":"    def test_evacuate_disable_password_return(self):"},{"line_number":340,"context_line":"        pass"},{"line_number":341,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_0eb33299","line":338,"in_reply_to":"7a740942_53dfa80c","updated":"2015-12-14 12:57:35.000000000","message":"Done","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    def test_evacuate_disable_password_return(self):"},{"line_number":340,"context_line":"        pass"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    @unittest.skip(\u0027Password is not returned from micro version 2.13 \u0027)"},{"line_number":343,"context_line":"    def test_evacuate_enable_password_return(self):"},{"line_number":344,"context_line":"        pass"},{"line_number":345,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_33e8dcb2","line":342,"updated":"2015-12-14 10:59:02.000000000","message":"ditto","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    def test_evacuate_disable_password_return(self):"},{"line_number":340,"context_line":"        pass"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    @unittest.skip(\u0027Password is not returned from micro version 2.13 \u0027)"},{"line_number":343,"context_line":"    def test_evacuate_enable_password_return(self):"},{"line_number":344,"context_line":"        pass"},{"line_number":345,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_2eae2e2e","line":342,"in_reply_to":"7a740942_33e8dcb2","updated":"2015-12-14 12:57:35.000000000","message":"Done","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    def test_evacuate_enable_password_return(self):"},{"line_number":344,"context_line":"        pass"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @unittest.skip(\u0027onSharedStorage was removed from micro version 2.13 \u0027)"},{"line_number":347,"context_line":"    def test_evacuate_instance_with_invalid_on_shared_storage(self):"},{"line_number":348,"context_line":"        pass"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_d3d39802","line":346,"updated":"2015-12-14 10:59:02.000000000","message":"ditto","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    def test_evacuate_enable_password_return(self):"},{"line_number":344,"context_line":"        pass"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @unittest.skip(\u0027onSharedStorage was removed from micro version 2.13 \u0027)"},{"line_number":347,"context_line":"    def test_evacuate_instance_with_invalid_on_shared_storage(self):"},{"line_number":348,"context_line":"        pass"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_cea8ca22","line":346,"in_reply_to":"7a740942_d3d39802","updated":"2015-12-14 12:57:35.000000000","message":"Done","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    def test_evacuate_instance_with_invalid_on_shared_storage(self):"},{"line_number":348,"context_line":"        pass"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    @unittest.skip(\u0027onSharedStorage was removed from micro version 2.13 \u0027)"},{"line_number":351,"context_line":"    @mock.patch(\u0027nova.objects.Instance.save\u0027)"},{"line_number":352,"context_line":"    def test_evacuate_not_shared_pass_generated(self, mock_save):"},{"line_number":353,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_b3d4cce8","line":350,"updated":"2015-12-14 10:59:02.000000000","message":"ditto","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    def test_evacuate_instance_with_invalid_on_shared_storage(self):"},{"line_number":348,"context_line":"        pass"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    @unittest.skip(\u0027onSharedStorage was removed from micro version 2.13 \u0027)"},{"line_number":351,"context_line":"    @mock.patch(\u0027nova.objects.Instance.save\u0027)"},{"line_number":352,"context_line":"    def test_evacuate_not_shared_pass_generated(self, mock_save):"},{"line_number":353,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_eea34641","line":350,"in_reply_to":"7a740942_b3d4cce8","updated":"2015-12-14 12:57:35.000000000","message":"Done","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                          self.controller._evacuate,"},{"line_number":377,"context_line":"                          self.req, self.UUID, body\u003dbody)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    @unittest.skip(\u0027onSharedStorage was removed from micro version 2.13 \u0027)"},{"line_number":380,"context_line":"    @mock.patch(\u0027nova.objects.Instance.save\u0027)"},{"line_number":381,"context_line":"    def test_evacuate_shared_and_pass(self, mock_save):"},{"line_number":382,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_73098494","line":379,"updated":"2015-12-14 10:59:02.000000000","message":"ditto","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                          self.controller._evacuate,"},{"line_number":377,"context_line":"                          self.req, self.UUID, body\u003dbody)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    @unittest.skip(\u0027onSharedStorage was removed from micro version 2.13 \u0027)"},{"line_number":380,"context_line":"    @mock.patch(\u0027nova.objects.Instance.save\u0027)"},{"line_number":381,"context_line":"    def test_evacuate_shared_and_pass(self, mock_save):"},{"line_number":382,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_ae68def5","line":379,"in_reply_to":"7a740942_73098494","updated":"2015-12-14 12:57:35.000000000","message":"Done","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":381,"context_line":"    def test_evacuate_shared_and_pass(self, mock_save):"},{"line_number":382,"context_line":"        pass"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    @unittest.skip(\u0027from micro version 2.13 it is covered with \u0027"},{"line_number":385,"context_line":"                   \u0027test_evacuate_pass_generated\u0027)"},{"line_number":386,"context_line":"    def test_evacuate_instance_with_target(self):"},{"line_number":387,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_13ae0081","line":384,"updated":"2015-12-14 10:59:02.000000000","message":"ditto","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":381,"context_line":"    def test_evacuate_shared_and_pass(self, mock_save):"},{"line_number":382,"context_line":"        pass"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    @unittest.skip(\u0027from micro version 2.13 it is covered with \u0027"},{"line_number":385,"context_line":"                   \u0027test_evacuate_pass_generated\u0027)"},{"line_number":386,"context_line":"    def test_evacuate_instance_with_target(self):"},{"line_number":387,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_4e6b7af1","line":384,"in_reply_to":"7a740942_13ae0081","updated":"2015-12-14 12:57:35.000000000","message":"Done","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"}],"releasenotes/notes/remove-on-shared-storage-flag-from-evacuate-api-76a3d58616479fe9.yaml":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The onSharedStorage paramteres is removed from the body of the"},{"line_number":4,"context_line":"    /v2.1/{tenant_id}/servers/{server_id}/action request in microversion 2.13"},{"line_number":5,"context_line":"    if the action is evacuate. Nova will automatically detect if the instance"},{"line_number":6,"context_line":"    is on shared storage. Also adminPass is removed from the response body"},{"line_number":7,"context_line":"    which makes the response body empty."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a740942_b3512c32","line":4,"updated":"2015-12-14 10:59:02.000000000","message":"same suggestion as in nova/api/openstack/rest_api_version_history.rst","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The onSharedStorage paramteres is removed from the body of the"},{"line_number":4,"context_line":"    /v2.1/{tenant_id}/servers/{server_id}/action request in microversion 2.13"},{"line_number":5,"context_line":"    if the action is evacuate. Nova will automatically detect if the instance"},{"line_number":6,"context_line":"    is on shared storage. Also adminPass is removed from the response body"},{"line_number":7,"context_line":"    which makes the response body empty."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a740942_816053a6","line":4,"in_reply_to":"7a740942_b3512c32","updated":"2015-12-14 12:57:35.000000000","message":"Done","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"61bb151db0098b179c5a574ec650e4f8756f155c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    /v2.1/{tenant_id}/servers/{server_id}/action request in microversion 2.13"},{"line_number":5,"context_line":"    if the action is evacuate. Nova will automatically detect if the instance"},{"line_number":6,"context_line":"    is on shared storage. Also adminPass is removed from the response body"},{"line_number":7,"context_line":"    which makes the response body empty."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a740942_73366404","line":7,"updated":"2015-12-14 10:59:02.000000000","message":"ditto, same suggestion in nova/api/openstack/rest_api_version_history.rst","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3593116f3a8380aab9a6e32be2df8acb32451ccb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    /v2.1/{tenant_id}/servers/{server_id}/action request in microversion 2.13"},{"line_number":5,"context_line":"    if the action is evacuate. Nova will automatically detect if the instance"},{"line_number":6,"context_line":"    is on shared storage. Also adminPass is removed from the response body"},{"line_number":7,"context_line":"    which makes the response body empty."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a740942_a1630fb0","line":7,"in_reply_to":"7a740942_73366404","updated":"2015-12-14 12:57:35.000000000","message":"Done","commit_id":"565c8a28c147fb49336e3ecbd350c9294f53dc28"}]}