)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff278155afaecca6c7e35c48aa9816499aa9c6e4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix is_volume_backed_instance() for unset image_ref"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"is_volume_backed_instance() assumed from old times, that if"},{"line_number":10,"context_line":"instance_ref is not set, the instance is always volume backed.  This"},{"line_number":11,"context_line":"is not true anymore, since block device mappings can also reference"},{"line_number":12,"context_line":"images as source.  This fix adapts the test cases and function"},{"line_number":13,"context_line":"accordingly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_407d58b0","line":10,"updated":"2015-11-12 21:34:41.000000000","message":"s/instance_ref/image_ref/","commit_id":"fbae555ce0eac6efdb11dc1467005e06a11937d8"}],"nova/compute/api.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"2c587dde4977f47c5da9495120f7b7de3a281d4d","unresolved":false,"context_lines":[{"line_number":3252,"context_line":""},{"line_number":3253,"context_line":"    def is_volume_backed_instance(self, context, instance, bdms\u003dNone):"},{"line_number":3254,"context_line":"        root_bdm \u003d self._get_root_bdm(context, instance, bdms)"},{"line_number":3255,"context_line":"        if root_bdm:"},{"line_number":3256,"context_line":"            return root_bdm.is_volume"},{"line_number":3257,"context_line":"        # legacy case without bdm"},{"line_number":3258,"context_line":"        # we _assume_ that instance is backed by a volume, exactly if image_ref"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_9dd0eff7","line":3255,"updated":"2015-11-11 12:08:13.000000000","message":"My preference is for \u0027if root_bdm is None\u0027 here, but as this isn\u0027t a change from before this is just a nit.","commit_id":"bd822764065962926af650c25ba44279d4f2a28c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"028cf0c028d8676618702a3907e913718c45e975","unresolved":false,"context_lines":[{"line_number":3255,"context_line":"        if root_bdm:"},{"line_number":3256,"context_line":"            return root_bdm.is_volume"},{"line_number":3257,"context_line":"        # legacy case without bdm"},{"line_number":3258,"context_line":"        # we _assume_ that instance is backed by a volume, exactly if image_ref"},{"line_number":3259,"context_line":"        # is not set"},{"line_number":3260,"context_line":"        return not instance.image_ref"},{"line_number":3261,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_3f3e7728","line":3258,"updated":"2015-11-11 21:58:12.000000000","message":"you can leave off the \", exactly\" and it reads a little better IMO.","commit_id":"bd822764065962926af650c25ba44279d4f2a28c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"a2b02e53d1376592af95f23ab7bca9ba0b137269","unresolved":false,"context_lines":[{"line_number":3255,"context_line":"        if root_bdm:"},{"line_number":3256,"context_line":"            return root_bdm.is_volume"},{"line_number":3257,"context_line":"        # legacy case without bdm"},{"line_number":3258,"context_line":"        # we _assume_ that instance is backed by a volume, exactly if image_ref"},{"line_number":3259,"context_line":"        # is not set"},{"line_number":3260,"context_line":"        return not instance.image_ref"},{"line_number":3261,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_e0d5751b","line":3258,"updated":"2015-11-12 18:00:10.000000000","message":"This nit is still there, but only if you touch it again.","commit_id":"fbae555ce0eac6efdb11dc1467005e06a11937d8"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"f8df6bef74b7e0fcf863bad24931e49ada04a8a4","unresolved":false,"context_lines":[{"line_number":3255,"context_line":"        if root_bdm:"},{"line_number":3256,"context_line":"            return root_bdm.is_volume"},{"line_number":3257,"context_line":"        # legacy case without bdm"},{"line_number":3258,"context_line":"        # we _assume_ that instance is backed by a volume, exactly if image_ref"},{"line_number":3259,"context_line":"        # is not set"},{"line_number":3260,"context_line":"        return not instance.image_ref"},{"line_number":3261,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_5af8e9c4","line":3258,"in_reply_to":"da85f559_e0d5751b","updated":"2015-11-12 20:29:42.000000000","message":"agreed.","commit_id":"fbae555ce0eac6efdb11dc1467005e06a11937d8"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"1293da8bcde861cfbef3e53987c46cd430e7f64a","unresolved":false,"context_lines":[{"line_number":3257,"context_line":"        # legacy case without bdm"},{"line_number":3258,"context_line":"        # we _assume_ that instance is backed by a volume, exactly if image_ref"},{"line_number":3259,"context_line":"        # is not set"},{"line_number":3260,"context_line":"        return not instance.image_ref"},{"line_number":3261,"context_line":""},{"line_number":3262,"context_line":"    @check_instance_lock"},{"line_number":3263,"context_line":"    @check_instance_cell"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_04119baf","line":3260,"range":{"start_line":3260,"start_character":8,"end_line":3260,"end_character":37},"updated":"2015-11-13 01:43:13.000000000","message":"TBH I am not sure you need this.\n\nOld (veeery old like Havana release) would not insert a block device mapping entry for an image meaning it would not have a root_bdm. Actually that may not be entirely true, at that time we were happy to do all sorts of data manipulations in migration scripts so transitioning to the new schema which recorded the \u0027boot_index\u0027 may have also inserted the needed entries, but there may have been bugs and weird edge cases with that.\n\nSo in theory just returning False here might be enough.\n\nThis is of course \"safer\" - but maybe the comment should reflect the above just so that there is less confusion about what \"legacy\" means","commit_id":"fbae555ce0eac6efdb11dc1467005e06a11937d8"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"76e326b97e0ada18ead6fa1259e8623eb57f9b9b","unresolved":false,"context_lines":[{"line_number":3257,"context_line":"        # legacy case without bdm"},{"line_number":3258,"context_line":"        # we _assume_ that instance is backed by a volume, exactly if image_ref"},{"line_number":3259,"context_line":"        # is not set"},{"line_number":3260,"context_line":"        return not instance.image_ref"},{"line_number":3261,"context_line":""},{"line_number":3262,"context_line":"    @check_instance_lock"},{"line_number":3263,"context_line":"    @check_instance_cell"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_bcc3fa89","line":3260,"range":{"start_line":3260,"start_character":8,"end_line":3260,"end_character":37},"in_reply_to":"da85f559_04119baf","updated":"2015-11-13 09:45:50.000000000","message":"I tried to replicate this, but the obvious method didn\u0027t work (see comments on the bug). I didn\u0027t spend a huge amount of time on it, but it did look to me as though it might still be possible to trigger this if using the legacy block device mapping api, which novaclient will still use when given the --block-device-mapping argument. Another possibility is an instance which was created with old nova and is still around.\n\nEither way, I\u0027m confident alaski saw it :) Might as well fix it.","commit_id":"fbae555ce0eac6efdb11dc1467005e06a11937d8"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"51d1cf8e42b25e20891cb34503ab5b1252eeddda","unresolved":false,"context_lines":[{"line_number":3257,"context_line":"        # legacy case without bdm"},{"line_number":3258,"context_line":"        # we _assume_ that instance is backed by a volume, exactly if image_ref"},{"line_number":3259,"context_line":"        # is not set"},{"line_number":3260,"context_line":"        return not instance.image_ref"},{"line_number":3261,"context_line":""},{"line_number":3262,"context_line":"    @check_instance_lock"},{"line_number":3263,"context_line":"    @check_instance_cell"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_16a08342","line":3260,"range":{"start_line":3260,"start_character":8,"end_line":3260,"end_character":37},"in_reply_to":"da85f559_55372ae3","updated":"2015-11-18 08:23:57.000000000","message":"@ sven yes that\u0027s what I meant but am not confident enough in that assertion :) so making the comment more clear was what I would be happy with","commit_id":"fbae555ce0eac6efdb11dc1467005e06a11937d8"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"6d2a937ff73dead9bdc7d6cb3c69064af0bbdc65","unresolved":false,"context_lines":[{"line_number":3257,"context_line":"        # legacy case without bdm"},{"line_number":3258,"context_line":"        # we _assume_ that instance is backed by a volume, exactly if image_ref"},{"line_number":3259,"context_line":"        # is not set"},{"line_number":3260,"context_line":"        return not instance.image_ref"},{"line_number":3261,"context_line":""},{"line_number":3262,"context_line":"    @check_instance_lock"},{"line_number":3263,"context_line":"    @check_instance_cell"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_55372ae3","line":3260,"range":{"start_line":3260,"start_character":8,"end_line":3260,"end_character":37},"in_reply_to":"da85f559_bcc3fa89","updated":"2015-11-13 17:35:54.000000000","message":"I think both of you misunderstand each other. As I understand Nikola he doesn\u0027t question the fix, but just that we still (even after the fix) look at the value of image_ref, which he questions if necessary at all, because he suggests that all instances running on current nova have always a root bdm. Correct, Nikola?","commit_id":"fbae555ce0eac6efdb11dc1467005e06a11937d8"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"2c587dde4977f47c5da9495120f7b7de3a281d4d","unresolved":false,"context_lines":[{"line_number":8929,"context_line":"        self.assertIsNone("},{"line_number":8930,"context_line":"            self.compute_api._volume_size(inst_type, blank_bdm))"},{"line_number":8931,"context_line":""},{"line_number":8932,"context_line":"    def test_is_volume_backed_instance_no_bdm_no_image(self):"},{"line_number":8933,"context_line":"        ctxt \u003d self.context"},{"line_number":8934,"context_line":""},{"line_number":8935,"context_line":"        instance \u003d self._create_fake_instance_obj({\u0027image_ref\u0027: \u0027\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_46d95421","line":8932,"updated":"2015-11-11 12:08:13.000000000","message":"This change doesn\u0027t look related?","commit_id":"bd822764065962926af650c25ba44279d4f2a28c"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"094c398d51b61c3c384d67e6ac0e30d0487a33d9","unresolved":false,"context_lines":[{"line_number":8929,"context_line":"        self.assertIsNone("},{"line_number":8930,"context_line":"            self.compute_api._volume_size(inst_type, blank_bdm))"},{"line_number":8931,"context_line":""},{"line_number":8932,"context_line":"    def test_is_volume_backed_instance_no_bdm_no_image(self):"},{"line_number":8933,"context_line":"        ctxt \u003d self.context"},{"line_number":8934,"context_line":""},{"line_number":8935,"context_line":"        instance \u003d self._create_fake_instance_obj({\u0027image_ref\u0027: \u0027\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_910e9839","line":8932,"in_reply_to":"da85f559_46d95421","updated":"2015-11-11 13:01:22.000000000","message":"I think it\u0027s important to make clear now, that there is always a combination of imageref and bdm. Before this fix it was irrelevant if dbm was set. Whenever imageref was empty, it assumed a volume backed instance. So the \"no_bdm\" part in this test was irrelevant. Now it is relevant, and it should be made explicit, that the test only works without bdm.","commit_id":"bd822764065962926af650c25ba44279d4f2a28c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"200f7c84ecc2d85e9deaf2cbca957f00a87be332","unresolved":false,"context_lines":[{"line_number":8929,"context_line":"        self.assertIsNone("},{"line_number":8930,"context_line":"            self.compute_api._volume_size(inst_type, blank_bdm))"},{"line_number":8931,"context_line":""},{"line_number":8932,"context_line":"    def test_is_volume_backed_instance_no_bdm_no_image(self):"},{"line_number":8933,"context_line":"        ctxt \u003d self.context"},{"line_number":8934,"context_line":""},{"line_number":8935,"context_line":"        instance \u003d self._create_fake_instance_obj({\u0027image_ref\u0027: \u0027\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_d7573058","line":8932,"in_reply_to":"da85f559_910e9839","updated":"2015-11-11 13:13:58.000000000","message":"Makes sense.","commit_id":"bd822764065962926af650c25ba44279d4f2a28c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"2c587dde4977f47c5da9495120f7b7de3a281d4d","unresolved":false,"context_lines":[{"line_number":8936,"context_line":"        self.assertTrue("},{"line_number":8937,"context_line":"            self.compute_api.is_volume_backed_instance(ctxt, instance, None))"},{"line_number":8938,"context_line":""},{"line_number":8939,"context_line":"    def test_is_volume_backed_instance_empty_bdm_with_image(self):"},{"line_number":8940,"context_line":"        ctxt \u003d self.context"},{"line_number":8941,"context_line":"        instance \u003d self._create_fake_instance_obj({\u0027root_device_name\u0027: \u0027vda\u0027})"},{"line_number":8942,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_062d8cfd","line":8939,"updated":"2015-11-11 12:08:13.000000000","message":"ditto","commit_id":"bd822764065962926af650c25ba44279d4f2a28c"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"094c398d51b61c3c384d67e6ac0e30d0487a33d9","unresolved":false,"context_lines":[{"line_number":8936,"context_line":"        self.assertTrue("},{"line_number":8937,"context_line":"            self.compute_api.is_volume_backed_instance(ctxt, instance, None))"},{"line_number":8938,"context_line":""},{"line_number":8939,"context_line":"    def test_is_volume_backed_instance_empty_bdm_with_image(self):"},{"line_number":8940,"context_line":"        ctxt \u003d self.context"},{"line_number":8941,"context_line":"        instance \u003d self._create_fake_instance_obj({\u0027root_device_name\u0027: \u0027vda\u0027})"},{"line_number":8942,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_eca70709","line":8939,"in_reply_to":"da85f559_062d8cfd","updated":"2015-11-11 13:01:22.000000000","message":"as above, it\u0027s important that the image is set.","commit_id":"bd822764065962926af650c25ba44279d4f2a28c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"028cf0c028d8676618702a3907e913718c45e975","unresolved":false,"context_lines":[{"line_number":8936,"context_line":"        self.assertTrue("},{"line_number":8937,"context_line":"            self.compute_api.is_volume_backed_instance(ctxt, instance, None))"},{"line_number":8938,"context_line":""},{"line_number":8939,"context_line":"    def test_is_volume_backed_instance_empty_bdm_with_image(self):"},{"line_number":8940,"context_line":"        ctxt \u003d self.context"},{"line_number":8941,"context_line":"        instance \u003d self._create_fake_instance_obj({\u0027root_device_name\u0027: \u0027vda\u0027})"},{"line_number":8942,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_3f251708","line":8939,"in_reply_to":"da85f559_b7538c6a","updated":"2015-11-11 21:58:12.000000000","message":"This should be \u0027no_image\u0027 right?","commit_id":"bd822764065962926af650c25ba44279d4f2a28c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"200f7c84ecc2d85e9deaf2cbca957f00a87be332","unresolved":false,"context_lines":[{"line_number":8936,"context_line":"        self.assertTrue("},{"line_number":8937,"context_line":"            self.compute_api.is_volume_backed_instance(ctxt, instance, None))"},{"line_number":8938,"context_line":""},{"line_number":8939,"context_line":"    def test_is_volume_backed_instance_empty_bdm_with_image(self):"},{"line_number":8940,"context_line":"        ctxt \u003d self.context"},{"line_number":8941,"context_line":"        instance \u003d self._create_fake_instance_obj({\u0027root_device_name\u0027: \u0027vda\u0027})"},{"line_number":8942,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_b7538c6a","line":8939,"in_reply_to":"da85f559_eca70709","updated":"2015-11-11 13:13:58.000000000","message":"Ditto.","commit_id":"bd822764065962926af650c25ba44279d4f2a28c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"2c587dde4977f47c5da9495120f7b7de3a281d4d","unresolved":false,"context_lines":[{"line_number":8957,"context_line":"        self.assertTrue("},{"line_number":8958,"context_line":"            self.compute_api.is_volume_backed_instance(ctxt, instance, bdms))"},{"line_number":8959,"context_line":""},{"line_number":8960,"context_line":"    def test_is_volume_backed_instance_bdm_local_no_image(self):"},{"line_number":8961,"context_line":"        # if the root device is local the instance is not volume backed, even"},{"line_number":8962,"context_line":"        # if no image_ref is set."},{"line_number":8963,"context_line":"        ctxt \u003d self.context"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_a6da80e6","line":8960,"updated":"2015-11-11 12:08:13.000000000","message":"I think you\u0027re missing a test here. I think you need to duplicate this test to have:\n\ntest_is_volume_backed_instance_bdm_local_no_imageref\ntest_is_volume_backed_instance_bdm_local_with_imageref","commit_id":"bd822764065962926af650c25ba44279d4f2a28c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"200f7c84ecc2d85e9deaf2cbca957f00a87be332","unresolved":false,"context_lines":[{"line_number":8957,"context_line":"        self.assertTrue("},{"line_number":8958,"context_line":"            self.compute_api.is_volume_backed_instance(ctxt, instance, bdms))"},{"line_number":8959,"context_line":""},{"line_number":8960,"context_line":"    def test_is_volume_backed_instance_bdm_local_no_image(self):"},{"line_number":8961,"context_line":"        # if the root device is local the instance is not volume backed, even"},{"line_number":8962,"context_line":"        # if no image_ref is set."},{"line_number":8963,"context_line":"        ctxt \u003d self.context"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_f7d354d3","line":8960,"in_reply_to":"da85f559_575340e2","updated":"2015-11-11 13:13:58.000000000","message":"I\u0027m sure some would argue that we need to cover all permutations all the time :) I think we certainly need to cover important permutations. I think this one is important because this is the test whose behaviour we\u0027re changing in this patch. We should specifically demonstrate here that\u0027s what we\u0027re doing and it\u0027s deliberate.","commit_id":"bd822764065962926af650c25ba44279d4f2a28c"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"094c398d51b61c3c384d67e6ac0e30d0487a33d9","unresolved":false,"context_lines":[{"line_number":8957,"context_line":"        self.assertTrue("},{"line_number":8958,"context_line":"            self.compute_api.is_volume_backed_instance(ctxt, instance, bdms))"},{"line_number":8959,"context_line":""},{"line_number":8960,"context_line":"    def test_is_volume_backed_instance_bdm_local_no_image(self):"},{"line_number":8961,"context_line":"        # if the root device is local the instance is not volume backed, even"},{"line_number":8962,"context_line":"        # if no image_ref is set."},{"line_number":8963,"context_line":"        ctxt \u003d self.context"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_575340e2","line":8960,"in_reply_to":"da85f559_a6da80e6","updated":"2015-11-11 13:01:22.000000000","message":"I don\u0027t think it makes sense to test for all permutations (then I would need to add three other tests as well), but only the conflicting combinations (corner cases). We test already that empty_bdm_with_image is false and bdm_local_no_image is false. Then bdm_local_with_image would be double false. ;-)\n\nI might rename all test functions to make these combinatorics clearer?","commit_id":"bd822764065962926af650c25ba44279d4f2a28c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"028cf0c028d8676618702a3907e913718c45e975","unresolved":false,"context_lines":[{"line_number":8957,"context_line":"        self.assertTrue("},{"line_number":8958,"context_line":"            self.compute_api.is_volume_backed_instance(ctxt, instance, bdms))"},{"line_number":8959,"context_line":""},{"line_number":8960,"context_line":"    def test_is_volume_backed_instance_bdm_local_no_image(self):"},{"line_number":8961,"context_line":"        # if the root device is local the instance is not volume backed, even"},{"line_number":8962,"context_line":"        # if no image_ref is set."},{"line_number":8963,"context_line":"        ctxt \u003d self.context"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_1f7b73c2","line":8960,"in_reply_to":"da85f559_f7d354d3","updated":"2015-11-11 21:58:12.000000000","message":"I would be happy to see more permutations covered.","commit_id":"bd822764065962926af650c25ba44279d4f2a28c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff278155afaecca6c7e35c48aa9816499aa9c6e4","unresolved":false,"context_lines":[{"line_number":8931,"context_line":""},{"line_number":8932,"context_line":"    def test_is_volume_backed_instance_no_image(self):"},{"line_number":8933,"context_line":"        ctxt \u003d self.context"},{"line_number":8934,"context_line":""},{"line_number":8935,"context_line":"        instance \u003d self._create_fake_instance_obj({\u0027image_ref\u0027: \u0027\u0027})"},{"line_number":8936,"context_line":"        self.assertTrue("},{"line_number":8937,"context_line":"            self.compute_api.is_volume_backed_instance(ctxt, instance, None))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_605dfc47","side":"PARENT","line":8934,"updated":"2015-11-12 21:34:41.000000000","message":"Unrelated whitespace change.","commit_id":"77e80d6873f621b709c60e6eed13dd8c94eda910"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"a2b02e53d1376592af95f23ab7bca9ba0b137269","unresolved":false,"context_lines":[{"line_number":8951,"context_line":"        self.assertTrue("},{"line_number":8952,"context_line":"            self.compute_api.is_volume_backed_instance(ctxt, instance, bdms))"},{"line_number":8953,"context_line":""},{"line_number":8954,"context_line":"    def test_is_volume_backed_instance_bdm_local_no_image(self):"},{"line_number":8955,"context_line":"        # if the root device is local the instance is not volume backed, even"},{"line_number":8956,"context_line":"        # if no image_ref is set."},{"line_number":8957,"context_line":"        ctxt \u003d self.context"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_e06015a7","line":8954,"updated":"2015-11-12 18:00:10.000000000","message":"Ok, thinking about this more carefully I see why you\u0027ve done this. This is the specifically broken case: there\u0027s a bdm, but it\u0027s for a local disk and there\u0027s no image_ref. This is the test which would previously have failed.\n\nI would still have left the old test in place, but I don\u0027t want to get hung up on it. It\u0027s not as important as I originally thought.","commit_id":"fbae555ce0eac6efdb11dc1467005e06a11937d8"}]}