)]}'
{"id":"openstack%2Fnova~2437","triplet_id":"openstack%2Fnova~master~Ia11b3d4d3db930eb31ccc2f74635971ba6edc32c","project":"openstack/nova","branch":"master","topic":"bug/898485","hashtags":[],"change_id":"Ia11b3d4d3db930eb31ccc2f74635971ba6edc32c","subject":"Makes disassociate by timeout work with multi-host","status":"MERGED","created":"2011-12-17 00:07:20.000000000","updated":"2011-12-28 19:14:20.000000000","submitted":"2011-12-21 16:31:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"10e2bb027ed80d9c1026a9339abdd1a531f86049","_number":2437,"virtual_id_number":2437,"owner":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":1,"date":"2011-12-21 16:31:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"recommended":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"date":"2011-12-21 11:48:18.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":1,"date":"2011-12-20 17:42:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2011-12-21 16:21:42.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"date":"2011-12-21 16:31:35.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-12-20 17:42:55.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2011-12-21 11:48:18.000000000","updated_by":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"reviewer":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"state":"REVIEWER"},{"updated":"2011-12-21 16:21:42.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2011-12-21 16:31:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"47f9d99c2dfc6587788c13081e3c889147811305","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2011-12-20 17:42:55.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"e050b0c18ad7deb95ed4e85bf2a93ce7b28b25ec","author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"date":"2011-12-21 11:48:18.000000000","message":"Patch Set 1:\n\n@Vish: Just to check (as its a bit hard to tell from the commenst trail in the bug) - does this still leave the mechanism for freeing up IPs under the control of DNSmasq ?\r\n\r\nThe original bug report seemed to propose changing this, which would be a concern","accounts_in_message":[],"_revision_number":1},{"id":"4b6843ccf5941e7b8dae9b4dc19cddfc7ec1a9c9","author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"date":"2011-12-21 11:50:18.000000000","message":"Patch Set 1:\n\nBTW - is there a way to flag fixes which are good candidates for diablo.stable ?","accounts_in_message":[],"_revision_number":1},{"id":"de200917b1636f68d47e84140557baebe37cb061","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2011-12-21 16:21:42.000000000","message":"Patch Set 1: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"dea996696b0c142154323da97728250d17dc04e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-21 16:31:35.000000000","message":"Patch Set 1: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-nova-unittests/325/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/2088/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/713/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"c43362c1af106c87db9b6076adc3ac79c46697b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-21 16:31:36.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"552d30fef17b211d35625b9ad14f881441a8b8bb","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2011-12-27 17:31:16.000000000","message":"Patch Set 1:\n\nAny chance we can get an answer for Phil\u0027s first question, please?\n\nDoes this still leave the mechanism for freeing up IPs under the control of DNSmasq?\n\nPhil, as for tagging stablo/diablo, I\u0027m working on a solution for this... I\u0027ll send you an email later.\n\n-jay","accounts_in_message":[],"_revision_number":1},{"id":"c3bc7be2b73654b1e92de1df65c2d0f1a1b78052","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2011-12-28 19:14:20.000000000","message":"Patch Set 1:\n\nSorry about the slow response, was on vacation.\n\nThis does not free up ips under the control of dnsmasq, so the timeout will have to be longer than the lease time for this to work properly.\n\nThis patch restores the original timeout behavior, which was to timeout leases after a set time.  There is a \"better\" option that immediately releases ips from dnsmasq on terminate.  The flag is:\n--force_dhcp_release\n\nbut it depends on an extra utility from the dnsmasq package that may not exist on all installs.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fb6850a5b9d7d61a4bb96af8d1cd516fd139c1f8","revisions":{"fb6850a5b9d7d61a4bb96af8d1cd516fd139c1f8":{"kind":"REWORK","_number":1,"created":"2011-12-17 00:07:20.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/37/2437/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/37/2437/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/37/2437/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/37/2437/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/37/2437/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/37/2437/1"}}},"commit":{"parents":[{"commit":"106ea5eda8458b44846207a3df69cf1837789828","subject":"Merge \"Call get_instance_nw_info with elevated context, as documented in nova/network/manager.py\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/106ea5eda8458b44846207a3df69cf1837789828"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2011-12-17 00:02:54.000000000","tz":-480},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2011-12-17 00:07:11.000000000","tz":-480},"subject":"Makes disassociate by timeout work with multi-host","message":"Makes disassociate by timeout work with multi-host\n\n * fixes bug 898485\n * updates timeout query to key off of instance host as well\n * removes unused status\u003d1 in related query\n\nChange-Id: Ia11b3d4d3db930eb31ccc2f74635971ba6edc32c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fb6850a5b9d7d61a4bb96af8d1cd516fd139c1f8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fb6850a5b9d7d61a4bb96af8d1cd516fd139c1f8"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"106ea5eda8458b44846207a3df69cf1837789828","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}