)]}'
{"nova/db/sqlalchemy/migrate_repo/versions/161_fix_system_metadata_none_strings.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"59e2c03ef4cc704df14a868c6d5c210747f507f9","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    sys_meta.update().\\"},{"line_number":25,"context_line":"        values(value\u003dNone).\\"},{"line_number":26,"context_line":"        where(sys_meta.c.value \u003d\u003d \u0027None\u0027).\\"},{"line_number":27,"context_line":"        execute()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    now \u003d timeutils.utcnow()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2FvQQ%3D","line":26,"updated":"2013-03-14 13:29:27.000000000","message":"I was wondering this morning if we should try to only hit the existing records where name like \u0027instance_type_%\" as well? That will further cut down on what we hi. For some reason I was thinking that we really should do a clean sweep, but further consideration this morning makes me think this is too wide a filter. Also note that this (and the proposed change) would nuke an otherwise-valid flavor with name or flavorid of \"None\", but I guess that\u0027s a risk we should take?","commit_id":"ed2928965de67b8bfaf0d97d5e9f1e0ac44622cd"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"694c1830d8dc23e1d50885d4731bd2dfbb567bad","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    sys_meta.update().\\"},{"line_number":25,"context_line":"        values(value\u003dNone).\\"},{"line_number":26,"context_line":"        where(sys_meta.c.value \u003d\u003d \u0027None\u0027).\\"},{"line_number":27,"context_line":"        execute()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    now \u003d timeutils.utcnow()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2Fu88%3D","line":26,"in_reply_to":"AAAAN3%2F%2Fu9M%3D","updated":"2013-03-14 15:48:12.000000000","message":"agree","commit_id":"ed2928965de67b8bfaf0d97d5e9f1e0ac44622cd"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"d9d53f75b315c849f65912fc52f431967834a4d7","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    sys_meta.update().\\"},{"line_number":25,"context_line":"        values(value\u003dNone).\\"},{"line_number":26,"context_line":"        where(sys_meta.c.value \u003d\u003d \u0027None\u0027).\\"},{"line_number":27,"context_line":"        execute()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    now \u003d timeutils.utcnow()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2Fu9M%3D","line":26,"in_reply_to":"AAAAN3%2F%2FvQQ%3D","updated":"2013-03-14 15:43:27.000000000","message":"yes just updating the instance_type_% seems better. we could explicitly ignore flavorid and name since they are required on creating a flavor to work around the issue you mention above.","commit_id":"ed2928965de67b8bfaf0d97d5e9f1e0ac44622cd"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"ef71771121c3a80d55e97c1570d04ac8ff1faec3","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    now \u003d timeutils.utcnow()"},{"line_number":30,"context_line":"    sys_meta.update().\\"},{"line_number":31,"context_line":"        values(created_at\u003dnow).\\"},{"line_number":32,"context_line":"        execute()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2FvcU%3D","line":31,"updated":"2013-03-14 09:02:28.000000000","message":"shouldn\u0027t this have:  where c.created_at \u003d\u003d None?   (I say \u003d\u003d because \u0027is None\u0027 doesn\u0027t work w/ sqlalchemy).   Otherwise, this is updating every single row AFAICT","commit_id":"ed2928965de67b8bfaf0d97d5e9f1e0ac44622cd"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"59e2c03ef4cc704df14a868c6d5c210747f507f9","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    now \u003d timeutils.utcnow()"},{"line_number":30,"context_line":"    sys_meta.update().\\"},{"line_number":31,"context_line":"        values(created_at\u003dnow).\\"},{"line_number":32,"context_line":"        execute()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2FvQs%3D","line":31,"in_reply_to":"AAAAN3%2F%2FvcU%3D","updated":"2013-03-14 13:29:27.000000000","message":"Yes, it should.","commit_id":"ed2928965de67b8bfaf0d97d5e9f1e0ac44622cd"}]}