)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"3abdb7ef2aa3f04227ebc3dbc1188ed5c0cbd6be","unresolved":false,"context_lines":[{"line_number":1614,"context_line":"    # This must be done in a separate transaction, so that this one is not"},{"line_number":1615,"context_line":"    # aborted in case a concurrent one succeeds first and the unique constraint"},{"line_number":1616,"context_line":"    # for security group names is violated by a concurrent INSERT"},{"line_number":1617,"context_line":"    security_group_ensure_default(context, context.session)"},{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"    values \u003d values.copy()"},{"line_number":1620,"context_line":"    values[\u0027metadata\u0027] \u003d _metadata_refs("}],"source_content_type":"text/x-python","patch_set":10,"id":"ba63e191_8b300603","line":1617,"updated":"2016-01-19 19:48:29.000000000","message":"This was just removed in https://review.openstack.org/#/c/246302/ .  Why is it being added back in?","commit_id":"9cd93c4736c8a4de064c9a7d9b21995943d22a37"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"736698f5ab76105ffdb7015ac772dbd0d99c9187","unresolved":false,"context_lines":[{"line_number":1614,"context_line":"    # This must be done in a separate transaction, so that this one is not"},{"line_number":1615,"context_line":"    # aborted in case a concurrent one succeeds first and the unique constraint"},{"line_number":1616,"context_line":"    # for security group names is violated by a concurrent INSERT"},{"line_number":1617,"context_line":"    security_group_ensure_default(context, context.session)"},{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"    values \u003d values.copy()"},{"line_number":1620,"context_line":"    values[\u0027metadata\u0027] \u003d _metadata_refs("}],"source_content_type":"text/x-python","patch_set":10,"id":"9a68dd71_a2b0c68c","line":1617,"in_reply_to":"9a68dd71_dc17e952","updated":"2016-01-20 16:53:27.000000000","message":"Gotcha.  I looked at these patches in the reverse order and missed the dependency chain.  So many patches :)","commit_id":"9cd93c4736c8a4de064c9a7d9b21995943d22a37"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"bdd8eaf2b051003afbd16a4f536dffa0467d18ba","unresolved":false,"context_lines":[{"line_number":1614,"context_line":"    # This must be done in a separate transaction, so that this one is not"},{"line_number":1615,"context_line":"    # aborted in case a concurrent one succeeds first and the unique constraint"},{"line_number":1616,"context_line":"    # for security group names is violated by a concurrent INSERT"},{"line_number":1617,"context_line":"    security_group_ensure_default(context, context.session)"},{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"    values \u003d values.copy()"},{"line_number":1620,"context_line":"    values[\u0027metadata\u0027] \u003d _metadata_refs("}],"source_content_type":"text/x-python","patch_set":10,"id":"9a68dd71_dc17e952","line":1617,"in_reply_to":"ba63e191_8b300603","updated":"2016-01-20 14:10:49.000000000","message":"This argument here is needed for backward compatibility and also for the tests.\n\nIn this patch we don\u0027t change the code of security_groups. The patch you mentioned depends on this one. So, the next patch in the chain (\u0027security_group\u0027 https://review.openstack.org/#/c/246302/) will remove this parameter.","commit_id":"9cd93c4736c8a4de064c9a7d9b21995943d22a37"}]}