)]}'
{"nova/cmd/serialproxy.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5b0f234851e8f12f887ae00d767573a7e280ce30","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":29,"context_line":"CONF.register_cli_opt(serial.serialproxy_host_opt, \"serial_console\")"},{"line_number":30,"context_line":"CONF.register_cli_opt(serial.serialproxy_port_opt, \"serial_console\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_09308f00","line":29,"updated":"2015-11-17 17:28:11.000000000","message":"should we add register_cli_opts method into serial_console?","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"084013f7a69ec8f336e87a8fc0dd9fe59023cac1","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":29,"context_line":"CONF.register_cli_opt(serial.serialproxy_host_opt, \"serial_console\")"},{"line_number":30,"context_line":"CONF.register_cli_opt(serial.serialproxy_port_opt, \"serial_console\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_174e6196","line":29,"in_reply_to":"ba8a016a_09308f00","updated":"2015-11-17 17:37:56.000000000","message":"I had that in the first patch set and discovered that this is too late in the flow when oslo.config slurps in the config options. It raises an error when we do that.","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"66c56a12724c7494f9b9717f83f3b7be0c93165a","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":29,"context_line":"CONF.register_cli_opt(serial.serialproxy_host_opt, \"serial_console\")"},{"line_number":30,"context_line":"CONF.register_cli_opt(serial.serialproxy_port_opt, \"serial_console\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_2b30e000","line":29,"in_reply_to":"ba8a016a_174e6196","updated":"2015-11-17 18:43:52.000000000","message":"I was thinking make sure register_cli_opt still runs here, but just add these two lines into serial_console? Just so its clear inside that file they are also used as cli opts.","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"f7162987f38e9853332421b924a8687a17efeba7","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":29,"context_line":"CONF.register_cli_opt(serial.serialproxy_host_opt, \"serial_console\")"},{"line_number":30,"context_line":"CONF.register_cli_opt(serial.serialproxy_port_opt, \"serial_console\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_0b858005","line":29,"in_reply_to":"ba8a016a_2b30e000","updated":"2015-11-19 09:24:21.000000000","message":"@John: Got it. That should be possible. I\u0027m going to test it out.","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"}],"nova/conf/serial_console.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5b0f234851e8f12f887ae00d767573a7e280ce30","unresolved":false,"context_lines":[{"line_number":18,"context_line":"DEFAULT_PORT_RANGE \u003d \u002710000:20000\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"enabled_opt \u003d cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":21,"context_line":"                          default\u003dFalse,"},{"line_number":22,"context_line":"                          help\u003d\u0027Enable serial console related features\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"port_range_opt \u003d cfg.StrOpt(\u0027port_range\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_a97063dd","line":21,"updated":"2015-11-17 17:28:11.000000000","message":"Nit: I am tempted to go for 4 spaces from the left only on here, so it looks neater.","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"66c56a12724c7494f9b9717f83f3b7be0c93165a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"DEFAULT_PORT_RANGE \u003d \u002710000:20000\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"enabled_opt \u003d cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":21,"context_line":"                          default\u003dFalse,"},{"line_number":22,"context_line":"                          help\u003d\u0027Enable serial console related features\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"port_range_opt \u003d cfg.StrOpt(\u0027port_range\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_ab129060","line":21,"in_reply_to":"ba8a016a_1abe88d4","updated":"2015-11-17 18:43:52.000000000","message":"yeah, I am thinking about when you start adding \"\"\" more than anything, but just thinking it would make it easier to read. I could be wrong, just my eyes go crazy looking at all the different indents, for some reason.","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"f7162987f38e9853332421b924a8687a17efeba7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"DEFAULT_PORT_RANGE \u003d \u002710000:20000\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"enabled_opt \u003d cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":21,"context_line":"                          default\u003dFalse,"},{"line_number":22,"context_line":"                          help\u003d\u0027Enable serial console related features\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"port_range_opt \u003d cfg.StrOpt(\u0027port_range\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_abfa3473","line":21,"in_reply_to":"ba8a016a_4710b44e","updated":"2015-11-19 09:24:21.000000000","message":"Sure, I\u0027ll see if the pep8 check gives me the chance.","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"084013f7a69ec8f336e87a8fc0dd9fe59023cac1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"DEFAULT_PORT_RANGE \u003d \u002710000:20000\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"enabled_opt \u003d cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":21,"context_line":"                          default\u003dFalse,"},{"line_number":22,"context_line":"                          help\u003d\u0027Enable serial console related features\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"port_range_opt \u003d cfg.StrOpt(\u0027port_range\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_1abe88d4","line":21,"in_reply_to":"ba8a016a_a97063dd","updated":"2015-11-17 17:37:56.000000000","message":"You mean this?\n\n    enabled_opt \u003d cfg.BoolOpt(\u0027enabled\u0027,\n        default\u003dFalse,\n        # and so on","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"aec8585def8d65f98a3d947c9e06e9b3b0abae39","unresolved":false,"context_lines":[{"line_number":18,"context_line":"DEFAULT_PORT_RANGE \u003d \u002710000:20000\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"enabled_opt \u003d cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":21,"context_line":"                          default\u003dFalse,"},{"line_number":22,"context_line":"                          help\u003d\u0027Enable serial console related features\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"port_range_opt \u003d cfg.StrOpt(\u0027port_range\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_4710b44e","line":21,"in_reply_to":"ba8a016a_ab129060","updated":"2015-11-17 19:24:39.000000000","message":"I strongly prefer indentation for continued lines to be 2 levels, not 1 (i.e., 8 spaces). This way a block-starting line is clearly not part of the block:\n\n    def some_very_long_method_name_with_lots_of_params(foo,\n            bar, baz, foo2, bar2, baz2):\n       my_var \u003d foo\n       [rest of code]\n\nIn the case of code like this, having all the continued lines indented to different levels just looks ugly. Having them all indented 8 spaces is much cleaner.","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5b0f234851e8f12f887ae00d767573a7e280ce30","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            serialproxy_port_opt]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def register_opts(conf):"},{"line_number":67,"context_line":"    conf.register_opts(ALL_OPTS, group\u003d\"serial_console\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_3419267a","line":66,"updated":"2015-11-17 17:28:11.000000000","message":"I wonder about a register_cli_opts method in here?","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"084013f7a69ec8f336e87a8fc0dd9fe59023cac1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            serialproxy_port_opt]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def register_opts(conf):"},{"line_number":67,"context_line":"    conf.register_opts(ALL_OPTS, group\u003d\"serial_console\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_b712f560","line":66,"in_reply_to":"ba8a016a_3419267a","updated":"2015-11-17 17:37:56.000000000","message":"That will raise an error because it\u0027s too late in the flow of \"oslo.config\". Patch set 1 had it and failed terribly.","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"017d61ce0f26e47a5555275e6d457170aca886f0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"DEFAULT_PORT_RANGE \u003d \u002710000:20000\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"enabled_opt \u003d cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":21,"context_line":"                          default\u003dFalse,"},{"line_number":22,"context_line":"                          help\u003d\u0027Enable serial console related features\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"port_range_opt \u003d cfg.StrOpt(\u0027port_range\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_97e62dae","line":21,"updated":"2015-11-20 09:49:36.000000000","message":"Nit: indent is odd, but this is fixed in the next patch, OK.","commit_id":"c55edcf0e11ce16ec585603ba254111835c0a73d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"017d61ce0f26e47a5555275e6d457170aca886f0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    conf.register_cli_opt(serialproxy_port_opt, \"serial_console\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def list_opts():"},{"line_number":76,"context_line":"    return (\"serial_console\", ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_b221ff9f","line":75,"updated":"2015-11-20 09:49:36.000000000","message":"Nit: the comment here is in the next patch, but OK.","commit_id":"c55edcf0e11ce16ec585603ba254111835c0a73d"}],"nova/console/serial.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5b0f234851e8f12f887ae00d767573a7e280ce30","unresolved":false,"context_lines":[{"line_number":29,"context_line":"ALLOCATED_PORTS \u003d set()  # in-memory set of already allocated ports"},{"line_number":30,"context_line":"SERIAL_LOCK \u003d \u0027serial-lock\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# TODO(sahid): Add a method to initialize ALOCATED_PORTS with the"},{"line_number":35,"context_line":"# already binded TPC port(s). (cf from danpb: list all running guests and"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_14bf42fc","line":32,"updated":"2015-11-17 17:28:11.000000000","message":"should we not explicitly import the options?\n\neven its if not required, its probably a good idea (we could add a check for that, eventually)","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"084013f7a69ec8f336e87a8fc0dd9fe59023cac1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"ALLOCATED_PORTS \u003d set()  # in-memory set of already allocated ports"},{"line_number":30,"context_line":"SERIAL_LOCK \u003d \u0027serial-lock\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# TODO(sahid): Add a method to initialize ALOCATED_PORTS with the"},{"line_number":35,"context_line":"# already binded TPC port(s). (cf from danpb: list all running guests and"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_5a689087","line":32,"in_reply_to":"ba8a016a_14bf42fc","updated":"2015-11-17 17:37:56.000000000","message":"I had a look at the \"import_opt\" method in \"oslo.config\" and if I\u0027m not mistaken, all it does is doing an \"__import__(module)\" call under the cover and registers the config options again to be sure. I had the impression that the \"import_opt\" method is useful in projects which don\u0027t use \"CONF\" as the global config object. But we use it as global config object. That\u0027s why I didn\u0027t see a benefit in still using \"import_opt\".","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"66c56a12724c7494f9b9717f83f3b7be0c93165a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"ALLOCATED_PORTS \u003d set()  # in-memory set of already allocated ports"},{"line_number":30,"context_line":"SERIAL_LOCK \u003d \u0027serial-lock\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# TODO(sahid): Add a method to initialize ALOCATED_PORTS with the"},{"line_number":35,"context_line":"# already binded TPC port(s). (cf from danpb: list all running guests and"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_a609652e","line":32,"in_reply_to":"ba8a016a_5a689087","updated":"2015-11-17 18:43:52.000000000","message":"oh, that makes sense.\n\nLets try without. It is cleaner that way.","commit_id":"b1e8ac08b4038dde94839ce27d60e9b63075daa7"}]}