)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bbd0c59ba4fd381fb88bd92d1775125e8467fddb","unresolved":false,"context_lines":[{"line_number":2145,"context_line":"                if network_info is not None:"},{"line_number":2146,"context_line":"                    network_info.wait(do_raise\u003dFalse)"},{"line_number":2147,"context_line":"        except exception.UnexpectedDeletingTaskStateError:"},{"line_number":2148,"context_line":"            instance.task_state \u003d task_states.DELETING"},{"line_number":2149,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2150,"context_line":"                # Make sure the async call finishes"},{"line_number":2151,"context_line":"                if network_info is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_e5edf1b7","line":2148,"range":{"start_line":2148,"start_character":12,"end_line":2148,"end_character":54},"updated":"2016-01-15 22:58:34.000000000","message":"From what I can tell, UnexpectedDeletingTaskStateError implies that the instance.task_state is already DELETING, so I don\u0027t think we need to set it here? And if we don\u0027t need to set it here, then we don\u0027t need to separate InstanceNotFound and UnexpectedDeletingTaskStateError in the except block anymore.","commit_id":"75b9f94ea94bc8ab27082522adcbee76b13eb229"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"a268ba3ba0e4cf1b677b2b7296e900d195570d8a","unresolved":false,"context_lines":[{"line_number":2145,"context_line":"                if network_info is not None:"},{"line_number":2146,"context_line":"                    network_info.wait(do_raise\u003dFalse)"},{"line_number":2147,"context_line":"        except exception.UnexpectedDeletingTaskStateError:"},{"line_number":2148,"context_line":"            instance.task_state \u003d task_states.DELETING"},{"line_number":2149,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2150,"context_line":"                # Make sure the async call finishes"},{"line_number":2151,"context_line":"                if network_info is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_a4176dec","line":2148,"range":{"start_line":2148,"start_character":12,"end_line":2148,"end_character":54},"in_reply_to":"da6ed579_e5edf1b7","updated":"2016-01-19 03:15:00.000000000","message":"Hm, Thanks, will update","commit_id":"75b9f94ea94bc8ab27082522adcbee76b13eb229"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bbd0c59ba4fd381fb88bd92d1775125e8467fddb","unresolved":false,"context_lines":[{"line_number":2909,"context_line":"        if reschedule_update:"},{"line_number":2910,"context_line":"            self.instance.save().AndReturn(self.instance)"},{"line_number":2911,"context_line":""},{"line_number":2912,"context_line":"    def _build_and_run_instance_update(self):"},{"line_number":2913,"context_line":"        self.mox.StubOutWithMock(self.instance, \u0027save\u0027)"},{"line_number":2914,"context_line":"        self._build_resources_instance_update(stub\u003dFalse)"},{"line_number":2915,"context_line":"        self.instance.save(expected_task_state\u003d"},{"line_number":2916,"context_line":"                task_states.BLOCK_DEVICE_MAPPING).AndReturn(self.instance)"},{"line_number":2917,"context_line":""},{"line_number":2918,"context_line":"    def _build_resources_instance_update_with_expected_task(self, stub\u003dTrue):"},{"line_number":2919,"context_line":"        if stub:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_129fadb5","line":2916,"range":{"start_line":2912,"start_character":4,"end_line":2916,"end_character":74},"updated":"2016-01-15 22:58:34.000000000","message":"It appears this code would be dead now and could be removed","commit_id":"75b9f94ea94bc8ab27082522adcbee76b13eb229"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"a268ba3ba0e4cf1b677b2b7296e900d195570d8a","unresolved":false,"context_lines":[{"line_number":2909,"context_line":"        if reschedule_update:"},{"line_number":2910,"context_line":"            self.instance.save().AndReturn(self.instance)"},{"line_number":2911,"context_line":""},{"line_number":2912,"context_line":"    def _build_and_run_instance_update(self):"},{"line_number":2913,"context_line":"        self.mox.StubOutWithMock(self.instance, \u0027save\u0027)"},{"line_number":2914,"context_line":"        self._build_resources_instance_update(stub\u003dFalse)"},{"line_number":2915,"context_line":"        self.instance.save(expected_task_state\u003d"},{"line_number":2916,"context_line":"                task_states.BLOCK_DEVICE_MAPPING).AndReturn(self.instance)"},{"line_number":2917,"context_line":""},{"line_number":2918,"context_line":"    def _build_resources_instance_update_with_expected_task(self, stub\u003dTrue):"},{"line_number":2919,"context_line":"        if stub:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_24cffdb1","line":2916,"range":{"start_line":2912,"start_character":4,"end_line":2916,"end_character":74},"in_reply_to":"da6ed579_129fadb5","updated":"2016-01-19 03:15:00.000000000","message":"Done","commit_id":"75b9f94ea94bc8ab27082522adcbee76b13eb229"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bbd0c59ba4fd381fb88bd92d1775125e8467fddb","unresolved":false,"context_lines":[{"line_number":2923,"context_line":"                                 task_states.SCHEDULING, None)"},{"line_number":2924,"context_line":"        ).AndReturn(self.instance)"},{"line_number":2925,"context_line":""},{"line_number":2926,"context_line":"    def _build_resources_instance_update(self, stub\u003dTrue):"},{"line_number":2927,"context_line":"        if stub:"},{"line_number":2928,"context_line":"            self.mox.StubOutWithMock(self.instance, \u0027save\u0027)"},{"line_number":2929,"context_line":"        self.instance.save().AndReturn(self.instance)"},{"line_number":2930,"context_line":""},{"line_number":2931,"context_line":"    def _notify_about_instance_usage(self, event, stub\u003dTrue, **kwargs):"},{"line_number":2932,"context_line":"        if stub:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_326191d4","line":2929,"range":{"start_line":2926,"start_character":4,"end_line":2929,"end_character":53},"updated":"2016-01-15 22:58:34.000000000","message":"It appears this code would be dead now and could be removed","commit_id":"75b9f94ea94bc8ab27082522adcbee76b13eb229"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"a268ba3ba0e4cf1b677b2b7296e900d195570d8a","unresolved":false,"context_lines":[{"line_number":2923,"context_line":"                                 task_states.SCHEDULING, None)"},{"line_number":2924,"context_line":"        ).AndReturn(self.instance)"},{"line_number":2925,"context_line":""},{"line_number":2926,"context_line":"    def _build_resources_instance_update(self, stub\u003dTrue):"},{"line_number":2927,"context_line":"        if stub:"},{"line_number":2928,"context_line":"            self.mox.StubOutWithMock(self.instance, \u0027save\u0027)"},{"line_number":2929,"context_line":"        self.instance.save().AndReturn(self.instance)"},{"line_number":2930,"context_line":""},{"line_number":2931,"context_line":"    def _notify_about_instance_usage(self, event, stub\u003dTrue, **kwargs):"},{"line_number":2932,"context_line":"        if stub:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_04caf9a1","line":2929,"range":{"start_line":2926,"start_character":4,"end_line":2929,"end_character":53},"in_reply_to":"da6ed579_326191d4","updated":"2016-01-19 03:15:00.000000000","message":"Done","commit_id":"75b9f94ea94bc8ab27082522adcbee76b13eb229"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bbd0c59ba4fd381fb88bd92d1775125e8467fddb","unresolved":false,"context_lines":[{"line_number":3718,"context_line":"            raise test_exception"},{"line_number":3719,"context_line":""},{"line_number":3720,"context_line":"        try:"},{"line_number":3721,"context_line":"            self.instance.task_state \u003d task_states.NETWORKING"},{"line_number":3722,"context_line":"            with self.compute._build_resources(self.context, self.instance,"},{"line_number":3723,"context_line":"                    self.requested_networks, self.security_groups,"},{"line_number":3724,"context_line":"                    self.image, self.block_device_mapping):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_be70eddd","line":3721,"updated":"2016-01-15 22:58:34.000000000","message":"Nit: This should be outside the try block like you have at L3746","commit_id":"75b9f94ea94bc8ab27082522adcbee76b13eb229"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"46111a9c6432058b649c65bf2978284010e34933","unresolved":false,"context_lines":[{"line_number":2981,"context_line":"        if reschedule_update:"},{"line_number":2982,"context_line":"            self.instance.save().AndReturn(self.instance)"},{"line_number":2983,"context_line":""},{"line_number":2984,"context_line":"    def _build_resources_instance_update_with_expected_task(self, stub\u003dTrue):"},{"line_number":2985,"context_line":"        if stub:"},{"line_number":2986,"context_line":"            self.mox.StubOutWithMock(self.instance, \u0027save\u0027)"},{"line_number":2987,"context_line":"        self.instance.save("}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_4bf819c5","line":2984,"updated":"2016-02-08 23:10:30.000000000","message":"do we maybe also want a test that shows what happens when the task state doesn\u0027t match the expected value?","commit_id":"ea751a5c4a9d33bb87c54001929e0985834b9ed3"}]}