)]}'
{"id":"openstack%2Fnova~24550","triplet_id":"openstack%2Fnova~master~If1148653edd96bd70b983c2fa89cd9973d80e48b","project":"openstack/nova","branch":"master","topic":"bug/1107721","hashtags":[],"change_id":"If1148653edd96bd70b983c2fa89cd9973d80e48b","subject":"Remove unnecessary checks in api.py","status":"MERGED","created":"2013-03-15 19:01:20.000000000","updated":"2013-03-25 19:08:09.000000000","submitted":"2013-03-25 19:08:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":13,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1d3b31784aed29c0cf4e97fbca10e67de4f09ea1","_number":24550,"virtual_id_number":24550,"owner":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":0,"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"value":0,"_account_id":1007,"name":"Nathanael I Burton","email":"nathanael.i.burton.work@gmail.com","username":"mathrock"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":2,"date":"2013-03-25 19:08:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":1,"date":"2013-03-22 15:35:08.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},{"value":0,"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"recommended":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"all":[{"value":1,"date":"2013-03-25 00:49:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":2,"date":"2013-03-25 17:58:39.000000000","_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"value":0,"_account_id":1007,"name":"Nathanael I Burton","email":"nathanael.i.burton.work@gmail.com","username":"mathrock"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":2,"date":"2013-03-22 15:27:14.000000000","_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},{"value":1,"date":"2013-03-25 16:13:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},{"value":0,"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"all":[{"value":0,"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":1,"date":"2013-03-25 17:58:39.000000000","_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"value":0,"_account_id":1007,"name":"Nathanael I Burton","email":"nathanael.i.burton.work@gmail.com","username":"mathrock"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"date":"2013-03-22 15:27:14.000000000","_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},{"value":0,"date":"2013-03-25 16:13:10.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},{"value":0,"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":0,"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"value":0,"_account_id":1007,"name":"Nathanael I Burton","email":"nathanael.i.burton.work@gmail.com","username":"mathrock"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},{"value":0,"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"_account_id":1007,"name":"Nathanael I Burton","email":"nathanael.i.burton.work@gmail.com","username":"mathrock"},{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-15 19:17:10.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2013-03-15 22:51:34.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-03-17 12:29:33.000000000","updated_by":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"reviewer":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"state":"REVIEWER"},{"updated":"2013-03-18 13:58:11.000000000","updated_by":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"reviewer":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"state":"REVIEWER"},{"updated":"2013-03-18 18:54:09.000000000","updated_by":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"reviewer":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"state":"REVIEWER"},{"updated":"2013-03-18 20:49:55.000000000","updated_by":{"_account_id":1007,"name":"Nathanael I Burton","email":"nathanael.i.burton.work@gmail.com","username":"mathrock"},"reviewer":{"_account_id":1007,"name":"Nathanael I Burton","email":"nathanael.i.burton.work@gmail.com","username":"mathrock"},"state":"REVIEWER"},{"updated":"2013-03-18 21:19:32.000000000","updated_by":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"reviewer":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"state":"REVIEWER"},{"updated":"2013-03-22 15:27:14.000000000","updated_by":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"reviewer":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"state":"REVIEWER"},{"updated":"2013-03-22 15:35:08.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-03-25 00:49:27.000000000","updated_by":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"reviewer":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"state":"REVIEWER"},{"updated":"2013-03-25 16:13:10.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2013-03-25 17:58:39.000000000","updated_by":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"reviewer":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"state":"REVIEWER"},{"updated":"2013-03-25 19:08:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"eafa31770f523961330668c58f3b1038f0d6b1bd","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2013-03-15 19:17:10.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"e35a0bcd62c29284af00b9d968016b329c940b2a","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-15 19:22:50.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/78159\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/78160\n","accounts_in_message":[],"_revision_number":1},{"id":"cfa3f5418580b0633ab14585df7ac767252b6682","author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"date":"2013-03-15 19:23:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d9102382f478bbfd59083a03cc23625c7f806455","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-03-15 19:23:21.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"aeb96f2080e129e59a073276d0442f5117a1b7d6","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-15 19:47:18.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/78163\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/78164\n","accounts_in_message":[],"_revision_number":2},{"id":"75174ec5e99cd0ca3849ec6554f32494cdd96ea8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-15 20:11:31.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/24550/2/check/gate-nova-pep8/23097 : SUCCESS\n- http://logs.openstack.org/24550/2/check/gate-nova-docs/17455 : SUCCESS\n- http://logs.openstack.org/24550/2/check/gate-nova-python26/18864 : FAILURE\n- http://logs.openstack.org/24550/2/check/gate-nova-python27/18952 : FAILURE\n- http://logs.openstack.org/24550/2/check/gate-tempest-devstack-vm-full/9190 : SUCCESS\n- http://logs.openstack.org/24550/2/check/gate-tempest-devstack-vm-postgres-full/8906 : SUCCESS\n- http://logs.openstack.org/24550/2/check/gate-tempest-devstack-vm-quantum/14522 : SUCCESS\n- http://logs.openstack.org/24550/2/check/gate-nova-pylint/9528 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"452cb5762609b5f2221b5e6daad69708d9273e36","author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"date":"2013-03-15 20:33:31.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"51482221ff4672b6416481efdf289e5b09cdcdff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-15 21:22:24.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/24550/3/check/gate-nova-pep8/23105 : SUCCESS\n- http://logs.openstack.org/24550/3/check/gate-nova-docs/17460 : SUCCESS\n- http://logs.openstack.org/24550/3/check/gate-nova-python26/18869 : SUCCESS\n- http://logs.openstack.org/24550/3/check/gate-nova-python27/18957 : SUCCESS\n- http://logs.openstack.org/24550/3/check/gate-tempest-devstack-vm-full/9210 : SUCCESS\n- http://logs.openstack.org/24550/3/check/gate-tempest-devstack-vm-postgres-full/8926 : SUCCESS\n- http://logs.openstack.org/24550/3/check/gate-tempest-devstack-vm-quantum/14542 : SUCCESS\n- http://logs.openstack.org/24550/3/check/gate-nova-pylint/9532 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"981bee358733cbdd99f4ec99f5e9e7a389e8cc4d","author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"date":"2013-03-15 23:39:22.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"1e641523b90507c0e05419051ca53942be56670d","author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"date":"2013-03-15 23:58:26.000000000","message":"Patch Set 3: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"8c291a5a9cb3a970fb26c7ac371b5074fa673901","author":{"_account_id":1007,"name":"Nathanael I Burton","email":"nathanael.i.burton.work@gmail.com","username":"mathrock"},"date":"2013-03-17 06:10:49.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"fdbb6e83bb2b1b55224799130596de58cd863fde","author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"date":"2013-03-17 12:29:33.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"b8ba0b268cf85c0987b7f8a95df27953a32ef9ea","author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"date":"2013-03-18 04:53:35.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nIMHO the remove tests to non running instances that were supposed to fail should be converted to tests that assert it works on those Power states","accounts_in_message":[],"_revision_number":3},{"id":"57e8063d6ce8364ed479ba0926ae2d026705004a","author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"date":"2013-03-18 04:59:16.000000000","message":"Patch Set 3:\n\nIMHO the remove tests to non running instances that were supposed to fail should be converted to tests that assert it works on those Power states\n\nAnd maybe we should do some real tests (not unit, in tempest I think) to check how it will behave with changing adding removing the Sec. groups during server BUILD state","accounts_in_message":[],"_revision_number":3},{"id":"f60a27ad524bb2b47766dcc73bb5cc42bec17dd7","author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"date":"2013-03-18 13:46:06.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"fb9ce913588e4906241d4183c96cc5527952fa3d","author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"date":"2013-03-18 13:48:08.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"ff9cc776a506e4c3ef599fad00d5437ac1b60a72","author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"date":"2013-03-18 13:58:11.000000000","message":"Patch Set 5: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"30495d65cbaa069756f20fb23a3e971ba631eac1","author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"date":"2013-03-18 14:20:20.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"33e167fdecdf3e30a4d524a085c663c544dead10","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-18 14:43:49.000000000","message":"Patch Set 6: Works for me\n\nSmokeStack Results (patch set 6):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/78521\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/78522\n","accounts_in_message":[],"_revision_number":6},{"id":"e5c82a2043ccff798f0eda242c196fd8540f3249","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-18 15:07:16.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/24550/6/check/gate-nova-pep8/23153 : SUCCESS\n- http://logs.openstack.org/24550/6/check/gate-nova-docs/17504 : SUCCESS\n- http://logs.openstack.org/24550/6/check/gate-nova-python26/18913 : SUCCESS\n- http://logs.openstack.org/24550/6/check/gate-nova-python27/19001 : SUCCESS\n- http://logs.openstack.org/24550/6/check/gate-tempest-devstack-vm-full/9341 : SUCCESS\n- http://logs.openstack.org/24550/6/check/gate-tempest-devstack-vm-postgres-full/9056 : SUCCESS\n- http://logs.openstack.org/24550/6/check/gate-tempest-devstack-vm-quantum/14696 : SUCCESS\n- http://logs.openstack.org/24550/6/check/gate-nova-pylint/9560 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"a1a77a89cf8546332139248a7c3aba3648017acb","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-03-18 18:54:09.000000000","message":"Patch Set 6: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nminor nit in commit message","accounts_in_message":[],"_revision_number":6},{"id":"f8027288e47ed8c3d1a92e49cc0e7d6d68f37a22","author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"date":"2013-03-18 19:05:54.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"964e0881dee71a1f7f7f80b1c51d4392dd686356","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-03-18 19:06:10.000000000","message":"Patch Set 7:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":7},{"id":"da060e63b3785e40a56ed784fea42bb0dd362e08","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-18 19:32:42.000000000","message":"Patch Set 7: Works for me\n\nSmokeStack Results (patch set 7):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/78581\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/78582\n","accounts_in_message":[],"_revision_number":7},{"id":"a6401ee32c44c79da5901a09fa65210260b95d5b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-18 19:55:22.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/24550/7/check/gate-nova-pep8/23168 : SUCCESS\n- http://logs.openstack.org/24550/7/check/gate-nova-docs/17519 : SUCCESS\n- http://logs.openstack.org/24550/7/check/gate-nova-python26/18928 : SUCCESS\n- http://logs.openstack.org/24550/7/check/gate-nova-python27/19016 : SUCCESS\n- http://logs.openstack.org/24550/7/check/gate-tempest-devstack-vm-full/9389 : SUCCESS\n- http://logs.openstack.org/24550/7/check/gate-tempest-devstack-vm-postgres-full/9104 : SUCCESS\n- http://logs.openstack.org/24550/7/check/gate-tempest-devstack-vm-quantum/14754 : SUCCESS\n- http://logs.openstack.org/24550/7/check/gate-nova-pylint/9572 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":7},{"id":"b3a282638fd4395c34573d181a96139ace3a2add","author":{"_account_id":1007,"name":"Nathanael I Burton","email":"nathanael.i.burton.work@gmail.com","username":"mathrock"},"date":"2013-03-18 20:49:55.000000000","message":"Patch Set 7: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":7},{"id":"5d0bd199d71ecc0d9956cf224770ec708e88e795","author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"date":"2013-03-18 21:19:32.000000000","message":"Patch Set 7: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"2058d413945fd43d6432102a1254f088126734bb","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-03-18 21:47:58.000000000","message":"Patch Set 7: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nsee inline","accounts_in_message":[],"_revision_number":7},{"id":"3fcbe314273689d7d925b1b3a6df6b7e69b1648e","author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"date":"2013-03-20 12:52:14.000000000","message":"Patch Set 7: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"8a2c4deb6ec347572e505967d882a66b974e55c7","author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"date":"2013-03-21 19:17:20.000000000","message":"Patch Set 7: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"6e053c1527409a93935f0a7efc1a0582c831b970","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-03-21 19:40:52.000000000","message":"Patch Set 7: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"80781997ae3ab33f62878c9bbc79394746559893","author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"date":"2013-03-22 14:26:29.000000000","message":"Patch Set 7: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"eac4267475103c028e47cd40a8ed1f5c83317b4a","author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"date":"2013-03-22 15:14:00.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"f1455ccf9bbed58a94bfbbd7e90d198a3360c413","author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"date":"2013-03-22 15:27:14.000000000","message":"Patch Set 8: Looks good to me (core reviewer)\n\nCode itself looks ok. I\u0027m not wholly convinced of the utility of adding security groups to things that are off, but I suppose it could make some things easier. \n\nAs far as changing the API is concerned, this falls under the domain of the extensions, and as far as I\u0027m concerned, those are (somewhat) mutable. Since it doesn\u0027t look like it would break a useful feature in anyway (it merely opens the door to using this code path in a few more states) I don\u0027t see why it would be a problem.","accounts_in_message":[],"_revision_number":8},{"id":"b7af33758345b21aa562f5bbd0f2df731d65991a","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-22 15:35:08.000000000","message":"Patch Set 8: Works for me\n\nSmokeStack Results (patch set 8):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/79459\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/79460\n","accounts_in_message":[],"_revision_number":8},{"id":"032efd25739f222a44dfc0cab8f4604b5642453a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-22 15:58:49.000000000","message":"Patch Set 8: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/24550/8/check/gate-nova-pep8/23418 : SUCCESS\n- http://logs.openstack.org/24550/8/check/gate-nova-docs/17749 : SUCCESS\n- http://logs.openstack.org/24550/8/check/gate-nova-python26/19158 : SUCCESS\n- http://logs.openstack.org/24550/8/check/gate-nova-python26-rhel6/37 : FAILURE (non-voting)\n- http://logs.openstack.org/24550/8/check/gate-nova-python27/19246 : SUCCESS\n- http://logs.openstack.org/24550/8/check/gate-tempest-devstack-vm-full/10066 : SUCCESS\n- http://logs.openstack.org/24550/8/check/gate-tempest-devstack-vm-postgres-full/9781 : SUCCESS\n- http://logs.openstack.org/24550/8/check/gate-tempest-devstack-vm-quantum/15543 : SUCCESS\n- http://logs.openstack.org/24550/8/check/gate-nova-pylint/9741 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":8},{"id":"4cd210c3e3d6e8201173607a289b9cb0a0b2939f","author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"date":"2013-03-25 00:49:27.000000000","message":"Patch Set 8: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":8},{"id":"0c2106273f04757a963cd65ffb9d3c90a12f31da","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2013-03-25 16:13:10.000000000","message":"Patch Set 8: Looks good to me, but someone else must approve\n\nMatt, reasonable enough.","accounts_in_message":[],"_revision_number":8},{"id":"abea63ae919db685cbfb77dc745098e3aba3b8e5","author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"date":"2013-03-25 17:58:39.000000000","message":"Patch Set 8: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":8},{"id":"c9f3f6cd33c4c845c580ce322a8cad1d77846ea1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-25 17:58:44.000000000","message":"Patch Set 8: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":8},{"id":"0535d6c2f13c026dc3e9ab520ce6d69fc9617fdd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-25 19:08:07.000000000","message":"Patch Set 8: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/24550/8/gate/gate-nova-docs/17864 : SUCCESS\n- http://logs.openstack.org/24550/8/gate/gate-nova-pep8/23549 : SUCCESS\n- http://logs.openstack.org/24550/8/gate/gate-nova-python26/19272 : SUCCESS\n- http://logs.openstack.org/24550/8/gate/gate-nova-python27/19360 : SUCCESS\n- http://logs.openstack.org/24550/8/gate/gate-tempest-devstack-vm-full/10381 : SUCCESS\n- http://logs.openstack.org/24550/8/gate/gate-tempest-devstack-vm-postgres-full/10097 : SUCCESS\n- http://logs.openstack.org/24550/8/gate/gate-tempest-devstack-vm-quantum/15910 : SUCCESS\n","accounts_in_message":[],"_revision_number":8},{"id":"810e38d7c11c018f04eada40c712a8cd620a86d9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-25 19:08:09.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"074f64cd67b96f31b9e43299b633e9df71450f59","revisions":{"2b7aa4be2cec035d19e4f35baa8fe3926a284c93":{"kind":"REWORK","_number":1,"created":"2013-03-15 19:01:20.000000000","uploader":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"ref":"refs/changes/50/24550/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/50/24550/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/50/24550/1"}}},"commit":{"parents":[{"commit":"f14cd697c005f946886f90f7af8379c58e062ed1","subject":"Merge \"Fix OS-DCF:diskconfig XML handling\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f14cd697c005f946886f90f7af8379c58e062ed1"}]}],"author":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-15 18:55:12.000000000","tz":-240},"committer":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-15 18:59:37.000000000","tz":-240},"subject":"Remove unnecessary check in apy.py","message":"Remove unnecessary check in apy.py\n\nRemove checks to make sure instance is in running state\nwhen adding or removing security groups to/from an\ninstance.\nFixes bug 1107721\n\nChange-Id: If1148653edd96bd70b983c2fa89cd9973d80e48b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b7aa4be2cec035d19e4f35baa8fe3926a284c93"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b7aa4be2cec035d19e4f35baa8fe3926a284c93"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f14cd697c005f946886f90f7af8379c58e062ed1","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"e5f543df233232a81365ce33f80f37d2ce8d3068":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-03-15 19:23:06.000000000","uploader":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"ref":"refs/changes/50/24550/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/50/24550/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/50/24550/2"}}},"commit":{"parents":[{"commit":"f14cd697c005f946886f90f7af8379c58e062ed1","subject":"Merge \"Fix OS-DCF:diskconfig XML handling\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f14cd697c005f946886f90f7af8379c58e062ed1"}]}],"author":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-15 18:55:12.000000000","tz":-240},"committer":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-15 19:20:57.000000000","tz":-240},"subject":"Remove unnecessary checks in api.py","message":"Remove unnecessary checks in api.py\n\nRemove checks to make sure instance is in running state\nwhen adding or removing security groups to/from an\ninstance.\nFixes bug 1107721\n\nChange-Id: If1148653edd96bd70b983c2fa89cd9973d80e48b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e5f543df233232a81365ce33f80f37d2ce8d3068"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e5f543df233232a81365ce33f80f37d2ce8d3068"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f14cd697c005f946886f90f7af8379c58e062ed1","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"033f81de9a8e0f79c0936e796e81f906cb565577":{"kind":"REWORK","_number":3,"created":"2013-03-15 20:33:31.000000000","uploader":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"ref":"refs/changes/50/24550/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/50/24550/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/50/24550/3"}}},"commit":{"parents":[{"commit":"11f65872503e1779ece1d5f83a19627b23267235","subject":"Merge \"Make os-services API extensions consistent.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/11f65872503e1779ece1d5f83a19627b23267235"}]}],"author":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-15 18:55:12.000000000","tz":-240},"committer":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-15 20:32:18.000000000","tz":-240},"subject":"Remove unnecessary checks in api.py","message":"Remove unnecessary checks in api.py\n\nRemove checks to make sure instance is in running state\nwhen adding or removing security groups to/from an\ninstance.\nFixes bug 1107721\n\nChange-Id: If1148653edd96bd70b983c2fa89cd9973d80e48b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/033f81de9a8e0f79c0936e796e81f906cb565577"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/033f81de9a8e0f79c0936e796e81f906cb565577"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"11f65872503e1779ece1d5f83a19627b23267235","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"a1bc4f89de2084933099ba20dcf2755e7a35e5e8":{"kind":"REWORK","_number":4,"created":"2013-03-18 13:46:06.000000000","uploader":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"ref":"refs/changes/50/24550/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/50/24550/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/50/24550/4"}}},"commit":{"parents":[{"commit":"c519a378a28ec1f5752034bb0550197f100f799e","subject":"Merge \"Reset migrating task state for more Exceptions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c519a378a28ec1f5752034bb0550197f100f799e"}]}],"author":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-15 18:55:12.000000000","tz":-240},"committer":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-18 13:44:54.000000000","tz":-240},"subject":"Remove unnecessary checks in api.py","message":"Remove unnecessary checks in api.py\n\nRemove checks to make sure instance is in running state\nwhen adding or removing security groups to/from an\ninstance.\nModified unit test accordingly\nFixes bug 1107721\n\nChange-Id: If1148653edd96bd70b983c2fa89cd9973d80e48b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a1bc4f89de2084933099ba20dcf2755e7a35e5e8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a1bc4f89de2084933099ba20dcf2755e7a35e5e8"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c519a378a28ec1f5752034bb0550197f100f799e","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"9812789f6dfcbf2ad84e1973d731c53c3f344914":{"kind":"REWORK","_number":5,"created":"2013-03-18 13:48:08.000000000","uploader":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"ref":"refs/changes/50/24550/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/50/24550/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/50/24550/5"}}},"commit":{"parents":[{"commit":"c519a378a28ec1f5752034bb0550197f100f799e","subject":"Merge \"Reset migrating task state for more Exceptions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c519a378a28ec1f5752034bb0550197f100f799e"}]}],"author":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-15 18:55:12.000000000","tz":-240},"committer":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-18 13:46:47.000000000","tz":-240},"subject":"Remove unnecessary checks in api.py","message":"Remove unnecessary checks in api.py\n\nRemove checks to make sure instance is in running state\nwhen adding or removing security groups to/from an\ninstance.\nModified unit test accordingly\nFixes bug 1107721\n\nChange-Id: If1148653edd96bd70b983c2fa89cd9973d80e48b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9812789f6dfcbf2ad84e1973d731c53c3f344914"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9812789f6dfcbf2ad84e1973d731c53c3f344914"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c519a378a28ec1f5752034bb0550197f100f799e","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"cbebebd729fbf763d8376c817b61a8012cc632c2":{"kind":"REWORK","_number":6,"created":"2013-03-18 14:20:20.000000000","uploader":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"ref":"refs/changes/50/24550/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/50/24550/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/50/24550/6"}}},"commit":{"parents":[{"commit":"c519a378a28ec1f5752034bb0550197f100f799e","subject":"Merge \"Reset migrating task state for more Exceptions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c519a378a28ec1f5752034bb0550197f100f799e"}]}],"author":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-15 18:55:12.000000000","tz":-240},"committer":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-18 14:18:56.000000000","tz":-240},"subject":"Remove unnecessary checks in api.py","message":"Remove unnecessary checks in api.py\n\nRemove checks to make sure instance is in running state\nwhen adding or removing security groups to/from an\ninstance.\nModified unit test accordingly\nFixes bug 1107721\n\nChange-Id: If1148653edd96bd70b983c2fa89cd9973d80e48b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cbebebd729fbf763d8376c817b61a8012cc632c2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cbebebd729fbf763d8376c817b61a8012cc632c2"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c519a378a28ec1f5752034bb0550197f100f799e","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"b31a89ad575064193e8db35547b6217b76ca2ba0":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":7,"created":"2013-03-18 19:05:54.000000000","uploader":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"ref":"refs/changes/50/24550/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/50/24550/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/50/24550/7"}}},"commit":{"parents":[{"commit":"47ded8e6127a7e07620c16c07621ca5d79dd881d","subject":"Merge \"Fix issues with cells and resize\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/47ded8e6127a7e07620c16c07621ca5d79dd881d"}]}],"author":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-15 18:55:12.000000000","tz":-240},"committer":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-18 19:04:42.000000000","tz":-240},"subject":"Remove unnecessary checks in api.py","message":"Remove unnecessary checks in api.py\n\nRemove existing check to ensure instance was running\nwhen adding or removing security groups to/from an\ninstance.\nModified unit test accordingly\nFixes bug 1107721\n\nChange-Id: If1148653edd96bd70b983c2fa89cd9973d80e48b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b31a89ad575064193e8db35547b6217b76ca2ba0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b31a89ad575064193e8db35547b6217b76ca2ba0"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"47ded8e6127a7e07620c16c07621ca5d79dd881d","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"074f64cd67b96f31b9e43299b633e9df71450f59":{"kind":"REWORK","_number":8,"created":"2013-03-22 15:14:00.000000000","uploader":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"ref":"refs/changes/50/24550/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/50/24550/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/50/24550/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/50/24550/8"}}},"commit":{"parents":[{"commit":"c21016c26749f4efb0978d5e4fea9560fc4d0603","subject":"Merge \"Change arguments to volume_detach()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c21016c26749f4efb0978d5e4fea9560fc4d0603"}]}],"author":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-15 18:55:12.000000000","tz":-240},"committer":{"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","date":"2013-03-22 15:12:44.000000000","tz":-240},"subject":"Remove unnecessary checks in api.py","message":"Remove unnecessary checks in api.py\n\nRemove existing check to ensure instance was running\nwhen adding or removing security groups to/from an\ninstance.\nModified unit test accordingly\nFixes bug 1107721\n\nChange-Id: If1148653edd96bd70b983c2fa89cd9973d80e48b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/074f64cd67b96f31b9e43299b633e9df71450f59"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/074f64cd67b96f31b9e43299b633e9df71450f59"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c21016c26749f4efb0978d5e4fea9560fc4d0603","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}