)]}'
{"nova/tests/test_db_api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"82d02264e5897c134bc1ed1d383bba4b20f41b47","unresolved":false,"context_lines":[{"line_number":2017,"context_line":"        # NOTE(boris-42): Due to the bug 1156227 this won\u0027t work. In havana-1"},{"line_number":2018,"context_line":"        #                 it will be fixed."},{"line_number":2019,"context_line":"        #self.assertRaises(exception.VirtualInterfaceCreateException,"},{"line_number":2020,"context_line":"        #                  self._create_virt_interface, {})"},{"line_number":2021,"context_line":""},{"line_number":2022,"context_line":"    def test_virtual_interface_get(self):"},{"line_number":2023,"context_line":"        vif \u003d self._create_virt_interface({})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F%2B0s%3D","line":2020,"updated":"2013-03-18 16:20:16.000000000","message":"I think I\u0027d prefer this to be a skip with the comment instead of disabled code.","commit_id":"0b6b81ebfe1f8c74c3a147ce6349d640b0996a57"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"dd66064352aeda94a2d3df66325cd4aefe45ed09","unresolved":false,"context_lines":[{"line_number":2017,"context_line":"        # NOTE(boris-42): Due to the bug 1156227 this won\u0027t work. In havana-1"},{"line_number":2018,"context_line":"        #                 it will be fixed."},{"line_number":2019,"context_line":"        #self.assertRaises(exception.VirtualInterfaceCreateException,"},{"line_number":2020,"context_line":"        #                  self._create_virt_interface, {})"},{"line_number":2021,"context_line":""},{"line_number":2022,"context_line":"    def test_virtual_interface_get(self):"},{"line_number":2023,"context_line":"        vif \u003d self._create_virt_interface({})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F%2Bu8%3D","line":2020,"in_reply_to":"AAAAOH%2F%2F%2B0s%3D","updated":"2013-03-18 17:20:57.000000000","message":"I can remove it, but I don\u0027t see any reason for that..\n\nThis is new (not old) code that will be uncommitted when Havana-1 starts. \n\nAnd It is easier to explain what this test should check through code instead of tons of words...","commit_id":"0b6b81ebfe1f8c74c3a147ce6349d640b0996a57"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9cdffad30f1ee00adebbf0af86151899c4a60106","unresolved":false,"context_lines":[{"line_number":2017,"context_line":"        # NOTE(boris-42): Due to the bug 1156227 this won\u0027t work. In havana-1"},{"line_number":2018,"context_line":"        #                 it will be fixed."},{"line_number":2019,"context_line":"        #self.assertRaises(exception.VirtualInterfaceCreateException,"},{"line_number":2020,"context_line":"        #                  self._create_virt_interface, {})"},{"line_number":2021,"context_line":""},{"line_number":2022,"context_line":"    def test_virtual_interface_get(self):"},{"line_number":2023,"context_line":"        vif \u003d self._create_virt_interface({})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F%2Buw%3D","line":2020,"in_reply_to":"AAAAOH%2F%2F%2Bu8%3D","updated":"2013-03-18 17:23:53.000000000","message":"I don\u0027t want you to remove this, I want you to leave the code there, uncommented, and put a @skip on the test function. I think commented-out code should be avoided whenever possible and the skip functionality gives us the proper mechanism to make this not run until it works, IMHO.","commit_id":"0b6b81ebfe1f8c74c3a147ce6349d640b0996a57"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"82d02264e5897c134bc1ed1d383bba4b20f41b47","unresolved":false,"context_lines":[{"line_number":2034,"context_line":""},{"line_number":2035,"context_line":"    def test_virtual_interface_get_by_uuid(self):"},{"line_number":2036,"context_line":"        vif \u003d self._create_virt_interface({})"},{"line_number":2037,"context_line":"        real_vif \u003d db.virtual_interface_get_by_uuid(self.ctxt, vif[\u0027uuid\u0027])"},{"line_number":2038,"context_line":"        for key, value in vif.iteritems():"},{"line_number":2039,"context_line":"            self.assertEqual(value, real_vif[key])"},{"line_number":2040,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F%2B0k%3D","line":2037,"updated":"2013-03-18 16:20:16.000000000","message":"If this returns {} we would not notice and complain. Perhaps a check that the real_vif is not empty before we run the loop?","commit_id":"0b6b81ebfe1f8c74c3a147ce6349d640b0996a57"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"dd66064352aeda94a2d3df66325cd4aefe45ed09","unresolved":false,"context_lines":[{"line_number":2034,"context_line":""},{"line_number":2035,"context_line":"    def test_virtual_interface_get_by_uuid(self):"},{"line_number":2036,"context_line":"        vif \u003d self._create_virt_interface({})"},{"line_number":2037,"context_line":"        real_vif \u003d db.virtual_interface_get_by_uuid(self.ctxt, vif[\u0027uuid\u0027])"},{"line_number":2038,"context_line":"        for key, value in vif.iteritems():"},{"line_number":2039,"context_line":"            self.assertEqual(value, real_vif[key])"},{"line_number":2040,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F%2BvI%3D","line":2037,"in_reply_to":"AAAAOH%2F%2F%2B0k%3D","updated":"2013-03-18 17:20:57.000000000","message":"I am not sure that it is a good pattern.. To test it here one more time. \n\nWe assume that our method self._create_virt_interface() works correctly we have tested it in test_virtual_interface_create(). \n\nSo if it returns {} test_virtual_interface_create() will fail. \n\nFurthermore it will be a little bit confusing. \nWe are testing method1 and test fails because method2 doesn\u0027t work.","commit_id":"0b6b81ebfe1f8c74c3a147ce6349d640b0996a57"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"82d02264e5897c134bc1ed1d383bba4b20f41b47","unresolved":false,"context_lines":[{"line_number":2072,"context_line":"        vif \u003d vifs1[1]"},{"line_number":2073,"context_line":"        real_vif \u003d db.virtual_interface_get_by_instance_and_network(self.ctxt,"},{"line_number":2074,"context_line":"                                                                    inst_uuid2,"},{"line_number":2075,"context_line":"                                                                    network_id)"},{"line_number":2076,"context_line":"        for key, value in vif.iteritems():"},{"line_number":2077,"context_line":"            self.assertEqual(value, real_vif[key])"},{"line_number":2078,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F%2B0g%3D","line":2075,"updated":"2013-03-18 16:20:16.000000000","message":"Ditto.","commit_id":"0b6b81ebfe1f8c74c3a147ce6349d640b0996a57"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"618825b85b642c200a1d14680e1508f5f8d4aefe","unresolved":false,"context_lines":[{"line_number":2033,"context_line":"        for key, value in vif.iteritems():"},{"line_number":2034,"context_line":"            self.assertEqual(value, real_vif[key])"},{"line_number":2035,"context_line":""},{"line_number":2036,"context_line":"    def test_virtual_interface_get_by_uuid(self):"},{"line_number":2037,"context_line":"        vif \u003d self._create_virt_interface({})"},{"line_number":2038,"context_line":"        real_vif \u003d db.virtual_interface_get_by_uuid(self.ctxt, vif[\u0027uuid\u0027])"},{"line_number":2039,"context_line":"        for key, value in vif.iteritems():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F%2BUs%3D","line":2036,"updated":"2013-03-18 20:46:34.000000000","message":"This test method and the two before it don\u0027t really test that the db.virtual_interface_get* methods do anything different.  Maybe multiple unique vifs could be created to test that they\u0027re being retrieved by the correct property.","commit_id":"494daa4f35923d0806afd7af6d381fb12e002ca1"}]}