)]}'
{"nova/tests/unit/virt/hyperv/test_vmops.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"e9e73c570c01bfc7b3dfc202514c92c6c57815be","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(1, overhead[\u0027disk_gb\u0027])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_estimate_instance_no_overhead(self):"},{"line_number":94,"context_line":"        mock_instance \u003d mock.MagicMock(memory_mb\u003d1000)"},{"line_number":95,"context_line":"        overhead \u003d self._vmops.estimate_instance_overhead(mock_instance)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        self.assertEqual(0, overhead[\u0027memory_mb\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d5026b6f","line":94,"updated":"2015-12-03 16:41:03.000000000","message":"Just a small note: looks like in this case, the disk overhead is ignored. An alternative would be to just ceil this value.","commit_id":"949f114131edb74e8fa8fe0346a5981de23d1c31"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"81d2303eba4c71571e95b45078307ee0420e09c6","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.assertEqual(1, overhead[\u0027disk_gb\u0027])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_estimate_instance_no_overhead(self):"},{"line_number":94,"context_line":"        mock_instance \u003d mock.MagicMock(memory_mb\u003d1000)"},{"line_number":95,"context_line":"        overhead \u003d self._vmops.estimate_instance_overhead(mock_instance)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        self.assertEqual(0, overhead[\u0027memory_mb\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_2bad8e88","line":94,"in_reply_to":"7a740942_d5026b6f","updated":"2015-12-03 17:10:24.000000000","message":"then it would an exageration for instances that have XX64-X512 MB, IMO. If you would spawn a lot of instances that require small amounts of memory, then the resource tracker will consider that a lot more of the disk storage space is used than it actually is.\n\nI think the best solution would be to round up from 512MB to the next GB, floor otherwise.","commit_id":"949f114131edb74e8fa8fe0346a5981de23d1c31"}],"nova/virt/hyperv/vmops.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"d32e970c37c48e010a583ab590c3c7cd9ac5dec3","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        # file on the local disk. The file size is the same as the VM\u0027s amount"},{"line_number":165,"context_line":"        # of memory."},{"line_number":166,"context_line":"        return {\u0027memory_mb\u0027: 0,"},{"line_number":167,"context_line":"                \u0027disk_gb\u0027: instance_info.memory_mb // units.Ki}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def get_info(self, instance):"},{"line_number":170,"context_line":"        \"\"\"Get information about the VM.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_f8fe7e04","line":167,"updated":"2015-12-03 16:47:38.000000000","message":"Instance info is actually a dict, so the Hyper-V CI is getting:\nAttributeError: \u0027dict\u0027 object has no attribute \u0027memory_mb\u0027","commit_id":"949f114131edb74e8fa8fe0346a5981de23d1c31"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"81d2303eba4c71571e95b45078307ee0420e09c6","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        # file on the local disk. The file size is the same as the VM\u0027s amount"},{"line_number":165,"context_line":"        # of memory."},{"line_number":166,"context_line":"        return {\u0027memory_mb\u0027: 0,"},{"line_number":167,"context_line":"                \u0027disk_gb\u0027: instance_info.memory_mb // units.Ki}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def get_info(self, instance):"},{"line_number":170,"context_line":"        \"\"\"Get information about the VM.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_8b37e2e2","line":167,"in_reply_to":"7a740942_f8fe7e04","updated":"2015-12-03 17:10:24.000000000","message":"Done","commit_id":"949f114131edb74e8fa8fe0346a5981de23d1c31"}]}