)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"64558f51847c83b98ec92cd137dc305dc1e8bb77","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Markus Zoeller \u003cmzoeller@de.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-19 11:04:43 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"config options: enhance help test of section \"serial_console\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The help text of the config options got enhanced to improve the quality"},{"line_number":10,"context_line":"of their documentation. I used a syntax which is in the ReST format."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_3752e135","line":7,"updated":"2015-11-20 09:48:10.000000000","message":"nit: s/test/text/","commit_id":"757871971fdb8e88167e56c9050b1dfb7e483284"}],"nova/conf/serial_console.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"64558f51847c83b98ec92cd137dc305dc1e8bb77","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    # Because of bug 1395819 in oslo.config we cannot pass in the OptGroup."},{"line_number":200,"context_line":"    # As soon as this bug is fixed is oslo.config and Nova uses the"},{"line_number":201,"context_line":"    # version which contains this fix, we can pass in the OptGroup instead"},{"line_number":202,"context_line":"    # of its name. This allows the generation of the group help too."},{"line_number":203,"context_line":"    return (serial_opt_group.name, ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_f71d3973","line":202,"updated":"2015-11-20 09:48:10.000000000","message":"Nit: probably should have this in the dependent patch.","commit_id":"757871971fdb8e88167e56c9050b1dfb7e483284"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"155a3073a5dec7ca751e2407795521ee9b6431a9","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    # Because of bug 1395819 in oslo.config we cannot pass in the OptGroup."},{"line_number":200,"context_line":"    # As soon as this bug is fixed is oslo.config and Nova uses the"},{"line_number":201,"context_line":"    # version which contains this fix, we can pass in the OptGroup instead"},{"line_number":202,"context_line":"    # of its name. This allows the generation of the group help too."},{"line_number":203,"context_line":"    return (serial_opt_group.name, ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_328aef64","line":202,"in_reply_to":"ba8a016a_f71d3973","updated":"2015-11-20 09:53:16.000000000","message":"The previous patch in this series didn\u0027t use OptGroups but just a plain group name (\"serial_console\"). That\u0027s why I introduced the OptGroup in this patch.","commit_id":"757871971fdb8e88167e56c9050b1dfb7e483284"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"582a7bbd07bb35f509b608a2532040a441c5ab43","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        help\u003d\"\"\""},{"line_number":53,"context_line":"A range of TCP ports a guest can use for its backend."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Each instance which gets created will use one port out of this range. If the"},{"line_number":56,"context_line":"range is not big enough to provide another port for an new instance, this"},{"line_number":57,"context_line":"instance won\u0027t get launched."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_7d0eb933","line":55,"updated":"2015-11-23 13:09:09.000000000","message":"Emm....not sure whether is my English problem. It shouldn\u0027t be out of this range? it should be in of this range.","commit_id":"64107f3d58fabcba95394a04c24ef747870c5e98"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"263a8566880b40ab83f1b0889a2f95dfc0a331bf","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        help\u003d\"\"\""},{"line_number":53,"context_line":"A range of TCP ports a guest can use for its backend."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Each instance which gets created will use one port out of this range. If the"},{"line_number":56,"context_line":"range is not big enough to provide another port for an new instance, this"},{"line_number":57,"context_line":"instance won\u0027t get launched."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_f7171d52","line":55,"in_reply_to":"ba8a016a_7d0eb933","updated":"2015-11-23 15:25:33.000000000","message":"I think both are possible.","commit_id":"64107f3d58fabcba95394a04c24ef747870c5e98"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"582a7bbd07bb35f509b608a2532040a441c5ab43","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Possible values:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* \u003cscheme\u003e\u003cIP-address\u003e\u003cport-number\u003e"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Services which consume this:"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_bdcc21bc","line":83,"updated":"2015-11-23 13:09:09.000000000","message":"nit, maybe \u003cscheme\u003e://\u003cip-address\u003e:\u003cport-number\u003e","commit_id":"64107f3d58fabcba95394a04c24ef747870c5e98"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"62a5815708597f6d9b75d199256cff3abb69ff6a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        help\u003d\"\"\""},{"line_number":106,"context_line":"DEPRECATED: this option has no effect anymore. Please use"},{"line_number":107,"context_line":"\"proxyclient_address\" instead. This option is deprecated and will be removed"},{"line_number":108,"context_line":"in future releases.\"\"\")"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"proxyclient_address_opt \u003d cfg.StrOpt(\u0027proxyclient_address\u0027,"},{"line_number":111,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_504521b1","line":108,"updated":"2015-11-20 13:52:39.000000000","message":"Nit: \"removed in a future release\" is probably better wording, as it doesn\u0027t imply that it absolutely will be gone in the next release, but it might be.","commit_id":"64107f3d58fabcba95394a04c24ef747870c5e98"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"8adbaaf1f8b3b2259d60d06797ed3b6a69af14b6","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        help\u003d\"\"\""},{"line_number":106,"context_line":"DEPRECATED: this option has no effect anymore. Please use"},{"line_number":107,"context_line":"\"proxyclient_address\" instead. This option is deprecated and will be removed"},{"line_number":108,"context_line":"in future releases.\"\"\")"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"proxyclient_address_opt \u003d cfg.StrOpt(\u0027proxyclient_address\u0027,"},{"line_number":111,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_423554f5","line":108,"in_reply_to":"ba8a016a_504521b1","updated":"2015-11-20 15:13:28.000000000","message":"Yes, true. Can I use the standard-deprecation policy as a face-saver? :) I\u0027m going to be more careful with the wording in the future. If this review is -1\u0027ed for another thing, then I\u0027ll change it too.","commit_id":"64107f3d58fabcba95394a04c24ef747870c5e98"}]}