)]}'
{"nova/context.py":[{"author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"change_message_id":"c6bf301ca2ff6f037fdf3a385d199f726b872320","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if service_catalog is None:"},{"line_number":82,"context_line":"            service_catalog \u003d []"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # Only include required parts of service_catalog"},{"line_number":85,"context_line":"        self.service_catalog \u003d [s for s in service_catalog"},{"line_number":86,"context_line":"                if s.get(\u0027type\u0027) in (\u0027volume\u0027)]"},{"line_number":87,"context_line":"        self.instance_lock_checked \u003d instance_lock_checked"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F%2BfQ%3D","line":84,"updated":"2013-03-18 19:38:50.000000000","message":"shouldn\u0027t this be self.service_catalog?\nAlso, I would turn this into an if else stmt","commit_id":"b0986385aa440a1b0d1a6d0ce53ba54516586169"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"7dfe4d2e2174e23959527613ea1151a64f53ef68","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.request_id \u003d request_id"},{"line_number":79,"context_line":"        self.auth_token \u003d auth_token"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if not service_catalog:"},{"line_number":82,"context_line":"            # if list is empty or none"},{"line_number":83,"context_line":"            self.service_catalog \u003d []"},{"line_number":84,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F%2BRI%3D","line":81,"updated":"2013-03-18 21:04:36.000000000","message":"Really tiny-nit: if has a double-negative (yoda if).\n\nA slight improvement would be just to reverse the branches and do `if service_catalog`.","commit_id":"b2730f9f14c7e101f15e7d7b09caf540c8fc515b"}]}
