)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"c6094f1e8bb77740ba623599a9dc5303aa80ebb5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixed warn logging in sqlalchemy/api.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TrivialFix"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I70e6c92bcf595270dfa717810a9a2d94aecc0b21"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_765bfdf6","line":9,"updated":"2015-11-18 14:03:29.000000000","message":"Can you please add some info about why are you changing from _ to _LW?","commit_id":"25f8e456b56d00196b69e6badff259c055285164"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"c6094f1e8bb77740ba623599a9dc5303aa80ebb5","unresolved":false,"context_lines":[{"line_number":1556,"context_line":""},{"line_number":1557,"context_line":"    else:"},{"line_number":1558,"context_line":"        msg \u003d _LW(\u0027Unknown osapi_compute_unique_server_name_scope value: %s\u0027"},{"line_number":1559,"context_line":"                \u0027 Flag must be empty, \"global\" or\u0027"},{"line_number":1560,"context_line":"                \u0027 \"project\"\u0027) % CONF.osapi_compute_unique_server_name_scope"},{"line_number":1561,"context_line":"        LOG.warn(msg)"},{"line_number":1562,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_dba8d422","line":1559,"updated":"2015-11-18 14:03:29.000000000","message":"Just an indentation concern: please, add 2 spaces to this line so that it can be aligned with the beginning of the string in the line above.","commit_id":"25f8e456b56d00196b69e6badff259c055285164"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"c6094f1e8bb77740ba623599a9dc5303aa80ebb5","unresolved":false,"context_lines":[{"line_number":1557,"context_line":"    else:"},{"line_number":1558,"context_line":"        msg \u003d _LW(\u0027Unknown osapi_compute_unique_server_name_scope value: %s\u0027"},{"line_number":1559,"context_line":"                \u0027 Flag must be empty, \"global\" or\u0027"},{"line_number":1560,"context_line":"                \u0027 \"project\"\u0027) % CONF.osapi_compute_unique_server_name_scope"},{"line_number":1561,"context_line":"        LOG.warn(msg)"},{"line_number":1562,"context_line":"        return"},{"line_number":1563,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_1b7adcbd","line":1560,"updated":"2015-11-18 14:03:29.000000000","message":"same as above.","commit_id":"25f8e456b56d00196b69e6badff259c055285164"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"c6094f1e8bb77740ba623599a9dc5303aa80ebb5","unresolved":false,"context_lines":[{"line_number":5648,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":5649,"context_line":"                else:"},{"line_number":5650,"context_line":"                    msg \u003d _LW(\"Add metadata failed for aggregate %(id)s after \""},{"line_number":5651,"context_line":"                            \"%(retries)s retries\") % {\"id\": aggregate_id,"},{"line_number":5652,"context_line":"                                                      \"retries\": max_retries}"},{"line_number":5653,"context_line":"                    LOG.warn(msg)"},{"line_number":5654,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_5b42a469","line":5651,"updated":"2015-11-18 14:03:29.000000000","message":"same as above.","commit_id":"25f8e456b56d00196b69e6badff259c055285164"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"c6094f1e8bb77740ba623599a9dc5303aa80ebb5","unresolved":false,"context_lines":[{"line_number":5649,"context_line":"                else:"},{"line_number":5650,"context_line":"                    msg \u003d _LW(\"Add metadata failed for aggregate %(id)s after \""},{"line_number":5651,"context_line":"                            \"%(retries)s retries\") % {\"id\": aggregate_id,"},{"line_number":5652,"context_line":"                                                      \"retries\": max_retries}"},{"line_number":5653,"context_line":"                    LOG.warn(msg)"},{"line_number":5654,"context_line":""},{"line_number":5655,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_f62fed85","line":5652,"updated":"2015-11-18 14:03:29.000000000","message":"you\u0027ll need to update this line with 2 spaces too.","commit_id":"25f8e456b56d00196b69e6badff259c055285164"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"c022386f8ca8c4a9b0ba599ed136b637bda8cca2","unresolved":false,"context_lines":[{"line_number":1461,"context_line":"                          filter_by(address\u003daddress).\\"},{"line_number":1462,"context_line":"                          first()"},{"line_number":1463,"context_line":"    except db_exc.DBError:"},{"line_number":1464,"context_line":"        msg \u003d _LW(\"Invalid virtual interface address %s in request\") % address"},{"line_number":1465,"context_line":"        LOG.warn(msg)"},{"line_number":1466,"context_line":"        raise exception.InvalidIpAddressError(msg)"},{"line_number":1467,"context_line":"    return vif_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_621f7f08","line":1464,"updated":"2015-11-19 13:28:52.000000000","message":"I think this is not the right way for handle with log messages, please see: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function","commit_id":"1235fc3fbd2f49c2b3a6c283a82826b8791afec4"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"2e7f40fb5abf5f3e98ad65fe29458ec1d21dfbe9","unresolved":false,"context_lines":[{"line_number":724,"context_line":"        if not result:"},{"line_number":725,"context_line":"            raise exception.FloatingIpNotFound(id\u003did)"},{"line_number":726,"context_line":"    except db_exc.DBError:"},{"line_number":727,"context_line":"        LOG.warn(_LW(\"Invalid floating ip id %s in request\") % id)"},{"line_number":728,"context_line":"        raise exception.InvalidID(id\u003did)"},{"line_number":729,"context_line":"    return result"},{"line_number":730,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_7bcdbd64","line":727,"updated":"2015-11-20 06:22:58.000000000","message":"\"%\" should be replaced by \",\".","commit_id":"248101a02c7f6fbabf1ca947f9646f0b7f2f3388"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"08ce68d9a70bc98d597b5dc246eced7c1b1a5593","unresolved":false,"context_lines":[{"line_number":724,"context_line":"        if not result:"},{"line_number":725,"context_line":"            raise exception.FloatingIpNotFound(id\u003did)"},{"line_number":726,"context_line":"    except db_exc.DBError:"},{"line_number":727,"context_line":"        LOG.warn(_LW(\"Invalid floating ip id %s in request\") % id)"},{"line_number":728,"context_line":"        raise exception.InvalidID(id\u003did)"},{"line_number":729,"context_line":"    return result"},{"line_number":730,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_969d765b","line":727,"in_reply_to":"ba8a016a_25c70466","updated":"2016-01-13 13:05:36.000000000","message":"this should be \u0027,\u0027 by this doc, done","commit_id":"248101a02c7f6fbabf1ca947f9646f0b7f2f3388"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"552b42c1657a37cc4fba77925d517d46c4265c2e","unresolved":false,"context_lines":[{"line_number":724,"context_line":"        if not result:"},{"line_number":725,"context_line":"            raise exception.FloatingIpNotFound(id\u003did)"},{"line_number":726,"context_line":"    except db_exc.DBError:"},{"line_number":727,"context_line":"        LOG.warn(_LW(\"Invalid floating ip id %s in request\") % id)"},{"line_number":728,"context_line":"        raise exception.InvalidID(id\u003did)"},{"line_number":729,"context_line":"    return result"},{"line_number":730,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_25c70466","line":727,"in_reply_to":"ba8a016a_7bcdbd64","updated":"2015-11-20 12:38:36.000000000","message":"I\u0027m not sure, the \"%\" use are following the guideline. Please see: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-translated-messages","commit_id":"248101a02c7f6fbabf1ca947f9646f0b7f2f3388"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"2e7f40fb5abf5f3e98ad65fe29458ec1d21dfbe9","unresolved":false,"context_lines":[{"line_number":1553,"context_line":"    elif CONF.osapi_compute_unique_server_name_scope \u003d\u003d \u0027global\u0027:"},{"line_number":1554,"context_line":"        instance_with_same_name \u003d base_query.count()"},{"line_number":1555,"context_line":""},{"line_number":1556,"context_line":"    else:"},{"line_number":1557,"context_line":"        msg \u003d _(\u0027Unknown osapi_compute_unique_server_name_scope value: %s\u0027"},{"line_number":1558,"context_line":"                \u0027 Flag must be empty, \"global\" or\u0027"},{"line_number":1559,"context_line":"                \u0027 \"project\"\u0027) % CONF.osapi_compute_unique_server_name_scope"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_5b70f93f","line":1556,"updated":"2015-11-20 06:22:58.000000000","message":"\"_\" should be \"_LW\"","commit_id":"248101a02c7f6fbabf1ca947f9646f0b7f2f3388"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"08ce68d9a70bc98d597b5dc246eced7c1b1a5593","unresolved":false,"context_lines":[{"line_number":1553,"context_line":"    elif CONF.osapi_compute_unique_server_name_scope \u003d\u003d \u0027global\u0027:"},{"line_number":1554,"context_line":"        instance_with_same_name \u003d base_query.count()"},{"line_number":1555,"context_line":""},{"line_number":1556,"context_line":"    else:"},{"line_number":1557,"context_line":"        msg \u003d _(\u0027Unknown osapi_compute_unique_server_name_scope value: %s\u0027"},{"line_number":1558,"context_line":"                \u0027 Flag must be empty, \"global\" or\u0027"},{"line_number":1559,"context_line":"                \u0027 \"project\"\u0027) % CONF.osapi_compute_unique_server_name_scope"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_36a5aaa1","line":1556,"in_reply_to":"ba8a016a_256b8487","updated":"2016-01-13 13:05:36.000000000","message":"Done","commit_id":"248101a02c7f6fbabf1ca947f9646f0b7f2f3388"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"552b42c1657a37cc4fba77925d517d46c4265c2e","unresolved":false,"context_lines":[{"line_number":1553,"context_line":"    elif CONF.osapi_compute_unique_server_name_scope \u003d\u003d \u0027global\u0027:"},{"line_number":1554,"context_line":"        instance_with_same_name \u003d base_query.count()"},{"line_number":1555,"context_line":""},{"line_number":1556,"context_line":"    else:"},{"line_number":1557,"context_line":"        msg \u003d _(\u0027Unknown osapi_compute_unique_server_name_scope value: %s\u0027"},{"line_number":1558,"context_line":"                \u0027 Flag must be empty, \"global\" or\u0027"},{"line_number":1559,"context_line":"                \u0027 \"project\"\u0027) % CONF.osapi_compute_unique_server_name_scope"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_256b8487","line":1556,"in_reply_to":"ba8a016a_5b70f93f","updated":"2015-11-20 12:38:36.000000000","message":"++ for this case","commit_id":"248101a02c7f6fbabf1ca947f9646f0b7f2f3388"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"2e7f40fb5abf5f3e98ad65fe29458ec1d21dfbe9","unresolved":false,"context_lines":[{"line_number":1745,"context_line":"    except db_exc.DBError:"},{"line_number":1746,"context_line":"        # NOTE(sdague): catch all in case the db engine chokes on the"},{"line_number":1747,"context_line":"        # id because it\u0027s too long of an int to store."},{"line_number":1748,"context_line":"        msg \u003d _(\"Invalid instance id %s in request\") % instance_id"},{"line_number":1749,"context_line":"        LOG.warn(msg)"},{"line_number":1750,"context_line":"        raise exception.InvalidID(id\u003dinstance_id)"},{"line_number":1751,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_7b75bd61","line":1748,"updated":"2015-11-20 06:22:58.000000000","message":"Why not here? Also \"_\" should be \"_LW\".","commit_id":"248101a02c7f6fbabf1ca947f9646f0b7f2f3388"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"08ce68d9a70bc98d597b5dc246eced7c1b1a5593","unresolved":false,"context_lines":[{"line_number":1745,"context_line":"    except db_exc.DBError:"},{"line_number":1746,"context_line":"        # NOTE(sdague): catch all in case the db engine chokes on the"},{"line_number":1747,"context_line":"        # id because it\u0027s too long of an int to store."},{"line_number":1748,"context_line":"        msg \u003d _(\"Invalid instance id %s in request\") % instance_id"},{"line_number":1749,"context_line":"        LOG.warn(msg)"},{"line_number":1750,"context_line":"        raise exception.InvalidID(id\u003dinstance_id)"},{"line_number":1751,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_16aae670","line":1748,"in_reply_to":"ba8a016a_0509a0dd","updated":"2016-01-13 13:05:36.000000000","message":"Done","commit_id":"248101a02c7f6fbabf1ca947f9646f0b7f2f3388"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"552b42c1657a37cc4fba77925d517d46c4265c2e","unresolved":false,"context_lines":[{"line_number":1745,"context_line":"    except db_exc.DBError:"},{"line_number":1746,"context_line":"        # NOTE(sdague): catch all in case the db engine chokes on the"},{"line_number":1747,"context_line":"        # id because it\u0027s too long of an int to store."},{"line_number":1748,"context_line":"        msg \u003d _(\"Invalid instance id %s in request\") % instance_id"},{"line_number":1749,"context_line":"        LOG.warn(msg)"},{"line_number":1750,"context_line":"        raise exception.InvalidID(id\u003dinstance_id)"},{"line_number":1751,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_0509a0dd","line":1748,"in_reply_to":"ba8a016a_7b75bd61","updated":"2015-11-20 12:38:36.000000000","message":"++","commit_id":"248101a02c7f6fbabf1ca947f9646f0b7f2f3388"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"2e7f40fb5abf5f3e98ad65fe29458ec1d21dfbe9","unresolved":false,"context_lines":[{"line_number":5647,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":5648,"context_line":"                else:"},{"line_number":5649,"context_line":"                    msg \u003d _(\"Add metadata failed for aggregate %(id)s after \""},{"line_number":5650,"context_line":"                            \"%(retries)s retries\") % {\"id\": aggregate_id,"},{"line_number":5651,"context_line":"                                                      \"retries\": max_retries}"},{"line_number":5652,"context_line":"                    LOG.warn(msg)"},{"line_number":5653,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_7ba61daf","line":5650,"updated":"2015-11-20 06:22:58.000000000","message":"\"_\" should be \"_LW\"","commit_id":"248101a02c7f6fbabf1ca947f9646f0b7f2f3388"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"552b42c1657a37cc4fba77925d517d46c4265c2e","unresolved":false,"context_lines":[{"line_number":5647,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":5648,"context_line":"                else:"},{"line_number":5649,"context_line":"                    msg \u003d _(\"Add metadata failed for aggregate %(id)s after \""},{"line_number":5650,"context_line":"                            \"%(retries)s retries\") % {\"id\": aggregate_id,"},{"line_number":5651,"context_line":"                                                      \"retries\": max_retries}"},{"line_number":5652,"context_line":"                    LOG.warn(msg)"},{"line_number":5653,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_c512b809","line":5650,"in_reply_to":"ba8a016a_7ba61daf","updated":"2015-11-20 12:38:36.000000000","message":"++","commit_id":"248101a02c7f6fbabf1ca947f9646f0b7f2f3388"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"08ce68d9a70bc98d597b5dc246eced7c1b1a5593","unresolved":false,"context_lines":[{"line_number":5647,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":5648,"context_line":"                else:"},{"line_number":5649,"context_line":"                    msg \u003d _(\"Add metadata failed for aggregate %(id)s after \""},{"line_number":5650,"context_line":"                            \"%(retries)s retries\") % {\"id\": aggregate_id,"},{"line_number":5651,"context_line":"                                                      \"retries\": max_retries}"},{"line_number":5652,"context_line":"                    LOG.warn(msg)"},{"line_number":5653,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_b6b75ad7","line":5650,"in_reply_to":"ba8a016a_c512b809","updated":"2016-01-13 13:05:36.000000000","message":"Done","commit_id":"248101a02c7f6fbabf1ca947f9646f0b7f2f3388"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b5d70037fbd3e93b6cec8204e2450906f315de1d","unresolved":false,"context_lines":[{"line_number":6084,"context_line":"        # these rows until we clean up a dependent table.  Just"},{"line_number":6085,"context_line":"        # skip this table for now; we\u0027ll come back to it later."},{"line_number":6086,"context_line":"        LOG.warning(_LW(\"IntegrityError detected when archiving table \""},{"line_number":6087,"context_line":"                     \"%(tablename)s: %(error)s\"),"},{"line_number":6088,"context_line":"                    {\u0027tablename\u0027: tablename, \u0027error\u0027: six.text_type(ex)})"},{"line_number":6089,"context_line":"        return rows_archived"},{"line_number":6090,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_cc1ed2ba","line":6087,"updated":"2016-01-14 03:51:12.000000000","message":"It would be better to align the head of the \"%(tablename)s: %(error)s\" to the beginning of the \"IntegrityError detected when archiving table \".","commit_id":"2a2bb3d684aef3d5df422f1f9cc30e9b504ceb0a"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"47aa162c8b304ea962bf2f1e60de5c9bd49eba20","unresolved":false,"context_lines":[{"line_number":6084,"context_line":"        # these rows until we clean up a dependent table.  Just"},{"line_number":6085,"context_line":"        # skip this table for now; we\u0027ll come back to it later."},{"line_number":6086,"context_line":"        LOG.warning(_LW(\"IntegrityError detected when archiving table \""},{"line_number":6087,"context_line":"                     \"%(tablename)s: %(error)s\"),"},{"line_number":6088,"context_line":"                    {\u0027tablename\u0027: tablename, \u0027error\u0027: six.text_type(ex)})"},{"line_number":6089,"context_line":"        return rows_archived"},{"line_number":6090,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_e967fa4a","line":6087,"in_reply_to":"da6ed579_cc1ed2ba","updated":"2016-01-14 09:43:37.000000000","message":"Yes! done","commit_id":"2a2bb3d684aef3d5df422f1f9cc30e9b504ceb0a"}]}
