)]}'
{"id":"openstack%2Fnova~24721","triplet_id":"openstack%2Fnova~master~Ifdf49c59d8e983905ad6f31e0a3f7f64cd5a297c","project":"openstack/nova","branch":"master","topic":"bug/1130922","hashtags":[],"change_id":"Ifdf49c59d8e983905ad6f31e0a3f7f64cd5a297c","subject":"Adds return-type in two functions\u0027 docstrings","status":"MERGED","created":"2013-03-18 22:22:09.000000000","updated":"2013-03-26 05:36:12.000000000","submitted":"2013-03-26 05:36:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"974747f9065de80c2fdea456171ffb9794e3cdc7","_number":24721,"virtual_id_number":24721,"owner":{"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":2,"date":"2013-03-26 05:36:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-03-22 16:24:10.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":681,"name":"Debo~ Dutta","email":"ddutta@gmail.com","username":"debo"},{"value":0,"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"recommended":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"all":[{"value":1,"date":"2013-03-25 15:52:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-03-26 04:11:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},{"value":2,"date":"2013-03-26 01:01:53.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":1,"date":"2013-03-26 01:47:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":681,"name":"Debo~ Dutta","email":"ddutta@gmail.com","username":"debo"},{"value":0,"date":"2013-03-22 18:47:42.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},{"value":2,"date":"2013-03-26 04:59:25.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":0,"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},{"value":0,"date":"2013-03-26 01:01:53.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":681,"name":"Debo~ Dutta","email":"ddutta@gmail.com","username":"debo"},{"value":0,"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},{"value":1,"date":"2013-03-26 04:59:25.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":681,"name":"Debo~ Dutta","email":"ddutta@gmail.com","username":"debo"},{"value":0,"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":681,"name":"Debo~ Dutta","email":"ddutta@gmail.com","username":"debo"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},{"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-22 16:24:10.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-03-25 15:52:18.000000000","updated_by":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"reviewer":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"state":"REVIEWER"},{"updated":"2013-03-26 01:01:53.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-03-26 01:47:29.000000000","updated_by":{"_account_id":681,"name":"Debo~ Dutta","email":"ddutta@gmail.com","username":"debo"},"reviewer":{"_account_id":681,"name":"Debo~ Dutta","email":"ddutta@gmail.com","username":"debo"},"state":"REVIEWER"},{"updated":"2013-03-26 04:11:17.000000000","updated_by":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"reviewer":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"state":"REVIEWER"},{"updated":"2013-03-26 04:59:25.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-03-26 05:36:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"702316853d11437c718378e4bdf11721dc5629db","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-18 22:40:23.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/78618\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/78619\n","accounts_in_message":[],"_revision_number":1},{"id":"2512771a008bc2082e56c9fcf42ec585ae7258ee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-18 23:04:53.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/24721/1/check/gate-nova-pep8/23189 : SUCCESS\n- http://logs.openstack.org/24721/1/check/gate-nova-docs/17538 : SUCCESS\n- http://logs.openstack.org/24721/1/check/gate-nova-python26/18947 : SUCCESS\n- http://logs.openstack.org/24721/1/check/gate-nova-python27/19035 : SUCCESS\n- http://logs.openstack.org/24721/1/check/gate-tempest-devstack-vm-full/9432 : SUCCESS\n- http://logs.openstack.org/24721/1/check/gate-tempest-devstack-vm-postgres-full/9147 : SUCCESS\n- http://logs.openstack.org/24721/1/check/gate-tempest-devstack-vm-quantum/14804 : SUCCESS\n- http://logs.openstack.org/24721/1/check/gate-nova-pylint/9584 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"701f6c6dd07d746813b23ba8ae4bec5473870f33","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-19 00:43:23.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nThe doc should IMO specify also the required content of the dict and/or specify if it\u0027s driver dependent.","accounts_in_message":[],"_revision_number":1},{"id":"331e3b046f5bd5b7102d9d91935ef96a7d747e16","author":{"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},"date":"2013-03-19 17:38:11.000000000","message":"Patch Set 1:\n\nHi Alessandro,\n\nFrom what I read about the live-migration of libvirt and xen implementation of the checking, the content of the dictionary is hypervisor dependent. For KVM, check_can_live_migration returns a dict contains keys such as filename, block_migration, disck_over_commit, and disk_available_mb. For Xenapi, the same function returns a dict contains keys such as block_migration, another dict called migrated_data. I believe Hyper-v might have its own live-migration criterion..","accounts_in_message":[],"_revision_number":1},{"id":"dc8ba1c72ceb1a23e3fcd923b905717bbffba132","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-03-21 18:51:14.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"3d7447e8a59fa6d3c1aa3b5b1e62fb8c3354cd4a","author":{"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},"date":"2013-03-21 21:10:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"01fd33fc2955bb439097087c6c00ce84e8baefd7","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-21 21:11:15.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nHi Senhua,\n\nOk tx, I suggest to specify that it\u0027s driver dependent content if it\u0027s confirmed that specific data is not expected e.g. by manager.py.","accounts_in_message":[],"_revision_number":2},{"id":"2c73569be7293ca0d010057e55ed934060bab543","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-21 21:27:58.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/79321\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/79322\n","accounts_in_message":[],"_revision_number":2},{"id":"5800bf27e824ac2cd5f4058b9ffd60a4172b3991","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-21 22:29:46.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/24721/2/check/gate-nova-pep8/23390 : SUCCESS\n- http://logs.openstack.org/24721/2/check/gate-nova-docs/17723 : SUCCESS\n- http://logs.openstack.org/24721/2/check/gate-nova-python26/19132 : SUCCESS\n- http://logs.openstack.org/24721/2/check/gate-nova-python26-rhel6/16 : FAILURE (non-voting)\n- http://logs.openstack.org/24721/2/check/gate-nova-python27/19220 : SUCCESS\n- http://logs.openstack.org/24721/2/check/gate-tempest-devstack-vm-full/9947 : FAILURE\n- http://logs.openstack.org/24721/2/check/gate-tempest-devstack-vm-postgres-full/9662 : SUCCESS\n- http://logs.openstack.org/24721/2/check/gate-tempest-devstack-vm-quantum/15405 : SUCCESS\n- http://logs.openstack.org/24721/2/check/gate-nova-pylint/9720 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"7837de1147fa9e56ea2940ca245b910942c9156e","author":{"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},"date":"2013-03-22 01:44:01.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4aa4b7bc13b4f1a7782b28c2f3e2801ed25a40d9","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-22 02:01:41.000000000","message":"Patch Set 3: Works for me\n\nSmokeStack Results (patch set 3):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/79367\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/79368\n","accounts_in_message":[],"_revision_number":3},{"id":"f86272e4481a3b1f3b31bd560948527642cac24c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-22 02:26:41.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/24721/3/check/gate-nova-pep8/23404 : SUCCESS\n- http://logs.openstack.org/24721/3/check/gate-nova-docs/17736 : SUCCESS\n- http://logs.openstack.org/24721/3/check/gate-nova-python26/19145 : SUCCESS\n- http://logs.openstack.org/24721/3/check/gate-nova-python26-rhel6/25 : FAILURE (non-voting)\n- http://logs.openstack.org/24721/3/check/gate-nova-python27/19233 : SUCCESS\n- http://logs.openstack.org/24721/3/check/gate-tempest-devstack-vm-full/9981 : SUCCESS\n- http://logs.openstack.org/24721/3/check/gate-tempest-devstack-vm-postgres-full/9696 : SUCCESS\n- http://logs.openstack.org/24721/3/check/gate-tempest-devstack-vm-quantum/15450 : SUCCESS\n- http://logs.openstack.org/24721/3/check/gate-nova-pylint/9729 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"e319db1a61680194a62fb2cca7cda7e708cc5ddf","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-03-22 13:52:14.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"4785232d44adea3f1ae5673b60a335a33b1ed018","author":{"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},"date":"2013-03-22 16:03:21.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"01e442fe0a5cbf32f15d80768a3bdfde0333e76a","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-22 16:24:10.000000000","message":"Patch Set 4: Works for me\n\nSmokeStack Results (patch set 4):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/79472\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/79473\n","accounts_in_message":[],"_revision_number":4},{"id":"f2921ca84ccb3c26cbe85fc2bc1e745dc3669e1e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-22 17:51:17.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/24721/4/check/gate-nova-pep8/23422 : SUCCESS\n- http://logs.openstack.org/24721/4/check/gate-nova-docs/17753 : SUCCESS\n- http://logs.openstack.org/24721/4/check/gate-nova-python26/19162 : SUCCESS\n- http://logs.openstack.org/24721/4/check/gate-nova-python26-rhel6/39 : FAILURE (non-voting)\n- http://logs.openstack.org/24721/4/check/gate-nova-python27/19250 : SUCCESS\n- http://logs.openstack.org/24721/4/check/gate-tempest-devstack-vm-full/10076 : SUCCESS\n- http://logs.openstack.org/24721/4/check/gate-tempest-devstack-vm-postgres-full/9791 : FAILURE\n- http://logs.openstack.org/24721/4/check/gate-tempest-devstack-vm-quantum/15556 : SUCCESS\n- http://logs.openstack.org/24721/4/check/gate-nova-pylint/9743 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"2f90fbea08e363aedd505b986ae8cf651db1fd0e","author":{"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},"date":"2013-03-22 18:47:42.000000000","message":"Patch Set 4:\n\nrecheck bug 1130922","accounts_in_message":[],"_revision_number":4},{"id":"dddf3e6b5d80f070949e5b11bad42d6197c0c517","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-22 19:29:57.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/24721/4/check/gate-nova-pep8/23430 : SUCCESS\n- http://logs.openstack.org/24721/4/check/gate-nova-docs/17760 : SUCCESS\n- http://logs.openstack.org/24721/4/check/gate-nova-python26/19169 : SUCCESS\n- http://logs.openstack.org/24721/4/check/gate-nova-python26-rhel6/45 : FAILURE (non-voting)\n- http://logs.openstack.org/24721/4/check/gate-nova-python27/19257 : SUCCESS\n- http://logs.openstack.org/24721/4/check/gate-tempest-devstack-vm-full/10101 : SUCCESS\n- http://logs.openstack.org/24721/4/check/gate-tempest-devstack-vm-postgres-full/9816 : SUCCESS\n- http://logs.openstack.org/24721/4/check/gate-tempest-devstack-vm-quantum/15582 : SUCCESS\n- http://logs.openstack.org/24721/4/check/gate-nova-pylint/9749 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"199ad2333c72390365ea9322911dfdc3807aadc3","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-25 15:52:18.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"6635d902da60eb6c329714c4821d12df3419d0e3","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-03-26 01:01:53.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"168d8e71008fe36370926fc5847ae4b3da3207e0","author":{"_account_id":681,"name":"Debo~ Dutta","email":"ddutta@gmail.com","username":"debo"},"date":"2013-03-26 01:47:29.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"b56ae7cddb6812afc7d8e47bc4de57111e886b70","author":{"_account_id":4598,"name":"Giampaolo Lauria","email":"lauria@us.ibm.com","username":"lauria"},"date":"2013-03-26 04:11:17.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"5eff55fac1055fce4aa7a32070687fc2d39e0ced","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-03-26 04:59:25.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":4},{"id":"96a0275475431e63028974b3feba5abcfa1ee818","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-26 04:59:30.000000000","message":"Patch Set 4: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"ca988f7416079447e2482a85c6b0a9a5e626b73a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-26 05:36:07.000000000","message":"Patch Set 4: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/24721/4/gate/gate-nova-docs/17891 : SUCCESS\n- http://logs.openstack.org/24721/4/gate/gate-nova-pep8/23580 : SUCCESS\n- http://logs.openstack.org/24721/4/gate/gate-nova-python26/19299 : SUCCESS\n- http://logs.openstack.org/24721/4/gate/gate-nova-python27/19387 : SUCCESS\n- http://logs.openstack.org/24721/4/gate/gate-tempest-devstack-vm-full/10450 : SUCCESS\n- http://logs.openstack.org/24721/4/gate/gate-tempest-devstack-vm-postgres-full/10166 : SUCCESS\n- http://logs.openstack.org/24721/4/gate/gate-tempest-devstack-vm-quantum/15993 : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"52187cb8758a46d46d6ebe3fa47802931348c22d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-26 05:36:12.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2ee1c3d9f5342a135d422afcc7ea45264d232d2c","revisions":{"a21c71522f594cfe54ed67432fec43d436995d47":{"kind":"REWORK","_number":1,"created":"2013-03-18 22:22:09.000000000","uploader":{"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},"ref":"refs/changes/21/24721/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/24721/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/24721/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/24721/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/24721/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/24721/1"}}},"commit":{"parents":[{"commit":"85aebeb8b864f990cdfb78b6deafc8a3fe3c1e23","subject":"Merge \"Remove dead code.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/85aebeb8b864f990cdfb78b6deafc8a3fe3c1e23"}]}],"author":{"name":"Senhua Huang","email":"senhuang@cisco.com","date":"2013-03-18 22:20:19.000000000","tz":-420},"committer":{"name":"Senhua Huang","email":"senhuang@cisco.com","date":"2013-03-18 22:20:19.000000000","tz":-420},"subject":"Adds return-type in two functions\u0027 docstrings","message":"Adds return-type in two functions\u0027 docstrings\n\nChange-Id: Ifdf49c59d8e983905ad6f31e0a3f7f64cd5a297c\nFixes: bug #1130922\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a21c71522f594cfe54ed67432fec43d436995d47"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a21c71522f594cfe54ed67432fec43d436995d47"}]},"branch":"refs/heads/master"},"71ca0d9c9065e550d2363401cd2820eaa6aa81ff":{"kind":"REWORK","_number":2,"created":"2013-03-21 21:10:14.000000000","uploader":{"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},"ref":"refs/changes/21/24721/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/24721/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/24721/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/24721/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/24721/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/24721/2"}}},"commit":{"parents":[{"commit":"5499640f639009f60fbf909786770654e1f1b5a0","subject":"Merge \"Change type of ssh_port option from Str to Int\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5499640f639009f60fbf909786770654e1f1b5a0"}]}],"author":{"name":"Senhua Huang","email":"senhuang@cisco.com","date":"2013-03-18 22:20:19.000000000","tz":-420},"committer":{"name":"Senhua Huang","email":"senhuang@cisco.com","date":"2013-03-21 21:09:43.000000000","tz":-420},"subject":"Adds return-type in two functions\u0027 docstrings","message":"Adds return-type in two functions\u0027 docstrings\n\nChange-Id: Ifdf49c59d8e983905ad6f31e0a3f7f64cd5a297c\nFixes: bug #1130922\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/71ca0d9c9065e550d2363401cd2820eaa6aa81ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/71ca0d9c9065e550d2363401cd2820eaa6aa81ff"}]},"branch":"refs/heads/master"},"5612f50ea4aa1843a37c85af386f53a7ee3b422c":{"kind":"REWORK","_number":3,"created":"2013-03-22 01:44:01.000000000","uploader":{"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},"ref":"refs/changes/21/24721/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/24721/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/24721/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/24721/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/24721/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/24721/3"}}},"commit":{"parents":[{"commit":"127b32c00ca5e99439431d30d03775fd0e462f0a","subject":"Merge \"Make nova.virt.fake.FakeDriver useable in integration testing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/127b32c00ca5e99439431d30d03775fd0e462f0a"}]}],"author":{"name":"Senhua Huang","email":"senhuang@cisco.com","date":"2013-03-18 22:20:19.000000000","tz":-420},"committer":{"name":"Senhua Huang","email":"senhuang@cisco.com","date":"2013-03-22 01:43:38.000000000","tz":-420},"subject":"Adds return-type in two functions\u0027 docstrings","message":"Adds return-type in two functions\u0027 docstrings\n\nChange-Id: Ifdf49c59d8e983905ad6f31e0a3f7f64cd5a297c\nFixes: bug #1130922\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5612f50ea4aa1843a37c85af386f53a7ee3b422c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5612f50ea4aa1843a37c85af386f53a7ee3b422c"}]},"branch":"refs/heads/master"},"2ee1c3d9f5342a135d422afcc7ea45264d232d2c":{"kind":"REWORK","_number":4,"created":"2013-03-22 16:03:21.000000000","uploader":{"_account_id":6495,"name":"Senhua Huang","email":"senhua.huang@gmail.com","username":"senhuang"},"ref":"refs/changes/21/24721/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/24721/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/24721/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/24721/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/24721/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/24721/4"}}},"commit":{"parents":[{"commit":"86396da1addad7700bab15fb16e8e644f4f833e9","subject":"Merge \"Fixes passing arbitrary conductor_api argument\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/86396da1addad7700bab15fb16e8e644f4f833e9"}]}],"author":{"name":"Senhua Huang","email":"senhuang@cisco.com","date":"2013-03-18 22:20:19.000000000","tz":-420},"committer":{"name":"Senhua Huang","email":"senhuang@cisco.com","date":"2013-03-22 16:03:09.000000000","tz":-420},"subject":"Adds return-type in two functions\u0027 docstrings","message":"Adds return-type in two functions\u0027 docstrings\n\nChange-Id: Ifdf49c59d8e983905ad6f31e0a3f7f64cd5a297c\nFixes: bug #1130922\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2ee1c3d9f5342a135d422afcc7ea45264d232d2c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2ee1c3d9f5342a135d422afcc7ea45264d232d2c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}