)]}'
{"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"883f21089e2a8cbb94029f41ee92f0da3631a0e8","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        self.sparse \u003d CONF.libvirt.sparse_logical_volumes"},{"line_number":633,"context_line":"        self.preallocate \u003d not self.sparse"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        if self.preallocate:"},{"line_number":636,"context_line":"            self.driver_io \u003d \"native\""},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _supports_encryption(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_405c4b25","line":635,"range":{"start_line":635,"start_character":8,"end_line":635,"end_character":28},"updated":"2016-01-21 01:33:15.000000000","message":"Shouldn\u0027t you be checking \u0027if not self.sparse:\u0027 here given the commit message and spec?\n\nYou also don\u0027t have a unit test for this case.","commit_id":"6a955ede9d202d4d99bc821f6c5e7211d1dc6568"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"793fed6d18784b320bba69806916dbc9f5a8069e","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        self.sparse \u003d CONF.libvirt.sparse_logical_volumes"},{"line_number":633,"context_line":"        self.preallocate \u003d not self.sparse"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        if self.preallocate:"},{"line_number":636,"context_line":"            self.driver_io \u003d \"native\""},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _supports_encryption(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_f23e5ed9","line":635,"range":{"start_line":635,"start_character":8,"end_line":635,"end_character":28},"in_reply_to":"9a68dd71_0f050d79","updated":"2016-01-21 11:46:04.000000000","message":"The \"distance\" to the config option \"sparse_logical_volumes\" is reduced. Which is helpful if that option really gets deprecated as the TODO above indicates. That\u0027s why I thought it\u0027s fair to change it as Matt suggested.","commit_id":"6a955ede9d202d4d99bc821f6c5e7211d1dc6568"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"cd623abbb18b3e7f3f36fcb81b4dc0adae73f5b7","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        self.sparse \u003d CONF.libvirt.sparse_logical_volumes"},{"line_number":633,"context_line":"        self.preallocate \u003d not self.sparse"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        if self.preallocate:"},{"line_number":636,"context_line":"            self.driver_io \u003d \"native\""},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _supports_encryption(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_48b0e0dd","line":635,"range":{"start_line":635,"start_character":8,"end_line":635,"end_character":28},"in_reply_to":"9a68dd71_405c4b25","updated":"2016-01-21 10:41:24.000000000","message":"Done","commit_id":"6a955ede9d202d4d99bc821f6c5e7211d1dc6568"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"a93014be51fdf14b393b2bcb6458704a94a45c77","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        self.sparse \u003d CONF.libvirt.sparse_logical_volumes"},{"line_number":633,"context_line":"        self.preallocate \u003d not self.sparse"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        if self.preallocate:"},{"line_number":636,"context_line":"            self.driver_io \u003d \"native\""},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _supports_encryption(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_0f050d79","line":635,"range":{"start_line":635,"start_character":8,"end_line":635,"end_character":28},"in_reply_to":"9a68dd71_48b0e0dd","updated":"2016-01-21 11:19:10.000000000","message":"Out of curiousity: this is about readabiliy or something else?\nAs line 633 sets preallocate to the value of not sparse this version seemed fine to me.","commit_id":"6a955ede9d202d4d99bc821f6c5e7211d1dc6568"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"39c1292db4f6b46a0a5890d8d1a061a8f7063320","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        self.sparse \u003d CONF.libvirt.sparse_logical_volumes"},{"line_number":633,"context_line":"        self.preallocate \u003d not self.sparse"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        if self.preallocate:"},{"line_number":636,"context_line":"            self.driver_io \u003d \"native\""},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _supports_encryption(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_fe5b85f4","line":635,"range":{"start_line":635,"start_character":8,"end_line":635,"end_character":28},"in_reply_to":"9a68dd71_f23e5ed9","updated":"2016-01-21 12:55:10.000000000","message":"Ah, ok \u0026 thnx! :)","commit_id":"6a955ede9d202d4d99bc821f6c5e7211d1dc6568"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5182d4fe4825e390f8fee4c9779f19d525cdfc0","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        self.sparse \u003d CONF.libvirt.sparse_logical_volumes"},{"line_number":633,"context_line":"        self.preallocate \u003d not self.sparse"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        if self.preallocate:"},{"line_number":636,"context_line":"            self.driver_io \u003d \"native\""},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _supports_encryption(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_7d823296","line":635,"range":{"start_line":635,"start_character":8,"end_line":635,"end_character":28},"in_reply_to":"9a68dd71_fe5b85f4","updated":"2016-01-21 15:42:17.000000000","message":"Heh, I totally didn\u0027t see this:\n\nself.preallocate \u003d not self.sparse\n\nSo yeah, I guess it\u0027s mostly about readability then - and needing the unit test.","commit_id":"6a955ede9d202d4d99bc821f6c5e7211d1dc6568"}]}