)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"9d749ab390dbf57f95562d78f163d14ab845b4f7","unresolved":false,"context_lines":[{"line_number":5043,"context_line":"        dest_check_data[\u0027is_volume_backed\u0027] \u003d is_volume_backed"},{"line_number":5044,"context_line":"        block_device_info \u003d self._get_instance_block_device_info("},{"line_number":5045,"context_line":"                            ctxt, instance, refresh_conn_info\u003dTrue)"},{"line_number":5046,"context_line":"        result \u003d self.driver.check_can_live_migrate_source(ctxt, instance,"},{"line_number":5047,"context_line":"                                                           dest_check_data,"},{"line_number":5048,"context_line":"                                                           block_device_info)"},{"line_number":5049,"context_line":"        if isinstance(result, migrate_data_obj.LiveMigrateData):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_0fce855a","line":5046,"updated":"2015-11-20 21:11:42.000000000","message":"Is there any chance to this \u0027result\u0027 variable return different types of objects? \n\nI didn\u0027t found what type \u0027self.driver.check_can_live_migrate_source\u0027 will return.","commit_id":"21f0c959d06bb881b99484dbe69c1727925d759a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d8ad5e93ab700913aff34a9b831e9f9d63e6250","unresolved":false,"context_lines":[{"line_number":5060,"context_line":"                                       network_info,"},{"line_number":5061,"context_line":"                                       disk,"},{"line_number":5062,"context_line":"                                       migrate_data)"},{"line_number":5063,"context_line":"        if isinstance(pre_live_migration_data,"},{"line_number":5064,"context_line":"                      migrate_data_obj.LiveMigrateData):"},{"line_number":5065,"context_line":"            pre_live_migration_data \u003d pre_live_migration_data.to_legacy_dict()"},{"line_number":5066,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a710552_f69e48b7","line":5063,"updated":"2015-12-15 22:01:49.000000000","message":"This isn\u0027t tested.","commit_id":"f3af79a534653e2188ba9d8cdb0de7d98dbdadd3"}],"nova/objects/migrate_data.py":[{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"f162c03a79708129c223af0e06244efdffd9966f","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"@obj_base.NovaObjectRegistry.register_if(False)"},{"line_number":20,"context_line":"class LiveMigrateData(obj_base.NovaObject):"},{"line_number":21,"context_line":"    fields \u003d {"},{"line_number":22,"context_line":"        \u0027is_volume_backed\u0027: fields.BooleanField(),"},{"line_number":23,"context_line":"        \u0027migration\u0027: fields.ObjectField(\u0027Migration\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_7296a23f","line":20,"updated":"2015-12-11 15:52:34.000000000","message":"I think a hash for this should be in the object data in test_objects.py","commit_id":"c8af4df263b9f91ace629f52922339e7a6056284"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0932c630f6c91249d732ce0d5fd5ee1873e168e2","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"@obj_base.NovaObjectRegistry.register_if(False)"},{"line_number":20,"context_line":"class LiveMigrateData(obj_base.NovaObject):"},{"line_number":21,"context_line":"    fields \u003d {"},{"line_number":22,"context_line":"        \u0027is_volume_backed\u0027: fields.BooleanField(),"},{"line_number":23,"context_line":"        \u0027migration\u0027: fields.ObjectField(\u0027Migration\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_d5c0a052","line":20,"in_reply_to":"7a740942_7296a23f","updated":"2015-12-11 16:04:07.000000000","message":"No, because it\u0027s not registered. Otherwise the tests would be failing :)\n\nregister_if(False) does the object building and then doesn\u0027t register it.","commit_id":"c8af4df263b9f91ace629f52922339e7a6056284"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d8ad5e93ab700913aff34a9b831e9f9d63e6250","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"@obj_base.NovaObjectRegistry.register_if(False)"},{"line_number":20,"context_line":"class LiveMigrateData(obj_base.NovaObject):"},{"line_number":21,"context_line":"    fields \u003d {"},{"line_number":22,"context_line":"        \u0027is_volume_backed\u0027: fields.BooleanField(),"},{"line_number":23,"context_line":"        \u0027migration\u0027: fields.ObjectField(\u0027Migration\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a710552_363050e8","line":20,"updated":"2015-12-15 22:01:49.000000000","message":"No versioning on this because we don\u0027t expect version compat handling?","commit_id":"f3af79a534653e2188ba9d8cdb0de7d98dbdadd3"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"376e06561194313e3ae0045074c361d8b3dcab28","unresolved":false,"context_lines":[{"line_number":4262,"context_line":"            self.assertIsInstance(mock_cclms.call_args_list[0][0][2], dict)"},{"line_number":4263,"context_line":"            self.assertIsInstance(result, dict)"},{"line_number":4264,"context_line":""},{"line_number":4265,"context_line":"        _test()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_4f32b2a8","line":4265,"updated":"2015-12-03 07:51:35.000000000","message":"Looks like missing one test for \u0027pre_live_migration\u0027.","commit_id":"40c9bf2c539f53e56ae5c7fed8831925a2e87d3f"}]}