)]}'
{"doc/source/code-review.rst":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"b8325484620ada5e447b43784625c4bb85669a78","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Release Notes"},{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Nova has a new tool called \u0027reno\u0027 for providing release notes in-tree. That"},{"line_number":119,"context_line":"means that a series implementing a blueprint or a single change can directly"},{"line_number":120,"context_line":"provide a note for explaining what is the impact for Nova."},{"line_number":121,"context_line":"What we call a \u0027reno file\u0027 is a YAML file written in the releasenotes/notes"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_702150b4","line":118,"updated":"2015-11-20 10:29:15.000000000","message":"What about adding a link to the developer documentation of reno? \n\nhttp://docs.openstack.org/developer/reno/","commit_id":"3c88b6f1bce316cf56bc6a7820048c020f81122b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"826cc47103f9331062849c6707f6ef7e2ca23f23","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Release Notes"},{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Nova has a new tool called \u0027reno\u0027 for providing release notes in-tree. That"},{"line_number":119,"context_line":"means that a series implementing a blueprint or a single change can directly"},{"line_number":120,"context_line":"provide a note for explaining what is the impact for Nova."},{"line_number":121,"context_line":"What we call a \u0027reno file\u0027 is a YAML file written in the releasenotes/notes"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_d6f10203","line":118,"in_reply_to":"ba8a016a_702150b4","updated":"2015-11-20 16:15:26.000000000","message":"Yes, please.  Also:\n\ns/has a new tool/uses a new tool/","commit_id":"3c88b6f1bce316cf56bc6a7820048c020f81122b"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"623d4b770c2ebfc82748b0c0d208bf96eafcf8d0","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Nova has a new tool called \u0027reno\u0027 for providing release notes in-tree. That"},{"line_number":119,"context_line":"means that a series implementing a blueprint or a single change can directly"},{"line_number":120,"context_line":"provide a note for explaining what is the impact for Nova."},{"line_number":121,"context_line":"What we call a \u0027reno file\u0027 is a YAML file written in the releasenotes/notes"},{"line_number":122,"context_line":"tree which is generated using the reno tool."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_0840fb05","line":120,"range":{"start_line":120,"start_character":10,"end_line":120,"end_character":29},"updated":"2015-11-19 20:38:30.000000000","message":"s/note for explaining/note explaining","commit_id":"3c88b6f1bce316cf56bc6a7820048c020f81122b"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"623d4b770c2ebfc82748b0c0d208bf96eafcf8d0","unresolved":false,"context_lines":[{"line_number":119,"context_line":"means that a series implementing a blueprint or a single change can directly"},{"line_number":120,"context_line":"provide a note for explaining what is the impact for Nova."},{"line_number":121,"context_line":"What we call a \u0027reno file\u0027 is a YAML file written in the releasenotes/notes"},{"line_number":122,"context_line":"tree which is generated using the reno tool."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"When reviewing a specific patch or series, please consider the following :"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_a8668fb8","line":122,"updated":"2015-11-19 20:38:30.000000000","message":"What is the \u0027reno tool\u0027? How is it used by the developer when creating the reno file?","commit_id":"3c88b6f1bce316cf56bc6a7820048c020f81122b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"826cc47103f9331062849c6707f6ef7e2ca23f23","unresolved":false,"context_lines":[{"line_number":119,"context_line":"means that a series implementing a blueprint or a single change can directly"},{"line_number":120,"context_line":"provide a note for explaining what is the impact for Nova."},{"line_number":121,"context_line":"What we call a \u0027reno file\u0027 is a YAML file written in the releasenotes/notes"},{"line_number":122,"context_line":"tree which is generated using the reno tool."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"When reviewing a specific patch or series, please consider the following :"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_b6c0fe7d","line":122,"in_reply_to":"ba8a016a_8194af8a","updated":"2015-11-20 16:15:26.000000000","message":"It\u0027s also in the reno usage docs, which we should link to:\n\nhttp://docs.openstack.org/developer/reno/usage.html","commit_id":"3c88b6f1bce316cf56bc6a7820048c020f81122b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"26a9086c69f55fda089f4afbc4e1df18e6b7e7aa","unresolved":false,"context_lines":[{"line_number":119,"context_line":"means that a series implementing a blueprint or a single change can directly"},{"line_number":120,"context_line":"provide a note for explaining what is the impact for Nova."},{"line_number":121,"context_line":"What we call a \u0027reno file\u0027 is a YAML file written in the releasenotes/notes"},{"line_number":122,"context_line":"tree which is generated using the reno tool."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"When reviewing a specific patch or series, please consider the following :"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_8194af8a","line":122,"in_reply_to":"ba8a016a_a8668fb8","updated":"2015-11-20 08:49:05.000000000","message":"Shamelessly stolen from the keystone dev docs:\n\n    $ tox -e venv -- reno new \u003cbug-,bp-,whatever\u003e\n    $ git commit  # reno scans git log.\n    $ tox -e releasenotes\n\nhttp://docs.openstack.org/developer/keystone/developing.html#release-notes","commit_id":"3c88b6f1bce316cf56bc6a7820048c020f81122b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"826cc47103f9331062849c6707f6ef7e2ca23f23","unresolved":false,"context_lines":[{"line_number":121,"context_line":"What we call a \u0027reno file\u0027 is a YAML file written in the releasenotes/notes"},{"line_number":122,"context_line":"tree which is generated using the reno tool."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"When reviewing a specific patch or series, please consider the following :"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* If the patch has an UpgradeImpact flag, it should also include a reno file"},{"line_number":127,"context_line":"  providing an \u0027upgrade\u0027 comment. As a reminder, a DB migration or a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_b678fe2c","line":124,"updated":"2015-11-20 16:15:26.000000000","message":"Could also add something about the \u0027critical\u0027 or \u0027fixes\u0027 sections.  We don\u0027t want to have to add release notes for every fixed bug, that\u0027s what launchpad is for.\n\nBut for really hairy bugs that are fixed (or partially fixed in certain deployment configs/scenarios) but include a DocImpact that explains the fix or potential issues with it, then I\u0027d consider those candidates for inclusion in release notes.","commit_id":"3c88b6f1bce316cf56bc6a7820048c020f81122b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"826cc47103f9331062849c6707f6ef7e2ca23f23","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"When reviewing a specific patch or series, please consider the following :"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* If the patch has an UpgradeImpact flag, it should also include a reno file"},{"line_number":127,"context_line":"  providing an \u0027upgrade\u0027 comment. As a reminder, a DB migration or a"},{"line_number":128,"context_line":"  config opt modification (deprecation or default value) are good examples."},{"line_number":129,"context_line":"* If the patch fixes a known vulnerability, please verify that it has a reno"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_36096ede","line":126,"updated":"2015-11-20 16:15:26.000000000","message":"There are also docs out there on what UpgradeImpact means, we could also link to those.\n\nhttp://docs.openstack.org/infra/manual/developers.html#peer-review","commit_id":"3c88b6f1bce316cf56bc6a7820048c020f81122b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"826cc47103f9331062849c6707f6ef7e2ca23f23","unresolved":false,"context_lines":[{"line_number":129,"context_line":"* If the patch fixes a known vulnerability, please verify that it has a reno"},{"line_number":130,"context_line":"  file with the \u0027security\u0027 comment."},{"line_number":131,"context_line":"* If the patch adds a new REST resource, it\u0027s probably a good candidate for"},{"line_number":132,"context_line":"  having a \u0027feature\u0027 comment."},{"line_number":133,"context_line":"* If a nova-manage change or a python-novaclient change adds a new option, it"},{"line_number":134,"context_line":"  should include a reno file with a \u0027feature\u0027 comment."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_f629a638","line":132,"updated":"2015-11-20 16:15:26.000000000","message":"This may be generically true for any series that implements a feature blueprint.","commit_id":"3c88b6f1bce316cf56bc6a7820048c020f81122b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"826cc47103f9331062849c6707f6ef7e2ca23f23","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  file with the \u0027security\u0027 comment."},{"line_number":131,"context_line":"* If the patch adds a new REST resource, it\u0027s probably a good candidate for"},{"line_number":132,"context_line":"  having a \u0027feature\u0027 comment."},{"line_number":133,"context_line":"* If a nova-manage change or a python-novaclient change adds a new option, it"},{"line_number":134,"context_line":"  should include a reno file with a \u0027feature\u0027 comment."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_761616f3","line":133,"updated":"2015-11-20 16:15:26.000000000","message":"s/adds a new option/adds or changes a new command, including adding new options to existing commands/.","commit_id":"3c88b6f1bce316cf56bc6a7820048c020f81122b"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"26a9086c69f55fda089f4afbc4e1df18e6b7e7aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba8a016a_010bdfd6","line":135,"updated":"2015-11-20 08:49:05.000000000","message":"A negative list would help me here. IOW, in which cases is a release note *not* appropriate?","commit_id":"3c88b6f1bce316cf56bc6a7820048c020f81122b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9ee2adb94ed6e2a155da93a692d3da2a0c717e7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba8a016a_901e345e","line":135,"in_reply_to":"ba8a016a_010bdfd6","updated":"2015-11-20 10:09:46.000000000","message":"It might be good to describe which section of the reno file shall be used for what. For example I added a deprecation note to the \u0027other\u0027 section couple of days ago but it feels that \u0027other\u0027 section will contain a lot of mixed notes.\n\nAlso the usage of \u0027prelude\u0027 needs some guidance. When shall I add a description to \u0027prelude\u0027? How the content of the \u0027prelude\u0027 relates to the content of other sections.","commit_id":"3c88b6f1bce316cf56bc6a7820048c020f81122b"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7b2e46e4f433b4462c4f5e87ad3d528d670ca48c","unresolved":false,"context_lines":[{"line_number":121,"context_line":"Nova uses `reno \u003chttp://docs.openstack.org/developer/reno/usage.html\u003e`_ for"},{"line_number":122,"context_line":"providing release notes in-tree. That means that a patch can include a *reno"},{"line_number":123,"context_line":"file* or a series can have a follow-on change containing that file explaining"},{"line_number":124,"context_line":"what is the impact."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"What we call a *reno file* is a YAML file written in the releasenotes/notes"},{"line_number":127,"context_line":"tree which is generated using the reno tool this way :"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_3652cc14","line":124,"updated":"2015-11-24 16:50:41.000000000","message":"s/what is the impact/what the impact is/ (femtonit)","commit_id":"ac05d05dd09454f551a09b563e27c5e3b5c5fff6"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7b2e46e4f433b4462c4f5e87ad3d528d670ca48c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"file* or a series can have a follow-on change containing that file explaining"},{"line_number":124,"context_line":"what is the impact."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"What we call a *reno file* is a YAML file written in the releasenotes/notes"},{"line_number":127,"context_line":"tree which is generated using the reno tool this way :"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":".. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_d66d80cd","line":126,"updated":"2015-11-24 16:50:41.000000000","message":"s/What we call a *reno file* is a YAML file/A *reno file* is a YAML file/ (femtonit)","commit_id":"ac05d05dd09454f551a09b563e27c5e3b5c5fff6"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7b2e46e4f433b4462c4f5e87ad3d528d670ca48c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"what is the impact."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"What we call a *reno file* is a YAML file written in the releasenotes/notes"},{"line_number":127,"context_line":"tree which is generated using the reno tool this way :"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":".. code-block:: bash"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_d67b407a","line":127,"updated":"2015-11-24 16:50:41.000000000","message":"s/way :/way:/ (femtonit)","commit_id":"ac05d05dd09454f551a09b563e27c5e3b5c5fff6"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7b2e46e4f433b4462c4f5e87ad3d528d670ca48c","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* ``upgrade``"},{"line_number":149,"context_line":"    * The patch has an `UpgradeImpact \u003chttp://docs.openstack.org/infra/manual/developers.html#peer-review\u003e`_ tag"},{"line_number":150,"context_line":"    * A DB change is needing some operator modification (like a migration)"},{"line_number":151,"context_line":"    * A configuration option change (deprecation, removal or modified default)"},{"line_number":152,"context_line":"    * some specific changes that have a `DocImpact \u003chttp://docs.openstack.org/infra/manual/developers.html#peer-review\u003e`_ tag"},{"line_number":153,"context_line":"      but require further action from an operator perspective"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_964b782b","line":150,"updated":"2015-11-24 16:50:41.000000000","message":"s/is needing/needs/ (femtonit)","commit_id":"ac05d05dd09454f551a09b563e27c5e3b5c5fff6"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7b2e46e4f433b4462c4f5e87ad3d528d670ca48c","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    * A configuration option change (deprecation, removal or modified default)"},{"line_number":152,"context_line":"    * some specific changes that have a `DocImpact \u003chttp://docs.openstack.org/infra/manual/developers.html#peer-review\u003e`_ tag"},{"line_number":153,"context_line":"      but require further action from an operator perspective"},{"line_number":154,"context_line":"    * any patch that requires an action from the deployer in general"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"* ``security``"},{"line_number":157,"context_line":"    * If the patch fixes a known vulnerability"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_96e7f811","line":154,"updated":"2015-11-24 16:50:41.000000000","message":"Should we do s/operator/deployer/ globally for consistency?","commit_id":"ac05d05dd09454f551a09b563e27c5e3b5c5fff6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4a0f0da140898eee29315f4e354f82c2667c750f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"      new command, including adding new options to existing commands"},{"line_number":163,"context_line":"    * not all blueprints in general, just the ones impacting a `contractual API \u003chttp://docs.openstack.org/developer/nova/policies.html#public-contractual-apis\u003e`_"},{"line_number":164,"context_line":"    * a new virt driver is provided or an existing driver impacts the `HypervisorSupportMatrix \u003chttp://docs.openstack.org/developer/nova/support-matrix.html\u003e`_"},{"line_number":165,"context_line":"    * a *feature* removal (all the above describing a feature)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"* ``critical``"},{"line_number":168,"context_line":"    * Bugfixes categorized as Critical in Launchpad *impacting users*"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_50775802","line":165,"updated":"2015-11-24 16:24:16.000000000","message":"Do we also put feature deprecation here along with the removals?","commit_id":"ac05d05dd09454f551a09b563e27c5e3b5c5fff6"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"8de89481ea8753560110c9ccee1283c17f0e66a5","unresolved":false,"context_lines":[{"line_number":162,"context_line":"      new command, including adding new options to existing commands"},{"line_number":163,"context_line":"    * not all blueprints in general, just the ones impacting a `contractual API \u003chttp://docs.openstack.org/developer/nova/policies.html#public-contractual-apis\u003e`_"},{"line_number":164,"context_line":"    * a new virt driver is provided or an existing driver impacts the `HypervisorSupportMatrix \u003chttp://docs.openstack.org/developer/nova/support-matrix.html\u003e`_"},{"line_number":165,"context_line":"    * a *feature* removal (all the above describing a feature)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"* ``critical``"},{"line_number":168,"context_line":"    * Bugfixes categorized as Critical in Launchpad *impacting users*"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_d4f9ee4e","line":165,"in_reply_to":"9a8ffd7b_50775802","updated":"2015-11-24 20:35:34.000000000","message":"++","commit_id":"ac05d05dd09454f551a09b563e27c5e3b5c5fff6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c565a429aa41dd9dbb3e669506e2bdc4c782db30","unresolved":false,"context_lines":[{"line_number":162,"context_line":"      new command, including adding new options to existing commands"},{"line_number":163,"context_line":"    * not all blueprints in general, just the ones impacting a `contractual API \u003chttp://docs.openstack.org/developer/nova/policies.html#public-contractual-apis\u003e`_"},{"line_number":164,"context_line":"    * a new virt driver is provided or an existing driver impacts the `HypervisorSupportMatrix \u003chttp://docs.openstack.org/developer/nova/support-matrix.html\u003e`_"},{"line_number":165,"context_line":"    * a *feature* removal (all the above describing a feature)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"* ``critical``"},{"line_number":168,"context_line":"    * Bugfixes categorized as Critical in Launchpad *impacting users*"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_df7ee7ad","line":165,"in_reply_to":"9a8ffd7b_d4f9ee4e","updated":"2015-11-24 21:04:23.000000000","message":"After thinking more about that, I feel we should comment the deprecations and removals by the upgrade section until the deprecation section is provided by reno so I\u0027ll remove that line.","commit_id":"ac05d05dd09454f551a09b563e27c5e3b5c5fff6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"03983875653d45ee5e852d0c3c7820425a4a926c","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"* ``fixes``"},{"line_number":171,"context_line":"    * No clear definition of such bugfixes. Hairy long-standing bugs with high"},{"line_number":172,"context_line":"      importance that have been fixed are good candidates tho."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Three sections are left intentionally unexplained (``prelude``, ``issues`` and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_154a2284","line":172,"updated":"2015-11-24 16:14:53.000000000","message":"s/tho/though/","commit_id":"ac05d05dd09454f551a09b563e27c5e3b5c5fff6"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7b2e46e4f433b4462c4f5e87ad3d528d670ca48c","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Three sections are left intentionally unexplained (``prelude``, ``issues`` and"},{"line_number":176,"context_line":"``other``). Those are targeted to be filled in close to the release time for"},{"line_number":177,"context_line":"providing details about the soon-ish release. Don\u0027t use them unless you exactly"},{"line_number":178,"context_line":"know what you are doing."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_d698206d","line":177,"updated":"2015-11-24 16:50:41.000000000","message":"s/you exactly know/you know exactly/ (femtonit)","commit_id":"ac05d05dd09454f551a09b563e27c5e3b5c5fff6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a3f85ce1243f9ae7d23421759d9990bc6cd2454d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"Nova uses `reno \u003chttp://docs.openstack.org/developer/reno/usage.html\u003e`_ for"},{"line_number":122,"context_line":"providing release notes in-tree. That means that a patch can include a *reno"},{"line_number":123,"context_line":"file* or a series can have a follow-on change containing that file explaining"},{"line_number":124,"context_line":"what the impact is."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"A *reno file* is a YAML file written in the releasenotes/notes tree which is"},{"line_number":127,"context_line":"generated using the reno tool this way:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_d47c8922","line":124,"updated":"2015-11-24 22:24:19.000000000","message":"You can\u0027t end a sentence with a preposition!!!!","commit_id":"b169fd1d322fe71f858419157dc9ae8a11865b4d"}]}