)]}'
{"nova/tests/baremetal/test_tilera.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"76b156eb49f8972af3cfa375a0e1cb4acbbaabee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"# coding\u003dutf-8"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright (c) 2011 University of Southern California / ISI"},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2Fzxs%3D","line":4,"updated":"2013-03-26 18:43:58.000000000","message":"It\u0027s probably worth pointing out that this is 2013 :)  (Or was this code actually written in 2011?)","commit_id":"09529f6fdee781a8d585d50f31d2cdde44e05a82"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"76f5a161359adec22f0c779eb02dd8c8bf983943","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"# coding\u003dutf-8"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright (c) 2011 University of Southern California / ISI"},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2Fzjs%3D","line":4,"in_reply_to":"AAAAOH%2F%2FzwU%3D","updated":"2013-03-26 20:41:05.000000000","message":"Ah, OK.  Let\u0027s stick with when the code originated for the copyright date.  (Might be worth *adding* 2013, though, particularly if there are substantial changes since the 2011 version…)","commit_id":"09529f6fdee781a8d585d50f31d2cdde44e05a82"},{"author":{"_account_id":221,"name":"Mikyung Kang","email":"mkkang@isi.edu","username":"mkkang"},"change_message_id":"ce630f7576869a2be37daa60253beddfa0be3349","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"# coding\u003dutf-8"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright (c) 2011 University of Southern California / ISI"},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FzwU%3D","line":4,"in_reply_to":"AAAAOH%2F%2Fzxs%3D","updated":"2013-03-26 19:05:21.000000000","message":"Initial code was written in 2011 and merged into upstream at that time. In 2012, previous codes were deleted so that new bare-metal driver and database can be easily added/extended with PXE case. Now other all stuffs were added into upstream. So this back-end code is being added to upstream again, in 2013. Then, is it better to use 2013?","commit_id":"09529f6fdee781a8d585d50f31d2cdde44e05a82"}],"nova/virt/baremetal/tilera.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"76b156eb49f8972af3cfa375a0e1cb4acbbaabee","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    return image_info"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"class TILERA(base.NodeDriver):"},{"line_number":163,"context_line":"    \"\"\"Tilera bare metal driver.\"\"\""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def __init__(self, virtapi):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FzxM%3D","line":162,"updated":"2013-03-26 18:43:58.000000000","message":"Does this *have* to be all-caps?  I haven\u0027t looked at the conventions in the rest of the bare-metal code, but I would prefer CamelCase over ALLCAPS on a class name.","commit_id":"09529f6fdee781a8d585d50f31d2cdde44e05a82"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"76f5a161359adec22f0c779eb02dd8c8bf983943","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    return image_info"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"class TILERA(base.NodeDriver):"},{"line_number":163,"context_line":"    \"\"\"Tilera bare metal driver.\"\"\""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def __init__(self, virtapi):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2Fzjc%3D","line":162,"in_reply_to":"AAAAOH%2F%2FzwM%3D","updated":"2013-03-26 20:41:05.000000000","message":"Ugh.  In general, I prefer ALLCAPS for constants, CamelCase for class names, and snake_case for variable names and method names.  If we *have* to go with ALLCAPS for these class names, OK, but I would *really* prefer CamelCase if possible.","commit_id":"09529f6fdee781a8d585d50f31d2cdde44e05a82"},{"author":{"_account_id":221,"name":"Mikyung Kang","email":"mkkang@isi.edu","username":"mkkang"},"change_message_id":"ce630f7576869a2be37daa60253beddfa0be3349","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    return image_info"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"class TILERA(base.NodeDriver):"},{"line_number":163,"context_line":"    \"\"\"Tilera bare metal driver.\"\"\""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def __init__(self, virtapi):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FzwM%3D","line":162,"in_reply_to":"AAAAOH%2F%2FzxM%3D","updated":"2013-03-26 19:05:21.000000000","message":"Currently, baremetal driver can support both: PXE and TILERA cases. Based on merged pxe.py and ipmi.py codes, I\u0027m using a same way (ALLCAPS) to sync with other baremetal codes.","commit_id":"09529f6fdee781a8d585d50f31d2cdde44e05a82"}],"nova/virt/baremetal/tilera_pdu.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"76b156eb49f8972af3cfa375a0e1cb4acbbaabee","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    This PowerManager class provides mechanism for controlling the power state"},{"line_number":69,"context_line":"    of physical hardware via PDU calls."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, node, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FzxI%3D","line":70,"updated":"2013-03-26 18:43:58.000000000","message":"The blank line at the end of this docstring isn\u0027t necessary anymore, by the way.  (femtonit)","commit_id":"09529f6fdee781a8d585d50f31d2cdde44e05a82"},{"author":{"_account_id":221,"name":"Mikyung Kang","email":"mkkang@isi.edu","username":"mkkang"},"change_message_id":"ce630f7576869a2be37daa60253beddfa0be3349","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    This PowerManager class provides mechanism for controlling the power state"},{"line_number":69,"context_line":"    of physical hardware via PDU calls."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, node, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FzwA%3D","line":70,"in_reply_to":"AAAAOH%2F%2FzxI%3D","updated":"2013-03-26 19:05:21.000000000","message":"Got it. Thanks.","commit_id":"09529f6fdee781a8d585d50f31d2cdde44e05a82"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"76b156eb49f8972af3cfa375a0e1cb4acbbaabee","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    def activate_node(self):"},{"line_number":150,"context_line":"        \"\"\"Turns the power to node ON.\"\"\""},{"line_number":151,"context_line":"        if self._is_power(CONF.baremetal.tile_pdu_on) \\"},{"line_number":152,"context_line":"            and self.state \u003d\u003d baremetal_states.ACTIVE:"},{"line_number":153,"context_line":"            LOG.warning(_(\"Activate node called, but node %s \""},{"line_number":154,"context_line":"                          \"is already active\") % self.address)"},{"line_number":155,"context_line":"        self._power_on()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FzxA%3D","line":152,"updated":"2013-03-26 18:43:58.000000000","message":"Please use parentheses around the \u0027if\u0027 condition, so we can eliminate the backslash continuation here.","commit_id":"09529f6fdee781a8d585d50f31d2cdde44e05a82"},{"author":{"_account_id":221,"name":"Mikyung Kang","email":"mkkang@isi.edu","username":"mkkang"},"change_message_id":"ce630f7576869a2be37daa60253beddfa0be3349","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    def activate_node(self):"},{"line_number":150,"context_line":"        \"\"\"Turns the power to node ON.\"\"\""},{"line_number":151,"context_line":"        if self._is_power(CONF.baremetal.tile_pdu_on) \\"},{"line_number":152,"context_line":"            and self.state \u003d\u003d baremetal_states.ACTIVE:"},{"line_number":153,"context_line":"            LOG.warning(_(\"Activate node called, but node %s \""},{"line_number":154,"context_line":"                          \"is already active\") % self.address)"},{"line_number":155,"context_line":"        self._power_on()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2Fzv8%3D","line":152,"in_reply_to":"AAAAOH%2F%2FzxA%3D","updated":"2013-03-26 19:05:21.000000000","message":"Thanks. I\u0027ll follow-up.","commit_id":"09529f6fdee781a8d585d50f31d2cdde44e05a82"}]}