)]}'
{"id":"openstack%2Fnova~2485","triplet_id":"openstack%2Fnova~master~Ia06011f400394622ae346ff73f09ac13003b667c","project":"openstack/nova","branch":"master","topic":"jd/clean-disk-flags","hashtags":[],"change_id":"Ia06011f400394622ae346ff73f09ac13003b667c","subject":"Remove FLAGS.minimum_root_size","status":"ABANDONED","created":"2011-12-20 17:35:14.000000000","updated":"2012-01-24 06:03:15.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"baaa6c0c6fd452906abece438ca8fbafb73fd198","_number":2485,"virtual_id_number":2485,"owner":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"_account_id":357,"name":"Devin Carlen","email":"devin@openstack.org","username":"devcamcar"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":357,"name":"Devin Carlen","email":"devin@openstack.org","username":"devcamcar"},"all":[{"value":0,"date":"2011-12-21 11:15:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":-2,"date":"2011-12-21 18:41:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":357,"name":"Devin Carlen","email":"devin@openstack.org","username":"devcamcar"},{"value":0,"date":"2011-12-21 10:31:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2011-12-28 19:08:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"_account_id":357,"name":"Devin Carlen","email":"devin@openstack.org","username":"devcamcar"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"date":"2011-12-28 19:08:55.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":357,"name":"Devin Carlen","email":"devin@openstack.org","username":"devcamcar"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":357,"name":"Devin Carlen","email":"devin@openstack.org","username":"devcamcar"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-12-20 20:31:42.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2011-12-20 20:43:41.000000000","updated_by":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"reviewer":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"state":"REVIEWER"},{"updated":"2011-12-21 11:15:58.000000000","updated_by":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"reviewer":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"state":"REVIEWER"},{"updated":"2011-12-21 18:41:36.000000000","updated_by":{"_account_id":357,"name":"Devin Carlen","email":"devin@openstack.org","username":"devcamcar"},"reviewer":{"_account_id":357,"name":"Devin Carlen","email":"devin@openstack.org","username":"devcamcar"},"state":"REVIEWER"},{"updated":"2011-12-28 19:08:55.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"}],"messages":[{"id":"9b7940e001469cd2c53a0ec7a9c0c2204487b0da","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2011-12-20 20:31:42.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"42fbed19bd00dfafa190b34f7c1c96c0e4cfbcc9","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2011-12-20 20:43:41.000000000","message":"Patch Set 1:\n\nSo now size will not be passed to libvirt.utils.fetch_image() and so that will not do disk.extend(). Why is that no longer required?\n\nNote this patch conflicts somewhat with:\nhttps://review.openstack.org/#change,1993\nso I\u0027ll adjust that accordingly","accounts_in_message":[],"_revision_number":1},{"id":"51d72ae88563479bc01080cfadbfb2a06ea13144","author":{"_account_id":357,"name":"Devin Carlen","email":"devin@openstack.org","username":"devcamcar"},"date":"2011-12-20 23:01:07.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\nPlease explain why this change is needed and make sure there is a corresponding bug on launchpad for this.","accounts_in_message":[],"_revision_number":1},{"id":"ad3562a36c988e1607eecf1d19dc7bf71928e994","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2011-12-21 09:06:35.000000000","message":"Patch Set 1:\n\n@p-draigbrady\nI did not checked all call to fetch_image to check the size but I\u0027ll try to, but I\u0027m afraid that the patch will be bigger then. :)\n\n@Devin Carlen\nThe change is needed because the flag is not used by anyone else than libvirt (\u003d bug) and is useless AFAICT.","accounts_in_message":[],"_revision_number":1},{"id":"469e1b35cd6d526c11e642d540258ec191566514","author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"date":"2011-12-21 09:57:00.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\nEven weird special cases need a better justification to remove that just being weird :-)\r\n\r\nI belive that this flag is used to define the maximum size of a root disk in KVM.  Changing it has an impact on the size of image snaphots that are created, and we\u0027ve used in in our deployment for just that reason, so it can\u0027t just be removed from the system.\r\n\r\nI\u0027d agree that there may be better ways to control the size of snapshiots - but thats a much bigger change.","accounts_in_message":[],"_revision_number":1},{"id":"58e0aa06ab7b4e28a87e8132ca0c94f5d9270bbc","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2011-12-21 10:01:55.000000000","message":"Patch Set 1:\n\n@Phil\nWait, what? The maximum size of a root disk ? The flag is named *minimum_root_size*.\n\nThe flag is just used in one special case if you flavor name is m1.tiny, an has nothing to do with snapshots, so I am starting to doubt about your argumentation.","accounts_in_message":[],"_revision_number":1},{"id":"4684078232177d3a17cbcd0331f087d4a94b18a2","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2011-12-21 10:04:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b1e57ae59ff2f3c0ef283c0eea73ca5f7f96eebf","author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"date":"2011-12-21 10:22:48.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t submit this\n\n@Julian:  It\u0027s not only used if the flavor is m1.tiny.   The check says if the flavour is m1.tiny then set it to None. \r\n\r\nIn all other cases it gets passed through to libvirt.utils.fetch_image to set the minimum size of the root disk.  When a snapshot is created the imags is expanded to this size (I agree that this is a side effect rather than the main purpose of the flag)\r\n\r\nIf you don\u0027t have this mechanism then how can we define the minimum size of a root disk independtly of the stored image ?\r\n\r\nMaybe you don\u0027t see this as useful, but I still don\u0027t see a justification for taking this option away from others.","accounts_in_message":[],"_revision_number":2},{"id":"fb5f9d5c98f3bfc617d9eba2b3234234131010e6","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2011-12-21 10:31:43.000000000","message":"Patch Set 2:\n\n@Julian: It\u0027s not only used if the flavor is m1.tiny. The check says if the flavour is m1.tiny then set it to None. In all other cases it gets passed through to libvirt.utils.fetch_image to set the minimum size of the root disk. When a snapshot is created the imags is expanded to this size (I agree that this is a side effect rather than the main purpose of the flag) If you don\u0027t have this mechanism then how can we define the minimum size of a root disk independtly of the stored image ? Maybe you don\u0027t see this as useful, but I still don\u0027t see a justification for taking this option away from others.\n\n@Phil: I see what you mean. But that does not make this flag right anyway. If you want this feature, then it has to be implemented properly in the API and then in ALL virt systems. Right now this just looks an ugly hack.","accounts_in_message":[],"_revision_number":2},{"id":"c077d2e03f448298b9a208f823eecc2d6ecca45e","author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"date":"2011-12-21 11:15:58.000000000","message":"Patch Set 2: No score\n\nYep - agree its ugly.  Not convinced it should be raised to the API (i.e customer defined) though.\r\n\r\nIdeally root disk size should be something that is defined as a combination of flavour and image, and I seem to remember some talk about this at Boston.\r\n\r\nI\u0027d be happy to see a more elegant solutuion, but that still doesn\u0027t make me want to throw this away in the short term.\r\n\r\nIf you wanted to make the flag accept a value of 0 to give the same behaviour as if the flag wasn\u0027t defined then I\u0027d support that.","accounts_in_message":[],"_revision_number":2},{"id":"8d226e047bb16dbd64ad130d9b4964f4e1d7a329","author":{"_account_id":357,"name":"Devin Carlen","email":"devin@openstack.org","username":"devcamcar"},"date":"2011-12-21 18:41:36.000000000","message":"Patch Set 2: Do not submit\n\nBased on conversations here, it looks like this probably isn\u0027t the best way to approach this and that a more formal solution around dictating minimum root disk size is needed.","accounts_in_message":[],"_revision_number":2},{"id":"0f82ad5facce04df219847f896b937cb80ca8df6","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2011-12-28 19:08:55.000000000","message":"Patch Set 2:\n\nwe already have a plan for this:\n\nhttps://blueprints.launchpad.net/nova/+spec/disk-configuration-parity","accounts_in_message":[],"_revision_number":2},{"id":"bc34290cb63ae996524c4f7cae64c4150627c436","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-01-24 06:03:14.000000000","message":"Patch Set 2:\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":2},{"id":"986e29ccdfb63845cf7718afaa6947d461425df9","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-01-24 06:03:15.000000000","message":"Patch Set 2: Abandoned\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a498d9e21c7fee7eecd29678d7e1c75938d89a07","revisions":{"2ebb1627726a8a00bb91e04127120365448aa870":{"kind":"REWORK","_number":1,"created":"2011-12-20 17:35:14.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/85/2485/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/85/2485/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/2485/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/2485/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/2485/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/85/2485/1"}}},"commit":{"parents":[{"commit":"0eed0edcd08e1cd19e4ec2949d99baa37145fe26","subject":"Remove unused FLAGS.block_size","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0eed0edcd08e1cd19e4ec2949d99baa37145fe26"}]}],"author":{"name":"Julien Danjou","email":"julien.danjou@enovance.com","date":"2011-12-20 17:33:44.000000000","tz":60},"committer":{"name":"Julien Danjou","email":"julien.danjou@enovance.com","date":"2011-12-20 17:33:44.000000000","tz":60},"subject":"Remove FLAGS.minimum_root_size","message":"Remove FLAGS.minimum_root_size\n\nThis is not used anywhere except in a weird special case in libvirt.\n\nChange-Id: Ia06011f400394622ae346ff73f09ac13003b667c\nSigned-off-by: Julien Danjou \u003cjulien.danjou@enovance.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2ebb1627726a8a00bb91e04127120365448aa870"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2ebb1627726a8a00bb91e04127120365448aa870"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"0eed0edcd08e1cd19e4ec2949d99baa37145fe26","is_merged_in_target_branch":true,"change_id":"I41ba92f7443dba94e9e749c916833325f46fb750","change_number":2484,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"a498d9e21c7fee7eecd29678d7e1c75938d89a07":{"kind":"REWORK","_number":2,"created":"2011-12-21 10:04:47.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/85/2485/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/85/2485/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/2485/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/2485/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/2485/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/85/2485/2"}}},"commit":{"parents":[{"commit":"0cf2935688b84bb850f73b5974a0fd15b8f2015f","subject":"Clarify NoValidHost messages","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0cf2935688b84bb850f73b5974a0fd15b8f2015f"}]}],"author":{"name":"Julien Danjou","email":"julien.danjou@enovance.com","date":"2011-12-20 17:33:44.000000000","tz":60},"committer":{"name":"Julien Danjou","email":"julien.danjou@enovance.com","date":"2011-12-21 10:03:48.000000000","tz":60},"subject":"Remove FLAGS.minimum_root_size","message":"Remove FLAGS.minimum_root_size\n\nThis is not used anywhere except in a weird special case in libvirt.\n\nChange-Id: Ia06011f400394622ae346ff73f09ac13003b667c\nSigned-off-by: Julien Danjou \u003cjulien.danjou@enovance.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a498d9e21c7fee7eecd29678d7e1c75938d89a07"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a498d9e21c7fee7eecd29678d7e1c75938d89a07"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"0cf2935688b84bb850f73b5974a0fd15b8f2015f","is_merged_in_target_branch":true,"change_id":"I11102fb5c86966f2b7888d9cba29aed040dd8f4e","change_number":2496,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}