)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"dad72fed9fe7293179354769811bd744f8080d70","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix reclaim_instance_interval \u003c 0 never delete instance completely"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"CONF.reclaim_instance_interval is interval in seconds for reclaiming"},{"line_number":10,"context_line":"deleted instances. It should takes effect only when value is greater"},{"line_number":11,"context_line":"than 0. Bug current when set it with -1 for example, it will pass check"},{"line_number":12,"context_line":"[1] and do a soft delete, but can\u0027t pass check [2] and never have chance"},{"line_number":13,"context_line":"to clean up a soft deleted instance and release the quota."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a710552_c51dbe67","line":10,"updated":"2015-12-15 08:42:48.000000000","message":"s/takes/take/","commit_id":"d4a26718f279cfe3ceb055fb0b300ce1fb24e8fe"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"8542b96ab73fbd266df95a6893be5ce7fde20baa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix reclaim_instance_interval \u003c 0 never delete instance completely"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"CONF.reclaim_instance_interval is interval in seconds for reclaiming"},{"line_number":10,"context_line":"deleted instances. It should takes effect only when value is greater"},{"line_number":11,"context_line":"than 0. Bug current when set it with -1 for example, it will pass check"},{"line_number":12,"context_line":"[1] and do a soft delete, but can\u0027t pass check [2] and never have chance"},{"line_number":13,"context_line":"to clean up a soft deleted instance and release the quota."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a710552_a0366001","line":10,"in_reply_to":"5a710552_c51dbe67","updated":"2015-12-15 09:22:12.000000000","message":"Done","commit_id":"d4a26718f279cfe3ceb055fb0b300ce1fb24e8fe"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"dad72fed9fe7293179354769811bd744f8080d70","unresolved":false,"context_lines":[{"line_number":9,"context_line":"CONF.reclaim_instance_interval is interval in seconds for reclaiming"},{"line_number":10,"context_line":"deleted instances. It should takes effect only when value is greater"},{"line_number":11,"context_line":"than 0. Bug current when set it with -1 for example, it will pass check"},{"line_number":12,"context_line":"[1] and do a soft delete, but can\u0027t pass check [2] and never have chance"},{"line_number":13,"context_line":"to clean up a soft deleted instance and release the quota."},{"line_number":14,"context_line":"This commit set CONF.reclaim_instance_interval\u0027s minimum value is 0."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a710552_056986be","line":12,"updated":"2015-12-15 08:42:48.000000000","message":"What do [1] and [2] refer to?","commit_id":"d4a26718f279cfe3ceb055fb0b300ce1fb24e8fe"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"8542b96ab73fbd266df95a6893be5ce7fde20baa","unresolved":false,"context_lines":[{"line_number":9,"context_line":"CONF.reclaim_instance_interval is interval in seconds for reclaiming"},{"line_number":10,"context_line":"deleted instances. It should takes effect only when value is greater"},{"line_number":11,"context_line":"than 0. Bug current when set it with -1 for example, it will pass check"},{"line_number":12,"context_line":"[1] and do a soft delete, but can\u0027t pass check [2] and never have chance"},{"line_number":13,"context_line":"to clean up a soft deleted instance and release the quota."},{"line_number":14,"context_line":"This commit set CONF.reclaim_instance_interval\u0027s minimum value is 0."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a710552_403bfceb","line":12,"in_reply_to":"5a710552_056986be","updated":"2015-12-15 09:22:12.000000000","message":"Done","commit_id":"d4a26718f279cfe3ceb055fb0b300ce1fb24e8fe"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"dad72fed9fe7293179354769811bd744f8080d70","unresolved":false,"context_lines":[{"line_number":11,"context_line":"than 0. Bug current when set it with -1 for example, it will pass check"},{"line_number":12,"context_line":"[1] and do a soft delete, but can\u0027t pass check [2] and never have chance"},{"line_number":13,"context_line":"to clean up a soft deleted instance and release the quota."},{"line_number":14,"context_line":"This commit set CONF.reclaim_instance_interval\u0027s minimum value is 0."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1518848"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a710552_25db627e","line":14,"updated":"2015-12-15 08:42:48.000000000","message":"This line should be \u0027This commit sets CONF.reclaim_instance_interval\u0027s minimum value to 0.\u0027","commit_id":"d4a26718f279cfe3ceb055fb0b300ce1fb24e8fe"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"8542b96ab73fbd266df95a6893be5ce7fde20baa","unresolved":false,"context_lines":[{"line_number":11,"context_line":"than 0. Bug current when set it with -1 for example, it will pass check"},{"line_number":12,"context_line":"[1] and do a soft delete, but can\u0027t pass check [2] and never have chance"},{"line_number":13,"context_line":"to clean up a soft deleted instance and release the quota."},{"line_number":14,"context_line":"This commit set CONF.reclaim_instance_interval\u0027s minimum value is 0."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1518848"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a710552_60407857","line":14,"in_reply_to":"5a710552_25db627e","updated":"2015-12-15 09:22:12.000000000","message":"Done","commit_id":"d4a26718f279cfe3ceb055fb0b300ce1fb24e8fe"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"fece75cb522b28416df006f8c0b65a3d032cc84d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Closes-Bug: #1518848"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L752"},{"line_number":19,"context_line":"[2] https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6192"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Idd8faad1a40f8898a9471504e664c3676b1b0e06"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a710552_b5fe6d69","line":19,"updated":"2015-12-16 03:01:17.000000000","message":"These references are inappropriate because master codes will be changed.They point to the unintended place in the future.","commit_id":"5aa306b7be234a6477f83b8fe00aad63e0f33046"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f9ecafe147ecfdc943b04a51ff22034db62b9bfd","unresolved":false,"context_lines":[{"line_number":749,"context_line":"    def _delete(self, context, req, instance_uuid):"},{"line_number":750,"context_line":"        authorize(context, action\u003d\u0027delete\u0027)"},{"line_number":751,"context_line":"        instance \u003d self._get_server(context, req, instance_uuid)"},{"line_number":752,"context_line":"        if CONF.reclaim_instance_interval \u003e 0:"},{"line_number":753,"context_line":"            try:"},{"line_number":754,"context_line":"                self.compute_api.soft_delete(context, instance)"},{"line_number":755,"context_line":"            except exception.InstanceInvalidState:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_352ac67f","line":752,"updated":"2015-11-30 18:01:58.000000000","message":"instead of this, we should set min\u003d0 on the config side, as that will also ensure people configure things correctly","commit_id":"e156f702679445b5ded830fd85c403c180c59ab3"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"e9c8da8553f8a06f412bd505b9c4ef8f44ca4817","unresolved":false,"context_lines":[{"line_number":749,"context_line":"    def _delete(self, context, req, instance_uuid):"},{"line_number":750,"context_line":"        authorize(context, action\u003d\u0027delete\u0027)"},{"line_number":751,"context_line":"        instance \u003d self._get_server(context, req, instance_uuid)"},{"line_number":752,"context_line":"        if CONF.reclaim_instance_interval \u003e 0:"},{"line_number":753,"context_line":"            try:"},{"line_number":754,"context_line":"                self.compute_api.soft_delete(context, instance)"},{"line_number":755,"context_line":"            except exception.InstanceInvalidState:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_97a92327","line":752,"in_reply_to":"9a8ffd7b_352ac67f","updated":"2015-12-01 05:26:50.000000000","message":"yes, that makes sense.","commit_id":"e156f702679445b5ded830fd85c403c180c59ab3"}],"nova/compute/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"cf0fca8df4f8969c6a4b5f40aad1d58fcfeffc33","unresolved":false,"context_lines":[{"line_number":161,"context_line":"               help\u003d\"Number of seconds between instance network information \""},{"line_number":162,"context_line":"                    \"cache updates\"),"},{"line_number":163,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":164,"context_line":"               min\u003d0,"},{"line_number":165,"context_line":"               default\u003d0,"},{"line_number":166,"context_line":"               help\u003d\u0027Interval in seconds for reclaiming deleted instances.\u0027"},{"line_number":167,"context_line":"                    \u0027It takes effect only when value is greater than 0.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_31145fe7","line":164,"updated":"2015-12-14 07:47:21.000000000","message":"if the value is \u003c\u003d0 then the operation is skipped. So this would break existing setups if someone has for example set this as -1","commit_id":"b0a4bbe6d80828238c543ec3970c335d25f8fef0"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"28e9b1c57f7a3481288d08ca7861d852424d3c2c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"               help\u003d\"Number of seconds between instance network information \""},{"line_number":162,"context_line":"                    \"cache updates\"),"},{"line_number":163,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":164,"context_line":"               min\u003d0,"},{"line_number":165,"context_line":"               default\u003d0,"},{"line_number":166,"context_line":"               help\u003d\u0027Interval in seconds for reclaiming deleted instances.\u0027"},{"line_number":167,"context_line":"                    \u0027It takes effect only when value is greater than 0.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_eb1338ff","line":164,"in_reply_to":"7a740942_31145fe7","updated":"2015-12-14 11:50:16.000000000","message":"set with -1,  is wrong , that\u0027s the commit fix.  More details, please see the bug.","commit_id":"b0a4bbe6d80828238c543ec3970c335d25f8fef0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"cf0fca8df4f8969c6a4b5f40aad1d58fcfeffc33","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":164,"context_line":"               min\u003d0,"},{"line_number":165,"context_line":"               default\u003d0,"},{"line_number":166,"context_line":"               help\u003d\u0027Interval in seconds for reclaiming deleted instances.\u0027"},{"line_number":167,"context_line":"                    \u0027It takes effect only when value is greater than 0.\u0027),"},{"line_number":168,"context_line":"    cfg.IntOpt(\u0027volume_usage_poll_interval\u0027,"},{"line_number":169,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_71f747d3","line":166,"updated":"2015-12-14 07:47:21.000000000","message":"missing space at the end of the line","commit_id":"b0a4bbe6d80828238c543ec3970c335d25f8fef0"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"12f975bc5f18b78b784ecc8ae87958f114c4f98b","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    cfg.IntOpt(\u0027reclaim_instance_interval\u0027,"},{"line_number":164,"context_line":"               min\u003d0,"},{"line_number":165,"context_line":"               default\u003d0,"},{"line_number":166,"context_line":"               help\u003d\u0027Interval in seconds for reclaiming deleted instances.\u0027"},{"line_number":167,"context_line":"                    \u0027It takes effect only when value is greater than 0.\u0027),"},{"line_number":168,"context_line":"    cfg.IntOpt(\u0027volume_usage_poll_interval\u0027,"},{"line_number":169,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_0412f562","line":166,"in_reply_to":"7a740942_71f747d3","updated":"2015-12-15 03:16:02.000000000","message":"Done","commit_id":"b0a4bbe6d80828238c543ec3970c335d25f8fef0"}]}