)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"67fa8b9ba0880cf76998aa9e03129f33eb2de5dc","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"There were several issues around a vdis list without a \u0027root\u0027 disk."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Becuse the ISO boot was HVM, only 0-3 devices will work, so, the"},{"line_number":14,"context_line":"devices used have been re-ordered to ensure ISOs can be read"},{"line_number":15,"context_line":"by a HVM guest without PV tools. Once PV tools are present, a"},{"line_number":16,"context_line":"HVM guest will be able to access an ephemeral or swap disk."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAOH%2F%2FyFc%3D","line":13,"updated":"2013-03-27 17:32:56.000000000","message":"Typo - Because","commit_id":"85f6785578c813a98d222e10c4785dfb3d01b792"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"67fa8b9ba0880cf76998aa9e03129f33eb2de5dc","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                _(\u0027Unable to destroy VBD %s\u0027) % vbd_ref)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"def create_vbd(session, vm_ref, vdi_ref, userdevice, vbd_type\u003d\u0027disk\u0027,"},{"line_number":390,"context_line":"               read_only\u003dFalse, bootable\u003dFalse, osvol\u003dFalse,"},{"line_number":391,"context_line":"               empty\u003dFalse, unpluggable\u003dTrue):"},{"line_number":392,"context_line":"    \"\"\"Create a VBD record and returns its reference.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FyFI%3D","line":389,"updated":"2013-03-27 17:32:56.000000000","message":"For future extension wouldn\u0027t it make more sense to pass an over-rides dictionary into this?\n\ni.e. have bootable\u003dFalse by default, but if you pass {\u0027bootable\u0027:True} it gets added to vbd_rec\n\nThat way we can easily extend to using qos or similar in the future","commit_id":"85f6785578c813a98d222e10c4785dfb3d01b792"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a363d3b71252dd430620f08819f42b4e38d8e3f5","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                _(\u0027Unable to destroy VBD %s\u0027) % vbd_ref)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"def create_vbd(session, vm_ref, vdi_ref, userdevice, vbd_type\u003d\u0027disk\u0027,"},{"line_number":390,"context_line":"               read_only\u003dFalse, bootable\u003dFalse, osvol\u003dFalse,"},{"line_number":391,"context_line":"               empty\u003dFalse, unpluggable\u003dTrue):"},{"line_number":392,"context_line":"    \"\"\"Create a VBD record and returns its reference.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FxGw%3D","line":389,"in_reply_to":"AAAAOH%2F%2FyFI%3D","updated":"2013-03-28 11:39:14.000000000","message":"We could. That should be a separate change for that refactor of all the other callers.","commit_id":"85f6785578c813a98d222e10c4785dfb3d01b792"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"67fa8b9ba0880cf76998aa9e03129f33eb2de5dc","unresolved":false,"context_lines":[{"line_number":544,"context_line":"                                    kernel_file, ramdisk_file, use_pv_kernel)"},{"line_number":545,"context_line":"        return vm_ref"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    def _determine_vm_mode(self, instance, vdis, disk_image_type):"},{"line_number":548,"context_line":"        current_mode \u003d vm_mode.get_from_instance(instance)"},{"line_number":549,"context_line":"        if current_mode \u003d\u003d vm_mode.XEN or current_mode \u003d\u003d vm_mode.HVM:"},{"line_number":550,"context_line":"            return current_mode"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FyEw%3D","line":547,"updated":"2013-03-27 17:32:56.000000000","message":"Should we have a unit test for this function now it\u0027s separated out?","commit_id":"85f6785578c813a98d222e10c4785dfb3d01b792"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a363d3b71252dd430620f08819f42b4e38d8e3f5","unresolved":false,"context_lines":[{"line_number":544,"context_line":"                                    kernel_file, ramdisk_file, use_pv_kernel)"},{"line_number":545,"context_line":"        return vm_ref"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    def _determine_vm_mode(self, instance, vdis, disk_image_type):"},{"line_number":548,"context_line":"        current_mode \u003d vm_mode.get_from_instance(instance)"},{"line_number":549,"context_line":"        if current_mode \u003d\u003d vm_mode.XEN or current_mode \u003d\u003d vm_mode.HVM:"},{"line_number":550,"context_line":"            return current_mode"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FxGY%3D","line":547,"in_reply_to":"AAAAOH%2F%2FyEw%3D","updated":"2013-03-28 11:39:14.000000000","message":"I wondered about this, but its quite well covered with the existing tests, didn\u0027t want to duplicate the testing. I could add some if that is the direction people think we should go? I don\u0027t really like those big spawn tests, they are more integration than unit tests.\n\nThe old tests didn\u0027t catch the error before because the disk_type was hard coded to VHD, but I fixed that in this change.","commit_id":"85f6785578c813a98d222e10c4785dfb3d01b792"}]}