)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f3a02469217e8665d8f7c85c3eaffa9f9687c848","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The config options of the \"nova.conf\" section \"guestfs\""},{"line_number":10,"context_line":"got moved to the new central location \"nova/conf/guestfs.py\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9db186e7d665fa7ce05e806843592d739fdd9c7c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a740942_b9477c4a","line":11,"updated":"2015-12-10 00:19:26.000000000","message":"\u0027Implements: blueprint centralize-config-options\u0027 should be added.","commit_id":"ac95b5497219df66cb23e8a6d18aff51003343dd"}],"nova/conf/guestfs.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"2efc07afa4e09d90ebf7316db7a02ffc6d730f26","unresolved":false,"context_lines":[{"line_number":18,"context_line":"guestfs_opts \u003d ["},{"line_number":19,"context_line":"    cfg.BoolOpt(\u0027debug\u0027,"},{"line_number":20,"context_line":"                default\u003dFalse,"},{"line_number":21,"context_line":"                help\u003d\u0027Enable guestfs debug\u0027)"},{"line_number":22,"context_line":"]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ALL_OPTS \u003d [guestfs_opts]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_c9001905","line":21,"updated":"2015-11-24 09:13:36.000000000","message":"A subsequent patch should then add a few more words what this option does. And in which use cases it could be useful to switch to \"True\". From an operators point of view who doesn\u0027t know the code.","commit_id":"6d19418a50a1fea263cf84079093eb9a7a10bc88"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"2efc07afa4e09d90ebf7316db7a02ffc6d730f26","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                help\u003d\u0027Enable guestfs debug\u0027)"},{"line_number":22,"context_line":"]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ALL_OPTS \u003d [guestfs_opts]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def register_opts(conf):"},{"line_number":27,"context_line":"    conf.register_opts(ALL_OPTS, group\u003d\"guestfs\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_29e445de","line":24,"updated":"2015-11-24 09:13:36.000000000","message":"That\u0027s a list of lists which could be an issue. You could do this:\n\n    ALL_OPTS \u003d [] + guestfs_opts\n\nor this:\n\n    enable_guestfs_opt \u003d cfg.BoolOpt(\u0027debug\u0027,\n            default\u003dFalse,\n            help\u003d\u0027Enable guestfs debug\u0027)\n\n    ALL_OPTS \u003d [enable_guestfs_opt]","commit_id":"6d19418a50a1fea263cf84079093eb9a7a10bc88"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"305e60cdcb1af392564bd70b6551ded1076cfa6b","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"enable_guestfs_debug_opts \u003d cfg.BoolOpt(\u0027debug\u0027,"},{"line_number":19,"context_line":"                default\u003dFalse,"},{"line_number":20,"context_line":"                help\u003d\u0027Enable guestfs debug\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ALL_OPTS \u003d [enable_guestfs_debug_opts]"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_aa315eee","line":20,"updated":"2015-11-24 23:17:48.000000000","message":"Not sure about the indentation here. Either line it up visually, or indent the continued lines 2 levels (8 spaces).","commit_id":"13201ad78fd8e90e33bdb40a6ff7e3324e8296ab"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"e2bb83e245bdcd05fb8cd610d2628faf87b038dc","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"enable_guestfs_debug_opts \u003d cfg.BoolOpt(\u0027debug\u0027,"},{"line_number":19,"context_line":"                default\u003dFalse,"},{"line_number":20,"context_line":"                help\u003d\u0027Enable guestfs debug\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ALL_OPTS \u003d [enable_guestfs_debug_opts]"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_b1dd2144","line":20,"in_reply_to":"9a8ffd7b_aa315eee","updated":"2015-11-25 17:45:42.000000000","message":"Done","commit_id":"13201ad78fd8e90e33bdb40a6ff7e3324e8296ab"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"90714df6a5567284bdd22936ae33cd676a799201","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"enable_guestfs_debug_opts \u003d cfg.BoolOpt(\u0027debug\u0027,"},{"line_number":19,"context_line":"                                        default\u003dFalse,"},{"line_number":20,"context_line":"                                        help\u003d\u0027Enable guestfs debug\u0027)"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"fa69d971_affc52b8","line":18,"updated":"2016-01-07 00:37:02.000000000","message":"nit: since this is a single option, the name should be singular, not plural. But only change if you respin.","commit_id":"1bb2796c175c74414c9d445c9b950a48c3ec7a13"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"572452bebbb95d77c9e87e3f73e33930fa54aee7","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def list_opts():"},{"line_number":30,"context_line":"    return (\"guestfs\", ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":21,"id":"da6ed579_ab70c372","line":30,"range":{"start_line":30,"start_character":11,"end_line":30,"end_character":32},"updated":"2016-01-15 15:04:26.000000000","message":"Return a dict here","commit_id":"26931ec92e43fc3cc1247e7ce049c13cb32c1187"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0c0b2c0784649c0103b3e79438e3770bfbb17f0e","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def list_opts():"},{"line_number":30,"context_line":"    return {\"guestfs\": ALL_OPTS}"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa0719c6_3a63ab43","line":30,"range":{"start_line":30,"start_character":13,"end_line":30,"end_character":20},"updated":"2016-03-24 12:11:05.000000000","message":"we should probably define the opt_group so it gets a description, but that can be a follow up patch.","commit_id":"432682be365dfd9af627902e551f831ce472f626"}],"nova/opts.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c451c086c8131580d8f89db0a8cfbf06bf9b7708","unresolved":false,"context_lines":[{"line_number":117,"context_line":"             nova.keymgr.keymgr_opts,"},{"line_number":118,"context_line":"         )),"},{"line_number":119,"context_line":"        (\u0027rdp\u0027, nova.rdp.rdp_opts),"},{"line_number":120,"context_line":"        nova.conf.guestfs.list_opts(),"},{"line_number":121,"context_line":"        nova.conf.serial_console.list_opts(),"},{"line_number":122,"context_line":"        (\u0027spice\u0027,"},{"line_number":123,"context_line":"         itertools.chain("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_67739a16","line":120,"updated":"2015-11-25 10:53:53.000000000","message":"I think this should be in \"nova/virt/opts.py\"\n\nsee https://github.com/openstack/nova/blob/master/nova/virt/opts.py#L69","commit_id":"13201ad78fd8e90e33bdb40a6ff7e3324e8296ab"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"e2bb83e245bdcd05fb8cd610d2628faf87b038dc","unresolved":false,"context_lines":[{"line_number":117,"context_line":"             nova.keymgr.keymgr_opts,"},{"line_number":118,"context_line":"         )),"},{"line_number":119,"context_line":"        (\u0027rdp\u0027, nova.rdp.rdp_opts),"},{"line_number":120,"context_line":"        nova.conf.guestfs.list_opts(),"},{"line_number":121,"context_line":"        nova.conf.serial_console.list_opts(),"},{"line_number":122,"context_line":"        (\u0027spice\u0027,"},{"line_number":123,"context_line":"         itertools.chain("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_51c4f55d","line":120,"in_reply_to":"9a8ffd7b_67739a16","updated":"2015-11-25 17:45:42.000000000","message":"right - i put it there and forgot to take it out of here.","commit_id":"13201ad78fd8e90e33bdb40a6ff7e3324e8296ab"}],"nova/virt/disk/vfs/guestfs.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"2efc07afa4e09d90ebf7316db7a02ffc6d730f26","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import nova.conf"},{"line_number":22,"context_line":"from nova.conf import guestfs as guestfs_conf"},{"line_number":23,"context_line":"from nova import exception"},{"line_number":24,"context_line":"from nova.i18n import _"},{"line_number":25,"context_line":"from nova.i18n import _LW"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_692c8d02","line":22,"updated":"2015-11-24 09:13:36.000000000","message":"This import is not necessary","commit_id":"6d19418a50a1fea263cf84079093eb9a7a10bc88"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"2efc07afa4e09d90ebf7316db7a02ffc6d730f26","unresolved":false,"context_lines":[{"line_number":32,"context_line":"guestfs \u003d None"},{"line_number":33,"context_line":"forceTCG \u003d False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CONF \u003d cfg.guestfs.CONF"},{"line_number":36,"context_line":"guestfs_conf.register_opts(CONF)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_09f7018c","line":35,"updated":"2015-11-24 09:13:36.000000000","message":"That should be\n\n    CONF \u003d nova.conf.CONF","commit_id":"6d19418a50a1fea263cf84079093eb9a7a10bc88"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"2efc07afa4e09d90ebf7316db7a02ffc6d730f26","unresolved":false,"context_lines":[{"line_number":33,"context_line":"forceTCG \u003d False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"CONF \u003d cfg.guestfs.CONF"},{"line_number":36,"context_line":"guestfs_conf.register_opts(CONF)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def force_tcg(force\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_e9407da7","line":36,"updated":"2015-11-24 09:13:36.000000000","message":"This line is not necessary. The registration of the imports is done when the \"nova.conf\" gets imported at line 21.","commit_id":"6d19418a50a1fea263cf84079093eb9a7a10bc88"}]}