)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3ce18f969b667b476916151cffc2f751ba8e0386","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-24 05:52:52 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: introduce freeze filesystems"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia530b1072c5af21dc114be627af90a39e38fa01b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_ee2543c2","line":7,"updated":"2015-11-24 19:55:07.000000000","message":"A little more detail is needed (the \"why\", rather than the \"what\"), IMO","commit_id":"54f257bb562417ad2761ccfaedd78e28967ed43b"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e6573b5a21ad364afe8f7795246c98bcc603c6aa","unresolved":false,"context_lines":[{"line_number":1521,"context_line":"            # We should be able to remove domain at the end."},{"line_number":1522,"context_line":"            domain \u003d guest._domain"},{"line_number":1523,"context_line":"            if quiesced:"},{"line_number":1524,"context_line":"                guest.freeze_filesystems()"},{"line_number":1525,"context_line":"            else:"},{"line_number":1526,"context_line":"                domain.fsThaw()"},{"line_number":1527,"context_line":"        except libvirt.libvirtError as ex:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_3545f8b2","line":1524,"updated":"2015-11-30 13:41:29.000000000","message":"freeze_filesystems \u003d\u003e freeze_filesystem","commit_id":"b15644cc52261c0b21830a342ddac3fa5e7635d6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2991bbd212028c8bd5184a6f811ff031474920c9","unresolved":false,"context_lines":[{"line_number":1521,"context_line":"            # We should be able to remove domain at the end."},{"line_number":1522,"context_line":"            domain \u003d guest._domain"},{"line_number":1523,"context_line":"            if quiesced:"},{"line_number":1524,"context_line":"                guest.freeze_filesystems()"},{"line_number":1525,"context_line":"            else:"},{"line_number":1526,"context_line":"                domain.fsThaw()"},{"line_number":1527,"context_line":"        except libvirt.libvirtError as ex:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_7850555f","line":1524,"in_reply_to":"9a8ffd7b_3545f8b2","updated":"2015-11-30 13:56:42.000000000","message":"I may be wrong but since we do not pass device on that function, this function will freeze all mounted guest\u0027s filesystems. That is why i called it with a \u0027S\u0027","commit_id":"b15644cc52261c0b21830a342ddac3fa5e7635d6"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"cf4671b87bb764d67592fb9a9ad54be8f86f84cb","unresolved":false,"context_lines":[{"line_number":1521,"context_line":"            # We should be able to remove domain at the end."},{"line_number":1522,"context_line":"            domain \u003d guest._domain"},{"line_number":1523,"context_line":"            if quiesced:"},{"line_number":1524,"context_line":"                guest.freeze_filesystems()"},{"line_number":1525,"context_line":"            else:"},{"line_number":1526,"context_line":"                domain.fsThaw()"},{"line_number":1527,"context_line":"        except libvirt.libvirtError as ex:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_aa7d3a6e","line":1524,"in_reply_to":"9a8ffd7b_7850555f","updated":"2015-12-03 13:04:11.000000000","message":"yeah i think using plural as you have is correct","commit_id":"b15644cc52261c0b21830a342ddac3fa5e7635d6"}],"nova/virt/libvirt/guest.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e6573b5a21ad364afe8f7795246c98bcc603c6aa","unresolved":false,"context_lines":[{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        return disk_path"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def freeze_filesystems(self):"},{"line_number":406,"context_line":"        \"\"\"Freeze filesystems within guest.\"\"\""},{"line_number":407,"context_line":"        self._domain.fsFreeze()"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_b50fa887","line":405,"updated":"2015-11-30 13:41:29.000000000","message":"freeze_filesystems \u003d\u003e freeze_filesystem","commit_id":"b15644cc52261c0b21830a342ddac3fa5e7635d6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e6573b5a21ad364afe8f7795246c98bcc603c6aa","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        return disk_path"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def freeze_filesystems(self):"},{"line_number":406,"context_line":"        \"\"\"Freeze filesystems within guest.\"\"\""},{"line_number":407,"context_line":"        self._domain.fsFreeze()"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_151f94b8","line":406,"updated":"2015-11-30 13:41:29.000000000","message":"filesystems \u003d\u003e filesystem","commit_id":"b15644cc52261c0b21830a342ddac3fa5e7635d6"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"cf4671b87bb764d67592fb9a9ad54be8f86f84cb","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        return disk_path"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def freeze_filesystems(self):"},{"line_number":406,"context_line":"        \"\"\"Freeze filesystems within guest.\"\"\""},{"line_number":407,"context_line":"        self._domain.fsFreeze()"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_0ae6c643","line":406,"in_reply_to":"9a8ffd7b_151f94b8","updated":"2015-12-03 13:04:11.000000000","message":"No, it freezes all filesystems so using plural is correct","commit_id":"b15644cc52261c0b21830a342ddac3fa5e7635d6"}]}
