)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"082f639d105c5eeee7ecb9a789bc00b17593780d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Follow libvirt to add support for the hotplug of a vif"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib78907ed9d52c8e2542e0d9612ca7d915855836b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a8ffd7b_de160958","line":11,"updated":"2015-11-30 14:26:58.000000000","message":"Need to link to John\u0027s blueprint and make it clear that this is follow on work from I56503c0736cb465a9991b50b71bc1a904347d4f7.\nAdd \"blueprint: xenapi-vif-hotplug\"\n\nIf you alter the Change-ID to be I56503c0736cb465a9991b50b71bc1a904347d4f7 in the commit message, then it will highlight it as follow on work.","commit_id":"37ce6b56ff242549396634a4237a51f2de5b01b4"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"082f639d105c5eeee7ecb9a789bc00b17593780d","unresolved":false,"context_lines":[{"line_number":1943,"context_line":"        # don\u0027t race on the detected device number"},{"line_number":1944,"context_line":"        @utils.synchronized(\u0027vif-\u0027 + instance[\u0027uuid\u0027])"},{"line_number":1945,"context_line":"        def unplug():"},{"line_number":1946,"context_line":"            self.vif_driver.unplug(instance, vif)"},{"line_number":1947,"context_line":""},{"line_number":1948,"context_line":"        unplug()"},{"line_number":1949,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_a97af175","line":1946,"updated":"2015-11-30 14:26:58.000000000","message":"This seems to do nothing?  Therefore the whole changeset does nothing?","commit_id":"37ce6b56ff242549396634a4237a51f2de5b01b4"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"340e1cae17f857214bfe432c9ad7a5c83f655727","unresolved":false,"context_lines":[{"line_number":1918,"context_line":"        plug()"},{"line_number":1919,"context_line":"        self.firewall_driver.setup_basic_filtering(instance, [vif])"},{"line_number":1920,"context_line":""},{"line_number":1921,"context_line":"    def _find_next_vif_device(self, instance):"},{"line_number":1922,"context_line":"        vm_ref \u003d self._get_vm_opaque_ref(instance)"},{"line_number":1923,"context_line":"        vif_refs \u003d self._session.call_xenapi(\"VM.get_VIFs\", vm_ref)"},{"line_number":1924,"context_line":"        if len(vif_refs) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_7a364d52","line":1921,"updated":"2015-12-03 09:53:58.000000000","message":"A suggestion for implementing this function\n\nvm_ref \u003d self._get_vm_opaque_ref(instance)\ndevices \u003d self._session.call_xenapi(\u0027VM.get_allowed_VIF_devices\u0027,\n                                           vm_ref)\nif len(devices) \u003e 0:\n        return devices[0]\nelse:\n        return 9 or raise XXX","commit_id":"8bed0463b3e613c6328697dc519fb876654f1ad5"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"30781ff788b3c45002621fbd9eab09bbd1a8f2d8","unresolved":false,"context_lines":[{"line_number":1931,"context_line":""},{"line_number":1932,"context_line":"        devices.sort()"},{"line_number":1933,"context_line":"        next_device \u003d 0"},{"line_number":1934,"context_line":"        for devices in devices:"},{"line_number":1935,"context_line":"            next_device +\u003d 1"},{"line_number":1936,"context_line":"            if next_device !\u003d device:"},{"line_number":1937,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_42612e38","line":1934,"updated":"2015-12-03 05:43:37.000000000","message":"should be for \"device\" not \"devices\"","commit_id":"8bed0463b3e613c6328697dc519fb876654f1ad5"}]}
