)]}'
{"nova/tests/unit/virt/libvirt/test_guest.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"935b7181a9a1309d82ef35d2a5f37c3ca86fe47e","unresolved":false,"context_lines":[{"line_number":447,"context_line":"    def test_migrate_v2(self):"},{"line_number":448,"context_line":"        self.guest.migrate(\u0027an-uri\u0027, domain_xml\u003d\u0027\u003c/xml\u003e\u0027, flags\u003d1, bandwidth\u003d2)"},{"line_number":449,"context_line":"        self.domain.migrateToURI2.assert_called_once_with("},{"line_number":450,"context_line":"            \u0027an-uri\u0027, dxml\u003d\u0027\u003c/xml\u003e\u0027, flags\u003d1, bandwidth\u003d2)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"class GuestBlockTestCase(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a7e1126_d521c3b5","line":450,"range":{"start_line":450,"start_character":57,"end_line":450,"end_character":58},"updated":"2015-12-17 16:19:41.000000000","message":"We have some code in migrate that catches exception and calls back in recursively. We ought to test that here too","commit_id":"f2d6f50db7f6d958bb27f9ffa18cb0ff2844e53e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1bf29c06a2d8ff4b411e52ed8dcb85ea713cc110","unresolved":false,"context_lines":[{"line_number":447,"context_line":"    def test_migrate_v2(self):"},{"line_number":448,"context_line":"        self.guest.migrate(\u0027an-uri\u0027, domain_xml\u003d\u0027\u003c/xml\u003e\u0027, flags\u003d1, bandwidth\u003d2)"},{"line_number":449,"context_line":"        self.domain.migrateToURI2.assert_called_once_with("},{"line_number":450,"context_line":"            \u0027an-uri\u0027, dxml\u003d\u0027\u003c/xml\u003e\u0027, flags\u003d1, bandwidth\u003d2)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"class GuestBlockTestCase(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a7e1126_da97848e","line":450,"in_reply_to":"3a7e1126_d521c3b5","updated":"2015-12-18 10:59:49.000000000","message":"It\u0027s covered in test_driver.py, line 6567, test: test_live_migration_raises_unsupported_config_exception().\n\nWe can make it more concise here.","commit_id":"f2d6f50db7f6d958bb27f9ffa18cb0ff2844e53e"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6a09f9188faeda5c2fdc20e35d4fd3f1834fd81e","unresolved":false,"context_lines":[{"line_number":5669,"context_line":"                        flags\u003dlogical_sum,"},{"line_number":5670,"context_line":"                        bandwidth\u003dCONF.libvirt.live_migration_bandwidth)"},{"line_number":5671,"context_line":"                else:"},{"line_number":5672,"context_line":"                    raise"},{"line_number":5673,"context_line":"        except Exception as e:"},{"line_number":5674,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":5675,"context_line":"                LOG.error(_LE(\"Live Migration failure: %s\"), e,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_6aae722f","line":5672,"updated":"2015-12-03 13:13:17.000000000","message":"I think we should move this entire \u0027except\u0027 block into guest.py - the driver.py code shouldn\u0027t know / workaround libvirt bugs.","commit_id":"ff9009c6d9ea9a52faa12f06a7a48ac94efac7ba"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4215015bda0298ba23769a8de07be374234d04ac","unresolved":false,"context_lines":[{"line_number":5669,"context_line":"                        flags\u003dlogical_sum,"},{"line_number":5670,"context_line":"                        bandwidth\u003dCONF.libvirt.live_migration_bandwidth)"},{"line_number":5671,"context_line":"                else:"},{"line_number":5672,"context_line":"                    raise"},{"line_number":5673,"context_line":"        except Exception as e:"},{"line_number":5674,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":5675,"context_line":"                LOG.error(_LE(\"Live Migration failure: %s\"), e,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_2ab71df6","line":5672,"in_reply_to":"9a8ffd7b_6aae722f","updated":"2015-12-08 08:31:44.000000000","message":"How do handle methods \u0027_check_graphics_addresses_can_live_migrate\u0027 and \u0027_verify_serial_console_is_disabled\u0027 called if first call of migrate fails ? - We can probably add this in \u0027compat\u0027 module. I will see what can i do.","commit_id":"ff9009c6d9ea9a52faa12f06a7a48ac94efac7ba"}],"nova/virt/libvirt/guest.py":[{"author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"change_message_id":"94917e7b8e84c097fee45309479cfa0498bd4944","unresolved":false,"context_lines":[{"line_number":447,"context_line":"    def migrate(self, destination, flags\u003d0, domain_xml\u003dNone, bandwidth\u003d0):"},{"line_number":448,"context_line":"        \"\"\"Migrate guest object from its current host to the destination"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"        :param destination: URI of host destination where guest will be migrate"},{"line_number":451,"context_line":"        :param flags: May be one of more of the following:"},{"line_number":452,"context_line":"           VIR_MIGRATE_LIVE Do not pause the VM during migration"},{"line_number":453,"context_line":"           VIR_MIGRATE_PEER2PEER Direct connection between source \u0026"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_81619a3b","line":450,"updated":"2015-12-07 07:29:39.000000000","message":"destination host , migrate-\u003emigrated","commit_id":"2019490de075b27e59515f69035c6a30214d141d"},{"author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"change_message_id":"94917e7b8e84c097fee45309479cfa0498bd4944","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        \"\"\"Migrate guest object from its current host to the destination"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"        :param destination: URI of host destination where guest will be migrate"},{"line_number":451,"context_line":"        :param flags: May be one of more of the following:"},{"line_number":452,"context_line":"           VIR_MIGRATE_LIVE Do not pause the VM during migration"},{"line_number":453,"context_line":"           VIR_MIGRATE_PEER2PEER Direct connection between source \u0026"},{"line_number":454,"context_line":"                                 destination hosts"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_a164d648","line":451,"updated":"2015-12-07 07:29:39.000000000","message":"one or more","commit_id":"2019490de075b27e59515f69035c6a30214d141d"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"4a2ed3040053b32b4be52fc2297a7781c0caaffd","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            if params:"},{"line_number":524,"context_line":"                self._domain.migrateToURI3("},{"line_number":525,"context_line":"                    destination, params\u003dparams,"},{"line_number":526,"context_line":"                    flags\u003dflags, bandwidth\u003dbandwidth)"},{"line_number":527,"context_line":"            else:"},{"line_number":528,"context_line":"                self._domain.migrateToURI2("},{"line_number":529,"context_line":"                    destination, dxml\u003ddomain_xml,"}],"source_content_type":"text/x-python","patch_set":36,"id":"9abb7d3a_ba7c48b6","line":526,"range":{"start_line":526,"start_character":33,"end_line":526,"end_character":52},"updated":"2016-06-03 10:17:50.000000000","message":"We missed this there - migrateToURI3 does not take bandwidth parameter.\n\nFix is up for review https://review.openstack.org/325204","commit_id":"33d77b812437787a0eb32c542461b211efab2f71"}]}