)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fcdc24cc2b09201178ce331e307ced1e479ecaaa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aliasgar Ginwala \u003caginwala@ebaysf.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-27 03:43:59 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixes free_gb value when scheduler receives free_disk_gb from"},{"line_number":8,"context_line":"compute. Some times when None is received, it tries to convert it"},{"line_number":9,"context_line":"to MB and fails due to Nonetype multiplication with int"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_e64ff131","line":7,"updated":"2015-11-28 13:56:11.000000000","message":"please see https://wiki.openstack.org/wiki/GitCommitMessages\n\nthis is missing a short header line","commit_id":"b578986f2a7b651091113907197813fa4d2d2446"},{"author":{"_account_id":19318,"name":"aginwala","email":"aginwala@ebaysf.com","username":"aginwala"},"change_message_id":"0daf03f301a483ae248b25b71143b2a1a4d591c1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aliasgar Ginwala \u003caginwala@ebaysf.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-27 03:43:59 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixes free_gb value when scheduler receives free_disk_gb from"},{"line_number":8,"context_line":"compute. Some times when None is received, it tries to convert it"},{"line_number":9,"context_line":"to MB and fails due to Nonetype multiplication with int"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_7c8aa465","line":7,"in_reply_to":"9a8ffd7b_e64ff131","updated":"2015-11-29 19:35:06.000000000","message":"Sure will take care of it","commit_id":"b578986f2a7b651091113907197813fa4d2d2446"}],"nova/scheduler/host_manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fcdc24cc2b09201178ce331e307ced1e479ecaaa","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # Assume virtual size is all consumed by instances if use qcow2 disk."},{"line_number":198,"context_line":"        free_gb \u003d compute.free_disk_gb"},{"line_number":199,"context_line":"        if free_gb is None:"},{"line_number":200,"context_line":"            free_gb \u003d 0"},{"line_number":201,"context_line":"        least_gb \u003d compute.disk_available_least"},{"line_number":202,"context_line":"        if least_gb is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_866145ab","line":199,"updated":"2015-11-28 13:56:11.000000000","message":"this is missing a unit test","commit_id":"b578986f2a7b651091113907197813fa4d2d2446"},{"author":{"_account_id":19318,"name":"aginwala","email":"aginwala@ebaysf.com","username":"aginwala"},"change_message_id":"0daf03f301a483ae248b25b71143b2a1a4d591c1","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # Assume virtual size is all consumed by instances if use qcow2 disk."},{"line_number":198,"context_line":"        free_gb \u003d compute.free_disk_gb"},{"line_number":199,"context_line":"        if free_gb is None:"},{"line_number":200,"context_line":"            free_gb \u003d 0"},{"line_number":201,"context_line":"        least_gb \u003d compute.disk_available_least"},{"line_number":202,"context_line":"        if least_gb is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_bc948c8a","line":199,"in_reply_to":"9a8ffd7b_866145ab","updated":"2015-11-29 19:35:06.000000000","message":"Sure I will cover it . Thought it was not a new function or feature and hence did not commit the unit test.","commit_id":"b578986f2a7b651091113907197813fa4d2d2446"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"17ae6dfcf782ea1c5689f654ec5fecaeb3b67023","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        all_ram_mb \u003d compute.memory_mb"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # Assume virtual size is all consumed by instances if use qcow2 disk."},{"line_number":198,"context_line":"        free_gb \u003d compute.free_disk_gb or 0"},{"line_number":199,"context_line":"        least_gb \u003d compute.disk_available_least"},{"line_number":200,"context_line":"        if least_gb is not None:"},{"line_number":201,"context_line":"            if least_gb \u003e free_gb:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_cdcdee87","line":198,"updated":"2015-11-30 20:12:01.000000000","message":"usually this kind of changes need some unit test\nyou can reach nova/tests/unit/scheduler/*\nfor some samples there","commit_id":"da3a16f1d67059f08b3710eeb253922fb9df7c20"},{"author":{"_account_id":19318,"name":"aginwala","email":"aginwala@ebaysf.com","username":"aginwala"},"change_message_id":"eaf0420e9d1a0c59363e83bb5401aeafaf4bcfe8","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        all_ram_mb \u003d compute.memory_mb"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # Assume virtual size is all consumed by instances if use qcow2 disk."},{"line_number":198,"context_line":"        free_gb \u003d compute.free_disk_gb or 0"},{"line_number":199,"context_line":"        least_gb \u003d compute.disk_available_least"},{"line_number":200,"context_line":"        if least_gb is not None:"},{"line_number":201,"context_line":"            if least_gb \u003e free_gb:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_2d16fa55","line":198,"in_reply_to":"9a8ffd7b_cdcdee87","updated":"2015-11-30 20:22:03.000000000","message":"The fake values are already initialized to 0 in the fake tests functions with dummy values and hence this is not over riding any features so was wandering whether we still need one unit test.","commit_id":"da3a16f1d67059f08b3710eeb253922fb9df7c20"}]}