)]}'
{"nova/tests/unit/db/test_db_api.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"d436e5e91ca0fe23fb17a03815eb50d4257e0d96","unresolved":false,"context_lines":[{"line_number":9250,"context_line":""},{"line_number":9251,"context_line":"        # exception was successfully caught"},{"line_number":9252,"context_line":"        db.instance_info_cache_update(self.context, instance2.uuid,"},{"line_number":9253,"context_line":"                                      {\u0027instance_uuid\u0027: instance1.uuid})"},{"line_number":9254,"context_line":""},{"line_number":9255,"context_line":"        info_cache1 \u003d db.instance_info_cache_get(self.context, instance1.uuid)"},{"line_number":9256,"context_line":"        self.assertEqual(network_info1, info_cache1.network_info)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_d84ce69f","line":9253,"updated":"2015-11-30 12:47:01.000000000","message":"Heh, this is probably a bit of a hack (in a sense, that we update the instance_uuid value, but only network_info in runtime), still, it allows to hit the except clause in the implementation easily without any mocks.","commit_id":"31399a77591dcda4b06556a305229ad97eec6d44"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"caca4019a4023bf3da392b5a977af4feb029bbc5","unresolved":false,"context_lines":[{"line_number":9437,"context_line":"        db.instance_info_cache_update(self.context, instance2.uuid,"},{"line_number":9438,"context_line":"                                      {\u0027network_info\u0027: network_info2})"},{"line_number":9439,"context_line":""},{"line_number":9440,"context_line":"        # exception was successfully caught"},{"line_number":9441,"context_line":"        db.instance_info_cache_update(self.context, instance2.uuid,"},{"line_number":9442,"context_line":"                                      {\u0027instance_uuid\u0027: instance1.uuid})"},{"line_number":9443,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_1a0fda88","line":9440,"updated":"2016-02-17 21:39:51.000000000","message":"It would be good to get a short comment explaining why this raises the exception.","commit_id":"c4d6840b25b616921445111743cabd1daf0f347b"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"ceec5c12673181172191b04b06a9c354fe9dfa50","unresolved":false,"context_lines":[{"line_number":9437,"context_line":"        db.instance_info_cache_update(self.context, instance2.uuid,"},{"line_number":9438,"context_line":"                                      {\u0027network_info\u0027: network_info2})"},{"line_number":9439,"context_line":""},{"line_number":9440,"context_line":"        # exception was successfully caught"},{"line_number":9441,"context_line":"        db.instance_info_cache_update(self.context, instance2.uuid,"},{"line_number":9442,"context_line":"                                      {\u0027instance_uuid\u0027: instance1.uuid})"},{"line_number":9443,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_2c7cd871","line":9440,"in_reply_to":"dae33548_1a0fda88","updated":"2016-02-19 13:04:13.000000000","message":"Done","commit_id":"c4d6840b25b616921445111743cabd1daf0f347b"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4187b6d4f9e848d0bbcd5a2fa21156e7569fc4a1","unresolved":false,"context_lines":[{"line_number":9388,"context_line":"class TestInstanceInfoCache(test.TestCase):"},{"line_number":9389,"context_line":"    def setUp(self):"},{"line_number":9390,"context_line":"        super(TestInstanceInfoCache, self).setUp()"},{"line_number":9391,"context_line":"        self.user_id \u003d \u0027fake\u0027"},{"line_number":9392,"context_line":"        self.project_id \u003d \u0027fake\u0027"},{"line_number":9393,"context_line":"        self.context \u003d context.RequestContext(self.user_id, self.project_id)"},{"line_number":9394,"context_line":""},{"line_number":9395,"context_line":"    def test_instance_info_cache_get(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_496da097","line":9392,"range":{"start_line":9391,"start_character":7,"end_line":9392,"end_character":32},"updated":"2016-02-20 12:43:44.000000000","message":"user_id and project_id are not used by tests, so do we really need these 2 fields?","commit_id":"b063041c50c5981f293045080b27c6b45d5d605f"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"c987ad2398e306ddbec629b0b790898ed8c713a6","unresolved":false,"context_lines":[{"line_number":9388,"context_line":"class TestInstanceInfoCache(test.TestCase):"},{"line_number":9389,"context_line":"    def setUp(self):"},{"line_number":9390,"context_line":"        super(TestInstanceInfoCache, self).setUp()"},{"line_number":9391,"context_line":"        self.user_id \u003d \u0027fake\u0027"},{"line_number":9392,"context_line":"        self.project_id \u003d \u0027fake\u0027"},{"line_number":9393,"context_line":"        self.context \u003d context.RequestContext(self.user_id, self.project_id)"},{"line_number":9394,"context_line":""},{"line_number":9395,"context_line":"    def test_instance_info_cache_get(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_891208b3","line":9392,"range":{"start_line":9391,"start_character":7,"end_line":9392,"end_character":32},"in_reply_to":"bae84128_496da097","updated":"2016-02-20 12:57:12.000000000","message":"Actually they are not, but I like variables more than just writing \u0027fake, fake\u0027 in creating context (e.g. in Db testcase the sutiation is the same https://github.com/openstack/nova/blob/master/nova/tests/unit/db/test_db_api.py#L138-#L140)","commit_id":"b063041c50c5981f293045080b27c6b45d5d605f"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"dc29d6f2c4005257f99f6c92cb61c99e96ddc76d","unresolved":false,"context_lines":[{"line_number":9388,"context_line":"class TestInstanceInfoCache(test.TestCase):"},{"line_number":9389,"context_line":"    def setUp(self):"},{"line_number":9390,"context_line":"        super(TestInstanceInfoCache, self).setUp()"},{"line_number":9391,"context_line":"        self.user_id \u003d \u0027fake\u0027"},{"line_number":9392,"context_line":"        self.project_id \u003d \u0027fake\u0027"},{"line_number":9393,"context_line":"        self.context \u003d context.RequestContext(self.user_id, self.project_id)"},{"line_number":9394,"context_line":""},{"line_number":9395,"context_line":"    def test_instance_info_cache_get(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_2ee7d4ac","line":9392,"range":{"start_line":9391,"start_character":7,"end_line":9392,"end_character":32},"in_reply_to":"bae84128_6936a404","updated":"2016-02-24 12:35:15.000000000","message":"ok, done","commit_id":"b063041c50c5981f293045080b27c6b45d5d605f"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"803f5e0e518b2e07ae1ce1e6ca3e48b04f51ecfc","unresolved":false,"context_lines":[{"line_number":9388,"context_line":"class TestInstanceInfoCache(test.TestCase):"},{"line_number":9389,"context_line":"    def setUp(self):"},{"line_number":9390,"context_line":"        super(TestInstanceInfoCache, self).setUp()"},{"line_number":9391,"context_line":"        self.user_id \u003d \u0027fake\u0027"},{"line_number":9392,"context_line":"        self.project_id \u003d \u0027fake\u0027"},{"line_number":9393,"context_line":"        self.context \u003d context.RequestContext(self.user_id, self.project_id)"},{"line_number":9394,"context_line":""},{"line_number":9395,"context_line":"    def test_instance_info_cache_get(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_6936a404","line":9392,"range":{"start_line":9391,"start_character":7,"end_line":9392,"end_character":32},"in_reply_to":"bae84128_891208b3","updated":"2016-02-20 13:16:36.000000000","message":"I\u0027d prefer local variable here.","commit_id":"b063041c50c5981f293045080b27c6b45d5d605f"}]}