)]}'
{"nova/scheduler/host_manager.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f7080dd9a90c96d3910c5bbfde87d19d51835f42","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                if name_to_cls_map:"},{"line_number":522,"context_line":"                    return name_to_cls_map.values()"},{"line_number":523,"context_line":"                else:"},{"line_number":524,"context_line":"                    return []"},{"line_number":525,"context_line":"            hosts \u003d six.itervalues(name_to_cls_map)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        return self.filter_handler.get_filtered_objects(filters,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_df84d5d3","line":524,"updated":"2015-11-30 10:19:10.000000000","message":"We\u0027d better have log at here, to tell operator what happened at here.\n\nFor example, there is log at 307 in https://review.openstack.org/#/c/15702/6/nova/scheduler/host_manager.py\n\nI\u0027m also thinking of another way, whether we can check host existed in the beginning. for example, https://github.com/openstack/nova/blob/master/nova/compute/api.py#L983 we only have one forced_host actually, so we can check it in the early stage and feedback to the user.","commit_id":"f400b4c0820f0ff969ba693766895096d5a15b73"},{"author":{"_account_id":15648,"name":"Yingxin","email":"yingxin.cheng@intel.com","username":"Yingxin"},"change_message_id":"31c6d85770ea63a53d666651b429d174ebf9d935","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                if name_to_cls_map:"},{"line_number":522,"context_line":"                    return name_to_cls_map.values()"},{"line_number":523,"context_line":"                else:"},{"line_number":524,"context_line":"                    return []"},{"line_number":525,"context_line":"            hosts \u003d six.itervalues(name_to_cls_map)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        return self.filter_handler.get_filtered_objects(filters,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_db78f8f4","line":524,"in_reply_to":"9a8ffd7b_df84d5d3","updated":"2015-12-07 03:27:40.000000000","message":"\u003e We\u0027d better have log at here, to tell operator what happened at here. For example, there is log at 307 in https://review.openstack.org/#/c/15702/6/nova/scheduler/host_manager.py\n\nThere are logs between #L456-496. E.g. if there are no name_to_cls_map, the log will be \"No nodes matched due to not matching \u0027force_nodes(hosts)\u0027 value of ...\"\n\n\u003e I\u0027m also thinking of another way, whether we can check host existed in the beginning. for example, https://github.com/openstack/nova/blob/master/nova/compute/api.py#L983 we only have one forced_host actually, so we can check it in the early stage and feedback to the user.\n\nI think it is better to be checked inside scheduler. Since there could be changes about force_hosts https://github.com/openstack/nova/blob/master/nova/compute/api.py#L562-L565","commit_id":"f400b4c0820f0ff969ba693766895096d5a15b73"}]}