)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3d16fc2f1e08335c3a76e33cd4b12c885472aab2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds ability to enable Fault tolerance (FT) on a VM"},{"line_number":10,"context_line":"within vcenter cluster. On Nova, when instance is launched"},{"line_number":11,"context_line":"with \"--meta ft-policy\u003dtrue\". The VM will be enabled with FT protection"},{"line_number":12,"context_line":"from failures of CPU, network, and storage. The faied vm will be"},{"line_number":13,"context_line":"automatically recovered with well kept runtime context."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_5d9d71ba","line":11,"updated":"2015-12-03 14:45:19.000000000","message":"is this something that we want a usual tenant to be able to leverage. this may lead them to exploit the resources that they have on the VC.\ni think that only an admin should be able to do this. maybe consider providing this as a flavor extra_spec","commit_id":"298cbd9c04fcd14b89254d01b835ec6a628c4e2b"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"4fff597e4ec8bc3401408f893d72f971dba606f0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds ability to enable Fault tolerance (FT) on a VM"},{"line_number":10,"context_line":"within vcenter cluster. On Nova, when instance is launched"},{"line_number":11,"context_line":"with \"--meta ft-policy\u003dtrue\". The VM will be enabled with FT protection"},{"line_number":12,"context_line":"from failures of CPU, network, and storage. The faied vm will be"},{"line_number":13,"context_line":"automatically recovered with well kept runtime context."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_48ed5c8a","line":11,"in_reply_to":"9a8ffd7b_5d9d71ba","updated":"2015-12-04 09:18:33.000000000","message":"Done","commit_id":"298cbd9c04fcd14b89254d01b835ec6a628c4e2b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8a15f182af73fde1dc3754d77dd5c45d088e31ab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Enable Fault tolerance on VM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds ability to enable Fault tolerance (FT) on a VM"},{"line_number":10,"context_line":"within vcenter cluster. On Nova, when instance is launched"},{"line_number":11,"context_line":"with a flavour of extra_spec set as \"vmware:ft-policy\u003dtrue\"."},{"line_number":12,"context_line":"The VM will be enabled with FT protection from failures of CPU,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a740942_4dce83b5","line":9,"updated":"2015-12-07 09:03:30.000000000","message":"ability \u003d\u003e the ability","commit_id":"f60974fa09aa0a3719867e3311ce588a06d48e4c"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"48382f3777d0aaa400dd67b182a4060a60c027dc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Enable Fault tolerance on VM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds ability to enable Fault tolerance (FT) on a VM"},{"line_number":10,"context_line":"within vcenter cluster. On Nova, when instance is launched"},{"line_number":11,"context_line":"with a flavour of extra_spec set as \"vmware:ft-policy\u003dtrue\"."},{"line_number":12,"context_line":"The VM will be enabled with FT protection from failures of CPU,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a740942_ff3eb989","line":9,"in_reply_to":"7a740942_4dce83b5","updated":"2015-12-08 08:04:18.000000000","message":"Done","commit_id":"f60974fa09aa0a3719867e3311ce588a06d48e4c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8a15f182af73fde1dc3754d77dd5c45d088e31ab","unresolved":false,"context_lines":[{"line_number":10,"context_line":"within vcenter cluster. On Nova, when instance is launched"},{"line_number":11,"context_line":"with a flavour of extra_spec set as \"vmware:ft-policy\u003dtrue\"."},{"line_number":12,"context_line":"The VM will be enabled with FT protection from failures of CPU,"},{"line_number":13,"context_line":"network, and storage. The faied vm will be automatically recovered"},{"line_number":14,"context_line":"with well kept runtime context."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint vmware-enable-ft"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a740942_8d3b0b9c","line":13,"updated":"2015-12-07 09:03:30.000000000","message":"faied \u003d\u003e failed","commit_id":"f60974fa09aa0a3719867e3311ce588a06d48e4c"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"48382f3777d0aaa400dd67b182a4060a60c027dc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"within vcenter cluster. On Nova, when instance is launched"},{"line_number":11,"context_line":"with a flavour of extra_spec set as \"vmware:ft-policy\u003dtrue\"."},{"line_number":12,"context_line":"The VM will be enabled with FT protection from failures of CPU,"},{"line_number":13,"context_line":"network, and storage. The faied vm will be automatically recovered"},{"line_number":14,"context_line":"with well kept runtime context."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint vmware-enable-ft"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a740942_1f44e518","line":13,"in_reply_to":"7a740942_8d3b0b9c","updated":"2015-12-08 08:04:18.000000000","message":"Done","commit_id":"f60974fa09aa0a3719867e3311ce588a06d48e4c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8a15f182af73fde1dc3754d77dd5c45d088e31ab","unresolved":false,"context_lines":[{"line_number":13,"context_line":"network, and storage. The faied vm will be automatically recovered"},{"line_number":14,"context_line":"with well kept runtime context."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint vmware-enable-ft"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I4edd7603ca3f0234b11008d53b02508b4f5d94ca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a740942_ad04c7bf","line":16,"updated":"2015-12-07 09:03:30.000000000","message":"My concern with this is how it will affect the scheduler. The scheduler will not be aware of the extra resources that need to be allocated.\n\nPlease add DocImpact and add the release note","commit_id":"f60974fa09aa0a3719867e3311ce588a06d48e4c"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"48382f3777d0aaa400dd67b182a4060a60c027dc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"network, and storage. The faied vm will be automatically recovered"},{"line_number":14,"context_line":"with well kept runtime context."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint vmware-enable-ft"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I4edd7603ca3f0234b11008d53b02508b4f5d94ca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a740942_df4add25","line":16,"in_reply_to":"7a740942_ad04c7bf","updated":"2015-12-08 08:04:18.000000000","message":"Done","commit_id":"f60974fa09aa0a3719867e3311ce588a06d48e4c"}],"nova/tests/unit/virt/vmwareapi/test_configdrive.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7e9c780d7f32be9df3dff648befe5683df613c52","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.test_instance.flavor \u003d objects.Flavor(vcpus\u003d4, memory_mb\u003d8192,"},{"line_number":84,"context_line":"                                                   ephemeral_gb\u003d0, swap\u003d0,"},{"line_number":85,"context_line":"                                                   extra_specs\u003d{})"},{"line_number":86,"context_line":"        self.test_instance.metadata \u003d {}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        (image_service, image_id) \u003d glance.get_remote_image_service(context,"},{"line_number":89,"context_line":"                                    image_ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_86fed069","line":86,"updated":"2015-12-04 10:46:37.000000000","message":"why do we still need this?","commit_id":"699dcb9647d6d919f9bf66cf92022bee05b0c905"}],"nova/tests/unit/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7e9c780d7f32be9df3dff648befe5683df613c52","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        self.uuid \u003d uuid"},{"line_number":348,"context_line":"        self.instance \u003d fake_instance.fake_instance_obj("},{"line_number":349,"context_line":"                self.context, **values)"},{"line_number":350,"context_line":"        self.instance.metadata \u003d {}"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    def _create_vm(self, node\u003dNone, num_instances\u003d1, uuid\u003dNone,"},{"line_number":353,"context_line":"                   instance_type\u003d\u0027m1.large\u0027, powered_on\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_46f9c87f","line":350,"updated":"2015-12-04 10:46:37.000000000","message":"ditto","commit_id":"699dcb9647d6d919f9bf66cf92022bee05b0c905"}],"nova/tests/unit/virt/vmwareapi/test_vmops.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7e9c780d7f32be9df3dff648befe5683df613c52","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                      extra_specs\u003d{})"},{"line_number":97,"context_line":"        self._instance.flavor \u003d self._flavor"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        self._instance.metadata \u003d {}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self._vmops \u003d vmops.VMwareVMOps(self._session, self._virtapi, None,"},{"line_number":102,"context_line":"                                        cluster\u003dcluster.obj)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_c62b78ea","line":99,"updated":"2015-12-04 10:46:37.000000000","message":"ditto","commit_id":"699dcb9647d6d919f9bf66cf92022bee05b0c905"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a61fbd3869b86be09424a34bb044db41f0224cc3","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    return metadata.get(\u0027ft-policy\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"def enable_vm_ft(session, instance, cluster, vm_ref, extra_specs):"},{"line_number":214,"context_line":"    ft_hint \u003d _get_ft_policy(extra_specs, instance)"},{"line_number":215,"context_line":"    if ft_hint is not True:"},{"line_number":216,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_34858306","line":213,"updated":"2015-12-02 09:48:24.000000000","message":"where is this code tested","commit_id":"392f51a001377c722f882a89018395eb8d09a5de"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"81aa4192bd7188f1eb624cab474050cfdd57436a","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    return metadata.get(\u0027ft-policy\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"def enable_vm_ft(session, instance, cluster, vm_ref, extra_specs):"},{"line_number":214,"context_line":"    ft_hint \u003d _get_ft_policy(extra_specs, instance)"},{"line_number":215,"context_line":"    if ft_hint is not True:"},{"line_number":216,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_4c888071","line":213,"in_reply_to":"9a8ffd7b_34858306","updated":"2015-12-03 06:57:00.000000000","message":"done","commit_id":"392f51a001377c722f882a89018395eb8d09a5de"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a61fbd3869b86be09424a34bb044db41f0224cc3","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            session.vim, \"CreateSecondaryVM_Task\", vm_ref)"},{"line_number":220,"context_line":"        session._wait_for_task(reconfig_task)"},{"line_number":221,"context_line":"    except Exception:"},{"line_number":222,"context_line":"        LOG.exception(_LE(\u0027Enable VM FT failed\u0027), instance\u003dinstance)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"def get_vm_create_spec(client_factory, instance, data_store_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_748b0b1f","line":222,"updated":"2015-12-02 09:48:24.000000000","message":"why do we need a log exception here? why not log error? if this fails then the exception should be raised. it feels like that defeats the purpose of this feature","commit_id":"392f51a001377c722f882a89018395eb8d09a5de"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"81aa4192bd7188f1eb624cab474050cfdd57436a","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            session.vim, \"CreateSecondaryVM_Task\", vm_ref)"},{"line_number":220,"context_line":"        session._wait_for_task(reconfig_task)"},{"line_number":221,"context_line":"    except Exception:"},{"line_number":222,"context_line":"        LOG.exception(_LE(\u0027Enable VM FT failed\u0027), instance\u003dinstance)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"def get_vm_create_spec(client_factory, instance, data_store_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_cc94708c","line":222,"in_reply_to":"9a8ffd7b_748b0b1f","updated":"2015-12-03 06:57:00.000000000","message":"done","commit_id":"392f51a001377c722f882a89018395eb8d09a5de"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3d16fc2f1e08335c3a76e33cd4b12c885472aab2","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        return"},{"line_number":225,"context_line":"    try:"},{"line_number":226,"context_line":"        reconfig_task \u003d session._call_method("},{"line_number":227,"context_line":"            session.vim, \"CreateSecondaryVM_Task\", vm_ref)"},{"line_number":228,"context_line":"        session._wait_for_task(reconfig_task)"},{"line_number":229,"context_line":"    except Exception as err:"},{"line_number":230,"context_line":"        LOG.error(_LE(u\u0027Enable VM FT failed: %s\u0027), err)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_bdb7bd1f","line":227,"updated":"2015-12-03 14:45:19.000000000","message":"the try should be around the _wait_for task\n\ni am still not sure why we do not raise here as the user would not be getting the service they requested","commit_id":"298cbd9c04fcd14b89254d01b835ec6a628c4e2b"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"4fff597e4ec8bc3401408f893d72f971dba606f0","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        return"},{"line_number":225,"context_line":"    try:"},{"line_number":226,"context_line":"        reconfig_task \u003d session._call_method("},{"line_number":227,"context_line":"            session.vim, \"CreateSecondaryVM_Task\", vm_ref)"},{"line_number":228,"context_line":"        session._wait_for_task(reconfig_task)"},{"line_number":229,"context_line":"    except Exception as err:"},{"line_number":230,"context_line":"        LOG.error(_LE(u\u0027Enable VM FT failed: %s\u0027), err)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_6772cce7","line":227,"in_reply_to":"9a8ffd7b_bdb7bd1f","updated":"2015-12-04 09:18:33.000000000","message":"I will let raise happen and log message for convenience of debug","commit_id":"298cbd9c04fcd14b89254d01b835ec6a628c4e2b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3d16fc2f1e08335c3a76e33cd4b12c885472aab2","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            session.vim, \"CreateSecondaryVM_Task\", vm_ref)"},{"line_number":228,"context_line":"        session._wait_for_task(reconfig_task)"},{"line_number":229,"context_line":"    except Exception as err:"},{"line_number":230,"context_line":"        LOG.error(_LE(u\u0027Enable VM FT failed: %s\u0027), err)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"def get_vm_create_spec(client_factory, instance, data_store_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_9d8e7977","line":230,"updated":"2015-12-03 14:45:19.000000000","message":"why the u\u0027?","commit_id":"298cbd9c04fcd14b89254d01b835ec6a628c4e2b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7e9c780d7f32be9df3dff648befe5683df613c52","unresolved":false,"context_lines":[{"line_number":206,"context_line":"def _get_ft_policy(extra_specs, instance):"},{"line_number":207,"context_line":"    if extra_specs.ft_policy:"},{"line_number":208,"context_line":"        return extra_specs.ft_policy"},{"line_number":209,"context_line":"    metadata \u003d dict(instance.metadata)"},{"line_number":210,"context_line":"    return metadata.get(\u0027ft-policy\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_46278812","line":209,"updated":"2015-12-04 10:46:37.000000000","message":"why the metadata? That is something that should not be provided to a tenant. My point here is, why would a cloud operator enable a tenant to have the ability to spin up 2 vm\u0027s.\nWhat does this imply for the scheduling? How will we deal with that?","commit_id":"699dcb9647d6d919f9bf66cf92022bee05b0c905"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"d12c7416da745c24fd3eace9e000508fa7c068ff","unresolved":false,"context_lines":[{"line_number":206,"context_line":"def _get_ft_policy(extra_specs, instance):"},{"line_number":207,"context_line":"    if extra_specs.ft_policy:"},{"line_number":208,"context_line":"        return extra_specs.ft_policy"},{"line_number":209,"context_line":"    metadata \u003d dict(instance.metadata)"},{"line_number":210,"context_line":"    return metadata.get(\u0027ft-policy\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_6fb057de","line":209,"in_reply_to":"7a740942_46278812","updated":"2015-12-04 11:47:12.000000000","message":"Done","commit_id":"699dcb9647d6d919f9bf66cf92022bee05b0c905"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8a15f182af73fde1dc3754d77dd5c45d088e31ab","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"def enable_vm_ft(session, instance, cluster, vm_ref, extra_specs):"},{"line_number":207,"context_line":"    ft_enable \u003d None"},{"line_number":208,"context_line":"    if extra_specs.ft_policy:"},{"line_number":209,"context_line":"        ft_enable \u003d extra_specs.ft_policy"},{"line_number":210,"context_line":"    if ft_enable is not True:"},{"line_number":211,"context_line":"        return"},{"line_number":212,"context_line":"    reconfig_task \u003d session._call_method("},{"line_number":213,"context_line":"        session.vim, \"CreateSecondaryVM_Task\", vm_ref)"},{"line_number":214,"context_line":"    LOG.debug(\"Enabling FT on VM\", instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_8d622bac","line":211,"range":{"start_line":207,"start_character":0,"end_line":211,"end_character":14},"updated":"2015-12-07 09:03:30.000000000","message":"lines 207 \u003d\u003e 211 could be:\nif not extra_specs.ft_policy:\n    return","commit_id":"f60974fa09aa0a3719867e3311ce588a06d48e4c"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"48382f3777d0aaa400dd67b182a4060a60c027dc","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    if extra_specs.ft_policy:"},{"line_number":209,"context_line":"        ft_enable \u003d extra_specs.ft_policy"},{"line_number":210,"context_line":"    if ft_enable is not True:"},{"line_number":211,"context_line":"        return"},{"line_number":212,"context_line":"    reconfig_task \u003d session._call_method("},{"line_number":213,"context_line":"        session.vim, \"CreateSecondaryVM_Task\", vm_ref)"},{"line_number":214,"context_line":"    LOG.debug(\"Enabling FT on VM\", instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_bf74b167","line":211,"in_reply_to":"7a740942_8d622bac","updated":"2015-12-08 08:04:18.000000000","message":"Done","commit_id":"f60974fa09aa0a3719867e3311ce588a06d48e4c"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3d16fc2f1e08335c3a76e33cd4b12c885472aab2","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            storage_policy \u003d flavor.extra_specs.get(\u0027vmware:storage_policy\u0027,"},{"line_number":328,"context_line":"                    CONF.vmware.pbm_default_policy)"},{"line_number":329,"context_line":"            extra_specs.storage_policy \u003d storage_policy"},{"line_number":330,"context_line":"        extra_config \u003d flavor.extra_specs.get(\u0027vmware:extra_config\u0027)"},{"line_number":331,"context_line":"        if extra_config:"},{"line_number":332,"context_line":"            try:"},{"line_number":333,"context_line":"                extra_specs.extra_config \u003d jsonutils.loads(extra_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_dd740169","line":330,"updated":"2015-12-03 14:45:19.000000000","message":"this does not look like it is related","commit_id":"298cbd9c04fcd14b89254d01b835ec6a628c4e2b"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"4fff597e4ec8bc3401408f893d72f971dba606f0","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            storage_policy \u003d flavor.extra_specs.get(\u0027vmware:storage_policy\u0027,"},{"line_number":328,"context_line":"                    CONF.vmware.pbm_default_policy)"},{"line_number":329,"context_line":"            extra_specs.storage_policy \u003d storage_policy"},{"line_number":330,"context_line":"        extra_config \u003d flavor.extra_specs.get(\u0027vmware:extra_config\u0027)"},{"line_number":331,"context_line":"        if extra_config:"},{"line_number":332,"context_line":"            try:"},{"line_number":333,"context_line":"                extra_specs.extra_config \u003d jsonutils.loads(extra_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_28b6d08a","line":330,"in_reply_to":"9a8ffd7b_dd740169","updated":"2015-12-04 09:18:33.000000000","message":"change it into specific extra_specs get","commit_id":"298cbd9c04fcd14b89254d01b835ec6a628c4e2b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8a15f182af73fde1dc3754d77dd5c45d088e31ab","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        # Create the VM"},{"line_number":302,"context_line":"        vm_ref \u003d vm_util.create_vm(self._session, instance, dc_info.vmFolder,"},{"line_number":303,"context_line":"                                   config_spec, self._root_resource_pool)"},{"line_number":304,"context_line":"        vm_util.enable_vm_ft(self._session, instance,"},{"line_number":305,"context_line":"                             self._cluster, vm_ref, extra_specs)"},{"line_number":306,"context_line":"        return vm_ref"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_edfacfbc","line":304,"updated":"2015-12-07 09:03:30.000000000","message":"i think that you need a test in test_vmops for this","commit_id":"f60974fa09aa0a3719867e3311ce588a06d48e4c"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"48382f3777d0aaa400dd67b182a4060a60c027dc","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        # Create the VM"},{"line_number":302,"context_line":"        vm_ref \u003d vm_util.create_vm(self._session, instance, dc_info.vmFolder,"},{"line_number":303,"context_line":"                                   config_spec, self._root_resource_pool)"},{"line_number":304,"context_line":"        vm_util.enable_vm_ft(self._session, instance,"},{"line_number":305,"context_line":"                             self._cluster, vm_ref, extra_specs)"},{"line_number":306,"context_line":"        return vm_ref"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_7f6ac982","line":304,"in_reply_to":"7a740942_edfacfbc","updated":"2015-12-08 08:04:18.000000000","message":"Done","commit_id":"f60974fa09aa0a3719867e3311ce588a06d48e4c"}]}