)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"682b39da7851d0b72cd053120ec301bf62e09a35","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sumant Murke \u003csumant.murke@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-01 20:18:03 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Nova.cells.messaging.instance_update_at_top assuming instance object resolved"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova.cells.messaging.instance_updatea_at_top allways assumes the instance parameter"},{"line_number":10,"context_line":"as an object but sometimes it gets dictionary of instances. This patch resolves the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_7a7bdef5","line":7,"updated":"2016-01-05 04:12:42.000000000","message":"Commit messages should start with a short 50 character or less summary on a single line (without a period). Subsequent lines should be wrapped at 72 characters.\n\nhttp://docs.openstack.org/infra/manual/developers.html#committing-a-change\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"a2abd9e0d8914a93279ac9777997c8c0384bb944"}],"nova/cells/messaging.py":[{"author":{"_account_id":18336,"name":"Sumant Murke","email":"sumant.murke@intel.com","username":"sumantmurke"},"change_message_id":"9d7a56ca3fea282db89ffce65a2a5425c0528238","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        items_to_remove \u003d [\u0027id\u0027, \u0027security_groups\u0027, \u0027volumes\u0027, \u0027cell_name\u0027,"},{"line_number":1019,"context_line":"                           \u0027name\u0027, \u0027metadata\u0027]"},{"line_number":1020,"context_line":"        if not isinstance(instance, objects_base.NovaObject):"},{"line_number":1021,"context_line":"            instance \u003d objects_base.NovaObject.obj_from_primitive(instance)"},{"line_number":1022,"context_line":"        instance.obj_reset_changes(items_to_remove)"},{"line_number":1023,"context_line":"        instance.cell_name \u003d _reverse_path(message.routing_path)"},{"line_number":1024,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_29730582","line":1021,"updated":"2015-12-01 21:51:33.000000000","message":"I am trying to use \"obj_from_primitive\" method declared in \"oslo.VersionedObject\".The API i am using is not converting it to an Instance Object\nI have couple of questions here\n1. Should I write a new method that converts obj_from_primitive in \"base.py\"  ?\n2. Dosent versioned object take care of converting the primitive to obj ?","commit_id":"a2abd9e0d8914a93279ac9777997c8c0384bb944"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"91d44c0ee168cffafb131af97c3f53e02b8293eb","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        items_to_remove \u003d [\u0027id\u0027, \u0027security_groups\u0027, \u0027volumes\u0027, \u0027cell_name\u0027,"},{"line_number":1019,"context_line":"                           \u0027name\u0027, \u0027metadata\u0027]"},{"line_number":1020,"context_line":"        if not isinstance(instance, objects_base.NovaObject):"},{"line_number":1021,"context_line":"            instance \u003d objects_base.NovaObject.obj_from_primitive(instance)"},{"line_number":1022,"context_line":"        instance.obj_reset_changes(items_to_remove)"},{"line_number":1023,"context_line":"        instance.cell_name \u003d _reverse_path(message.routing_path)"},{"line_number":1024,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_bb0b7bd4","line":1021,"in_reply_to":"9a8ffd7b_29730582","updated":"2015-12-02 19:19:53.000000000","message":"the obj_to_primitive() method used in https://github.com/openstack/nova/blob/86fe90f7056432416ea3c2335ea8c2ad6e16b79a/nova/cells/rpcapi.py#L205 is not the opposite of this obj_from_primitive() method.  What you probably need to use is objects.Instance._from_db_object() to create the instance object.","commit_id":"a2abd9e0d8914a93279ac9777997c8c0384bb944"}]}