)]}'
{"nova/network/linux_net.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"9fd0bcd3711f88c2c08647d84bba7e5b384370d9","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    cfg.StrOpt(\u0027iptables_drop_action\u0027,"},{"line_number":122,"context_line":"               default\u003d\u0027DROP\u0027,"},{"line_number":123,"context_line":"               help\u003d(\u0027The table that iptables to jump to when a packet is \u0027"},{"line_number":124,"context_line":"                     \u0027to be dropped.\u0027)),"},{"line_number":125,"context_line":"    ]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2Fzq0%3D","line":124,"updated":"2013-03-26 19:45:57.000000000","message":"The parentheses around the help text aren\u0027t strictly necessary (femtonit)","commit_id":"c9e3d539222233037820b7f74301247f631cd066"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a4e486152d180bec001f668ab37d1989aaf25ded","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    cfg.StrOpt(\u0027iptables_drop_action\u0027,"},{"line_number":122,"context_line":"               default\u003d\u0027DROP\u0027,"},{"line_number":123,"context_line":"               help\u003d(\u0027The table that iptables to jump to when a packet is \u0027"},{"line_number":124,"context_line":"                     \u0027to be dropped.\u0027)),"},{"line_number":125,"context_line":"    ]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2FzYs%3D","line":124,"in_reply_to":"AAAAOH%2F%2FzZY%3D","updated":"2013-03-26 22:20:48.000000000","message":"*shrug* 6 of one, half-dozen of the other.  I think what the other options are doing is sufficient, and consistency would argue for this one to look like them, but…","commit_id":"c9e3d539222233037820b7f74301247f631cd066"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"ca60c9319b61182401bb82ec31fb4b6bdee0edea","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    cfg.StrOpt(\u0027iptables_drop_action\u0027,"},{"line_number":122,"context_line":"               default\u003d\u0027DROP\u0027,"},{"line_number":123,"context_line":"               help\u003d(\u0027The table that iptables to jump to when a packet is \u0027"},{"line_number":124,"context_line":"                     \u0027to be dropped.\u0027)),"},{"line_number":125,"context_line":"    ]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2FzZY%3D","line":124,"in_reply_to":"AAAAOH%2F%2Fzq0%3D","updated":"2013-03-26 22:15:10.000000000","message":"This is true, but I think its more readable this way.","commit_id":"c9e3d539222233037820b7f74301247f631cd066"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"9fd0bcd3711f88c2c08647d84bba7e5b384370d9","unresolved":false,"context_lines":[{"line_number":1494,"context_line":"            else:"},{"line_number":1495,"context_line":"                ipv4_filter.add_rule(\u0027FORWARD\u0027,"},{"line_number":1496,"context_line":"                                     (\u0027--in-interface %s -j %s\u0027"},{"line_number":1497,"context_line":"                                      % (bridge, CONF.iptables_drop_action)))"},{"line_number":1498,"context_line":"                ipv4_filter.add_rule(\u0027FORWARD\u0027,"},{"line_number":1499,"context_line":"                                     (\u0027--out-interface %s -j %s\u0027"},{"line_number":1500,"context_line":"                                      % (bridge, CONF.iptables_drop_action)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2Fzqw%3D","line":1497,"updated":"2013-03-26 19:45:57.000000000","message":"The extra parentheses around the string substitution aren\u0027t necessary (femtonit)","commit_id":"c9e3d539222233037820b7f74301247f631cd066"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a4e486152d180bec001f668ab37d1989aaf25ded","unresolved":false,"context_lines":[{"line_number":1494,"context_line":"            else:"},{"line_number":1495,"context_line":"                ipv4_filter.add_rule(\u0027FORWARD\u0027,"},{"line_number":1496,"context_line":"                                     (\u0027--in-interface %s -j %s\u0027"},{"line_number":1497,"context_line":"                                      % (bridge, CONF.iptables_drop_action)))"},{"line_number":1498,"context_line":"                ipv4_filter.add_rule(\u0027FORWARD\u0027,"},{"line_number":1499,"context_line":"                                     (\u0027--out-interface %s -j %s\u0027"},{"line_number":1500,"context_line":"                                      % (bridge, CONF.iptables_drop_action)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2FzYc%3D","line":1497,"in_reply_to":"AAAAOH%2F%2FzZU%3D","updated":"2013-03-26 22:20:48.000000000","message":"*shrug* I don\u0027t think it\u0027s a big deal, personally, but I don\u0027t have a strong opinion here, either.  I will say that what I tend to do is put the operator at the end of the line; i.e., if I were to write this line of code, it would look like:\n\n    ipv4_filter.add_rule(\u0027FORWARD\u0027,\n                         \u0027--in-interface %s -j %s\u0027 %\n                         (bridge, CONF.iptables_drop_action))\n\nThat tends to make sense to me, but I accept that some may find it a little less readable than the parenthesized version.  I don\u0027t think there\u0027s a single right answer here, though, so…","commit_id":"c9e3d539222233037820b7f74301247f631cd066"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"ca60c9319b61182401bb82ec31fb4b6bdee0edea","unresolved":false,"context_lines":[{"line_number":1494,"context_line":"            else:"},{"line_number":1495,"context_line":"                ipv4_filter.add_rule(\u0027FORWARD\u0027,"},{"line_number":1496,"context_line":"                                     (\u0027--in-interface %s -j %s\u0027"},{"line_number":1497,"context_line":"                                      % (bridge, CONF.iptables_drop_action)))"},{"line_number":1498,"context_line":"                ipv4_filter.add_rule(\u0027FORWARD\u0027,"},{"line_number":1499,"context_line":"                                     (\u0027--out-interface %s -j %s\u0027"},{"line_number":1500,"context_line":"                                      % (bridge, CONF.iptables_drop_action)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2FzZU%3D","line":1497,"in_reply_to":"AAAAOH%2F%2Fzqw%3D","updated":"2013-03-26 22:15:10.000000000","message":"This is true, but it lines the string continuation up nicely on the next line so its obviously all the one string not a new arg.","commit_id":"c9e3d539222233037820b7f74301247f631cd066"}]}