)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"6a373c97494ed40f69f115d799eefd5d75872004","unresolved":false,"context_lines":[{"line_number":10,"context_line":"use until instance was been unpaused. It is same even we detach disk"},{"line_number":11,"context_line":"with live option. When users try to attach available volume libvirt will"},{"line_number":12,"context_line":"raise exception. Log will only recored with device is in use and device"},{"line_number":13,"context_line":"is buzy. Users will probably felt confuse."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We can specify other device name, but it is not hourned in"},{"line_number":16,"context_line":"libvirt. Maybe we can just notify users when they try to attach disk to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aed3d3a_beff2300","line":13,"updated":"2016-02-26 20:46:18.000000000","message":"How about the following?\n\nIf we try to detach a disk from a puased instance, the device will remain in use until the instance is unpaused. It is the same even when detaching the disk with the \u0027live\u0027 option. When users try to attach the available volume, libvert will raise an exception. Logs only record when the device is in use and busy so users will be confused.","commit_id":"11d98443c045309e9a2c094cc5d73088147c9003"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"6a373c97494ed40f69f115d799eefd5d75872004","unresolved":false,"context_lines":[{"line_number":15,"context_line":"We can specify other device name, but it is not hourned in"},{"line_number":16,"context_line":"libvirt. Maybe we can just notify users when they try to attach disk to"},{"line_number":17,"context_line":"exist device in paused instance. Besides this situation didn\u0027t need to"},{"line_number":18,"context_line":"connect volume."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I436149e194713a714701ca4d37138faab67ce6fa"},{"line_number":21,"context_line":"Closes-Bug: 1427732"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aed3d3a_9e297f8c","line":18,"updated":"2016-02-26 20:46:18.000000000","message":"And here...\n\nWe can specify a different device name when reattaching the volume, but it is not honored by libvirt. Raise an exception when attaching a disk to an existing device in a paused instance.","commit_id":"11d98443c045309e9a2c094cc5d73088147c9003"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"6a373c97494ed40f69f115d799eefd5d75872004","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"        if (state \u003d\u003d power_state.PAUSED and"},{"line_number":1127,"context_line":"            guest.get_disk(disk_dev) is not None):"},{"line_number":1128,"context_line":"            LOG.error(_LE(\u0027Device %(device_name)s already exists in \u0027"},{"line_number":1129,"context_line":"                              \u0027paused instance. It will probably have problem \u0027"},{"line_number":1130,"context_line":"                              \u0027when try to attach volume to paused instance. \u0027"},{"line_number":1131,"context_line":"                              \u0027Plase unpause instance and reattach again.\u0027),"},{"line_number":1132,"context_line":"                          {\u0027device_name\u0027: disk_dev})"},{"line_number":1133,"context_line":"            raise exception.DevicePathInUse(path\u003dmountpoint)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_c3605438","line":1130,"range":{"start_line":1129,"start_character":48,"end_line":1130,"end_character":77},"updated":"2016-02-26 20:46:18.000000000","message":"I don\u0027t think this statement is necessary -- it isn\u0027t definitive.","commit_id":"11d98443c045309e9a2c094cc5d73088147c9003"}]}