)]}'
{"nova/compute/api.py":[{"author":{"_account_id":357,"name":"Devin Carlen","email":"devin@openstack.org","username":"devcamcar"},"change_message_id":"b30bd0bc5760d2c9e2dbdcae014c20a560394af3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import webob.exc"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from nova import block_device"},{"line_number":30,"context_line":"from nova.compute import instance_types"},{"line_number":31,"context_line":"from nova.compute import power_state"},{"line_number":32,"context_line":"from nova.compute import task_states"},{"line_number":33,"context_line":"from nova.compute import vm_states"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F7UQ%3D","line":30,"updated":"2011-12-21 19:20:52.000000000","message":"Not sure how this is better?  Normally the convention is to follow alphabetical order.\n\nfrom nova import a\nfrom nova import b\nfrom nova.a import a\nfrom nova.b import b\n\netc\n\nThis just seems really arbitrary?","commit_id":"473768cd7673cb8332b30ac4d3051461cd4ab447"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"e9d441b38abb8223332bda06d75f5365d9dcfd6d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import webob.exc"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from nova import block_device"},{"line_number":30,"context_line":"from nova.compute import instance_types"},{"line_number":31,"context_line":"from nova.compute import power_state"},{"line_number":32,"context_line":"from nova.compute import task_states"},{"line_number":33,"context_line":"from nova.compute import vm_states"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F7T4%3D","line":30,"in_reply_to":"AAAAC3%2F%2F7UQ%3D","updated":"2011-12-21 19:24:09.000000000","message":"HACKING actually says you order imports by full module path. That means you ignore the structure of the import statement in favor of the underlying module path. So here I\u0027m really ordering like this:\n\nnova.block_device\n\nnova.compute.instance_types\n\n...\n\nnova.exception","commit_id":"473768cd7673cb8332b30ac4d3051461cd4ab447"}],"nova/compute/utils.py":[{"author":{"_account_id":357,"name":"Devin Carlen","email":"devin@openstack.org","username":"devcamcar"},"change_message_id":"b30bd0bc5760d2c9e2dbdcae014c20a560394af3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from nova import db"},{"line_number":21,"context_line":"from nova import flags"},{"line_number":22,"context_line":"from nova.notifier import api as notifier_api"},{"line_number":23,"context_line":"from nova import utils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"FLAGS \u003d flags.FLAGS"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F7UM%3D","line":23,"updated":"2011-12-21 19:20:52.000000000","message":"Same comment here.  I don\u0027t see the logic behind this.","commit_id":"473768cd7673cb8332b30ac4d3051461cd4ab447"}]}