)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a86b70ac967e879dd50d1d096354c94416f50d7b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The config options  of the \"nova.conf\" section \"rdp\""},{"line_number":10,"context_line":"got moved to the new central location \"nova/conf/rdp.py\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I16e96d0a45b409ff69e449482ce3c600db347182"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a740942_aca65bbf","line":12,"updated":"2015-12-04 04:44:56.000000000","message":"\u0027Implements: blueprint centralize-config-options\u0027 should be added.","commit_id":"d66bc0e462500b6bc7a578c0647a8fd13aa9e10a"}],"nova/conf/rdp.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"912ed434b52f7b39a2d0dfb0f835a9f70ccecd00","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"enabled_opt \u003d cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":20,"context_line":"                          default\u003dFalse,"},{"line_number":21,"context_line":"                          help\u003d\u0027Enable RDP related features\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"html5_proxy_base_url \u003d cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"},{"line_number":24,"context_line":"                                  default\u003d\u0027http://127.0.0.1:6083/\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_5e593434","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":61},"updated":"2015-12-02 14:04:05.000000000","message":"nit: We concluded in one of the other reviews that the following format looks like the most readable one:\n\n    enabled_opt \u003d cfg.BoolOpt(\u0027enabled\u0027,\n            default\u003dFalse,\n            help\u003d\u0027Enable RDP related features\u0027)\n\nThat\u0027s 8 spaces from the left hand side for the arguments \"default\" and \"help\".","commit_id":"c27c920aac58edc79c38098e9bbff39ba3b98eeb"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"912ed434b52f7b39a2d0dfb0f835a9f70ccecd00","unresolved":false,"context_lines":[{"line_number":23,"context_line":"html5_proxy_base_url \u003d cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"},{"line_number":24,"context_line":"                                  default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":25,"context_line":"                                  help\u003d\u0027Location of RDP html5 console proxy, \u0027"},{"line_number":26,"context_line":"                                       \u0027in the form \"http://127.0.0.1:6083/\"\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ALL_OPTS \u003d [enabled_opt,"},{"line_number":29,"context_line":"            html5_proxy_base_url]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_3ea230fd","line":26,"updated":"2015-12-02 14:04:05.000000000","message":"Same format nit like the config option above.","commit_id":"c27c920aac58edc79c38098e9bbff39ba3b98eeb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"25b118867a7d51541c2dfcf68c3e0df1107e4cee","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"enabled_opt \u003d cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":20,"context_line":"        default\u003dFalse,"},{"line_number":21,"context_line":"        help\u003d\u0027Enable RDP related features\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_5f67ace8","line":18,"updated":"2016-01-06 10:00:03.000000000","message":"nit: I\u0027m pretty sure this space shouldn\u0027t be here, but pep8 isn\u0027t complaining so I\u0027m wrong..","commit_id":"facba9657b413959eeffe7cd1a69a1d8a3a5edd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"25b118867a7d51541c2dfcf68c3e0df1107e4cee","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"enabled_opt \u003d cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":20,"context_line":"        default\u003dFalse,"},{"line_number":21,"context_line":"        help\u003d\u0027Enable RDP related features\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"html5_proxy_base_url \u003d cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"},{"line_number":24,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_ff4a2054","line":21,"range":{"start_line":19,"start_character":26,"end_line":21,"end_character":42},"updated":"2016-01-06 10:00:03.000000000","message":"nit: could you wrap these on their own lines w/ 4 space indent (it\u0027s vastly more readable, IMO)?","commit_id":"facba9657b413959eeffe7cd1a69a1d8a3a5edd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"25b118867a7d51541c2dfcf68c3e0df1107e4cee","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def register_opts(conf):"},{"line_number":33,"context_line":"    conf.register_opts(ALL_OPTS, group\u003d\"rdp\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_df539c15","line":33,"range":{"start_line":33,"start_character":39,"end_line":33,"end_character":44},"updated":"2016-01-06 10:00:03.000000000","message":"see below","commit_id":"facba9657b413959eeffe7cd1a69a1d8a3a5edd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"25b118867a7d51541c2dfcf68c3e0df1107e4cee","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def list_opts():"},{"line_number":37,"context_line":"    return (\"rdp\", ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_9f2204a2","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":17},"updated":"2016-01-06 10:00:03.000000000","message":"This should probably be done with an OptGroup so that you can provide a description and other good stuff - see here for example: https://review.openstack.org/#/c/263763/3/nova/conf/vnc.py","commit_id":"facba9657b413959eeffe7cd1a69a1d8a3a5edd6"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"689b1424cb9f1706b07e09bbc70d44b54090e7c6","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def list_opts():"},{"line_number":37,"context_line":"    return (\"rdp\", ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a68dd71_84070581","line":37,"updated":"2016-01-25 14:47:52.000000000","message":"Only if you respin: the format for list_opts() has changed. It now expects a dict, but can handle a tuple, too. So if you respin, please change this to:\n\n    return {\"rdp\": ALL_OPTS}","commit_id":"de28e5141d81353cf2279a4f8c11abc5eddf4efa"},{"author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"change_message_id":"c3fd7c16aca856454e0f78050e5e7f6b222608c5","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def list_opts():"},{"line_number":37,"context_line":"    return (\"rdp\", ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a68dd71_623ba99d","line":37,"in_reply_to":"9a68dd71_84070581","updated":"2016-01-26 14:30:50.000000000","message":"That could be why the docs job is failing","commit_id":"de28e5141d81353cf2279a4f8c11abc5eddf4efa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"83d726ded050f420d0fe350244c520ed9b36d3b7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"enabled_opt \u003d cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":20,"context_line":"        default\u003dFalse,"},{"line_number":21,"context_line":"        help\u003d\u0027Enable RDP related features\u0027)"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a68dd71_e592439f","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":11},"updated":"2016-01-26 14:44:18.000000000","message":"nit: Drop the opt suffix (or apply it across the board, but I\u0027d rather former)","commit_id":"ca626a3cb0c0257a2a232310b0f8f316e997ac2b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"77450bd7fe756c2c2ea7ac3af756e0599070ecd6","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def list_opts():"},{"line_number":37,"context_line":"    return (\"rdp\", ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a5de9d1_01bc396b","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":28},"updated":"2016-01-27 13:32:05.000000000","message":"This should return a dict now","commit_id":"778975391cc8190d19c0d0586151950aa5a9c48b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8978c8dbbd8b110104747f3a55e9dbfaf3c4a36e","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def register_opts(conf):"},{"line_number":33,"context_line":"    conf.register_opts(ALL_OPTS, group\u003d\"rdp\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa0719c6_e176ead5","line":33,"updated":"2016-03-23 12:14:48.000000000","message":"Nit: we could now create the rdp group and add a description, but lets do that as a follow on I guess.","commit_id":"c5c539e5cbf42de6b49d930880227413b1322d2d"}],"nova/opts.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"376d3a0b73015cd0570dce775a82f167d44eb5c2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"import nova.pci.request"},{"line_number":52,"context_line":"import nova.pci.whitelist"},{"line_number":53,"context_line":"import nova.quota"},{"line_number":54,"context_line":"import nova.rdp"},{"line_number":55,"context_line":"import nova.service"},{"line_number":56,"context_line":"import nova.servicegroup.api"},{"line_number":57,"context_line":"import nova.servicegroup.drivers.zk"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_a937ba4b","line":54,"updated":"2015-12-02 18:31:14.000000000","message":"That\u0027s the one I\u0027ve overlooked. Sorry. That import should be removed too.","commit_id":"e6d9a4bae54739e85f9929220ad3f2885bd75d9d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ff90e35c206590150e2a02dd7efb3bf5fed6f6d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"             nova.keymgr.conf_key_mgr.key_mgr_opts,"},{"line_number":107,"context_line":"             nova.keymgr.keymgr_opts,"},{"line_number":108,"context_line":"         )),"},{"line_number":109,"context_line":"        nova.conf.rdp.list_opts(),"},{"line_number":110,"context_line":"        nova.conf.serial_console.list_opts(),"},{"line_number":111,"context_line":"        (\u0027spice\u0027,"},{"line_number":112,"context_line":"         itertools.chain("},{"line_number":113,"context_line":"             nova.cmd.spicehtml5proxy.opts,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a68dd71_02598d8e","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":45},"updated":"2016-01-26 14:37:52.000000000","message":"These are no longer needed. Get rid of them and your docs failure will go away. See: https://review.openstack.org/#/c/257956/16/nova/virt/opts.py","commit_id":"de28e5141d81353cf2279a4f8c11abc5eddf4efa"}],"nova/rdp/__init__.py":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"45c41ae44cb72b202db5fe079ec1d5cfbc8f58a4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#    ]"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"#CONF \u003d cfg.CONF"},{"line_number":35,"context_line":"#CONF.register_opts(rdp_opts, group\u003d\u0027rdp\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_f4260ecd","line":35,"updated":"2015-12-02 13:34:32.000000000","message":"let\u0027s just delete this? Can we delete the whole file?","commit_id":"15ea4b6985797b07d9c4e1fc4aa8c19ac5121dc7"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"912ed434b52f7b39a2d0dfb0f835a9f70ccecd00","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import nova.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"CONF \u003d nova.conf.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_6b3d5cdc","line":19,"updated":"2015-12-02 14:04:05.000000000","message":"We can delete that. The import\n\n    CONF \u003d nova.conf.CONF\n\nin the module\n\n    nova.compute.manager\n\ndoes that already. And the nova.compute.manager is the only module which uses the rdp config options. I would say we can delete the whole package \"rdp\". I didn\u0027t find any import of this package at other places in the code.","commit_id":"c27c920aac58edc79c38098e9bbff39ba3b98eeb"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"9839c664aaf52af808a0931f81018328846fee32","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import nova.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"CONF \u003d nova.conf.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_17d06f1e","line":19,"in_reply_to":"9a8ffd7b_6b3d5cdc","updated":"2015-12-02 14:48:51.000000000","message":"@Markus: Good catch! I didn\u0027t realize that the rdp package only contained this __init__.py file.","commit_id":"c27c920aac58edc79c38098e9bbff39ba3b98eeb"}]}