)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"6cae68d27428c1bc13886fd349d8663baa8409f8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Add tests for migration"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Fix instance_type_access_add method"},{"line_number":17,"context_line":"\tReplace Select then Insert -\u003e Try to Insert."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"blueprint db-enforce-unique-keys"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAOX%2F%2F8aE%3D","line":17,"updated":"2013-04-04 22:51:52.000000000","message":"attonit: There\u0027s a tab on this line…","commit_id":"5248653c7b14a6a01f2d5886d3d5c32d48e6ad34"}],"nova/tests/test_migrations.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"138052d14511a621fecdd11046979a1ee385af3b","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        it_projects \u003d get_table(engine, \u0027instance_type_projects\u0027)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        deleted \u003d it_projects.c.deleted \u003d\u003d it_projects.c.id"},{"line_number":1178,"context_line":"        not_deleted \u003d it_projects.c.deleted !\u003d it_projects.c.id"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"        projects_pr1 \u003d it_projects.select().\\"},{"line_number":1181,"context_line":"                        where(it_projects.c.project_id \u003d\u003d \u0027pr1\u0027).\\"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2FxsY%3D","line":1178,"updated":"2013-03-27 22:05:11.000000000","message":"Even though it will probably have the same result, I think this \"not_deleted\" test is not a good representation of the expected behavior of the deleted column.\n\nThe actual test is \"deleted !\u003d default_deleted_value\" or, in this case, \"deleted !\u003d 0\". I would like to see that here.","commit_id":"f7fffb737912881b58dffc85d67c80178516cca4"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"43f83d13cc3ba9968f906c9becca6849c3553948","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        it_projects \u003d get_table(engine, \u0027instance_type_projects\u0027)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        deleted \u003d it_projects.c.deleted \u003d\u003d it_projects.c.id"},{"line_number":1178,"context_line":"        not_deleted \u003d it_projects.c.deleted !\u003d it_projects.c.id"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"        projects_pr1 \u003d it_projects.select().\\"},{"line_number":1181,"context_line":"                        where(it_projects.c.project_id \u003d\u003d \u0027pr1\u0027).\\"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2Fxbs%3D","line":1178,"in_reply_to":"AAAAOH%2F%2FxsY%3D","updated":"2013-03-28 03:54:41.000000000","message":"Ok i will fix it.. Thanks","commit_id":"f7fffb737912881b58dffc85d67c80178516cca4"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"235681a63ca5380dd37f850ae00ab309ee769334","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"        self.assertEqual(1, len(get_(\u0027pr1\u0027, \u002731\u0027, True)))"},{"line_number":1227,"context_line":"        self.assertEqual(1, len(get_(\u0027pr2\u0027, \u002731\u0027, False)))"},{"line_number":1228,"context_line":"        self.assertRaises(sqlalchemy.exc.IntegrityError,"},{"line_number":1229,"context_line":"                          it_projects.insert().execute,"},{"line_number":1230,"context_line":"                          dict(instance_type\u003d31, project_id\u003d\u0027pr1\u0027, deleted\u003d0))"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F8b0%3D","line":1229,"updated":"2013-04-04 22:34:46.000000000","message":"Shouldn\u0027t this be `execute()`?","commit_id":"5248653c7b14a6a01f2d5886d3d5c32d48e6ad34"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"242e3398214c1fad5b94981219f8fc26f0dc2093","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"        self.assertEqual(1, len(get_(\u0027pr1\u0027, \u002731\u0027, True)))"},{"line_number":1227,"context_line":"        self.assertEqual(1, len(get_(\u0027pr2\u0027, \u002731\u0027, False)))"},{"line_number":1228,"context_line":"        self.assertRaises(sqlalchemy.exc.IntegrityError,"},{"line_number":1229,"context_line":"                          it_projects.insert().execute,"},{"line_number":1230,"context_line":"                          dict(instance_type\u003d31, project_id\u003d\u0027pr1\u0027, deleted\u003d0))"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F8as%3D","line":1229,"in_reply_to":"AAAAOX%2F%2F8a0%3D","updated":"2013-04-04 22:43:06.000000000","message":"np thanks for reviews\u003d)","commit_id":"5248653c7b14a6a01f2d5886d3d5c32d48e6ad34"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"eddc0ec7932cf0ced8e71004a8b933a78a1b7c86","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"        self.assertEqual(1, len(get_(\u0027pr1\u0027, \u002731\u0027, True)))"},{"line_number":1227,"context_line":"        self.assertEqual(1, len(get_(\u0027pr2\u0027, \u002731\u0027, False)))"},{"line_number":1228,"context_line":"        self.assertRaises(sqlalchemy.exc.IntegrityError,"},{"line_number":1229,"context_line":"                          it_projects.insert().execute,"},{"line_number":1230,"context_line":"                          dict(instance_type\u003d31, project_id\u003d\u0027pr1\u0027, deleted\u003d0))"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F8bU%3D","line":1229,"in_reply_to":"AAAAOX%2F%2F8b0%3D","updated":"2013-04-04 22:37:39.000000000","message":"Nope..\nassertRaises will call second parameter with parameters that are after second and check that in that case it raises IntegrityError.","commit_id":"5248653c7b14a6a01f2d5886d3d5c32d48e6ad34"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"2f038da4d46ac14cba36a39cf670c499e216079d","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"        self.assertEqual(1, len(get_(\u0027pr1\u0027, \u002731\u0027, True)))"},{"line_number":1227,"context_line":"        self.assertEqual(1, len(get_(\u0027pr2\u0027, \u002731\u0027, False)))"},{"line_number":1228,"context_line":"        self.assertRaises(sqlalchemy.exc.IntegrityError,"},{"line_number":1229,"context_line":"                          it_projects.insert().execute,"},{"line_number":1230,"context_line":"                          dict(instance_type\u003d31, project_id\u003d\u0027pr1\u0027, deleted\u003d0))"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOX%2F%2F8a0%3D","line":1229,"in_reply_to":"AAAAOX%2F%2F8bU%3D","updated":"2013-04-04 22:41:16.000000000","message":"Ah right, sorry about that.\n\nI sorta figured I was wrong there b/c I\u0027m sure the tests were passing, but didn\u0027t see immediately why.","commit_id":"5248653c7b14a6a01f2d5886d3d5c32d48e6ad34"}]}