)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a8cea7476347eacac6b771ef849e18a6f0d71aa3","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"        # network validation, but port creation requires some details"},{"line_number":1179,"context_line":"        # from the hypervisor.  So we just check the quota and return"},{"line_number":1180,"context_line":"        # how many of the requested number of instances can be created"},{"line_number":1181,"context_line":"        if ports_needed_per_instance:"},{"line_number":1182,"context_line":"            quotas \u003d neutron.show_quota(tenant_id\u003dcontext.project_id)[\u0027quota\u0027]"},{"line_number":1183,"context_line":"            if quotas.get(\u0027port\u0027, -1) \u003d\u003d -1:"},{"line_number":1184,"context_line":"                # Unlimited Port Quota"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d202120b","line":1181,"updated":"2015-12-07 08:56:46.000000000","message":"it is really not clear why we actually need this code in the first place. why not just let the create_port fail if there is no quota.\n\nWhat is there is a parallel thread running and it needs to create a port. If say there is one port free then both will succeed with these checks and then fail when the port is created.\n\nWhat in fact does this do it has 2 call to Neutron that are effectively useless.","commit_id":"bf027800f7badf547681d64e124b60523712b4be"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a011de062df87480e42602303967e306205484e1","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"        # network validation, but port creation requires some details"},{"line_number":1179,"context_line":"        # from the hypervisor.  So we just check the quota and return"},{"line_number":1180,"context_line":"        # how many of the requested number of instances can be created"},{"line_number":1181,"context_line":"        if ports_needed_per_instance:"},{"line_number":1182,"context_line":"            quotas \u003d neutron.show_quota(tenant_id\u003dcontext.project_id)[\u0027quota\u0027]"},{"line_number":1183,"context_line":"            if quotas.get(\u0027port\u0027, -1) \u003d\u003d -1:"},{"line_number":1184,"context_line":"                # Unlimited Port Quota"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_b90b988d","line":1181,"in_reply_to":"7a740942_d202120b","updated":"2015-12-07 15:11:28.000000000","message":"See this spec https://review.openstack.org/#/c/250993/ which is attempting to address that race case.","commit_id":"bf027800f7badf547681d64e124b60523712b4be"}]}