)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"8b61639060a6247d4a852ecdadb1ce0679ef59e1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The config options of the \"nova.conf\" section \"wsgi\""},{"line_number":10,"context_line":"got moved to the new central location \"nova/conf/wsgi.py\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I4bf8ea48c374d5d35fbbd37c125607e05d3679e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a7e1126_753de88d","line":11,"updated":"2015-12-21 16:03:02.000000000","message":"Please reference to the blueprint","commit_id":"0e0b869d4e29035dc00bc76a2c314f861ed1153d"}],"nova/conf/wsgi.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1ee8d5e978f5ad2ff92e3e8a9df08e87e3d6c0ce","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"api_paste_config_opt \u003d cfg.StrOpt(\u0027api_paste_config\u0027,"},{"line_number":19,"context_line":"                                  default\u003d\"api-paste.ini\","},{"line_number":20,"context_line":"                                  help\u003d\u0027File name for the paste.deploy config for nova-api\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"wsgi_log_format_opt \u003d cfg.StrOpt(\u0027wsgi_log_format\u0027,"},{"line_number":23,"context_line":"                                 default\u003d\u0027%(client_ip)s \"%(request_line)s\" status: %(status_code)s\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_7783c803","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":92},"updated":"2015-12-03 09:27:52.000000000","message":"The readability will be increased when you use 8 spaces from the left for the arguments. For example:\n\n    api_paste_config_opt \u003d cfg.StrOpt(\u0027api_paste_config\u0027,\n            default\u003d\"api-paste.ini\",\n            help\u003d\u0027File name for the paste.deploy [...]\u0027)\n\nWhen you do this format change to all the config options here you will see that it looks much better this way.","commit_id":"810c01e244360c714ece951b0106bb435950e1cd"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"253d2932546ad0e4ff1f3404e5c0f9b9ea00f86a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"api_paste_config_opt \u003d cfg.StrOpt(\u0027api_paste_config\u0027,"},{"line_number":19,"context_line":"                                  default\u003d\"api-paste.ini\","},{"line_number":20,"context_line":"                                  help\u003d\u0027File name for the paste.deploy config for nova-api\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"wsgi_log_format_opt \u003d cfg.StrOpt(\u0027wsgi_log_format\u0027,"},{"line_number":23,"context_line":"                                 default\u003d\u0027%(client_ip)s \"%(request_line)s\" status: %(status_code)s\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_5fd8d41d","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":92},"in_reply_to":"9a8ffd7b_7783c803","updated":"2015-12-03 18:23:15.000000000","message":"Done","commit_id":"810c01e244360c714ece951b0106bb435950e1cd"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ae916923eeaed2a38ef35755f1e9aec98f5270ff","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def register_opts(conf):"},{"line_number":88,"context_line":"    conf.register_opts(ALL_OPTS, group\u003d\"wsgi\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_352620cf","line":88,"updated":"2015-12-04 12:45:54.000000000","message":"These options are in the DEFAULT group, which means this must be:\n\n    def register_opts(conf):\n        conf.register_opts(ALL_OPTS)","commit_id":"67b28c3885232f0e333ba63a10726b4b89251889"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ae916923eeaed2a38ef35755f1e9aec98f5270ff","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    conf.register_opts(ALL_OPTS, group\u003d\"wsgi\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def list_opts():"},{"line_number":92,"context_line":"    return (\"wsgi\", ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_350dc03e","line":92,"range":{"start_line":91,"start_character":0,"end_line":92,"end_character":29},"updated":"2015-12-04 12:45:54.000000000","message":"These options are in the DEFAULT group, which means this must be:\n\n    def list_opts():\n        return (\"DEFAULT\", ALL_OPTS)","commit_id":"67b28c3885232f0e333ba63a10726b4b89251889"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"24c7a86d5cfacd01f5f3395d636e3e154127c6f2","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def list_opts():"},{"line_number":92,"context_line":"    return (ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_da632f19","line":92,"updated":"2015-12-04 22:15:33.000000000","message":"This should be:\n\n    return (\"DEFAULT\", ALL_OPTS)","commit_id":"3b3205cd5f26a653152a86ba457b692ddca77162"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"5e13806ba3cd8f859743546ea0aba18cb78bf728","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def list_opts():"},{"line_number":92,"context_line":"    return (ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_239b2a74","line":92,"in_reply_to":"7a740942_da632f19","updated":"2015-12-04 23:54:24.000000000","message":"Done","commit_id":"3b3205cd5f26a653152a86ba457b692ddca77162"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f0a1c1cd4c2fd7ac9ff00600f73c865eaf1dfd7d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"api_paste_config_opt \u003d cfg.StrOpt(\u0027api_paste_config\u0027,"},{"line_number":19,"context_line":"         default\u003d\"api-paste.ini\","},{"line_number":20,"context_line":"         help\u003d\u0027File name for the paste.deploy config for nova-api\u0027)"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_ddd42821","line":18,"range":{"start_line":18,"start_character":34,"end_line":18,"end_character":53},"updated":"2016-01-05 16:42:08.000000000","message":"nit: I suggest putting this down onto the next line w/ 4 spaces (it\u0027s more readable, IMO)","commit_id":"cb6573912fc0f6d1f158899275057344120030d1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b514e8c9a26d9bcd58644becdf39d365540a3a62","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def list_opts():"},{"line_number":92,"context_line":"    return (\"DEFAULT\", ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":17,"id":"da6ed579_eb0d5ce8","line":92,"range":{"start_line":92,"start_character":11,"end_line":92,"end_character":32},"updated":"2016-01-15 14:49:21.000000000","message":"this needs to return a dict now","commit_id":"036716cb5c8be96d5aac2606665857b2045b4fd2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7c19d9388dec80f146a235163e1a2de5229052b4","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"api_paste_config_opt \u003d cfg.StrOpt(\u0027api_paste_config\u0027,"},{"line_number":19,"context_line":"         default\u003d\"api-paste.ini\","},{"line_number":20,"context_line":"         help\u003d\u0027File name for the paste.deploy config for nova-api\u0027)"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"7a5de9d1_419f915f","line":18,"range":{"start_line":18,"start_character":16,"end_line":18,"end_character":20},"updated":"2016-01-27 13:26:13.000000000","message":"nit: Remove the \u0027_opt\u0027 suffix - we\u0027re not using Hungarian notation here [1] :)\n\n[1] https://en.wikipedia.org/wiki/Hungarian_notation","commit_id":"2f16d7317cd37e864f588911b78efeabec2e6160"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"7aca28d0288476eda19e2c3fb8cf7f117d82a2af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a57f1b5_190357ba","line":1,"updated":"2016-02-09 19:27:03.000000000","message":"Just FYI, it\u0027s not proper to include this copyright unless you work for the Foundation and even then it\u0027s not necessary.","commit_id":"6b38d9cc2e3d1848a142ee2948c0530f0ecc4441"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"469cdd06aeea027b647570acfb2cff62e5af17fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a57f1b5_abf2ea04","line":1,"in_reply_to":"3a57f1b5_190357ba","updated":"2016-02-09 19:44:34.000000000","message":"thanks alaski - i will not add that going forward","commit_id":"6b38d9cc2e3d1848a142ee2948c0530f0ecc4441"}],"nova/opts.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ae916923eeaed2a38ef35755f1e9aec98f5270ff","unresolved":false,"context_lines":[{"line_number":78,"context_line":"             nova.cmd.novnc.opts,"},{"line_number":79,"context_line":"             nova.cmd.novncproxy.opts,"},{"line_number":80,"context_line":"             nova.cmd.spicehtml5proxy.opts,"},{"line_number":81,"context_line":"             nova.conf.wsgi.list_opts(),"},{"line_number":82,"context_line":"             nova.console.manager.console_manager_opts,"},{"line_number":83,"context_line":"             nova.console.rpcapi.rpcapi_opts,"},{"line_number":84,"context_line":"             nova.console.xvp.xvp_opts,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_67571b03","line":81,"updated":"2015-12-04 12:45:54.000000000","message":"This line should be in line 105 like this:\n\n    )),\n    nova.conf.wsgi.list_opts(),\n    (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),","commit_id":"67b28c3885232f0e333ba63a10726b4b89251889"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"47ba84a85c6b41d47e35bd518dc9e42c9c484cef","unresolved":false,"context_lines":[{"line_number":100,"context_line":"             nova.utils.utils_opts,"},{"line_number":101,"context_line":"             nova.vnc.vnc_opts,"},{"line_number":102,"context_line":"             nova.vnc.xvp_proxy.xvp_proxy_opts,"},{"line_number":103,"context_line":"             nova.volume._volume_opts"},{"line_number":104,"context_line":"         )),"},{"line_number":105,"context_line":"        nova.conf.wsgi.list_opts(),"},{"line_number":106,"context_line":"        (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_86ed57f1","line":103,"updated":"2015-12-04 18:33:04.000000000","message":"Please don\u0027t remove the comma. It helps to reduce this diff and future diffs if an element is added after this one.","commit_id":"b2a6f882eaf92f8f5d1ba8b946679e3a25ef8a9b"}],"nova/wsgi.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d333d6e9e32e72cff96b92aada1cb20dac9a6a4a","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class Server(service.ServiceBase):"},{"line_number":50,"context_line":"    \"\"\"Server class to manage a WSGI server, serving a WSGI application.\"\"\""},{"line_number":51,"context_line":"    default_pool_size \u003d CONF.wsgi.wsgi_default_pool_size"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, name, app, host\u003d\u00270.0.0.0\u0027, port\u003d0, pool_size\u003dNone,"},{"line_number":54,"context_line":"                       protocol\u003deventlet.wsgi.HttpProtocol, backlog\u003d128,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_7fc58d59","line":51,"updated":"2015-12-03 19:25:31.000000000","message":"nit: unrelated change (removed line)","commit_id":"67b28c3885232f0e333ba63a10726b4b89251889"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"47ba84a85c6b41d47e35bd518dc9e42c9c484cef","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class Server(service.ServiceBase):"},{"line_number":50,"context_line":"    \"\"\"Server class to manage a WSGI server, serving a WSGI application.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    default_pool_size \u003d CONF.wsgi.wsgi_default_pool_size"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def __init__(self, name, app, host\u003d\u00270.0.0.0\u0027, port\u003d0, pool_size\u003dNone,"},{"line_number":55,"context_line":"                       protocol\u003deventlet.wsgi.HttpProtocol, backlog\u003d128,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_e6821b00","line":52,"updated":"2015-12-04 18:33:04.000000000","message":"The wsgi options are still in the DEFAULT section of CONF, so they will still be referenced the same as before. This and all of the changes below that reference \u0027CONF.wsgi.foo\u0027 should be reverted back to simply being \u0027CONF.foo\u0027.","commit_id":"b2a6f882eaf92f8f5d1ba8b946679e3a25ef8a9b"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"4401409b14007eb1c2d284cf9e4ae74fe42299bc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import eventlet"},{"line_number":28,"context_line":"import eventlet.wsgi"},{"line_number":29,"context_line":"import greenlet"},{"line_number":30,"context_line":"import nova.conf"},{"line_number":31,"context_line":"from oslo_log import log as logging"},{"line_number":32,"context_line":"from oslo_service import service"},{"line_number":33,"context_line":"from oslo_utils import excutils"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a68dd71_a45896fb","line":30,"updated":"2016-01-21 15:59:38.000000000","message":"This should be in the nova section for imports, right above line 40.","commit_id":"b5eba7c09e6fc36f2ff852b945c90d9165bf60cc"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"7da55506de3b89044f6253a702fb4b78e24fee17","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import eventlet"},{"line_number":28,"context_line":"import eventlet.wsgi"},{"line_number":29,"context_line":"import greenlet"},{"line_number":30,"context_line":"import nova.conf"},{"line_number":31,"context_line":"from oslo_log import log as logging"},{"line_number":32,"context_line":"from oslo_service import service"},{"line_number":33,"context_line":"from oslo_utils import excutils"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a68dd71_1e78c28e","line":30,"in_reply_to":"9a68dd71_a45896fb","updated":"2016-01-21 19:19:50.000000000","message":"Done","commit_id":"b5eba7c09e6fc36f2ff852b945c90d9165bf60cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1752760c43288db197fce1bfde5db3b4922168e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"7a5de9d1_26c4eb3e","side":"PARENT","updated":"2016-01-27 13:13:23.000000000","message":"You changed the file mode for these files. I\u0027ve fixed for you. Hopefully that\u0027s ok.","commit_id":"c131f0e03e068199968c92152be196004c688f00"}]}