)]}'
{"doc/source/code-review.rst":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f618893ce2feae5a1996e6cd5616e92ab8dc9832","unresolved":false,"context_lines":[{"line_number":88,"context_line":"REST API"},{"line_number":89,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The design of REST API should follow"},{"line_number":92,"context_line":"`OpenStack API Working Group guideline \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"basically. It is nice to read all part of the guideline for developers and"},{"line_number":94,"context_line":"reviewers, but the guideline is very long. So here picks main points up:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a740942_4678e8c4","line":91,"updated":"2015-12-04 10:50:38.000000000","message":"I think we need a key extra bit here:\n\nWhen adding making a change to the nova API, we should always follow the API WG guidelines, rather than going for \"local\" consistency.\n\nThat was my biggest surprise in how we are enforcing these rules right now, but I think I buy into that now.","commit_id":"8778ea39b43b66dadeb7528575c6dc777522ebd5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d4d43b42794c52cbac9c7734ee39617d46566ac7","unresolved":false,"context_lines":[{"line_number":88,"context_line":"REST API"},{"line_number":89,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The design of REST API should follow"},{"line_number":92,"context_line":"`OpenStack API Working Group guideline \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"basically. It is nice to read all part of the guideline for developers and"},{"line_number":94,"context_line":"reviewers, but the guideline is very long. So here picks main points up:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a740942_6994d78a","line":91,"in_reply_to":"7a740942_4678e8c4","updated":"2015-12-04 11:11:05.000000000","message":"Nice suggestion, thanks!","commit_id":"8778ea39b43b66dadeb7528575c6dc777522ebd5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a57127115cac1e2830074cd0c315908d08e3a195","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The design of REST API should follow"},{"line_number":92,"context_line":"`OpenStack API Working Group guideline \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"basically. It is nice to read all part of the guideline for developers and"},{"line_number":94,"context_line":"reviewers, but the guideline is very long. So here picks main points up:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a740942_66e5e407","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":9},"updated":"2015-12-04 10:47:25.000000000","message":"Nit, not sure we need \"basically\" in this sentence.\n\nI think we should be stronger here:\ns/nice to read all part/should read all of/","commit_id":"8778ea39b43b66dadeb7528575c6dc777522ebd5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d4d43b42794c52cbac9c7734ee39617d46566ac7","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The design of REST API should follow"},{"line_number":92,"context_line":"`OpenStack API Working Group guideline \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"basically. It is nice to read all part of the guideline for developers and"},{"line_number":94,"context_line":"reviewers, but the guideline is very long. So here picks main points up:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a740942_49979b90","line":93,"in_reply_to":"7a740942_66e5e407","updated":"2015-12-04 11:11:05.000000000","message":"\"basically\" implies that sometime we took local consistency, so I wrote that. but the above your suggestion can remove it, thanks for it.","commit_id":"8778ea39b43b66dadeb7528575c6dc777522ebd5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a57127115cac1e2830074cd0c315908d08e3a195","unresolved":false,"context_lines":[{"line_number":91,"context_line":"The design of REST API should follow"},{"line_number":92,"context_line":"`OpenStack API Working Group guideline \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"basically. It is nice to read all part of the guideline for developers and"},{"line_number":94,"context_line":"reviewers, but the guideline is very long. So here picks main points up:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a740942_a6ec2cc8","line":94,"range":{"start_line":94,"start_character":43,"end_line":94,"end_character":71},"updated":"2015-12-04 10:47:25.000000000","message":"Here are some key points:\n\nor something similar?","commit_id":"8778ea39b43b66dadeb7528575c6dc777522ebd5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d4d43b42794c52cbac9c7734ee39617d46566ac7","unresolved":false,"context_lines":[{"line_number":91,"context_line":"The design of REST API should follow"},{"line_number":92,"context_line":"`OpenStack API Working Group guideline \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"basically. It is nice to read all part of the guideline for developers and"},{"line_number":94,"context_line":"reviewers, but the guideline is very long. So here picks main points up:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a740942_a92b9f2f","line":94,"in_reply_to":"7a740942_a6ec2cc8","updated":"2015-12-04 11:11:05.000000000","message":"Nice words, thanks","commit_id":"8778ea39b43b66dadeb7528575c6dc777522ebd5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a57127115cac1e2830074cd0c315908d08e3a195","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    * URL should not include underscores, and use ``hyphens`` instead."},{"line_number":104,"context_line":"    * The field names, which are contained in a request/response body, should"},{"line_number":105,"context_line":"      use ``snake_case`` style, not CamelCase or MixedCase style."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Config Options"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a740942_868330cc","line":106,"updated":"2015-12-04 10:47:25.000000000","message":"Probably worth highlighting the error codes and HTTP verb stuff as well?\nhttp://specs.openstack.org/openstack/api-wg/guidelines/http.html#http-response-codes","commit_id":"8778ea39b43b66dadeb7528575c6dc777522ebd5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d4d43b42794c52cbac9c7734ee39617d46566ac7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    * URL should not include underscores, and use ``hyphens`` instead."},{"line_number":104,"context_line":"    * The field names, which are contained in a request/response body, should"},{"line_number":105,"context_line":"      use ``snake_case`` style, not CamelCase or MixedCase style."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Config Options"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a740942_c92b8bea","line":106,"in_reply_to":"7a740942_868330cc","updated":"2015-12-04 11:11:05.000000000","message":"Done","commit_id":"8778ea39b43b66dadeb7528575c6dc777522ebd5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f618893ce2feae5a1996e6cd5616e92ab8dc9832","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    * URL should not include underscores, and use ``hyphens`` instead."},{"line_number":104,"context_line":"    * The field names, which are contained in a request/response body, should"},{"line_number":105,"context_line":"      use ``snake_case`` style, not CamelCase or MixedCase style."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Config Options"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a740942_a6bbcc71","line":106,"in_reply_to":"7a740942_868330cc","updated":"2015-12-04 10:50:38.000000000","message":"Maybe also add there are common patterns for things like tags and paging, without any specific links?","commit_id":"8778ea39b43b66dadeb7528575c6dc777522ebd5"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d4d43b42794c52cbac9c7734ee39617d46566ac7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    * URL should not include underscores, and use ``hyphens`` instead."},{"line_number":104,"context_line":"    * The field names, which are contained in a request/response body, should"},{"line_number":105,"context_line":"      use ``snake_case`` style, not CamelCase or MixedCase style."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Config Options"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a740942_297fafab","line":106,"in_reply_to":"7a740942_a6bbcc71","updated":"2015-12-04 11:11:05.000000000","message":"Paging: we are discussing like https://specs.openstack.org/openstack/api-wg/guidelines/pagination_filter_sort.html#pagination\n\nTags is https://specs.openstack.org/openstack/api-wg/guidelines/tags.html?highlight\u003dtag\n\nbut I cannot find nice words for summarizing it for fitting here.\nSo I will update the patch without Tags.","commit_id":"8778ea39b43b66dadeb7528575c6dc777522ebd5"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"36f7cd6b8470a351653d63ee64f68e4481a1c375","unresolved":false,"context_lines":[{"line_number":88,"context_line":"REST API"},{"line_number":89,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"When adding making a change to the nova API, we should always follow"},{"line_number":92,"context_line":"`the API WG guidelines \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"rather than going for \"local\" consistency."},{"line_number":94,"context_line":"Developers and reviewers should read all of the guideline, but the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_9bc5b78f","line":91,"updated":"2015-12-04 17:04:20.000000000","message":"s/adding making/making/","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a523ccc65993318d735a0bf5d5bfe771127b6be9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"REST API"},{"line_number":89,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"When adding making a change to the nova API, we should always follow"},{"line_number":92,"context_line":"`the API WG guidelines \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"rather than going for \"local\" consistency."},{"line_number":94,"context_line":"Developers and reviewers should read all of the guideline, but the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_b0de740f","line":91,"in_reply_to":"7a740942_9bc5b78f","updated":"2015-12-06 04:31:33.000000000","message":"Done","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"36f7cd6b8470a351653d63ee64f68e4481a1c375","unresolved":false,"context_lines":[{"line_number":91,"context_line":"When adding making a change to the nova API, we should always follow"},{"line_number":92,"context_line":"`the API WG guidelines \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"rather than going for \"local\" consistency."},{"line_number":94,"context_line":"Developers and reviewers should read all of the guideline, but the"},{"line_number":95,"context_line":"guideline is very long. So here are some key points:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_db41ff0c","line":94,"updated":"2015-12-04 17:04:20.000000000","message":"s/guideline/guidelines/","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a523ccc65993318d735a0bf5d5bfe771127b6be9","unresolved":false,"context_lines":[{"line_number":91,"context_line":"When adding making a change to the nova API, we should always follow"},{"line_number":92,"context_line":"`the API WG guidelines \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"rather than going for \"local\" consistency."},{"line_number":94,"context_line":"Developers and reviewers should read all of the guideline, but the"},{"line_number":95,"context_line":"guideline is very long. So here are some key points:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_70e80cb5","line":94,"in_reply_to":"7a740942_db41ff0c","updated":"2015-12-06 04:31:33.000000000","message":"Done","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"36f7cd6b8470a351653d63ee64f68e4481a1c375","unresolved":false,"context_lines":[{"line_number":92,"context_line":"`the API WG guidelines \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"rather than going for \"local\" consistency."},{"line_number":94,"context_line":"Developers and reviewers should read all of the guideline, but the"},{"line_number":95,"context_line":"guideline is very long. So here are some key points:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_5b6d0f97","line":95,"updated":"2015-12-04 17:04:20.000000000","message":"s/the guideline is/they are/","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a523ccc65993318d735a0bf5d5bfe771127b6be9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"`the API WG guidelines \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"rather than going for \"local\" consistency."},{"line_number":94,"context_line":"Developers and reviewers should read all of the guideline, but the"},{"line_number":95,"context_line":"guideline is very long. So here are some key points:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_90eb38b0","line":95,"in_reply_to":"7a740942_5b6d0f97","updated":"2015-12-06 04:31:33.000000000","message":"Done","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"36f7cd6b8470a351653d63ee64f68e4481a1c375","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    * ``project`` should be presented on REST API instead of ``tenant``."},{"line_number":100,"context_line":"    * ``server`` should be presented on REST API instead of ``instance``."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* `Naming Conventions \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/naming.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_7bffabaa","line":99,"updated":"2015-12-04 17:04:20.000000000","message":"s/presented on/used in the/","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a523ccc65993318d735a0bf5d5bfe771127b6be9","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    * ``project`` should be presented on REST API instead of ``tenant``."},{"line_number":100,"context_line":"    * ``server`` should be presented on REST API instead of ``instance``."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* `Naming Conventions \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/naming.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_f0dcfc13","line":99,"in_reply_to":"7a740942_7bffabaa","updated":"2015-12-06 04:31:33.000000000","message":"Done","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"36f7cd6b8470a351653d63ee64f68e4481a1c375","unresolved":false,"context_lines":[{"line_number":97,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    * ``project`` should be presented on REST API instead of ``tenant``."},{"line_number":100,"context_line":"    * ``server`` should be presented on REST API instead of ``instance``."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* `Naming Conventions \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/naming.html\u003e`_"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_fb295b38","line":100,"updated":"2015-12-04 17:04:20.000000000","message":"ibid","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a523ccc65993318d735a0bf5d5bfe771127b6be9","unresolved":false,"context_lines":[{"line_number":97,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    * ``project`` should be presented on REST API instead of ``tenant``."},{"line_number":100,"context_line":"    * ``server`` should be presented on REST API instead of ``instance``."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* `Naming Conventions \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/naming.html\u003e`_"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_10d8a81c","line":100,"in_reply_to":"7a740942_fb295b38","updated":"2015-12-06 04:31:33.000000000","message":"Done","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"36f7cd6b8470a351653d63ee64f68e4481a1c375","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* `Naming Conventions \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/naming.html\u003e`_"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    * URL should not include underscores, and use ``hyphens`` instead."},{"line_number":105,"context_line":"    * The field names, which are contained in a request/response body, should"},{"line_number":106,"context_line":"      use ``snake_case`` style, not CamelCase or MixedCase style."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_fbe07bfc","line":104,"updated":"2015-12-04 17:04:20.000000000","message":"s/underscores, and use/underscores; use/\n\nWhy should \"hyphens\" be in a code font here?  I would expect a phrasing more like:\n\n\"use hyphens (\u0027-\u0027) instead.\"","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a523ccc65993318d735a0bf5d5bfe771127b6be9","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* `Naming Conventions \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/naming.html\u003e`_"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    * URL should not include underscores, and use ``hyphens`` instead."},{"line_number":105,"context_line":"    * The field names, which are contained in a request/response body, should"},{"line_number":106,"context_line":"      use ``snake_case`` style, not CamelCase or MixedCase style."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_30fa8476","line":104,"in_reply_to":"7a740942_fbe07bfc","updated":"2015-12-06 04:31:33.000000000","message":"Nice point.\n\nIn this file, code font is not used like this patch.\nSo I will remove the font.","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"36f7cd6b8470a351653d63ee64f68e4481a1c375","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    * URL should not include underscores, and use ``hyphens`` instead."},{"line_number":105,"context_line":"    * The field names, which are contained in a request/response body, should"},{"line_number":106,"context_line":"      use ``snake_case`` style, not CamelCase or MixedCase style."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* `HTTP Response Codes \u003chttp://specs.openstack.org/openstack/api-wg/guidelines/http.html#http-response-codes\u003e`_"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_9bcb7753","line":106,"updated":"2015-12-04 17:04:20.000000000","message":"s/names, which are contained/names contained/\n\ns@request/response body, should@request/response body should@\n\nIf you\u0027re going to put \"snake_case\" in a code font, I would expect the same with \"CamelCase\" and \"MixedCase\".  Also, I\u0027m not certain the distinction between \"CamelCase\" and \"MixedCase\"…","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a523ccc65993318d735a0bf5d5bfe771127b6be9","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    * URL should not include underscores, and use ``hyphens`` instead."},{"line_number":105,"context_line":"    * The field names, which are contained in a request/response body, should"},{"line_number":106,"context_line":"      use ``snake_case`` style, not CamelCase or MixedCase style."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* `HTTP Response Codes \u003chttp://specs.openstack.org/openstack/api-wg/guidelines/http.html#http-response-codes\u003e`_"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a740942_304124aa","line":106,"in_reply_to":"7a740942_9bcb7753","updated":"2015-12-06 04:31:33.000000000","message":"how about Mixed_Case ?","commit_id":"583bba74237fee5972e3af0248a076ce0d904494"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c54f2490373f1fe0a12e7e4fb8afbaa40a07527a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"When making a change to the nova API, we should always follow"},{"line_number":92,"context_line":"`the API WG guidelines \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"rather than going for \"local\" consistency."},{"line_number":94,"context_line":"Developers and reviewers should read all of the guidelines, but they are"},{"line_number":95,"context_line":"very long. So here are some key points:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a740942_b7605502","line":95,"range":{"start_line":94,"start_character":0,"end_line":95,"end_character":9},"updated":"2015-12-08 09:22:55.000000000","message":"Caution, the following is an open question. Considering that the existing is not enforcing the API WG rules, are we planning to have some eventual consistency in a later cycle ?\nAlso, I wonder if it could be doable to consider some hacking check (or a dedicated non-voting job for the first iterations) for ensuring that we\u0027re enforcing the rules.","commit_id":"56e953c6eb794efbb0db29ce8fec6545739f9c21"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"964f44a4a613405208cd66f61f4aa5d13ad1244f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"`the API WG guidelines \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"rather than going for \"local\" consistency."},{"line_number":94,"context_line":"Developers and reviewers should read all of the guidelines, but they are"},{"line_number":95,"context_line":"very long. So here are some key points:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a740942_ed6b6cb7","line":95,"in_reply_to":"7a740942_b7605502","updated":"2015-12-08 09:43:37.000000000","message":"Thanks for your review, Sylvain\n\nThat is a great question.\nMany guidelines of api-wg are come from Nova\u0027s experience because Nova API is super huge and we can see a lot of inconsistencies in the API.\n\nNova v3 API tries to fix this kind of inconsistencies which are against api-wg guideline, but the API had been removed for big incompatible impact to users.\n\nSo if we fix this consistency in this cycle with a microversion, that also will be a big impact to users.\nSo I am imaging difficult to fix the consistency of all existing APIs, but at least, we need to apply this guideline to new APIs.\n\nThen hacking rule also is difficult to be applied, I feel.\nI am happy that many reviewers know this for blocking this kind of inconsistency more.","commit_id":"56e953c6eb794efbb0db29ce8fec6545739f9c21"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d4246ae0580a7aedce314645f678b2e592575e6a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"`the API WG guidelines \u003chttps://specs.openstack.org/openstack/api-wg/\u003e`_"},{"line_number":93,"context_line":"rather than going for \"local\" consistency."},{"line_number":94,"context_line":"Developers and reviewers should read all of the guidelines, but they are"},{"line_number":95,"context_line":"very long. So here are some key points:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* `Terms \u003chttps://specs.openstack.org/openstack/api-wg/guidelines/terms.html\u003e`_"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a740942_cb7bf826","line":95,"in_reply_to":"7a740942_ed6b6cb7","updated":"2015-12-08 10:21:42.000000000","message":"I am OK with best effort here, lets move forward.\n\nbauzas: I totally agree with your comment on the consistency of the API. I was more for local consistency, and keeping new things using the new style, but this seems not to be the consensus from the the API sub team, and I can see arguments both ways.","commit_id":"56e953c6eb794efbb0db29ce8fec6545739f9c21"}]}