)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"29e88159fce2071b5ef244960eb402622601f5c5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The previous commit moved all the rdp options to a central"},{"line_number":10,"context_line":"location. This commit adds additional help text to those options."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Blueprint centralize-config-options"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2168d04db84b0e8a5e6b3320682c6baa61d61135"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"fa0719c6_cc966fef","line":12,"updated":"2016-03-23 15:39:29.000000000","message":"Please be aware that the effort in Newton is tracked with a\nnew (follow up) blueprint \n\n    centralize-config-options-newton\n\nIf questions arise, ping me. Thanks for your help here!","commit_id":"87a0137a1a62686dfd7a13f777da9047d78dd7ae"}],"nova/conf/rdp.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"9ea1bc4c4263c2e38f4ab8034bf7ca3884a6a778","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* ``nova compute service``"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Interdependencies to other options:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* None"},{"line_number":36,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_e9ae7997","line":33,"updated":"2015-12-04 15:22:18.000000000","message":"We came in Ed Leafes review for the scheduler options to the conclusion that \"Related options\" is enough and easier to understand for people who don\u0027t have English as a first language.","commit_id":"a42eb8d840fa4324a0129d8a2f21b7c7f88abe18"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c2e17bf5052e0d816c7b32feb08be83eefd066b4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"enabled_opt \u003d cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":20,"context_line":"        default\u003dFalse,"},{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"Enable the Remote Desktop Protocol (RDP) feature."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Possible values:"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_1bceb283","line":22,"updated":"2015-12-10 10:05:59.000000000","message":"I guess it would be superfluous to say that this only works with hyper-v compute nodes, right? That\u0027s basic knowledge of cloud admins I guess?","commit_id":"0766c9dc340cf8991120a6e76b0af5f4b8f80fab"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c2e17bf5052e0d816c7b32feb08be83eefd066b4","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Services which consume this:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* ``nova compute service``"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Related options:"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_fbb5e630","line":31,"updated":"2015-12-10 10:05:59.000000000","message":"* ``nova-compute``","commit_id":"0766c9dc340cf8991120a6e76b0af5f4b8f80fab"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c2e17bf5052e0d816c7b32feb08be83eefd066b4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"html5_proxy_base_url \u003d cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"},{"line_number":39,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":40,"context_line":"        help\u003d\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":43,"context_line":"The RDP html5 console proxy service will need to be configured. RDP html5"},{"line_number":44,"context_line":"console proxy services include FreeRDP, wsgate."}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_bb999e21","line":41,"updated":"2015-12-10 10:05:59.000000000","message":"nit: empty line at the beginning","commit_id":"0766c9dc340cf8991120a6e76b0af5f4b8f80fab"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c2e17bf5052e0d816c7b32feb08be83eefd066b4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":40,"context_line":"        help\u003d\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":43,"context_line":"The RDP html5 console proxy service will need to be configured. RDP html5"},{"line_number":44,"context_line":"console proxy services include FreeRDP, wsgate."},{"line_number":45,"context_line":"See https://github.com/FreeRDP/FreeRDP-WebConnect"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_bbf2fe6d","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":40},"updated":"2015-12-10 10:05:59.000000000","message":"IIUC the console proxy service will typically run on the controller node, which means that the localhost address only makes sense in a singlenode environment (like devstack) which, I assume, is not the typical customer environment. I don\u0027t know exactly how to express this, maybe you can take some hints from this change https://git.openstack.org/cgit/openstack/nova/commit/?id\u003d64107f3d58fabcba95394a04c24ef747870c5e98","commit_id":"0766c9dc340cf8991120a6e76b0af5f4b8f80fab"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c2e17bf5052e0d816c7b32feb08be83eefd066b4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        help\u003d\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":43,"context_line":"The RDP html5 console proxy service will need to be configured. RDP html5"},{"line_number":44,"context_line":"console proxy services include FreeRDP, wsgate."},{"line_number":45,"context_line":"See https://github.com/FreeRDP/FreeRDP-WebConnect"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_dbacaa8e","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":35},"updated":"2015-12-10 10:05:59.000000000","message":"And that service has to listen at the port 6083 I guess?","commit_id":"0766c9dc340cf8991120a6e76b0af5f4b8f80fab"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c2e17bf5052e0d816c7b32feb08be83eefd066b4","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Related options:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* None"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"\"\"\")"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_db334af5","line":57,"updated":"2015-12-10 10:05:59.000000000","message":"maybe something like this (in better English):\n\n    * ``rdp.enabled``: That option has to be set to True,\n    otherwise the option ``html5_proxy_base_url`` doesn\u0027t\n    have any effect.","commit_id":"0766c9dc340cf8991120a6e76b0af5f4b8f80fab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"89c3f5c81ee02eefbf3aa4ee93523bbcd1336d17","unresolved":false,"context_lines":[{"line_number":40,"context_line":"html5_proxy_base_url \u003d cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"},{"line_number":41,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":42,"context_line":"        help\u003d\"\"\""},{"line_number":43,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"The console proxy service is called with this token enriched URL and"},{"line_number":46,"context_line":"establishes the connection to the proper instance."}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_ec7fdcdd","line":43,"range":{"start_line":43,"start_character":52,"end_line":43,"end_character":57},"updated":"2016-01-06 09:53:24.000000000","message":"nit: HTML5","commit_id":"75e248441030758488ce1937d3296a184aded990"},{"author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"change_message_id":"29240f6a6b920bd523a5be22bf0e48b32afd7116","unresolved":false,"context_lines":[{"line_number":40,"context_line":"html5_proxy_base_url \u003d cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"},{"line_number":41,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":42,"context_line":"        help\u003d\"\"\""},{"line_number":43,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"The console proxy service is called with this token enriched URL and"},{"line_number":46,"context_line":"establishes the connection to the proper instance."}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_056796e9","line":43,"range":{"start_line":43,"start_character":52,"end_line":43,"end_character":57},"in_reply_to":"fa69d971_ec7fdcdd","updated":"2016-01-06 15:19:18.000000000","message":"done","commit_id":"75e248441030758488ce1937d3296a184aded990"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"89c3f5c81ee02eefbf3aa4ee93523bbcd1336d17","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        help\u003d\"\"\""},{"line_number":43,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"The console proxy service is called with this token enriched URL and"},{"line_number":46,"context_line":"establishes the connection to the proper instance."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The RDP html5 console proxy service will need to be configured."},{"line_number":49,"context_line":"Typically the console proxy service would be run on a controller node. The"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_4c586888","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":50},"updated":"2016-01-06 09:53:24.000000000","message":"nit: Your wrapping length is...varied. Could you just stick to 72/79 consistently?","commit_id":"75e248441030758488ce1937d3296a184aded990"},{"author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"change_message_id":"29240f6a6b920bd523a5be22bf0e48b32afd7116","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        help\u003d\"\"\""},{"line_number":43,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"The console proxy service is called with this token enriched URL and"},{"line_number":46,"context_line":"establishes the connection to the proper instance."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The RDP html5 console proxy service will need to be configured."},{"line_number":49,"context_line":"Typically the console proxy service would be run on a controller node. The"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_25f2da06","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":50},"in_reply_to":"fa69d971_4c586888","updated":"2016-01-06 15:19:18.000000000","message":"not sure what you mean by that - \u0027establishes\u0027 is not going to fit on line 45","commit_id":"75e248441030758488ce1937d3296a184aded990"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"89c3f5c81ee02eefbf3aa4ee93523bbcd1336d17","unresolved":false,"context_lines":[{"line_number":40,"context_line":"html5_proxy_base_url \u003d cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"},{"line_number":41,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":42,"context_line":"        help\u003d\"\"\""},{"line_number":43,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"The console proxy service is called with this token enriched URL and"},{"line_number":46,"context_line":"establishes the connection to the proper instance."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The RDP html5 console proxy service will need to be configured."},{"line_number":49,"context_line":"Typically the console proxy service would be run on a controller node. The"},{"line_number":50,"context_line":"localhost address used as default would only work in a single node environment"},{"line_number":51,"context_line":"i.e. devstack."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"RDP html5 console proxy services include FreeRDP, wsgate."},{"line_number":54,"context_line":"See: https://github.com/FreeRDP/FreeRDP-WebConnect"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Possible values:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* \u003cscheme\u003e://\u003cip-address\u003e:\u003cport-number\u003e/"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The scheme must be identical to the scheme configured for the RDP html5 console"},{"line_number":61,"context_line":"proxy service."},{"line_number":62,"context_line":"The IP address must be identical to the address on which the RDP html5 console"},{"line_number":63,"context_line":"proxy service is listening."},{"line_number":64,"context_line":"The port must be identical to the port on which the RDP html5 console proxy"},{"line_number":65,"context_line":"service is listening."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Services which consume this:"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_4cb4e87e","line":65,"range":{"start_line":43,"start_character":0,"end_line":65,"end_character":21},"updated":"2016-01-06 09:53:24.000000000","message":"Call me stupid but I still don\u0027t know what a console proxy is/what it\u0027s supposed to do after reading this. I don\u0027t know if that\u0027s the intended purpose of these strings, however...?","commit_id":"75e248441030758488ce1937d3296a184aded990"},{"author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"change_message_id":"29240f6a6b920bd523a5be22bf0e48b32afd7116","unresolved":false,"context_lines":[{"line_number":40,"context_line":"html5_proxy_base_url \u003d cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"},{"line_number":41,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":42,"context_line":"        help\u003d\"\"\""},{"line_number":43,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"The console proxy service is called with this token enriched URL and"},{"line_number":46,"context_line":"establishes the connection to the proper instance."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"The RDP html5 console proxy service will need to be configured."},{"line_number":49,"context_line":"Typically the console proxy service would be run on a controller node. The"},{"line_number":50,"context_line":"localhost address used as default would only work in a single node environment"},{"line_number":51,"context_line":"i.e. devstack."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"RDP html5 console proxy services include FreeRDP, wsgate."},{"line_number":54,"context_line":"See: https://github.com/FreeRDP/FreeRDP-WebConnect"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Possible values:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* \u003cscheme\u003e://\u003cip-address\u003e:\u003cport-number\u003e/"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"The scheme must be identical to the scheme configured for the RDP html5 console"},{"line_number":61,"context_line":"proxy service."},{"line_number":62,"context_line":"The IP address must be identical to the address on which the RDP html5 console"},{"line_number":63,"context_line":"proxy service is listening."},{"line_number":64,"context_line":"The port must be identical to the port on which the RDP html5 console proxy"},{"line_number":65,"context_line":"service is listening."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Services which consume this:"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_25e73aad","line":65,"range":{"start_line":43,"start_character":0,"end_line":65,"end_character":21},"in_reply_to":"fa69d971_4cb4e87e","updated":"2016-01-06 15:19:18.000000000","message":"I\u0027ve added \u0027An RDP HTML5 proxy allows a user to access via the web the text or graphical console of any Windows server or workstation using RDP\u0027","commit_id":"75e248441030758488ce1937d3296a184aded990"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"48dcd5144aa111ed18ba8853d7bf5110e65b3173","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"html5_proxy_base_url \u003d cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"},{"line_number":39,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":40,"context_line":"        help\u003d\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":43,"context_line":"The RDP html5 console proxy service will need to be configured. RDP html5"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a5de9d1_a16a0519","line":40,"updated":"2016-01-27 13:30:10.000000000","message":"nit: A quick summary line would be nice here (like a commit message - summary then paragraph with more details). Not important, however.","commit_id":"5b7d3717234ab5cef52469fd9f9990fa3258cdf2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"48dcd5144aa111ed18ba8853d7bf5110e65b3173","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Possible values:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* \u003cscheme\u003e://\u003cip-address\u003e:\u003cport-number\u003e/"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Services which consume this:"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a5de9d1_2165b544","line":49,"range":{"start_line":49,"start_character":2,"end_line":49,"end_character":40},"updated":"2016-01-27 13:30:10.000000000","message":"An URL? :)","commit_id":"5b7d3717234ab5cef52469fd9f9990fa3258cdf2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"48dcd5144aa111ed18ba8853d7bf5110e65b3173","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def list_opts():"},{"line_number":70,"context_line":"    return (\"rdp\", ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a5de9d1_c134e14b","line":70,"range":{"start_line":70,"start_character":11,"end_line":70,"end_character":28},"updated":"2016-01-27 13:30:10.000000000","message":"This should return a dict now","commit_id":"5b7d3717234ab5cef52469fd9f9990fa3258cdf2"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"a876398c668d81d8052dbf1f2dc2729e4c0d7747","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"Enable the Remote Desktop Protocol (RDP) feature."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Possible values:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* True: Enables the feature"},{"line_number":27,"context_line":"* False: Disables the feature"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Services which consume this:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"5a5ae5dd_b2023d0a","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":29},"updated":"2016-02-09 14:02:46.000000000","message":"Maybe it\u0027s just me, but this comes off as a bit like talking down to the operator. I would prefer something simpler like:\n\n    * Possible values:\n\n        True, False (default)","commit_id":"7c16ed155deaff45ac6de8d9140bd78976ca67b3"},{"author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"change_message_id":"f2e33e6880adb083d0b564c0751f8e3ea916f225","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"Enable the Remote Desktop Protocol (RDP) feature."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Possible values:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"* True: Enables the feature"},{"line_number":27,"context_line":"* False: Disables the feature"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Services which consume this:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a57f1b5_a252ee11","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":29},"in_reply_to":"5a5ae5dd_b2023d0a","updated":"2016-02-10 10:33:05.000000000","message":"I\u0027m just following what others have put in serial_console and cells","commit_id":"7c16ed155deaff45ac6de8d9140bd78976ca67b3"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"a876398c668d81d8052dbf1f2dc2729e4c0d7747","unresolved":false,"context_lines":[{"line_number":38,"context_line":"html5_proxy_base_url \u003d cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"},{"line_number":39,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":40,"context_line":"        help\u003d\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":43,"context_line":"The RDP html5 console proxy service will need to be configured. RDP html5"},{"line_number":44,"context_line":"console proxy services include FreeRDP, wsgate."}],"source_content_type":"text/x-python","patch_set":16,"id":"5a5ae5dd_75510f0e","line":41,"updated":"2016-02-09 14:02:46.000000000","message":"This blank line should be removed.","commit_id":"7c16ed155deaff45ac6de8d9140bd78976ca67b3"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"a876398c668d81d8052dbf1f2dc2729e4c0d7747","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":40,"context_line":"        help\u003d\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":43,"context_line":"The RDP html5 console proxy service will need to be configured. RDP html5"},{"line_number":44,"context_line":"console proxy services include FreeRDP, wsgate."},{"line_number":45,"context_line":"See https://github.com/FreeRDP/FreeRDP-WebConnect"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a5ae5dd_75782f90","line":42,"range":{"start_line":42,"start_character":52,"end_line":42,"end_character":57},"updated":"2016-02-09 14:02:46.000000000","message":"Should be \u0027HTML5\u0027 here, and below","commit_id":"7c16ed155deaff45ac6de8d9140bd78976ca67b3"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"a876398c668d81d8052dbf1f2dc2729e4c0d7747","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        help\u003d\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":43,"context_line":"The RDP html5 console proxy service will need to be configured. RDP html5"},{"line_number":44,"context_line":"console proxy services include FreeRDP, wsgate."},{"line_number":45,"context_line":"See https://github.com/FreeRDP/FreeRDP-WebConnect"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"5a5ae5dd_958feb74","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":64},"updated":"2016-02-09 14:02:46.000000000","message":"Not sure what this sentence means. If there is a default value, why would it *need* to be configured?","commit_id":"7c16ed155deaff45ac6de8d9140bd78976ca67b3"},{"author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"change_message_id":"f2e33e6880adb083d0b564c0751f8e3ea916f225","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        help\u003d\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"The URL an end user would use to connect to the RDP html5 console proxy."},{"line_number":43,"context_line":"The RDP html5 console proxy service will need to be configured. RDP html5"},{"line_number":44,"context_line":"console proxy services include FreeRDP, wsgate."},{"line_number":45,"context_line":"See https://github.com/FreeRDP/FreeRDP-WebConnect"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a57f1b5_a2a0aef5","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":64},"in_reply_to":"5a5ae5dd_958feb74","updated":"2016-02-10 10:33:05.000000000","message":"A RDP html service needs to be configured to listen at the address given..\n\nAnd now that I look at this I notice that Patch set8 - had way way more information than this patch - So I will put up a new patch set with the additional text from patch set 8","commit_id":"7c16ed155deaff45ac6de8d9140bd78976ca67b3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"740c2f8b4ad7fc481264d78e6aad7e023d7c5f70","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def register_opts(conf):"},{"line_number":85,"context_line":"    conf.register_opts(ALL_OPTS, group\u003d\"rdp\")"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa0719c6_2102a20b","line":85,"updated":"2016-03-23 12:16:27.000000000","message":"I think we should have a group config here too, but that can be a follow on patch.","commit_id":"87a0137a1a62686dfd7a13f777da9047d78dd7ae"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c766b9107c75415577fa966ea3c7621187fbd894","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Related options:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* None"},{"line_number":38,"context_line":"\"\"\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"html5_proxy_base_url \u003d cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa0719c6_b4751265","line":37,"updated":"2016-03-24 11:36:43.000000000","message":"I guess the above thing about hyper-v mean the virt_driver config is a related option?","commit_id":"fd1bc2b6f2dff51bef61a9b05bd02f1b9164eaca"},{"author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"change_message_id":"128f09d595d1b265a8ba7eae445c6b166b22ebcc","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Related options:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* None"},{"line_number":38,"context_line":"\"\"\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"html5_proxy_base_url \u003d cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa0719c6_c2a716a5","line":37,"in_reply_to":"fa0719c6_b4751265","updated":"2016-03-24 15:45:37.000000000","message":"Do you mean..\n\n* ``compute_driver``: Must specify a hyper-v driver.","commit_id":"fd1bc2b6f2dff51bef61a9b05bd02f1b9164eaca"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4c81253d8fba88240746ff036313bdd6b9cbba0b","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Related options:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* None"},{"line_number":38,"context_line":"\"\"\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"html5_proxy_base_url \u003d cfg.StrOpt(\u0027html5_proxy_base_url\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a122d0e_36f6008f","line":37,"in_reply_to":"fa0719c6_c2a716a5","updated":"2016-04-21 09:17:55.000000000","message":"yeah, something like that, I don\u0027t quite remember the name of that config right now.","commit_id":"fd1bc2b6f2dff51bef61a9b05bd02f1b9164eaca"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c766b9107c75415577fa966ea3c7621187fbd894","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Related options:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* ``rdp.enabled``: Must be set to ``True`` for ``html5_proxy_base_url`` to be"},{"line_number":76,"context_line":"                   effective."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"\"\")"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"fa0719c6_347742a1","line":76,"updated":"2016-03-24 11:36:43.000000000","message":"I think this only works with Hyper-V, we should mention that here I think?","commit_id":"fd1bc2b6f2dff51bef61a9b05bd02f1b9164eaca"},{"author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"change_message_id":"128f09d595d1b265a8ba7eae445c6b166b22ebcc","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Related options:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* ``rdp.enabled``: Must be set to ``True`` for ``html5_proxy_base_url`` to be"},{"line_number":76,"context_line":"                   effective."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"\"\")"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"fa0719c6_dd1c1b6c","line":76,"in_reply_to":"fa0719c6_347742a1","updated":"2016-03-24 15:45:37.000000000","message":"If this option is related to the enabled option, and the enabled option is related to the \u0027compute_driver\u0027 option, do I need to mention the compute driver option here as well?\n\nI\u0027d rather not document related options transitively.","commit_id":"fd1bc2b6f2dff51bef61a9b05bd02f1b9164eaca"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4c81253d8fba88240746ff036313bdd6b9cbba0b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Related options:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* ``rdp.enabled``: Must be set to ``True`` for ``html5_proxy_base_url`` to be"},{"line_number":76,"context_line":"                   effective."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"\"\")"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1a122d0e_363d602b","line":76,"in_reply_to":"fa0719c6_dd1c1b6c","updated":"2016-04-21 09:17:55.000000000","message":"Oh, I get you. Thats a good idea.","commit_id":"fd1bc2b6f2dff51bef61a9b05bd02f1b9164eaca"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"305d65cc8a7fe8f46a6de774034f20efb6697db4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"* True: Enables the feature"},{"line_number":29,"context_line":"* False: Disables the feature"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Services which consume this:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* ``nova compute service``"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Related options:"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"7aa08908_7ed5a8e3","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":26},"updated":"2016-06-16 15:48:40.000000000","message":"This section is no longer needed.\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"2e697f4e897b3ba8c337661dc43d295930e2da03"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"305d65cc8a7fe8f46a6de774034f20efb6697db4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"The port must be identical to the port on which the RDP HTML5 console proxy"},{"line_number":68,"context_line":"service is listening."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Services which consume this:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* ``nova-compute``"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Related options:"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"7aa08908_be05507a","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":18},"updated":"2016-06-16 15:48:40.000000000","message":"This section is no longer needed.\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"2e697f4e897b3ba8c337661dc43d295930e2da03"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dc4854d98f72d40fcaa8ecc0646a951544342884","unresolved":false,"context_lines":[{"line_number":26,"context_line":"enabled \u003d cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":27,"context_line":"                      default\u003dFalse,"},{"line_number":28,"context_line":"                      help\u003d\"\"\""},{"line_number":29,"context_line":"Enable the Remote Desktop Protocol (RDP) related features."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Hyper-V, unlike the majority of the hypervisors employed on Nova compute"},{"line_number":32,"context_line":"nodes, uses RDP instead of VNC and SPICE as a desktop sharing protocol to"}],"source_content_type":"text/x-python","patch_set":24,"id":"3aaa91ec_14a7bca7","line":29,"range":{"start_line":29,"start_character":7,"end_line":29,"end_character":11},"updated":"2016-06-30 13:47:00.000000000","message":"either drop \u0027the\u0027 or change \u0027related features\u0027 to just \u0027feature\u0027.","commit_id":"e99c85372b9abb15cc7fc921e7e0a7a91af289d9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dc4854d98f72d40fcaa8ecc0646a951544342884","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                      help\u003d\"\"\""},{"line_number":29,"context_line":"Enable the Remote Desktop Protocol (RDP) related features."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Hyper-V, unlike the majority of the hypervisors employed on Nova compute"},{"line_number":32,"context_line":"nodes, uses RDP instead of VNC and SPICE as a desktop sharing protocol to"},{"line_number":33,"context_line":"provide instance console access."},{"line_number":34,"context_line":"This option enables RDP for graphical console access for virtual machines"},{"line_number":35,"context_line":"created by Hyper-V."},{"line_number":36,"context_line":"Note: RDP should only be enabled on compute nodes that support the Hyper-V"},{"line_number":37,"context_line":"virtualization platform."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3aaa91ec_34c3d839","line":35,"range":{"start_line":31,"start_character":0,"end_line":35,"end_character":18},"updated":"2016-06-30 13:47:00.000000000","message":"This is one paragraph, yes? If so, removed space on L33","commit_id":"e99c85372b9abb15cc7fc921e7e0a7a91af289d9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dc4854d98f72d40fcaa8ecc0646a951544342884","unresolved":false,"context_lines":[{"line_number":33,"context_line":"provide instance console access."},{"line_number":34,"context_line":"This option enables RDP for graphical console access for virtual machines"},{"line_number":35,"context_line":"created by Hyper-V."},{"line_number":36,"context_line":"Note: RDP should only be enabled on compute nodes that support the Hyper-V"},{"line_number":37,"context_line":"virtualization platform."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":24,"id":"3aaa91ec_54e2e4d5","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":5},"updated":"2016-06-30 13:47:00.000000000","message":"**NOTE:** ?","commit_id":"e99c85372b9abb15cc7fc921e7e0a7a91af289d9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dc4854d98f72d40fcaa8ecc0646a951544342884","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Note: RDP should only be enabled on compute nodes that support the Hyper-V"},{"line_number":37,"context_line":"virtualization platform."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Possible values:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* True: Enables the feature"},{"line_number":42,"context_line":"* False: Disables the feature."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Related options:"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3aaa91ec_34dab817","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":30},"updated":"2016-06-30 13:47:00.000000000","message":"Don\u0027t think this is necessary anymore (ping johnthetubaguy or markus_z on IRC), so you could take the opportunity to drop this.","commit_id":"e99c85372b9abb15cc7fc921e7e0a7a91af289d9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"72fec5d81763c79c30d719019890c890de995ed4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Note: RDP should only be enabled on compute nodes that support the Hyper-V"},{"line_number":37,"context_line":"virtualization platform."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Possible values:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* True: Enables the feature"},{"line_number":42,"context_line":"* False: Disables the feature."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Related options:"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3aaa91ec_7791e246","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":30},"updated":"2016-06-30 13:19:20.000000000","message":"Nit: I would drop this.","commit_id":"e99c85372b9abb15cc7fc921e7e0a7a91af289d9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"06302df40e3f914d4775a43886b0acdd3abe4189","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Related options:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* ``compute_driver``: Must specify a hyper-v driver."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"\"\"\")"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3aaa91ec_f46ae518","line":44,"updated":"2016-06-30 15:55:26.000000000","message":"How about:\n\n * ``compute_driver``: Must be \u0027hyperv\u0027","commit_id":"0e32371554e9eb110b3ad172ef284c781c506942"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"06302df40e3f914d4775a43886b0acdd3abe4189","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        default\u003d\u0027http://127.0.0.1:6083/\u0027,"},{"line_number":50,"context_line":"        help\u003d\"\"\""},{"line_number":51,"context_line":"The URL an end user would use to connect to the RDP HTML5 console proxy."},{"line_number":52,"context_line":"The console proxy service is called with this token enriched URL and"},{"line_number":53,"context_line":"establishes the connection to the proper instance."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"An RDP HTML5 console proxy service will need to be configured to listen on the"}],"source_content_type":"text/x-python","patch_set":25,"id":"3aaa91ec_54765906","line":52,"updated":"2016-06-30 15:55:26.000000000","message":"s/token enriched/token-embedded/","commit_id":"0e32371554e9eb110b3ad172ef284c781c506942"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"45e72068336afb92c860e3f54716967619fc77f6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Copyright 2015-2016 OpenStack Foundation"},{"line_number":9,"context_line":"# All Rights Reserved."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":26,"id":"3aaa91ec_0d45c36d","line":8,"range":{"start_line":8,"start_character":16,"end_line":8,"end_character":21},"updated":"2016-07-01 09:19:29.000000000","message":"should have spotted this before: if you don\u0027t work for the foundation, I don\u0027t think you should be updating this","commit_id":"11019dd17283e2abbee728a4d2c59132a5d6e434"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"84f442902e0d7fd5210555be2b0008ec578ed964","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Copyright 2015-2016 OpenStack Foundation"},{"line_number":9,"context_line":"# All Rights Reserved."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":26,"id":"3aaa91ec_e6f5e2ed","line":8,"range":{"start_line":8,"start_character":16,"end_line":8,"end_character":21},"in_reply_to":"3aaa91ec_0d45c36d","updated":"2016-07-01 14:54:30.000000000","message":"Right - what you should do if you want to update the copyright is add an HPE copyright line in addition to the one that is here.","commit_id":"11019dd17283e2abbee728a4d2c59132a5d6e434"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"45e72068336afb92c860e3f54716967619fc77f6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"**Note:** RDP should only be enabled on compute nodes that support the Hyper-V"},{"line_number":36,"context_line":"virtualization platform."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Possible values:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* True: Enables the feature"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Related options:"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3aaa91ec_902d4691","line":40,"range":{"start_line":38,"start_character":0,"end_line":40,"end_character":27},"updated":"2016-07-01 09:19:29.000000000","message":"tbh, I think the entire section could be removed - we can infer this from the fact that this is a BoolOpt","commit_id":"11019dd17283e2abbee728a4d2c59132a5d6e434"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"45e72068336afb92c860e3f54716967619fc77f6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"The console proxy service is called with this token-embedded URL and"},{"line_number":53,"context_line":"establishes the connection to the proper instance."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"An RDP HTML5 console proxy service will need to be configured to listen on the"},{"line_number":56,"context_line":"address configured here."},{"line_number":57,"context_line":"Typically the console proxy service would be run on a controller node."},{"line_number":58,"context_line":"The localhost address used as default would only work in a single node"},{"line_number":59,"context_line":"environment i.e. devstack."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"An RDP HTML5 proxy allows a user to access via the web the text or graphical"},{"line_number":62,"context_line":"console of any Windows server or workstation using RDP. RDP HTML5 console"}],"source_content_type":"text/x-python","patch_set":26,"id":"3aaa91ec_10f4b6ee","line":59,"range":{"start_line":55,"start_character":0,"end_line":59,"end_character":26},"updated":"2016-07-01 09:19:29.000000000","message":"Same thing here as the other option - if this is one paragraph then the whitespace on line 56 should be dropped.","commit_id":"11019dd17283e2abbee728a4d2c59132a5d6e434"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"45e72068336afb92c860e3f54716967619fc77f6","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* ``rdp.enabled``: Must be set to ``True`` for ``html5_proxy_base_url`` to be"},{"line_number":80,"context_line":"                   effective."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"\"\"\")"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"ALL_OPTS \u003d [enabled,"}],"source_content_type":"text/x-python","patch_set":26,"id":"3aaa91ec_d0786e91","line":81,"updated":"2016-07-01 09:19:29.000000000","message":"nit: extra whitespace?","commit_id":"11019dd17283e2abbee728a4d2c59132a5d6e434"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f4b6efcd935a9034b3472a9fa3ddbc95bfa577f0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"nodes, uses RDP instead of VNC and SPICE as a desktop sharing protocol to"},{"line_number":33,"context_line":"provide instance console access. This option enables RDP for graphical"},{"line_number":34,"context_line":"console access for virtual machines created by Hyper-V."},{"line_number":35,"context_line":"**Note:** RDP should only be enabled on compute nodes that support the Hyper-V"},{"line_number":36,"context_line":"virtualization platform."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_70b774f5","line":35,"updated":"2016-07-25 21:27:08.000000000","message":"Shouldn\u0027t there be a blank line before this line?","commit_id":"1da7abbea04500f96d2a44b0c67009ed8f681f82"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f4b6efcd935a9034b3472a9fa3ddbc95bfa577f0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Possible values:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* True: Enables the feature"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Related options:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* ``compute_driver``: Must be hyperv."}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_b0c9ec7b","line":41,"updated":"2016-07-25 21:27:08.000000000","message":"I feel like False should be mentioned here too, otherwise this scans oddly.","commit_id":"1da7abbea04500f96d2a44b0c67009ed8f681f82"},{"author":{"_account_id":7133,"name":"Ryan Moore","email":"ryan.moore@hpe.com","username":"moory"},"change_message_id":"0059356cdade0002b5ecbae56205cf38570a9353","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Possible values:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* True: Enables the feature"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Related options:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* ``compute_driver``: Must be hyperv."}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_e72390bb","line":41,"in_reply_to":"dada55a8_b0c9ec7b","updated":"2016-07-26 09:57:17.000000000","message":"Asked to remove the False option by John Garbutt PS24","commit_id":"1da7abbea04500f96d2a44b0c67009ed8f681f82"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f4b6efcd935a9034b3472a9fa3ddbc95bfa577f0","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The scheme must be identical to the scheme configured for the RDP HTML5"},{"line_number":70,"context_line":"console proxy service."},{"line_number":71,"context_line":"The IP address must be identical to the address on which the RDP HTML5 console"},{"line_number":72,"context_line":"proxy service is listening."},{"line_number":73,"context_line":"The port must be identical to the port on which the RDP HTML5 console proxy"},{"line_number":74,"context_line":"service is listening."}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_90ab0889","line":71,"updated":"2016-07-25 21:27:08.000000000","message":"Missing blank line, or line wrapping.","commit_id":"1da7abbea04500f96d2a44b0c67009ed8f681f82"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f4b6efcd935a9034b3472a9fa3ddbc95bfa577f0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"console proxy service."},{"line_number":71,"context_line":"The IP address must be identical to the address on which the RDP HTML5 console"},{"line_number":72,"context_line":"proxy service is listening."},{"line_number":73,"context_line":"The port must be identical to the port on which the RDP HTML5 console proxy"},{"line_number":74,"context_line":"service is listening."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_70ae5499","line":73,"updated":"2016-07-25 21:27:08.000000000","message":"Ditto","commit_id":"1da7abbea04500f96d2a44b0c67009ed8f681f82"}]}