)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"ee87651df939eb0b0595532207d93928cc31958a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Enforce minimum vCenter version of 5.5"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of Mitaka, the minimum version of VMware vCenter will be"},{"line_number":10,"context_line":"enforce to 5.5.0.  Previous releases warned of deprecated"},{"line_number":11,"context_line":"versions less than 5.1.0."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9abb7d3a_a95c1eee","line":9,"updated":"2016-06-29 21:12:47.000000000","message":"update to newton now?","commit_id":"58c9cec03e6fc7661f2adc065c2099371aff7469"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4948aa243c1f10647027a42475af12454d4ff609","unresolved":false,"context_lines":[{"line_number":10,"context_line":"enforced to 5.5.0.  Previous OpenStack releases warned of the"},{"line_number":11,"context_line":"deprecation of versions less than 5.5."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The VMware driver CI will has already migrated to vCenter 6.0."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9f13e6cd6a49699f2b3cdce892fbf02634bf7618"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"fa7ab95a_4ebaa6c1","line":13,"range":{"start_line":13,"start_character":21,"end_line":13,"end_character":46},"updated":"2016-08-29 10:05:22.000000000","message":"\u0027has already migrated\u0027 maybe?","commit_id":"b3e0e303580e16d37c084c673046b6442b8bca88"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e3c3bd9657174ce924478921d3bbc7eb01dcd54","unresolved":false,"context_lines":[{"line_number":11,"context_line":"deprecation of versions less than 5.5."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The VMware driver CI will has already migrated to vCenter 6.0."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9f13e6cd6a49699f2b3cdce892fbf02634bf7618"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7a8ec9b2_b3e587a9","line":14,"updated":"2016-09-20 13:52:50.000000000","message":"We might need a DocImpact on this to create a bug for tracking changes needed on this docs page:\n\nhttp://docs.openstack.org/mitaka/config-reference/compute/hypervisor-vmware.html\n\nThat\u0027s talking about minimum versions of vSphere.","commit_id":"59405ee6e9f0614ee9c5c72d0b162e7412a9ced3"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"230f99796f6bac32303311dfe35c2f03b9b4d6b3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"deprecation of versions less than 5.5."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The VMware driver CI will has already migrated to vCenter 6.0."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9f13e6cd6a49699f2b3cdce892fbf02634bf7618"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5a8bc5a2_41bb60e5","line":14,"in_reply_to":"7a8ec9b2_b3e587a9","updated":"2016-09-23 23:04:29.000000000","message":"Done","commit_id":"59405ee6e9f0614ee9c5c72d0b162e7412a9ced3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92a5f55a6e96c73f6fbdea1a542478c157158987","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Enforce minimum vCenter version of 5.5"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of Newton, the minimum version of VMware vCenter will be"},{"line_number":10,"context_line":"enforced to 5.5.0.  Previous OpenStack releases warned of the"},{"line_number":11,"context_line":"deprecation of versions less than 5.5."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The VMware driver CI will has already migrated to vCenter 6.0."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"5a8bc5a2_bce8cbe3","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":17},"updated":"2016-09-24 00:24:22.000000000","message":"This isn\u0027t correct.","commit_id":"9ced423df13abc711895b1ec759c16302acab2c2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7622462e023724d6246f0031f363571ca414f3d4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"The VMware driver CI will has already migrated to vCenter 6.0."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DocImpact: Need version updates on the minimum vCenter included in"},{"line_number":17,"context_line":"http://docs.openstack.org/mitaka/config-reference/compute/hypervisor-vmware.html"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I9f13e6cd6a49699f2b3cdce892fbf02634bf7618"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5a8bc5a2_f08b4e66","line":17,"updated":"2016-09-24 17:38:12.000000000","message":"https://review.openstack.org/#/c/375770/","commit_id":"18b350621e1290a85703ca371eb3733959bd6acc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e5f95ad1b01e79090dd0ff281010ac4a44391dd1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"warned as deprecated. In two releases, 5.5.0 will become the"},{"line_number":12,"context_line":"new minimum version."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The VMware driver CI will has already migrated to vCenter 6.0."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DocImpact: Need version updates on the minimum vCenter included in"},{"line_number":17,"context_line":"http://docs.openstack.org/mitaka/config-reference/compute/hypervisor-vmware.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"3a98d1f4_a41b26c9","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":37},"updated":"2016-09-30 21:05:11.000000000","message":"Will or has?","commit_id":"2851ceaed3010c19f42e308be637b952edab092a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"63e08891d5caf7ebfde255ff51402917ad666b3f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"warned as deprecated. In two releases, 5.5.0 will become the"},{"line_number":12,"context_line":"new minimum version."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The VMware driver CI will has already migrated to vCenter 6.0."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DocImpact: Need version updates on the minimum vCenter included in"},{"line_number":17,"context_line":"http://docs.openstack.org/mitaka/config-reference/compute/hypervisor-vmware.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"3a98d1f4_ea05f710","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":37},"in_reply_to":"3a98d1f4_a41b26c9","updated":"2016-09-30 21:42:30.000000000","message":"Can haz vcenter 6.0?!\n\nIt already is, I checked that at one point.","commit_id":"2851ceaed3010c19f42e308be637b952edab092a"}],"nova/tests/unit/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4948aa243c1f10647027a42475af12454d4ff609","unresolved":false,"context_lines":[{"line_number":2284,"context_line":""},{"line_number":2285,"context_line":"    @mock.patch.object(oslo_vim_util, \u0027get_vc_version\u0027, return_value\u003d\u00275.1.0\u0027)"},{"line_number":2286,"context_line":"    def test_invalid_min_version(self, mock_version):"},{"line_number":2287,"context_line":"        self.assertRaises(exception.NovaException,"},{"line_number":2288,"context_line":"                          self.conn._check_min_version)"},{"line_number":2289,"context_line":""},{"line_number":2290,"context_line":"    @mock.patch.object(objects.Service, \u0027get_by_compute_host\u0027)"},{"line_number":2291,"context_line":"    def test_host_state_service_disabled(self, mock_service):"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_b26710e8","line":2288,"range":{"start_line":2287,"start_character":8,"end_line":2288,"end_character":55},"updated":"2016-08-29 10:05:22.000000000","message":"what about using testtools.ExpectedException here? It will allow verifying exception message either.","commit_id":"b3e0e303580e16d37c084c673046b6442b8bca88"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e3c3bd9657174ce924478921d3bbc7eb01dcd54","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        vc_version \u003d vim_util.get_vc_version(self._session)"},{"line_number":131,"context_line":"        LOG.info(_LI(\"VMware vCenter version: %s\"), vc_version)"},{"line_number":132,"context_line":"        if min_version \u003e v_utils.convert_version_to_int(vc_version):"},{"line_number":133,"context_line":"            # TODO(garyk): enforce this from M"},{"line_number":134,"context_line":"            LOG.warning(_LW(\u0027Running Nova with a VMware vCenter version less \u0027"},{"line_number":135,"context_line":"                            \u0027than %(version)s is deprecated. The required \u0027"},{"line_number":136,"context_line":"                            \u0027minimum version of vCenter will be raised to \u0027"},{"line_number":137,"context_line":"                            \u0027%(version)s in the 13.0.0 release.\u0027),"},{"line_number":138,"context_line":"                        {\u0027version\u0027: constants.MIN_VC_VERSION})"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @property"},{"line_number":141,"context_line":"    def need_legacy_block_device_info(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_d646814e","side":"PARENT","line":138,"range":{"start_line":133,"start_character":12,"end_line":138,"end_character":62},"updated":"2016-09-20 13:52:50.000000000","message":"So, we used to warn if you weren\u0027t using at least 5.1.0, now we\u0027re going straight to not starting nova-compute if you\u0027re not running at least 5.5.0? That seems like a pretty drastic jump without any warning period between 5.1.0 and 5.5.0 being the minimum.\n\nSeems we should have a period where:\n\n1. We fail if you\u0027re not running at least 5.1.0.\n2. We log a warning if you\u0027re not running at least 5.5.0 since that will be the \u0027next\u0027 minimum version, but isn\u0027t a failure today.\n\nThen in Pike we can raise the minimum to 5.5.0 and make it a failure if you\u0027re running less than 5.5.0.","commit_id":"b61cb28e9837fa2820ad70d78d3a109a5f0f07c6"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"230f99796f6bac32303311dfe35c2f03b9b4d6b3","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        vc_version \u003d vim_util.get_vc_version(self._session)"},{"line_number":131,"context_line":"        LOG.info(_LI(\"VMware vCenter version: %s\"), vc_version)"},{"line_number":132,"context_line":"        if min_version \u003e v_utils.convert_version_to_int(vc_version):"},{"line_number":133,"context_line":"            # TODO(garyk): enforce this from M"},{"line_number":134,"context_line":"            LOG.warning(_LW(\u0027Running Nova with a VMware vCenter version less \u0027"},{"line_number":135,"context_line":"                            \u0027than %(version)s is deprecated. The required \u0027"},{"line_number":136,"context_line":"                            \u0027minimum version of vCenter will be raised to \u0027"},{"line_number":137,"context_line":"                            \u0027%(version)s in the 13.0.0 release.\u0027),"},{"line_number":138,"context_line":"                        {\u0027version\u0027: constants.MIN_VC_VERSION})"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @property"},{"line_number":141,"context_line":"    def need_legacy_block_device_info(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a8bc5a2_81b568ef","side":"PARENT","line":138,"range":{"start_line":133,"start_character":12,"end_line":138,"end_character":62},"in_reply_to":"7a8ec9b2_d646814e","updated":"2016-09-23 23:04:29.000000000","message":"Done","commit_id":"b61cb28e9837fa2820ad70d78d3a109a5f0f07c6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92a5f55a6e96c73f6fbdea1a542478c157158987","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _check_min_version(self):"},{"line_number":129,"context_line":"        min_version \u003d v_utils.convert_version_to_int(constants.MIN_VC_VERSION)"},{"line_number":130,"context_line":"        next_min_ver \u003d v_utils.convert_version_to_int(\u00275.5.0\u0027)"},{"line_number":131,"context_line":"        vc_version \u003d vim_util.get_vc_version(self._session)"},{"line_number":132,"context_line":"        LOG.info(_LI(\"VMware vCenter version: %s\"), vc_version)"},{"line_number":133,"context_line":"        if  v_utils.convert_version_to_int(vc_version) \u003c min_version:"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_9caf8f93","line":130,"range":{"start_line":130,"start_character":54,"end_line":130,"end_character":61},"updated":"2016-09-24 00:24:22.000000000","message":"nit: it would be good to just define this as NEXT_MIN_VC_VERSION in constants, that\u0027s how the libvirt driver does this, then you only need to update the values in one place.","commit_id":"9ced423df13abc711895b1ec759c16302acab2c2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92a5f55a6e96c73f6fbdea1a542478c157158987","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        next_min_ver \u003d v_utils.convert_version_to_int(\u00275.5.0\u0027)"},{"line_number":131,"context_line":"        vc_version \u003d vim_util.get_vc_version(self._session)"},{"line_number":132,"context_line":"        LOG.info(_LI(\"VMware vCenter version: %s\"), vc_version)"},{"line_number":133,"context_line":"        if  v_utils.convert_version_to_int(vc_version) \u003c min_version:"},{"line_number":134,"context_line":"            raise exception.NovaException("},{"line_number":135,"context_line":"                _(\u0027Nova requires VMware vCenter version %s or greater.\u0027) %"},{"line_number":136,"context_line":"                constants.MIN_VC_VERSION)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_bc960b4a","line":133,"range":{"start_line":133,"start_character":10,"end_line":133,"end_character":12},"updated":"2016-09-24 00:24:22.000000000","message":"nit: weird double space here","commit_id":"9ced423df13abc711895b1ec759c16302acab2c2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92a5f55a6e96c73f6fbdea1a542478c157158987","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        LOG.info(_LI(\"VMware vCenter version: %s\"), vc_version)"},{"line_number":133,"context_line":"        if  v_utils.convert_version_to_int(vc_version) \u003c min_version:"},{"line_number":134,"context_line":"            raise exception.NovaException("},{"line_number":135,"context_line":"                _(\u0027Nova requires VMware vCenter version %s or greater.\u0027) %"},{"line_number":136,"context_line":"                constants.MIN_VC_VERSION)"},{"line_number":137,"context_line":"        elif v_utils.convert_version_to_int(vc_version) \u003c next_min_ver:"},{"line_number":138,"context_line":"            LOG.warning(_LW(\u0027Running Nova with a VMware vCenter version less \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_7c83a304","line":135,"updated":"2016-09-24 00:24:22.000000000","message":"I\u0027d suggest adding the current version to this error message.","commit_id":"9ced423df13abc711895b1ec759c16302acab2c2"}],"releasenotes/notes/minimum_vc_version-0695a79dc1df3caa.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e3c3bd9657174ce924478921d3bbc7eb01dcd54","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - As of Newton, the minimum version of VMware vCenter that nova compute will"},{"line_number":4,"context_line":"    interoperate with will be 5.5.0. Exploiters using older versions of vCenter"},{"line_number":5,"context_line":"    should upgrade."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7a8ec9b2_76af6de3","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":16},"updated":"2016-09-20 13:52:50.000000000","message":"This will need to change now that we\u0027re in Ocata.","commit_id":"59405ee6e9f0614ee9c5c72d0b162e7412a9ced3"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"230f99796f6bac32303311dfe35c2f03b9b4d6b3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - As of Newton, the minimum version of VMware vCenter that nova compute will"},{"line_number":4,"context_line":"    interoperate with will be 5.5.0. Exploiters using older versions of vCenter"},{"line_number":5,"context_line":"    should upgrade."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5a8bc5a2_a1b8a4e6","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":16},"in_reply_to":"7a8ec9b2_76af6de3","updated":"2016-09-23 23:04:29.000000000","message":"Done","commit_id":"59405ee6e9f0614ee9c5c72d0b162e7412a9ced3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92a5f55a6e96c73f6fbdea1a542478c157158987","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - As of Ocata, the minimum version of VMware vCenter that nova compute will"},{"line_number":4,"context_line":"    interoperate with will be 5.1.0. Exploiters using older versions of vCenter"},{"line_number":5,"context_line":"    should upgrade. The vCenter version of 5.5.0 is also now deprecated."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a8bc5a2_9c9dcf5b","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":47},"updated":"2016-09-24 00:24:22.000000000","message":"This seems like the wrong word to use. :)\n\nMaybe \u0027Deployments\u0027 instead?","commit_id":"9ced423df13abc711895b1ec759c16302acab2c2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92a5f55a6e96c73f6fbdea1a542478c157158987","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - As of Ocata, the minimum version of VMware vCenter that nova compute will"},{"line_number":4,"context_line":"    interoperate with will be 5.1.0. Exploiters using older versions of vCenter"},{"line_number":5,"context_line":"    should upgrade. The vCenter version of 5.5.0 is also now deprecated."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a8bc5a2_3cb75bd9","line":5,"range":{"start_line":5,"start_character":20,"end_line":5,"end_character":71},"updated":"2016-09-24 00:24:22.000000000","message":"This reads a bit odd, maybe instead:\n\n\"Running with vCenter version less than or equal to 5.5.0 is also now deprecated and 5.5.0 will become the minimum version in the 16.0.0 Pike release of Nova.\"","commit_id":"9ced423df13abc711895b1ec759c16302acab2c2"}]}