)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"3b03714754dec5742faaa356bb2a45da970d8fb7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"config options: Centralise PCI options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add options from \u0027pci/whitelist\u0027. These options are part of the"},{"line_number":10,"context_line":"\u0027default\u0027, this the \"nova.conf\" section \"default\" must be created."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib28a16ef7dccd98425f39cffcec7652aa0f05fa8"},{"line_number":13,"context_line":"Implements: blueprint centralize-config-options"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a740942_b9a123fa","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":65},"updated":"2015-12-08 11:49:26.000000000","message":"I don\u0027t quite understand this part of the sentence.","commit_id":"b7ba7832ed31a8a88701843f5a7a0d5893a29040"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"603f8425ebd435aef4efc06b7c381e75fb44dfa3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"config options: Centralise PCI options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add options from \u0027pci/whitelist\u0027. These options are part of the"},{"line_number":10,"context_line":"\u0027default\u0027, this the \"nova.conf\" section \"default\" must be created."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib28a16ef7dccd98425f39cffcec7652aa0f05fa8"},{"line_number":13,"context_line":"Implements: blueprint centralize-config-options"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a740942_f94fab31","line":10,"in_reply_to":"7a740942_b9a123fa","updated":"2015-12-08 12:05:46.000000000","message":"Oops: that\u0027s from version 1, where I created \u0027default.py\u0027 (before edleafe corrected me). Will fix.\n\nThere\u0027s no excuse for the grammar/typos though heh","commit_id":"b7ba7832ed31a8a88701843f5a7a0d5893a29040"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"a929b4e8c25c2431747241949a9a2f788f926206","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"config options: Centralise PCI options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add options from \u0027pci/whitelist\u0027. These options are part of the"},{"line_number":10,"context_line":"\u0027DEFAULT\u0027 group but are included in the \"nova.conf.pci\" file in hope"},{"line_number":11,"context_line":"that they can eventually be moved to a \u0027pci\u0027 group."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_1ab5a9eb","line":9,"updated":"2015-12-14 14:20:08.000000000","message":"What about pci/request ?","commit_id":"164406e099d09bd9be38ecaf802a422947e6fc28"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"fb8220256e990df2e56382e24860eedcd5d108dd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"config options: Centralise PCI options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add options from \u0027pci/whitelist\u0027. These options are part of the"},{"line_number":10,"context_line":"\u0027DEFAULT\u0027 group but are included in the \"nova.conf.pci\" file in hope"},{"line_number":11,"context_line":"that they can eventually be moved to a \u0027pci\u0027 group."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a7e1126_151fc45b","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":33},"updated":"2015-12-21 15:59:10.000000000","message":"nit: \"move pci related options.\"","commit_id":"077c0110c0308c085340b9eb624f640e724c27b6"}],"nova/conf/pci.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"3b03714754dec5742faaa356bb2a45da970d8fb7","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def list_opts():"},{"line_number":49,"context_line":"    # TODO(sfinucan): This should be moved into the PCI group and"},{"line_number":50,"context_line":"    # oslo_config.cfg.OptGroup used"},{"line_number":51,"context_line":"    return (\u0027\u0027, ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_36af802b","line":50,"updated":"2015-12-08 11:49:26.000000000","message":"I\u0027ve added this also to the etherpad as an option to re-evaluate (see at the bottom of https://etherpad.openstack.org/p/config-options )","commit_id":"b7ba7832ed31a8a88701843f5a7a0d5893a29040"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"603f8425ebd435aef4efc06b7c381e75fb44dfa3","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def list_opts():"},{"line_number":49,"context_line":"    # TODO(sfinucan): This should be moved into the PCI group and"},{"line_number":50,"context_line":"    # oslo_config.cfg.OptGroup used"},{"line_number":51,"context_line":"    return (\u0027\u0027, ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_9908e7db","line":50,"in_reply_to":"7a740942_36af802b","updated":"2015-12-08 12:05:46.000000000","message":"Sweet. Are you comfortable with the TODO for now?","commit_id":"b7ba7832ed31a8a88701843f5a7a0d5893a29040"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"3b03714754dec5742faaa356bb2a45da970d8fb7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def list_opts():"},{"line_number":49,"context_line":"    # TODO(sfinucan): This should be moved into the PCI group and"},{"line_number":50,"context_line":"    # oslo_config.cfg.OptGroup used"},{"line_number":51,"context_line":"    return (\u0027\u0027, ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_16584487","line":51,"updated":"2015-12-08 11:49:26.000000000","message":"I\u0027m not sure what the impact of the empty string is. We should double-check that in the result of \"tox -e genconfig\". Personally, I would prefer having \"DEFAULT\" here to make membership explicitly.","commit_id":"b7ba7832ed31a8a88701843f5a7a0d5893a29040"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f271bde6f83dcbc17ced7299c156ee51accd86d7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def list_opts():"},{"line_number":49,"context_line":"    # TODO(sfinucan): This should be moved into the PCI group and"},{"line_number":50,"context_line":"    # oslo_config.cfg.OptGroup used"},{"line_number":51,"context_line":"    return (\u0027\u0027, ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_bcd6f14c","line":51,"in_reply_to":"7a740942_16584487","updated":"2015-12-08 12:10:23.000000000","message":"Done","commit_id":"b7ba7832ed31a8a88701843f5a7a0d5893a29040"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"cefec6079ad970139710ada0405f25b9a70d0254","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def list_opts():"},{"line_number":49,"context_line":"    # TODO(sfinucan): This should be moved into the PCI group and"},{"line_number":50,"context_line":"    # oslo_config.cfg.OptGroup used"},{"line_number":51,"context_line":"    return (\u0027DEFAULT\u0027, ALL_OPTS)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_7c14094c","line":50,"updated":"2015-12-08 12:25:49.000000000","message":"Yepp, the TODO is perfectly fine. When doing the move to the \"pci\" group, just add me in CC of that review.","commit_id":"de1ce2bb8257c6622cff2069461f0f8732e23920"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"28c537aede8c3c3320154f0e950f820d245bcc86","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Intel, Inc."},{"line_number":2,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_ca31aba3","line":1,"updated":"2015-12-14 01:49:04.000000000","message":"Maybe this is 2015?","commit_id":"164406e099d09bd9be38ecaf802a422947e6fc28"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"fb8220256e990df2e56382e24860eedcd5d108dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Intel, Inc."},{"line_number":2,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_b52ef089","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":41},"updated":"2015-12-21 15:59:10.000000000","message":"nit(?): copyright statement with current year.","commit_id":"077c0110c0308c085340b9eb624f640e724c27b6"}],"nova/opts.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"3b03714754dec5742faaa356bb2a45da970d8fb7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"import nova.objectstore.s3server"},{"line_number":50,"context_line":"import nova.paths"},{"line_number":51,"context_line":"import nova.pci.request"},{"line_number":52,"context_line":"import nova.pci.whitelist"},{"line_number":53,"context_line":"import nova.quota"},{"line_number":54,"context_line":"import nova.rdp"},{"line_number":55,"context_line":"import nova.service"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_963434fc","line":52,"updated":"2015-12-08 11:49:26.000000000","message":"These two \"nova.pci\" imports are not necessary anymore, I guess.","commit_id":"b7ba7832ed31a8a88701843f5a7a0d5893a29040"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f271bde6f83dcbc17ced7299c156ee51accd86d7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"import nova.objectstore.s3server"},{"line_number":50,"context_line":"import nova.paths"},{"line_number":51,"context_line":"import nova.pci.request"},{"line_number":52,"context_line":"import nova.pci.whitelist"},{"line_number":53,"context_line":"import nova.quota"},{"line_number":54,"context_line":"import nova.rdp"},{"line_number":55,"context_line":"import nova.service"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_7cf5e9ea","line":52,"in_reply_to":"7a740942_963434fc","updated":"2015-12-08 12:10:23.000000000","message":"Done\n\nSurprised pep8 didn\u0027t see these","commit_id":"b7ba7832ed31a8a88701843f5a7a0d5893a29040"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d5120b1da28cdf5172db44f74a94f0924f0f9d26","unresolved":false,"context_lines":[{"line_number":111,"context_line":"             nova.keymgr.conf_key_mgr.key_mgr_opts,"},{"line_number":112,"context_line":"             nova.keymgr.keymgr_opts,"},{"line_number":113,"context_line":"         )),"},{"line_number":114,"context_line":"        nova.conf.pci.list_opts(),"},{"line_number":115,"context_line":"        (\u0027rdp\u0027, nova.rdp.rdp_opts),"},{"line_number":116,"context_line":"        nova.conf.serial_console.list_opts(),"},{"line_number":117,"context_line":"        (\u0027spice\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_f80fab36","line":114,"updated":"2016-01-14 16:59:13.000000000","message":"That\u0027s not needed anymore when you rebase that change. The \"nova/conf/opts.py\" which has merged 3 days ago will do that for you.","commit_id":"f57ea0a57e47e63191bcf06c711079cf78616540"}],"nova/pci/request.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"3b03714754dec5742faaa356bb2a45da970d8fb7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"from oslo_serialization import jsonutils"},{"line_number":44,"context_line":"import six"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"import nova"},{"line_number":47,"context_line":"from nova import exception"},{"line_number":48,"context_line":"from nova import objects"},{"line_number":49,"context_line":"from nova.pci import utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_b905a311","line":46,"updated":"2015-12-08 11:49:26.000000000","message":"\"import nova.conf\" would be more focused and will trigger the logic in \"nova.conf.__init__.py\" which is necessary to access the config options later.","commit_id":"b7ba7832ed31a8a88701843f5a7a0d5893a29040"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f271bde6f83dcbc17ced7299c156ee51accd86d7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"from oslo_serialization import jsonutils"},{"line_number":44,"context_line":"import six"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"import nova"},{"line_number":47,"context_line":"from nova import exception"},{"line_number":48,"context_line":"from nova import objects"},{"line_number":49,"context_line":"from nova.pci import utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_bcefd11c","line":46,"in_reply_to":"7a740942_b905a311","updated":"2015-12-08 12:10:23.000000000","message":"Done","commit_id":"b7ba7832ed31a8a88701843f5a7a0d5893a29040"}]}