)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4a3947c9a5ca92453d0dac07f87d602269138794","unresolved":false,"context_lines":[{"line_number":11,"context_line":"\"nova/conf/volume.py\"."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I12be4c97aa76d47589f99ea798673f69273111cd"},{"line_number":14,"context_line":"Implements: blueprint centralize-config-options"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"fa0719c6_4c0edf3b","line":14,"updated":"2016-03-23 15:41:03.000000000","message":"Please be aware that the effort in Newton is tracked with a\nnew (follow up) blueprint \n\n    centralize-config-options-newton\n\nIf questions arise, ping me. Thanks for your help here!","commit_id":"91d2bae03f0090c3ab4b1f97603abd017b007e37"}],"nova/conf/__init__.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"1605b35e005105b1a6e5efaadc5990197340e1c6","unresolved":false,"context_lines":[{"line_number":129,"context_line":"virt.register_opts(CONF)"},{"line_number":130,"context_line":"# vmware.register_opts(CONF)"},{"line_number":131,"context_line":"# vnc.register_opts(CONF)"},{"line_number":132,"context_line":"# volume.register_opts(CONF)"},{"line_number":133,"context_line":"# workarounds.register_opts(CONF)"},{"line_number":134,"context_line":"# wsgi.register_opts(CONF)"},{"line_number":135,"context_line":"# xenserver.register_opts(CONF)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a68dd71_a903ab75","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":28},"updated":"2016-01-27 00:18:31.000000000","message":"The line should be uncommented instead of adding the line 124.","commit_id":"8f69a64f9f6f350aca9885c9be61f02f0ef268ac"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"3acac2a24d3288f6836f8fbda6f8b692f2961b98","unresolved":false,"context_lines":[{"line_number":129,"context_line":"virt.register_opts(CONF)"},{"line_number":130,"context_line":"# vmware.register_opts(CONF)"},{"line_number":131,"context_line":"# vnc.register_opts(CONF)"},{"line_number":132,"context_line":"# volume.register_opts(CONF)"},{"line_number":133,"context_line":"# workarounds.register_opts(CONF)"},{"line_number":134,"context_line":"# wsgi.register_opts(CONF)"},{"line_number":135,"context_line":"# xenserver.register_opts(CONF)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a68dd71_8f390744","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":28},"in_reply_to":"9a68dd71_a903ab75","updated":"2016-01-27 01:26:48.000000000","message":"Done","commit_id":"8f69a64f9f6f350aca9885c9be61f02f0ef268ac"}],"nova/conf/volume.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4217a022fe2165fb79d4ea0e7dc47cc2e2ee6b0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a5de9d1_c65e3776","side":"PARENT","updated":"2016-01-27 13:15:18.000000000","message":"Wrong file mode","commit_id":"2cf6f0f4090b715992fad4b56e2f0c0ffcba3c05"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"87ed67e3f69ea17400dea13f1258cfd626471269","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def list_opts():"},{"line_number":75,"context_line":"    return (\u0027DEFAULT\u0027, ALL_DEFAULT_OPTS) + (CINDER_OPT_GROUP, ALL_CINDER_OPTS)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_35b1e447","line":75,"updated":"2015-12-11 16:04:24.000000000","message":"This doesn\u0027t work; the expected return is a single 2-tuple of (GROUP, [OPTS]).\n\nI recommend following the pattern in nova/conf/scheduler.py when a file has multiple groups. So you would have two methods: list_default_opts() and list_cinder_opts().","commit_id":"1c97be00a424240e58837e6891c6faed11846ed2"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"3acfc5d538237673745b62c0fa3cb7600394450a","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def list_opts():"},{"line_number":75,"context_line":"    return (\u0027DEFAULT\u0027, ALL_DEFAULT_OPTS) + (CINDER_OPT_GROUP, ALL_CINDER_OPTS)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_405dcc45","line":75,"in_reply_to":"7a740942_35b1e447","updated":"2015-12-11 16:30:01.000000000","message":"Done","commit_id":"1c97be00a424240e58837e6891c6faed11846ed2"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"183b3cd86ee3b74f9cfa64b5973790c39f122c2c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    conf.register_opts(ALL_CINDER_OPTS, group\u003dCINDER_OPT_GROUP)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def list_default_opts():"},{"line_number":80,"context_line":"    return (\u0027DEFAULT\u0027, ALL_DEFAULT_OPTS)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def list_cinder_opts():"},{"line_number":84,"context_line":"    return (CINDER_OPT_GROUP, ALL_CINDER_OPTS)"}],"source_content_type":"text/x-python","patch_set":17,"id":"da6ed579_ec473a49","line":84,"range":{"start_line":79,"start_character":0,"end_line":84,"end_character":46},"updated":"2016-01-13 14:53:15.000000000","message":"This is now different due to new \"nova/conf/opts.py\":\n\n    def list_opts():\n        return {\u0027DEFAULT\u0027: ALL_DEFAULT_OPTS,\n                CINDER_OPT_GROUP: ALL_CINDER_OPTS}","commit_id":"2e3084ed70bd7e51d4fad71423d70c4aa13dce70"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"252706ce1f92f79deb69e8e524dd5871a7275bae","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"default_opts \u003d ["},{"line_number":20,"context_line":"    cfg.StrOpt(\u0027volume_api_class\u0027,"},{"line_number":21,"context_line":"        default\u003d\u0027nova.volume.cinder.API\u0027,"},{"line_number":22,"context_line":"        help\u003d\u0027The full class name of the \u0027"},{"line_number":23,"context_line":"        \u0027volume API class to use\u0027),"},{"line_number":24,"context_line":"]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"cinder_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":22,"id":"7a5de9d1_c11f015a","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":35},"updated":"2016-01-27 13:21:13.000000000","message":"I\u0027d argue that these should be created as individual opts, not because they need to right now but because it would be consistent. Example:\n\n    volume_api_class \u003d cfg.StrOpt(\n        \u0027volume_api_class\u0027,\n        ...\n    )\n\n    DEFAULT_OPTS \u003d [\n        volume_api_class,\n    ]\n\nThoughts? Note that I\u0027m happy to fix this later if necessary.","commit_id":"61823a68652d14a9a16410a90f4e8c9e0881f2d8"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"411ae318084546926270644dfb4a8022ca281771","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"default_opts \u003d ["},{"line_number":20,"context_line":"    cfg.StrOpt(\u0027volume_api_class\u0027,"},{"line_number":21,"context_line":"        default\u003d\u0027nova.volume.cinder.API\u0027,"},{"line_number":22,"context_line":"        help\u003d\u0027The full class name of the \u0027"},{"line_number":23,"context_line":"        \u0027volume API class to use\u0027),"},{"line_number":24,"context_line":"]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"cinder_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":22,"id":"7a5de9d1_6a7e08e6","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":35},"in_reply_to":"7a5de9d1_c11f015a","updated":"2016-01-28 00:32:31.000000000","message":"im happy to do stylistic changes later too.  just would like to get this set merged before i do any more...","commit_id":"61823a68652d14a9a16410a90f4e8c9e0881f2d8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"20b757d1da152bec1b0cb5c17f8023ff47233675","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"default_opts \u003d ["},{"line_number":20,"context_line":"    oslo_config.cfg.StrOpt("},{"line_number":21,"context_line":"        \u0027volume_api_class\u0027,"},{"line_number":22,"context_line":"        default\u003d\u0027nova.volume.cinder.API\u0027,"},{"line_number":23,"context_line":"        help\u003d\u0027DEPRECATED: The full class name of the volume API class to use\u0027,"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa0719c6_153798ff","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":15},"updated":"2016-03-24 12:28:12.000000000","message":"I think thats causing the failures here, should just be cfg.","commit_id":"7d335ee8021984692c2112d367b1e9d729f299e5"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"7d67c0b8023a416a678c4a914e2fdb66688edfc0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"default_opts \u003d ["},{"line_number":20,"context_line":"    oslo_config.cfg.StrOpt("},{"line_number":21,"context_line":"        \u0027volume_api_class\u0027,"},{"line_number":22,"context_line":"        default\u003d\u0027nova.volume.cinder.API\u0027,"},{"line_number":23,"context_line":"        help\u003d\u0027DEPRECATED: The full class name of the volume API class to use\u0027,"}],"source_content_type":"text/x-python","patch_set":36,"id":"1a122d0e_c2df4ed4","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":15},"in_reply_to":"fa0719c6_153798ff","updated":"2016-04-27 16:30:36.000000000","message":"Done","commit_id":"7d335ee8021984692c2112d367b1e9d729f299e5"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"8d376b4c4a1f95ef3fb5e77fd4e0fc55b86765ce","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        deprecated_for_removal\u003dTrue)"},{"line_number":25,"context_line":"]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"cinder_opts \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt(\u0027catalog_info\u0027,"},{"line_number":29,"context_line":"            default\u003d\u0027volumev2:cinderv2:publicURL\u0027,"},{"line_number":30,"context_line":"            help\u003d\u0027Info to match when looking for cinder in the service \u0027"}],"source_content_type":"text/x-python","patch_set":41,"id":"9abb7d3a_960078ac","line":27,"updated":"2016-05-27 14:10:22.000000000","message":"These got already moved with commit 026468772672215d34a593e631d1e62d6a615aa4","commit_id":"8b612359bb221673cff649db8797c68309cb77ff"}],"nova/opts.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"87ed67e3f69ea17400dea13f1258cfd626471269","unresolved":false,"context_lines":[{"line_number":100,"context_line":"             nova.utils.monkey_patch_opts,"},{"line_number":101,"context_line":"             nova.utils.utils_opts,"},{"line_number":102,"context_line":"             nova.vnc.xvp_proxy.xvp_proxy_opts,"},{"line_number":103,"context_line":"             nova.volume.ALL_DEFAULT_OPTS,"},{"line_number":104,"context_line":"             nova.wsgi.wsgi_opts,"},{"line_number":105,"context_line":"         )),"},{"line_number":106,"context_line":"        (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_f5691c8d","line":103,"updated":"2015-12-11 16:04:24.000000000","message":"the change in the volume.py script, this should be moved out of this section and into the main section below by the other volume line:\n\n    nova.conf.volume.list_default_opts(),","commit_id":"1c97be00a424240e58837e6891c6faed11846ed2"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"3acfc5d538237673745b62c0fa3cb7600394450a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"             nova.utils.monkey_patch_opts,"},{"line_number":101,"context_line":"             nova.utils.utils_opts,"},{"line_number":102,"context_line":"             nova.vnc.xvp_proxy.xvp_proxy_opts,"},{"line_number":103,"context_line":"             nova.volume.ALL_DEFAULT_OPTS,"},{"line_number":104,"context_line":"             nova.wsgi.wsgi_opts,"},{"line_number":105,"context_line":"         )),"},{"line_number":106,"context_line":"        (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_e055d81d","line":103,"in_reply_to":"7a740942_f5691c8d","updated":"2015-12-11 16:30:01.000000000","message":"Done","commit_id":"1c97be00a424240e58837e6891c6faed11846ed2"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"87ed67e3f69ea17400dea13f1258cfd626471269","unresolved":false,"context_lines":[{"line_number":104,"context_line":"             nova.wsgi.wsgi_opts,"},{"line_number":105,"context_line":"         )),"},{"line_number":106,"context_line":"        (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),"},{"line_number":107,"context_line":"        (nova.conf.volume.CINDER_OPT_GROUP, nova.conf.volume.ALL_CINDER_OPTS),"},{"line_number":108,"context_line":"        (\u0027api_database\u0027, nova.db.sqlalchemy.api.api_db_opts),"},{"line_number":109,"context_line":"        (\u0027conductor\u0027, nova.conductor.api.conductor_opts),"},{"line_number":110,"context_line":"        (\u0027database\u0027, nova.db.sqlalchemy.api.oslo_db_options.database_opts),"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_b5d15459","line":107,"updated":"2015-12-11 16:04:24.000000000","message":"With the change in the volume.py script, this will now be:\n\n    nova.conf.volume.list_cinder_opts(),","commit_id":"1c97be00a424240e58837e6891c6faed11846ed2"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"3acfc5d538237673745b62c0fa3cb7600394450a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"             nova.wsgi.wsgi_opts,"},{"line_number":105,"context_line":"         )),"},{"line_number":106,"context_line":"        (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),"},{"line_number":107,"context_line":"        (nova.conf.volume.CINDER_OPT_GROUP, nova.conf.volume.ALL_CINDER_OPTS),"},{"line_number":108,"context_line":"        (\u0027api_database\u0027, nova.db.sqlalchemy.api.api_db_opts),"},{"line_number":109,"context_line":"        (\u0027conductor\u0027, nova.conductor.api.conductor_opts),"},{"line_number":110,"context_line":"        (\u0027database\u0027, nova.db.sqlalchemy.api.oslo_db_options.database_opts),"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_0053443a","line":107,"in_reply_to":"7a740942_b5d15459","updated":"2015-12-11 16:30:01.000000000","message":"Done","commit_id":"1c97be00a424240e58837e6891c6faed11846ed2"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"854d462c8235612a85d54537d51decbcd6b0dcd1","unresolved":false,"context_lines":[{"line_number":100,"context_line":"             nova.utils.monkey_patch_opts,"},{"line_number":101,"context_line":"             nova.utils.utils_opts,"},{"line_number":102,"context_line":"             nova.vnc.xvp_proxy.xvp_proxy_opts,"},{"line_number":103,"context_line":"             nova.conf.volume.list_default_opts(),"},{"line_number":104,"context_line":"             nova.wsgi.wsgi_opts,"},{"line_number":105,"context_line":"         )),"},{"line_number":106,"context_line":"        (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_6196ca3f","line":103,"updated":"2015-12-11 17:23:14.000000000","message":"This has to be moved out of the itertools.chain, since it contains the 2-tuple. Move it after the list_cinder_opts() line.","commit_id":"7874694782e26f5b9eb93e2fc795345c36a41054"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5214c268376b511e204e3c5dd7a59c688eca9ee2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import nova.baserpc"},{"line_number":17,"context_line":"import nova.cloudpipe.pipelib"},{"line_number":18,"context_line":"import nova.cmd.novnc"},{"line_number":19,"context_line":"import nova.cmd.novncproxy"},{"line_number":20,"context_line":"import nova.cmd.serialproxy"},{"line_number":21,"context_line":"import nova.cmd.spicehtml5proxy"},{"line_number":22,"context_line":"import nova.conductor.api"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a5ae5dd_8b1f245a","line":19,"updated":"2016-02-08 04:41:45.000000000","message":"This is an unrelated change.","commit_id":"a378f15d8115abfa33f45332df54753d8a1a3787"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"fa750197148a117f06bec4eb8aa3fa959556019d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import nova.baserpc"},{"line_number":17,"context_line":"import nova.cloudpipe.pipelib"},{"line_number":18,"context_line":"import nova.cmd.novnc"},{"line_number":19,"context_line":"import nova.cmd.novncproxy"},{"line_number":20,"context_line":"import nova.cmd.serialproxy"},{"line_number":21,"context_line":"import nova.cmd.spicehtml5proxy"},{"line_number":22,"context_line":"import nova.conductor.api"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a57f1b5_4d54b153","line":19,"in_reply_to":"5a5ae5dd_8b1f245a","updated":"2016-02-09 18:22:01.000000000","message":"Done","commit_id":"a378f15d8115abfa33f45332df54753d8a1a3787"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5214c268376b511e204e3c5dd7a59c688eca9ee2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"import nova.servicegroup.drivers.zk"},{"line_number":53,"context_line":"import nova.spice"},{"line_number":54,"context_line":"import nova.utils"},{"line_number":55,"context_line":"import nova.vnc"},{"line_number":56,"context_line":"import nova.vnc.xvp_proxy"},{"line_number":57,"context_line":"import nova.volume"},{"line_number":58,"context_line":"import nova.volume.cinder"},{"line_number":59,"context_line":"import nova.wsgi"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a5ae5dd_6b3988d6","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":25},"updated":"2016-02-08 04:41:45.000000000","message":"ditto","commit_id":"a378f15d8115abfa33f45332df54753d8a1a3787"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"fa750197148a117f06bec4eb8aa3fa959556019d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"import nova.servicegroup.drivers.zk"},{"line_number":53,"context_line":"import nova.spice"},{"line_number":54,"context_line":"import nova.utils"},{"line_number":55,"context_line":"import nova.vnc"},{"line_number":56,"context_line":"import nova.vnc.xvp_proxy"},{"line_number":57,"context_line":"import nova.volume"},{"line_number":58,"context_line":"import nova.volume.cinder"},{"line_number":59,"context_line":"import nova.wsgi"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a57f1b5_6d516d62","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":25},"in_reply_to":"5a5ae5dd_6b3988d6","updated":"2016-02-09 18:22:01.000000000","message":"Done","commit_id":"a378f15d8115abfa33f45332df54753d8a1a3787"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5214c268376b511e204e3c5dd7a59c688eca9ee2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"             nova.availability_zones.availability_zone_opts,"},{"line_number":72,"context_line":"             nova.cloudpipe.pipelib.cloudpipe_opts,"},{"line_number":73,"context_line":"             nova.cmd.novnc.opts,"},{"line_number":74,"context_line":"             nova.cmd.novncproxy.opts,"},{"line_number":75,"context_line":"             nova.cmd.spicehtml5proxy.opts,"},{"line_number":76,"context_line":"             nova.console.manager.console_manager_opts,"},{"line_number":77,"context_line":"             nova.console.rpcapi.rpcapi_opts,"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a5ae5dd_2b2f1089","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":38},"updated":"2016-02-08 04:41:45.000000000","message":"ditto","commit_id":"a378f15d8115abfa33f45332df54753d8a1a3787"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"fa750197148a117f06bec4eb8aa3fa959556019d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"             nova.availability_zones.availability_zone_opts,"},{"line_number":72,"context_line":"             nova.cloudpipe.pipelib.cloudpipe_opts,"},{"line_number":73,"context_line":"             nova.cmd.novnc.opts,"},{"line_number":74,"context_line":"             nova.cmd.novncproxy.opts,"},{"line_number":75,"context_line":"             nova.cmd.spicehtml5proxy.opts,"},{"line_number":76,"context_line":"             nova.console.manager.console_manager_opts,"},{"line_number":77,"context_line":"             nova.console.rpcapi.rpcapi_opts,"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a57f1b5_2d4b75b2","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":38},"in_reply_to":"5a5ae5dd_2b2f1089","updated":"2016-02-09 18:22:01.000000000","message":"Done","commit_id":"a378f15d8115abfa33f45332df54753d8a1a3787"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5214c268376b511e204e3c5dd7a59c688eca9ee2","unresolved":false,"context_lines":[{"line_number":89,"context_line":"             nova.service.service_opts,"},{"line_number":90,"context_line":"             nova.utils.monkey_patch_opts,"},{"line_number":91,"context_line":"             nova.utils.utils_opts,"},{"line_number":92,"context_line":"             nova.vnc.xvp_proxy.xvp_proxy_opts,"},{"line_number":93,"context_line":"             nova.wsgi.wsgi_opts,"},{"line_number":94,"context_line":"         )),"},{"line_number":95,"context_line":"        (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a5ae5dd_eb533815","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":47},"updated":"2016-02-08 04:41:45.000000000","message":"ditto","commit_id":"a378f15d8115abfa33f45332df54753d8a1a3787"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"fa750197148a117f06bec4eb8aa3fa959556019d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"             nova.service.service_opts,"},{"line_number":90,"context_line":"             nova.utils.monkey_patch_opts,"},{"line_number":91,"context_line":"             nova.utils.utils_opts,"},{"line_number":92,"context_line":"             nova.vnc.xvp_proxy.xvp_proxy_opts,"},{"line_number":93,"context_line":"             nova.wsgi.wsgi_opts,"},{"line_number":94,"context_line":"         )),"},{"line_number":95,"context_line":"        (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a57f1b5_cdc66116","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":47},"in_reply_to":"5a5ae5dd_eb533815","updated":"2016-02-09 18:22:01.000000000","message":"Done","commit_id":"a378f15d8115abfa33f45332df54753d8a1a3787"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5214c268376b511e204e3c5dd7a59c688eca9ee2","unresolved":false,"context_lines":[{"line_number":116,"context_line":"             [nova.console.rpcapi.rpcapi_cap_opt],"},{"line_number":117,"context_line":"             [nova.consoleauth.rpcapi.rpcapi_cap_opt],"},{"line_number":118,"context_line":"         )),"},{"line_number":119,"context_line":"        (\u0027vnc\u0027, nova.vnc.vnc_opts),"},{"line_number":120,"context_line":"        (\u0027workarounds\u0027, nova.utils.workarounds_opts),"},{"line_number":121,"context_line":"        (\u0027zookeeper\u0027, nova.servicegroup.drivers.zk.zk_driver_opts)"},{"line_number":122,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a5ae5dd_8b564404","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":35},"updated":"2016-02-08 04:41:45.000000000","message":"ditto","commit_id":"a378f15d8115abfa33f45332df54753d8a1a3787"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"fa750197148a117f06bec4eb8aa3fa959556019d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"             [nova.console.rpcapi.rpcapi_cap_opt],"},{"line_number":117,"context_line":"             [nova.consoleauth.rpcapi.rpcapi_cap_opt],"},{"line_number":118,"context_line":"         )),"},{"line_number":119,"context_line":"        (\u0027vnc\u0027, nova.vnc.vnc_opts),"},{"line_number":120,"context_line":"        (\u0027workarounds\u0027, nova.utils.workarounds_opts),"},{"line_number":121,"context_line":"        (\u0027zookeeper\u0027, nova.servicegroup.drivers.zk.zk_driver_opts)"},{"line_number":122,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a57f1b5_8dd069cb","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":35},"in_reply_to":"5a5ae5dd_8b564404","updated":"2016-02-09 18:22:01.000000000","message":"Done","commit_id":"a378f15d8115abfa33f45332df54753d8a1a3787"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"6fbc47fe70a970ca14c237b80e2569f051a32cf1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"             nova.service.service_opts,"},{"line_number":82,"context_line":"             nova.utils.monkey_patch_opts,"},{"line_number":83,"context_line":"             nova.utils.utils_opts,"},{"line_number":84,"context_line":"             nova.wsgi.wsgi_opts,"},{"line_number":85,"context_line":"         )),"},{"line_number":86,"context_line":"        (\u0027barbican\u0027, nova.keymgr.barbican.barbican_opts),"},{"line_number":87,"context_line":"        (\u0027api_database\u0027, nova.db.sqlalchemy.api.api_db_opts),"}],"source_content_type":"text/x-python","patch_set":31,"id":"dae33548_b15f6340","line":84,"range":{"start_line":84,"start_character":13,"end_line":84,"end_character":32},"updated":"2016-02-16 09:26:31.000000000","message":"wsgi_opts does not exist in nova/wsgi.py.","commit_id":"40b31f0dda7c2e2bdf44b5ede425fbd22ccb4a60"}],"nova/volume/__init__.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"20b757d1da152bec1b0cb5c17f8023ff47233675","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import oslo_config.cfg"},{"line_number":18,"context_line":"from oslo_utils import importutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def API():"},{"line_number":21,"context_line":"    volume_api_class \u003d oslo_config.cfg.CONF.volume_api_class"},{"line_number":22,"context_line":"    cls \u003d importutils.import_class(volume_api_class)"},{"line_number":23,"context_line":"    return cls()"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa0719c6_b5706c0c","line":20,"updated":"2016-03-24 12:28:12.000000000","message":"need an extra space here I think, see pep8","commit_id":"7d335ee8021984692c2112d367b1e9d729f299e5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"20b757d1da152bec1b0cb5c17f8023ff47233675","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_utils import importutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def API():"},{"line_number":21,"context_line":"    volume_api_class \u003d oslo_config.cfg.CONF.volume_api_class"},{"line_number":22,"context_line":"    cls \u003d importutils.import_class(volume_api_class)"},{"line_number":23,"context_line":"    return cls()"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa0719c6_f592e4f4","line":21,"range":{"start_line":21,"start_character":39,"end_line":21,"end_character":43},"updated":"2016-03-24 12:28:12.000000000","message":"should we not now use import nova.conf.CONF here?","commit_id":"7d335ee8021984692c2112d367b1e9d729f299e5"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"8d376b4c4a1f95ef3fb5e77fd4e0fc55b86765ce","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import oslo_config.cfg"},{"line_number":18,"context_line":"from oslo_utils import importutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"_volume_opts \u003d ["},{"line_number":21,"context_line":"    oslo_config.cfg.StrOpt("},{"line_number":22,"context_line":"        \u0027volume_api_class\u0027,"},{"line_number":23,"context_line":"        default\u003d\u0027nova.volume.cinder.API\u0027,"},{"line_number":24,"context_line":"        help\u003d\u0027DEPRECATED: The full class name of the volume API class to use\u0027,"},{"line_number":25,"context_line":"        deprecated_for_removal\u003dTrue)"},{"line_number":26,"context_line":"]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"oslo_config.cfg.CONF.register_opts(_volume_opts)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"9abb7d3a_965238dc","side":"PARENT","line":26,"range":{"start_line":20,"start_character":0,"end_line":26,"end_character":1},"updated":"2016-05-27 14:10:22.000000000","message":"This gets removed with change https://review.openstack.org/#/c/319530/","commit_id":"166f6ac3257d9b980c41b59ada0723e26d081be2"}],"nova/volume/cinder.py":[{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"eabea80f9b51b159972034fa20840ed03c2214ff","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if not _SESSION:"},{"line_number":61,"context_line":"        _SESSION \u003d session.Session.load_from_conf_options("},{"line_number":62,"context_line":"            CONF, nova.conf.cinder.CINDER_OPT_GROUP)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    url \u003d None"},{"line_number":65,"context_line":"    endpoint_override \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_8fb82e2c","line":62,"updated":"2015-12-10 01:20:13.000000000","message":"@marcus_z do you have any hints on how to properly handle the deprecated options for this??  The tests are failing like mad","commit_id":"f677c2a01dab1c727d78afb562fdbff4806a4754"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"f92f63ce362f4b971a91b34b9d7462507ba48031","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if not _SESSION:"},{"line_number":61,"context_line":"        _SESSION \u003d session.Session.load_from_conf_options("},{"line_number":62,"context_line":"            CONF, nova.conf.cinder.CINDER_OPT_GROUP)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    url \u003d None"},{"line_number":65,"context_line":"    endpoint_override \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_d0d8f981","line":62,"in_reply_to":"7a740942_8a100eaa","updated":"2015-12-10 13:27:43.000000000","message":"@tjones: I pasted a patch file at [1] which should pass the unit tests. These are keystone authentication options, they also exist for the interaction with Neutron and Barbican and possibly Ironic too. But only Neutron lists them correctly as in the generated \"nova.conf.sample\" file. That\u0027s a bug I guess, I have to double-check that, ignore that for now. I removed the \"list_opts\" method to satisfy the needs of \"nova/opts.py\", we can fix that later. Ed Leafe has a WIP for a PoC for that.\n\n[1] http://paste.openstack.org/show/481479/","commit_id":"f677c2a01dab1c727d78afb562fdbff4806a4754"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"b235cf48b38154c6697d704b0675b4b122a82e6e","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if not _SESSION:"},{"line_number":61,"context_line":"        _SESSION \u003d session.Session.load_from_conf_options("},{"line_number":62,"context_line":"            CONF, nova.conf.cinder.CINDER_OPT_GROUP)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    url \u003d None"},{"line_number":65,"context_line":"    endpoint_override \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_af8c0a80","line":62,"in_reply_to":"7a740942_8fb82e2c","updated":"2015-12-10 01:21:08.000000000","message":"i mean @markus_z :-)","commit_id":"f677c2a01dab1c727d78afb562fdbff4806a4754"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4b064aeff984496c81935171a6736d043f57f5df","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    if not _SESSION:"},{"line_number":61,"context_line":"        _SESSION \u003d session.Session.load_from_conf_options("},{"line_number":62,"context_line":"            CONF, nova.conf.cinder.CINDER_OPT_GROUP)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    url \u003d None"},{"line_number":65,"context_line":"    endpoint_override \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_8a100eaa","line":62,"in_reply_to":"7a740942_af8c0a80","updated":"2015-12-10 09:09:03.000000000","message":"I\u0027ll take a look.","commit_id":"f677c2a01dab1c727d78afb562fdbff4806a4754"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"7099054c27b55deb4244896700058c58bd34d8e2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from cinderclient.v1 import client as v1_client"},{"line_number":27,"context_line":"from keystoneclient import exceptions as keystone_exception"},{"line_number":28,"context_line":"from keystoneclient import session"},{"line_number":29,"context_line":"import nova.conf"},{"line_number":30,"context_line":"from oslo_log import log as logging"},{"line_number":31,"context_line":"from oslo_utils import excutils"},{"line_number":32,"context_line":"from oslo_utils import strutils"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a7e1126_9498c8c1","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":16},"updated":"2015-12-19 09:21:07.000000000","message":"it should be move to line 36, and \u0027from nova import conf\u0027 may be more simple to use?","commit_id":"15b49515b2b5f95e2e64e92a4e7b22ee1d14e04a"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"25746c070feca630ce17c122fc9045be6e2092f8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from cinderclient.v1 import client as v1_client"},{"line_number":27,"context_line":"from keystoneclient import exceptions as keystone_exception"},{"line_number":28,"context_line":"from keystoneclient import session"},{"line_number":29,"context_line":"import nova.conf"},{"line_number":30,"context_line":"from oslo_log import log as logging"},{"line_number":31,"context_line":"from oslo_utils import excutils"},{"line_number":32,"context_line":"from oslo_utils import strutils"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a7e1126_bea26897","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":16},"in_reply_to":"3a7e1126_9498c8c1","updated":"2015-12-21 09:06:59.000000000","message":"The import order is not right, that\u0027s true.\n\nWe started with \"import nova.conf\" and AFAIK there is no real difference to \"from nova import conf\". Personally I don\u0027t have strong feelings in this case and I don\u0027t think that it is that important.","commit_id":"15b49515b2b5f95e2e64e92a4e7b22ee1d14e04a"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"a71b82546ef5ab82cb3f3c4d5eb6dd2c08783840","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from cinderclient.v1 import client as v1_client"},{"line_number":27,"context_line":"from keystoneclient import exceptions as keystone_exception"},{"line_number":28,"context_line":"from keystoneclient import session"},{"line_number":29,"context_line":"import nova.conf"},{"line_number":30,"context_line":"from oslo_log import log as logging"},{"line_number":31,"context_line":"from oslo_utils import excutils"},{"line_number":32,"context_line":"from oslo_utils import strutils"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa69d971_fa1fd905","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":16},"in_reply_to":"3a7e1126_bea26897","updated":"2016-01-04 21:38:34.000000000","message":"\"import nova.conf\" is more explicit, since when it is used it forces the \"nova.conf.FOO\" structure. Other modules with \"conf\" modules may pollute the namespace.","commit_id":"15b49515b2b5f95e2e64e92a4e7b22ee1d14e04a"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"a71b82546ef5ab82cb3f3c4d5eb6dd2c08783840","unresolved":false,"context_lines":[{"line_number":43,"context_line":"session.Session.register_conf_options("},{"line_number":44,"context_line":"    CONF,"},{"line_number":45,"context_line":"        nova.conf.volume.CINDER_OPT_GROUP,"},{"line_number":46,"context_line":"        deprecated_opts\u003dnova.conf.volume.deprecated)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa69d971_fae6f913","line":46,"updated":"2016-01-04 21:38:34.000000000","message":"These should be moved to the nova/conf directory, too.","commit_id":"15b49515b2b5f95e2e64e92a4e7b22ee1d14e04a"}]}