)]}'
{"nova/network/quantumv2/__init__.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"037f6bcc34dd6472af5b71e28bef0a45782dae42","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        return httpclient.auth_token"},{"line_number":42,"context_line":"    except Exception, e:"},{"line_number":43,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":44,"context_line":"            LOG.exception(_(\u0027Quantum client authentication failed: %s\u0027), e)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def _get_client(token\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F0VE%3D","line":44,"updated":"2013-03-26 13:17:31.000000000","message":"Can we change this to LOG.error() ?\n\nI don\u0027t think logging a traceback here is really necessary.","commit_id":"7af436f362900ec164e758acf1b76848730bdcca"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f302dc4689a599addce12a9f49791172725f7ef8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        return httpclient.auth_token"},{"line_number":42,"context_line":"    except Exception, e:"},{"line_number":43,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":44,"context_line":"            LOG.exception(_(\u0027Quantum client authentication failed: %s\u0027), e)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def _get_client(token\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F0TE%3D","line":44,"in_reply_to":"AAAAOH%2F%2F0VE%3D","updated":"2013-03-26 13:39:41.000000000","message":"Agree","commit_id":"7af436f362900ec164e758acf1b76848730bdcca"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"b45c5f1ecd3bec6c6e2de43ddebbea5727cbe8ad","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            insecure\u003dCONF.quantum_api_insecure)"},{"line_number":40,"context_line":"        httpclient.authenticate()"},{"line_number":41,"context_line":"        return httpclient.auth_token"},{"line_number":42,"context_line":"    except Exception, e:"},{"line_number":43,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":44,"context_line":"            LOG.error(_(\u0027Quantum client authentication failed: %s\u0027), e)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F0I0%3D","line":42,"updated":"2013-03-26 14:54:40.000000000","message":"Can you use \"as e\" instead of \", e\"?\n\nhttp://stackoverflow.com/questions/2535760/python-try-except-comma-vs-as-in-except","commit_id":"a250e8017ee4528f553abf46c0a8649364e496cf"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"5c27b2ac712258515f25c1a32bdaecaabdf24324","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            insecure\u003dCONF.quantum_api_insecure)"},{"line_number":40,"context_line":"        httpclient.authenticate()"},{"line_number":41,"context_line":"        return httpclient.auth_token"},{"line_number":42,"context_line":"    except Exception, e:"},{"line_number":43,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":44,"context_line":"            LOG.error(_(\u0027Quantum client authentication failed: %s\u0027), e)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F0Fg%3D","line":42,"in_reply_to":"AAAAOH%2F%2F0I0%3D","updated":"2013-03-26 15:33:26.000000000","message":"Done","commit_id":"a250e8017ee4528f553abf46c0a8649364e496cf"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"b45c5f1ecd3bec6c6e2de43ddebbea5727cbe8ad","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        return httpclient.auth_token"},{"line_number":42,"context_line":"    except Exception, e:"},{"line_number":43,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":44,"context_line":"            LOG.error(_(\u0027Quantum client authentication failed: %s\u0027), e)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def _get_client(token\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F0IM%3D","line":44,"updated":"2013-03-26 14:54:40.000000000","message":"Do you want to swallow the traceback for all exceptions?  (catching Exception is pretty general)","commit_id":"a250e8017ee4528f553abf46c0a8649364e496cf"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"5c27b2ac712258515f25c1a32bdaecaabdf24324","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        return httpclient.auth_token"},{"line_number":42,"context_line":"    except Exception, e:"},{"line_number":43,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":44,"context_line":"            LOG.error(_(\u0027Quantum client authentication failed: %s\u0027), e)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def _get_client(token\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F0E8%3D","line":44,"in_reply_to":"AAAAOH%2F%2F0IM%3D","updated":"2013-03-26 15:33:26.000000000","message":"Nope, just QuantumClientException. Thanks for pointing!","commit_id":"a250e8017ee4528f553abf46c0a8649364e496cf"}]}